- Aug 05, 2014
-
-
Julien Gilli authored
Do not use first socket in second socket's connect handler. Probably a copy/paste mistake. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Herman Lee authored
On Windows, path.isAbsolute() returns an empty string on failed cases. This forces the return value to always be boolean. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
- Aug 03, 2014
-
-
Jackson Tian authored
Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
- Aug 02, 2014
-
-
Fedor Indutny authored
fix #8023
-
Lucio M. Tato authored
Internal function trim(arr). 2nd parameter of slice() should be slice's end index (not included). Because of function normalize() (called before trim()), "start" is always zero so the bug -for now- has no effect, but its a bug waiting to happen. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Sam Roberts authored
See joyent/node#8043, test passed on v0.11 already, but this makes the test stronger. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
- Aug 01, 2014
-
-
Jackson Tian authored
Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
cjihrig authored
This commit moves some common Worker code into the constructor via support for an options argument. Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Gabriel Wicke authored
This patch adds a fast path for parsing of simple path-only URLs, as commonly found in HTTP requests received by a server. Benchmark results [ms], before / after patch: /foo/bar 0.008956 0.000418 (fast path used) http://example.com/ 0.011426 0.011437 (normal slow path, no change) In a simple 'ab' benchmark of a single-threaded web server, this patch increases the request rate from around 6400 to 7400 req/s. Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Jul 31, 2014
-
-
Fedor Indutny authored
This reverts commit 4e68a28e.
-
Alexis Campailla authored
This is the Node side of the fix for Node's cluster module on Windows. https://github.com/joyent/node/issues/7691 The other required part is https://github.com/joyent/libuv/pull/1384 Windows and Unix return certain socket errors (i.e. EADDRINUSE) at different times: bind on Windows, and listen on Unix. In an effort to hide this difference, libuv on Windows stores such errors in the bind_error field of uv_tcp_t, to defer raising it at listen time. This worked fine except for the case in which a socket is shared in a Node cluster and a bind error occurs. A previous attempt to fix this ( https://github.com/joyent/libuv/commit/d1e6be1460f555a1f8a4063d7642696aa7238769 https://github.com/joyent/node/commit/3da36fe00e5d85414031ae812e473f16629d8645 ) was flawed becaused in an attempt to relay the error at the JS level it caused the master to start accepting connections. With this new approach, libuv itself is relaying the bind errors, providing for a uniform behavior of uv_tcp_listen. Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
fix #8031
-
Fedor Indutny authored
This reverts commit 7166b550.
-
Sam Roberts authored
v0.10 and node docs specific that in a worker, the 'message' and 'error' event emits on process, and on cluster.worker. Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Julien Gilli authored
internet/test-dns.js assumes that ::1 always resolves to "localhost" on all platforms. This is not what happens in reality. Some platforms resolve it to "ip6-localhost" too. There doesn't seem to be any consensus on what's the right thing to do. However, most sane platforms will use either one of these two values. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
- Jul 29, 2014
-
-
Yazhong Liu authored
Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
Conflicts: doc/api/buffer.markdown lib/_stream_readable.js lib/assert.js lib/buffer.js lib/child_process.js lib/http.js lib/string_decoder.js lib/zlib.js node.gyp test/simple/test-buffer.js test/simple/test-https-foafssl.js test/simple/test-stream2-compatibility.js test/simple/test-tls-server-verify.js
-
Fedor Indutny authored
`|` operation takes precendence on `+`, which will result in `new Buffer('ffffffff', 16).readUInt32BE(0)` returning `-1` instead of `ffffffff`. -
Julien Gilli authored
Prevent test-process-kill-pid.js tests suite from sending SIGHUP to its process group, which was causing the test runner to terminate. Fix jenkins' jobs for nodejs-master. Signed-off-by:Timothy J Fontaine <tjfontaine@gmail.com>
-
- Jul 28, 2014
-
-
cjihrig authored
Between 0.11.1 and 0.11.2, the message and error events stopped being usable via the cluster.worker object. This commit makes them usable again. Closes #7998. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Sam Roberts authored
Currently, invalid usage such as: process.kill('SIGTERM') process.kill(null) process.kill(undefined); all coerce the pid to 0, and signal the current process. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
- Jul 25, 2014
-
-
Fedor Indutny authored
Original commit message: Extend the interceptor setter ASSERT to support the JSGlobalProxy case. BUG=v8:3463 LOG=n R=dcarney@chromium.org Review URL: https://codereview.chromium.org/415973004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22589 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 Signed-off-by:Fedor Indutny <fedor@indutny.com> fix #7969
-
- Jul 24, 2014
-
-
cjihrig authored
Currently, stringification of an empty array outputs a single separator character. This commit causes an empty array to output the empty string. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
-
Fedor Indutny authored
fix #7963
-
Jackson Tian authored
Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Shigeki Ohtsu authored
When TLS Alert is occured in handshake, ClearOut only write it into wbio and does not flush to socket. TLS Alert should be written to socket with EncOut before socket is destroyed within its error callback. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Maciej Małecki authored
According to V8 changelog, `armv7` config variable was replaced by `arm_version`, with value either '7', '6' or 'default'. Detect ARMv7 and ARMv6 CPUs and default to 'default'. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
cjihrig authored
Currently, checkExecSyncError() attempts to access the contents of stderr. When stdio is set to 'ignore', this causes a crash. This commit adds a check on the access of stderr. Closes #7966. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Sam Roberts authored
Documentation claimed it accepted a single label argument, as time and timeEnd do, which was incorrect. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
-
Dean McNamee authored
This allows embedders enough control to initialize node, run the event loop, and cleanly exit (including calling handlers). Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
- Jul 23, 2014
-
-
Fedor Indutny authored
Expose missing constants and keep symbols on OSX.
-
Fedor Indutny authored
Expose missing constants and keep symbols on OSX.
-
- Jul 18, 2014
-
-
Fedor Indutny authored
Original commit message: Fix x64 MathMinMax for negative untagged int32 arguments. An untagged int32 has zeros in the upper half even if it is negative. Using cmpq to compare such numbers will incorrectly ignore the sign. BUG=164442 R=mvstanton@chromium.org Review URL: https://chromiumcodereview.appspot.com/11665007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@13273 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
- Jul 17, 2014
-
-
Fedor Indutny authored
Pass `-force_load` to linker when linking to `libv8_base` to preserve `v8dbg_` symbols, which are useful for debugging.
-
Brian White authored
Closes #7957.
-
- Jul 15, 2014
-
-
Fedor Indutny authored
-
Chris Dickinson authored
A ReadableStream with a base64 StringDecoder backed by only one or two bytes would fail to output its partial data before ending. This fix adds a check to see if the `read` was triggered by an internal `flow`, and if so, empties any remaining data. fixes #7914. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Ryan Graham authored
Emits on every call to cluster.setupMaster(), even if no new settings are given. This is because calling cluster.setupMaster() without arguments (or with an empty options object) results in the settings being restored to their defaults. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-