- Mar 04, 2018
-
-
Anna Henningsen authored
Display the constant name instead of a stream error code in the error message, because the numerical codes give absolutely no clue about what happened when an error is emitted. PR-URL: https://github.com/nodejs/node/pull/18966 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Luigi Pinca authored
The listener does not do anything if `allowHalfOpen` is enabled. Add it only when `allowHalfOpen` is disabled. PR-URL: https://github.com/nodejs/node/pull/18953 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This fixes a crash that occurred when a `Http2Stream` write is completed after it is already destroyed. Instead, don’t destroy the stream in that case and wait for GC to take over. PR-URL: https://github.com/nodejs/node/pull/19002 Fixes: https://github.com/nodejs/node/issues/18973 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Trivikram authored
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError PR-URL: https://github.com/nodejs/node/pull/19061 Fixes: https://github.com/nodejs/node/issues/18855 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: https://github.com/nodejs/node/pull/19046 Fixes: https://github.com/nodejs/node/issues/18983 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Сковорода Никита Андреевич authored
For tests / benchmarks that are creating Buffer instances for any reason other than to test Buffer constructor, use the new Buffer.alloc/Buffer.from API instead of the deprecated API. PR-URL: https://github.com/nodejs/node/pull/18980 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Zeke Sikelianos authored
PR-URL: https://github.com/nodejs/node/pull/18888 Fixes: https://github.com/nodejs/node/issues/18887 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Santiago Gimeno authored
So it does not use `common.PORT` anymore. PR-URL: https://github.com/nodejs/node/pull/18727 Reviewed-By:
-
Anna Henningsen authored
The error emitted when a connection is closed before the TLS handshake completes seemed rather unspefic by just saying `socket hang up`. Use a more verbose message, that also indicates that this is a purely client-side error, and remove a misleading comment. PR-URL: https://github.com/nodejs/node/pull/18989 Reviewed-By:
-
wuweiweiwu authored
The default message will be printed if the assertion fires. Use block scope for related variables and tests. PR-URL: https://github.com/nodejs/node/pull/19054 Reviewed-By:
-
Ujjwal Sharma authored
PR-URL: https://github.com/nodejs/node/pull/19126 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Eric Bickle authored
Documentation for N-API Custom Asynchronous Operations incorrectly stated that async execution happens on the main event loop. Added details to napi_create_async_work about which threads are used to invoke the execute and complete callbacks. Changed 'async' to 'asynchronous' in the documentation for Custom Asynchronous Operations. Changed "executes in parallel" to "can execute in parallel" for the documentation of napi_create_async_work execute parameter. PR-URL: https://github.com/nodejs/node/pull/19073 Fixes: https://github.com/nodejs/node/issues/19071 Reviewed-By:
-
Andreas Madsen authored
Allow the user to specify the filepath for the trace_events log file using a template string. PR-URL: https://github.com/nodejs/node/pull/18480 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Sergey Golovin authored
PR-URL: https://github.com/nodejs/node/pull/18717 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Chen Gang authored
PR-URL: https://github.com/nodejs/node/pull/19109 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
- Mar 03, 2018
-
-
Matteo Collina authored
The test was flaky because it relied on a specific order of asynchronous operation that were fired paralellely. This was true on most platform and conditions, but not all the time. See: https://github.com/nodejs/node/pull/18986 PR-URL: https://github.com/nodejs/node/pull/19093 Reviewed-By:
-
Seth Brenith authored
Attempting to make symlinks as a non-administrator user in Windows causes a permission error. We need to update test-fs-promises to avoid making symlinks if the platform does not support it. PR-URL: https://github.com/nodejs/node/pull/19018 Reviewed-By:
-
Joyee Cheung authored
The binding writeBuffer has been changed in https://github.com/nodejs/node/pull/19041 and it now requires the last argument to be a context object. makeSyncWrite was not updated accordingly, resulting assertions on Windows. This patch fixes the usage of writeBuffer there. Also fix errors.uvException() so error.message are no longer enumerable, this fixes the deepStrictEqual assertion on the error object in test-stdout-close-catch. PR-URL: https://github.com/nodejs/node/pull/19103 Refs: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Rich Trott authored
This reverts commit c05c73a6. The commit breaks Raspberry Pi CI. PR-URL: https://github.com/nodejs/node/pull/19101 Ref: https://github.com/nodejs/node/pull/19064#issuecomment-370092633 Reviewed-By:
-
Daijiro Wachi authored
Add tests of lchmod, chown, fchown and lchown. PR-URL: https://github.com/nodejs/node/pull/19064 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
Use common.platformTimeout() to give longer durations to Raspberry Pi devices to make test more reliable. PR-URL: https://github.com/nodejs/node/pull/18126 Fixes: https://github.com/nodejs/node/issues/16772 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18395 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ruben Bridgewater authored
This removes the `noAssert` argument and also adds some more tests. PR-URL: https://github.com/nodejs/node/pull/18395 Reviewed-By:
-
Ruben Bridgewater authored
There are a lot of changes in this commit: 1) Remove the `noAssert` argument from all read and write functions. 2) Improve the performance of all read floating point functions significantly. This is done by switching to TypedArrays as the write floating point write functions. 3) No implicit type coercion for offset and byteLength anymore. 4) Adds a lot of tests. 5) Moves the read and write functions to the internal buffer file to split the files in smaller chunks. 6) Reworked a lot of existing tests. 7) Improve the performane of all all read write functions by using a faster input validation and by improving function logic. 8) Significantly improved the performance of all read int functions. This is done by using a implementation without a loop. 9) Improved error handling. 10) Rename test file to use the correct subsystem. PR-URL: https://github.com/nodejs/node/pull/18395 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18395 Reviewed-By:
-
Ruben Bridgewater authored
This ports the Buffer#write(Double|Float)(B|L)E functions to JS. This fixes a security issue concerning type confusion and fixes another possible crash in combination with `noAssert`. In addition to that it will also significantly improve the write performance. Fixes: https://github.com/nodejs/node/issues/12179 Fixes: https://github.com/nodejs/node/issues/8724 PR-URL: https://github.com/nodejs/node/pull/18395 Reviewed-By:
-
Ruben Bridgewater authored
The FIXME is obsolete as it was meant about a indentation issue that got fixed a long time ago. PR-URL: https://github.com/nodejs/node/pull/18395 Reviewed-By:
-
- Mar 02, 2018
-
-
Richard Lau authored
libuv and zlib symbols are also purposefully re-exported by Node.js for use in Addons. Refs: https://github.com/nodejs/node/issues/17444 PR-URL: https://github.com/nodejs/node/pull/19013 Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
-
George Sapkin authored
PR-URL: https://github.com/nodejs/node/pull/18080 Reviewed-By:
-
Gabriel Schulhof authored
Passing a pointer to a static integer is sufficient for the test. PR-URL: https://github.com/nodejs/node/pull/19039 Reviewed-By:
Hitesh Kanwathirtha <hiteshk@microsoft.com>
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Anna Henningsen authored
`async` and `bytes` are only interesting when the write is coming from JS, and unnecessary otherwise. Also, make all of the stream `Write*()` bindings use the same code for setting these, and upgrade to the non-deprecated versions. PR-URL: https://github.com/nodejs/node/pull/18963 Reviewed-By:
-
XadillaX authored
Refs: https://github.com/nodejs/node/pull/18673 PR-URL: https://github.com/nodejs/node/pull/18924 Refs: https://github.com/nodejs/node/pull/18673 Refs: https://github.com/nodejs/node/blob/v9.5.0/src/node_http2.cc#L1481-L1484 Refs: https://github.com/nodejs/node/blob/v9.5.0/lib/_http_outgoing.js#L659-L661 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/18924 Fixes: https://github.com/nodejs/node/issues/18169 Refs: https://github.com/nodejs/node/pull/18673 Refs: https://github.com/nodejs/node/blob/v9.5.0/src/node_http2.cc#L1481-L1484 Refs: https://github.com/nodejs/node/blob/v9.5.0/lib/_http_outgoing.js#L659-L661 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
