- Feb 01, 2018
-
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18320 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18320 Reviewed-By:
-
Ruben Bridgewater authored
Due to the destructuring the outer variables were not set anymore. PR-URL: https://github.com/nodejs/node/pull/18320 Reviewed-By:
-
Ruben Bridgewater authored
It should say `win32` and not `posix`. PR-URL: https://github.com/nodejs/node/pull/18320 Reviewed-By:
-
Daniel Bevenius authored
This commit updates node_crypto to use the non-deprecated Set functions that return a v8::Maybe<bool>. PR-URL: https://github.com/nodejs/node/pull/17482 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Rod Vagg authored
Added tests to clarify the implicit behaviour of array header setting vs object header setting PR-URL: https://github.com/nodejs/node/pull/16568 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Bryan English authored
Under some conditions, the error received from getaddrinfo might actually be EAGAIN, meaning the request should be retried. Allowing for 5 retries before erroring out. Also replace one-off function with common.mustNotCall(). PR-URL: https://github.com/nodejs/node/pull/16534 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
I mistakenly introduced user defined variables using uppercase characters, reading the gyp documentation they state: "Predefined variables. By convention, these are named with CAPITAL_LETTERS. Predefined variables are set automatically by GYP" and also "By convention, user-defined variables are named with lowercase_letters." This commit renames the user defined variables to lowercase to follow the above mentioned convention. PR-URL: https://github.com/nodejs/node/pull/16238 Reviewed-By:
-
Ruben Bridgewater authored
Right now it is not documentated that WeakMap entries are not compared. This might result in some confusion. This adds a note about the behavior in `assert.deepStrictEqual`. This documentation is also references in `util.isDeepStrictEqual`, so we do not have to document it again for that function as the underlying algorithm is the same. PR-URL: https://github.com/nodejs/node/pull/18248 Fixes: https://github.com/nodejs/node/issues/18228 Refs: https://github.com/nodejs/node/pull/18228 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Gus Caplan authored
Returns the promises created by link so that they can be awaited to get rid of race conditions while resolving and loading modules. PR-URL: https://github.com/nodejs/node/pull/18394 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Ruben Bridgewater authored
In case no arguments are passed to `assert.ok` it should just use a default message. Otherwise `assert.ok` can not be used as a callback. PR-URL: https://github.com/nodejs/node/pull/18319 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18348 Refs: https://github.com/nodejs/node/issues/18106 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18348 Refs: https://github.com/nodejs/node/issues/18106 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18348 Refs: https://github.com/nodejs/node/issues/18106 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18348 Refs: https://github.com/nodejs/node/issues/18106 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18348 Refs: https://github.com/nodejs/node/issues/18106 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18348 Refs: https://github.com/nodejs/node/issues/18106 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18348 Refs: https://github.com/nodejs/node/issues/18106 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18348 Refs: https://github.com/nodejs/node/issues/18106 Reviewed-By:
-
Rich Trott authored
Move tmpdir functionality to its own module (common/tmpdir). PR-URL: https://github.com/nodejs/node/pull/17856 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
James M Snell authored
Runtime deprecate the crypto.DEFAULT_ENCODING property. This is specifically in preparation for eventual ESM support Refs: https://github.com/nodejs/node/pull/18131 PR-URL: https://github.com/nodejs/node/pull/18333 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Vse Mozhet Byt authored
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: https://github.com/nodejs/node/pull/18444 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Evan Lucas authored
Notable changes: * cluster - add cwd to cluster.settings (cjihrig) [#18399](https://github.com/nodejs/node/pull/18399) * deps - upgrade libuv to 1.19.1 (cjihrig) [#18260](https://github.com/nodejs/node/pull/18260) * meta - add Leko to collaborators (Leko) [#18117](https://github.com/nodejs/node/pull/18117) - add vdeturckheim as collaborator (vdeturckheim) [#18432](https://github.com/nodejs/node/pull/18432) * n-api - expose n-api version in process.versions (Michael Dawson) [#18067](https://github.com/nodejs/node/pull/18067) * perf_hooks - add performance.clear() (James M Snell) [#18046](https://github.com/nodejs/node/pull/18046) * stream - avoid writeAfterEnd() while ending (陈刚) [#18170](https://github.com/nodejs/node/pull/18170) PR-URL: https://github.com/nodejs/node/pull/18464
-
Myles Borins authored
currently if you want to use dynamic import you must use both the `--experimental-modules` and the `--harmony-dynamic-imports` flags. Chrome is currently shipping dynamic import unflagged, the flag only remains in V8 to guard embedders who have not set the appropriate callback from throwing an unhandled rejection when the feature is used. As such it is reasonable to enable the flag by default for `--experimental-modules` PR-URL: https://github.com/nodejs/node/pull/18387 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/18087 Reviewed-By:
-
Aaron Kau authored
PR-URL: https://github.com/nodejs/node/pull/18414 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Rich Trott authored
Welcome Gibson to the TSC! PR-URL: https://github.com/nodejs/node/pull/18481 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/18468 Reviewed-By:
-
- Jan 31, 2018
-
-
Michaël Zasso authored
Install URL and URLSearchParams on the global object, like they can be found in browser environments. PR-URL: https://github.com/nodejs/node/pull/18281 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/18460 Fixes: https://github.com/nodejs/node/issues/18459 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Rich Trott authored
Use common.busyLoop() which happens to make the test robust. PR-URL: https://github.com/nodejs/node/pull/18461 Reviewed-By:
-
Gus Caplan authored
Adds vm.Module, which wraps around ModuleWrap to provide an interface for developers to work with modules in a more reflective manner. Co-authored-by:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/17560 Reviewed-By:
-
Gus Caplan authored
Flattens ContextifyContext allows the context interface to be used in other parts of the code base. PR-URL: https://github.com/nodejs/node/pull/17560 Reviewed-By:
-
Myles Borins authored
Some whitespace was lost when #17489 landed. While I restored the one file causing the V8-CI to fail, I missed the remaining changes from Myles. This changes restores all whitespace differences with upstream. PR-URL: https://github.com/nodejs/node/pull/18366 Refs: https://github.com/nodejs/node/pull/18360 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Ali Ijaz Sheikh authored
It makes more sense to provide instructions on how to update the PR branch before instructions on pushing the commit. PR-URL: https://github.com/nodejs/node/pull/18355 Reviewed-By:
-
Сковорода Никита Андреевич authored
This adds a mention of `--pending-deprecation` flag effect in the Deprecated APIs document, and explicitly labels deprecations that support it. Refs: https://github.com/nodejs/node/issues/18417 PR-URL: https://github.com/nodejs/node/pull/18433 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Сковорода Никита Андреевич authored
This is described as being a doc-only deprecation subset. Refs: https://github.com/nodejs/node/issues/18417 PR-URL: https://github.com/nodejs/node/pull/18433 Reviewed-By:
-
Roman Reiss authored
Fixes: https://github.com/nodejs/node/issues/18434 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
- Jan 30, 2018
-
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/18376 Reviewed-By:
-
