- Apr 07, 2017
-
-
Eugene Ostroukhov authored
This pull request switches the signal handler to start inspector socket server instead of the legacy V8 debug protocol. PR-URL: https://github.com/nodejs/node/pull/11431 Fixes: https://github.com/nodejs/node/issues/8464 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Apr 06, 2017
-
-
Jan Krems authored
In the 2017-04-05 meeting, the CTC agreed to remove support for the legacy debugger in 8.0.0. This is the first step in this direction. Refs: https://github.com/nodejs/CTC/issues/94 PR-URL: https://github.com/nodejs/node/pull/12197 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Refael Ackermann authored
Intention was to get to `PRODUCT_DIR` so no need to do path voodoo Also added `'msvs_quote_cmd': 0` and more precise quoting PR-URL: https://github.com/nodejs/node/pull/11217 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com>
-
Daniel Bevenius authored
This commit adds lldbinit files from upstream V8 and also adds these so that they get installed when `make install` is run. Original commit message: [tools] add lldbinit The goal of this commit is to add the equivalent to gdbinit but for lldb. I've tried to replicate the commands as close as possible but I'm unsure about the jss command and hoping to get some feedback on it in addition to the bta command which I'm not sure how/when this could be used. This is probably just inexperience on my part. The lldbinit file can be placed into a directory prefixed with dot (.lldbinit) and the python script is currently expected to be in the same directory. The path to the script can be changed manually if needed as well. NOTRY=true Review-Url: https://codereview.chromium.org/2758373002 Cr-Commit-Position: refs/heads/master@{#44136} PR-URL: https://github.com/nodejs/node/pull/12061 Reviewed-By: -
Rich Trott authored
The current debugger is slated for removal soon. The debugger test that has been disabled for over four years is unlikely to be repaired at this point. Remove the test and its associated fixture. PR-URL: https://github.com/nodejs/node/pull/12199 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Rich Trott authored
Putting the link for the commit guideline at the bottom of the pull request template makes it a bit confusing when opening a pull request as the markdown does not render. Not everyone is familiar with the syntax used there and it is easy to mess it up (for example, by not leaving a blank line above it). It is more natural and useful if the URL is included inline. PR-URL: https://github.com/nodejs/node/pull/12216 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
alejandro authored
Because the final array length is known, it's better to allocate its final length at initialization time to avoid future reallocations. Also add an explicit buffer length greater than 0 comparison so it's more readable, avoids the internal ToBoolean call and follows the standard Node.js API format (as it can be checked in other similar structures where 'length > 0' is preferred over 'length') PR-URL: https://github.com/nodejs/node/pull/11733 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Matt Loring authored
src/tracing/trace_event.h was updated by applying the following changes: 1) Include src/tracing/trace_event_common.h instead of the one from v8 base. 2) Replace all instances of base::Atomic with intptr_t (trace events can only be generated from the main thread for now). 3) Replace instances of V8_INLINE with inline. 4) Eliminate uses of DCHECK. 5) Eliminate uses of V8_UNLIKELY, the branch predictor should be good enough alone. 6) Change the namespace used by trace_event.h from v8::internal::tracing to node::tracing. 7) Remove CallStatsScopedTracer class and related macros (they rely on V8 implementation details). 8) Change ConvertableToTraceFormat to v8::ConvertableToTraceFormat. 9) Add function "static void SetCurrentPlatform(v8::Platform* platform);" to the declaration of TraceEventHelper. PR-URL: https://github.com/nodejs/node/pull/12127 Reviewed-By:
-
Gabriel Schulhof authored
1. We define struct napi_env__ to include the isolate, the last exception, and the info about the last error. 2. We instantiate one struct napi_env__ during module registration and we pass it into the FunctionCallbackInfo for all subsequent entries into N-API when we create functions/accessors/finalizers. Once module unloading will be supported we shall have to delete the napi_env we create during module init. There is a clear separation between public and private API wrt. env: 1. Public APIs assert that env is not nullptr as their first action. 2. Private APIs need not validate env. They assume it's not nullptr. PR-URL: https://github.com/nodejs/node/pull/12195 Fixes: https://github.com/nodejs/abi-stable-node/issues/198 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Michael Dawson authored
Coverity was complaining that finalizer was being leaked in this method, however it should be freed when the buffer is finalized so I believe the message is invalid. Add the required comments to suppress the warning. PR-URL: https://github.com/nodejs/node/pull/12192 Reviewed-By:
Hitesh Kanwathirtha <hiteshk@microsoft.com>
-
Michael Dawson authored
The v8 n-api implementation had been depending on a one-to-one relationship between v8 and n-api v8 property attributes. Remove this dependency and fix coverity scan issue 165845. PR-URL: https://github.com/nodejs/node/pull/12191 Reviewed-By:
-
- Apr 05, 2017
-
-
Daniel Bevenius authored
Currently it is possible to configure using --without-ssl and --shared-openssl/--openssl-no-asm/openssl-fips without an error occuring. The commit add check for these combinations: $ ./configure --without-ssl --shared-openssl Error: --without-ssl is incompatible with --shared-openssl $ ./configure --without-ssl --openssl-no-asm Error: --without-ssl is incompatible with --openssl-no-asm $ ./configure --without-ssl --openssl-fips=dummy Error: --without-ssl is incompatible with --openssl-fips PR-URL: https://github.com/nodejs/node/pull/12175 Reviewed-By:
-
Daniel Bevenius authored
I noticed that few of the print statements in configure have a leading space with is not consistent with the rest of the file. Not sure if this intentional or not so creating this commit just to bring it up just in case. PR-URL: https://github.com/nodejs/node/pull/12176 Reviewed-By:
-
Vse Mozhet Byt authored
* Replace `var` by `const`. * Comment out ellipses. * Update code example (provide relevant file path, add missing option). PR-URL: https://github.com/nodejs/node/pull/12171 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/11690 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Vinay Hiremath authored
PR-URL: https://github.com/nodejs/node/pull/12221 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
DavidCai authored
PR-URL: https://github.com/nodejs/node/pull/12066 Reviewed-By:
-
Luca Maraschi authored
This test refactored the original test for mkdtempSync prefix validation and added the test also for the async function mkdtemp. PR-URL: https://github.com/nodejs/node/pull/12080 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Alexey Orlenko authored
This test ensures that UTF-8 characters can be used in core JavaScript modules built into Node's binary. PR-URL: https://github.com/nodejs/node/pull/11423 Ref: https://github.com/nodejs/node/pull/11129 Reviewed-By:
-
Jason Marsh authored
PR-URL: https://github.com/nodejs/node/pull/11635 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/11726 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Refael Ackermann authored
look for the actual produced `exe` not just the directory PR-URL: https://github.com/nodejs/node/pull/12120 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com>
-
Lovell Fuller authored
The auth property of a URL is decoded via decodeURIComponent, which can throw a URIError. The test URL here will trigger this. Adds documentation on the possible errors url.parse can throw. PR-URL: https://github.com/nodejs/node/pull/12135 Reviewed-By:
-
Michaël Zasso authored
Something unidentified at the moment is causing the arrays benchmarks to deopt when run with the TurboFan compiler. Refactor the test to use an inner function that can be correctly optimized by TurboFan and Crankshaft. PR-URL: https://github.com/nodejs/node/pull/11894 Ref: https://github.com/nodejs/node/issues/11851#issuecomment-287106714 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Daiki Arai authored
About setImmediate, the execution timing is after timers currently. PR-URL: https://github.com/nodejs/node/pull/12034 Reviewed-By:
-
Daiki Arai authored
About fs.read's 2nd argument, string is invalid. PR-URL: https://github.com/nodejs/node/pull/12034 Reviewed-By:
-
Luigi Pinca authored
Use the remaining listener directly if the array of listeners has only one element after running `EventEmitter.prototype.removeListener()`. Advantages: - Better memory usage and better performance if no new listeners are added for the same event. Disadvantages: - A new array must be created if new listeners are added for the same event. PR-URL: https://github.com/nodejs/node/pull/12043 Reviewed-By:
Ron Korving <ron@ronkorving.nl>
-
Rich Trott authored
ESLint 3.19.0 allows the specification of selectors that represent disallowed syntax. Replace our custom rule for timer arguments with a pair of `no-restricted-syntax` option objects. PR-URL: https://github.com/nodejs/node/pull/12162 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/12162 Reviewed-By:
-
Daniel Bevenius authored
At the moment Argv only supports three arguments which fulfilled my requirements when working on #9163. This commit adds support for a variable number of arguments. There is also a no-args constructor that is the equivalent to running "node -p process.version" which is hopefully alright as a default. PR-URL: https://github.com/nodejs/node/pull/12166 Ref: https://github.com/nodejs/node/pull/9163 Reviewed-By:
-
JR McEntee authored
This commit updates 3 additional references to Mac OS X in releases.md to macOS. PR-URL: https://github.com/nodejs/node/pull/12106 Fixes: https://github.com/nodejs/node/issues/12086 Reviewed-By:
-
JR McEntee authored
This commit updates two paragraphs that exceeded the 80 line standard after updating to macOS. PR-URL: https://github.com/nodejs/node/pull/12106 Fixes: https://github.com/nodejs/node/issues/12086 Reviewed-By:
-
JR McEntee authored
This update changes references to "Mac OS X", "OS X", and "OSX" in markdown files to "macOS". PR-URL: https://github.com/nodejs/node/pull/12106 Fixes: https://github.com/nodejs/node/issues/12086 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/12113 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Raphael Okon authored
Extra notes that options doesn't include the prototype when copied Fixes: https://github.com/nodejs/node/issues/12092 PR-URL: https://github.com/nodejs/node/pull/12124 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12134 Reviewed-By:
-
Refael Ackermann authored
not needed according to official python docs - https://docs.python.org/2/library/subprocess.html#index-2 PR-URL: https://github.com/nodejs/node/pull/12138 Reviewed-By:
-
Alexey Orlenko authored
The fast base64 decoder used to switch to the slow one permanently when it saw a whitespace or other garbage character. Since the most common situation such characters may be encountered in is line-wrapped base64 data, a more profitable strategy is to decode a single 24-bit group with the slow decoder and then continue running the fast algorithm. PR-URL: https://github.com/nodejs/node/pull/12146 Ref: https://github.com/nodejs/node/issues/12114 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
-
Rich Trott authored
internal/util.js definied toInteger() and toLength() but they were only used by buffer.js. Inlining these small functions results in a small but statistically-significant performance gain. PR-URL: https://github.com/nodejs/node/pull/12153 Reviewed-By:
-
DavidCai authored
PR-URL: https://github.com/nodejs/node/pull/12163 Reviewed-By:
-
