- Nov 13, 2018
-
-
Marie Terrier authored
PR-URL: https://github.com/nodejs/node/pull/24286 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Gabriel Schulhof authored
Create a class `PersistentToLocal` which contains three methods, `Strong`, `Weak`, and `Default`: * `Strong` returns a `Local` from a strong persistent reference, * `Weak` returns a `Local` from a weak persistent reference, and * `Default` decides based on `IsWeak()` which of the above two to call. These replace `node::StrongPersistentToLocal()`, `node::WeakPersistentToLocal()`, and `node::PersistentToLocal()`, respectively. PR-URL: https://github.com/nodejs/node/pull/24276 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/24292 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Lauri Piisang authored
There are test cases which validate the useful path of the function never runs the functionality of it is obsoleted by checkInvalidHeaderChar PR-URL: https://github.com/nodejs/node/pull/24173 Reviewed-By:
-
Emanuel Kluge authored
Have the actual value first & the expected value second. PR-URL: https://github.com/nodejs/node/pull/24149 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Paul Hodgson authored
Remove unused parameters triggerAsyncId and resource from oninit function in test-async-await.js. PR-URL: https://github.com/nodejs/node/pull/24268 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
cjihrig authored
Update ESLint to 5.9.0. PR-URL: https://github.com/nodejs/node/pull/24280 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
- Nov 12, 2018
-
-
Fran Herrero authored
PR-URL: https://github.com/nodejs/node/pull/24183 Reviewed-By:
-
kiyomizumia authored
PR-URL: https://github.com/nodejs/node/pull/24178 Reviewed-By:
-
Lauri Piisang authored
add test for tinyurl.com/codeandlearn-encoding-1 add test for tinyurl.com/codeandlearn-encoding-2 PR-URL: https://github.com/nodejs/node/pull/24162 Reviewed-By:
-
Robert Pamely authored
Adds tests assert the deprecated properties and methods in the dgram socket warn. It runs each test in a separate child process since each deprecation will only warn once. PR-URL: https://github.com/nodejs/node/pull/24177 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/24307 Refs: https://github.com/nodejs/build/issues/1568#issuecomment-437681599 Reviewed-By:
-
msmichellegar authored
PR-URL: https://github.com/nodejs/node/pull/24159 Reviewed-By:
-
Osmond van Hemert authored
PR-URL: https://github.com/nodejs/node/pull/24259 Reviewed-By:
-
Petar Dodev authored
Testing some of the more specific cases of using domain.add and domain.remove. For example, calling domain.add twice with same event emmiter and actually removing an event emitter from the domain. PR-URL: https://github.com/nodejs/node/pull/24163 Reviewed-By:
-
Ben Noordhuis authored
There is reason to believe the generated assembly isn't working correctly so let's disable it for now pending further investigation. PR-URL: https://github.com/nodejs/node/pull/24270 Refs: https://github.com/nodejs/node/issues/23913 Reviewed-By:
-
Peter Marshall authored
Original commit message: [heap-profiler] Fix a use-after-free when snapshots are deleted If a caller starts the sampling heap profiler and takes a snapshot, and then deletes the snapshot before the sampling has completed, a use-after-free will occur on the StringsStorage pointer. The same issue applies for StartTrackingHeapObjects which shares the same StringsStorage object. Bug: v8:8373 Change-Id: I5d69d60d3f9465f9dd3b3bef107c204e0fda0643 Reviewed-on: https://chromium-review.googlesource.com/c/1301477 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#57114} PR-URL: https://github.com/nodejs/node/pull/24272 Refs: https://github.com/v8/v8/commit/b87d408f65b9ab49a4d199e850d2358995deaeb2 Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/24127 Reviewed-By:
Mathias Buus <mathiasbuus@gmail.com>
-
Vladyslav Kopylash authored
PR-URL: https://github.com/nodejs/node/pull/24186 Reviewed-By:
-
Alessandro Gatti authored
Add test that creates an error with a control character in the message. PR-URL: https://github.com/nodejs/node/pull/24182 Reviewed-By:
-
Martin Kask authored
Fix the order of assert.strictEqual() arguments. It should have first argument as the calculated/tested value. PR-URL: https://github.com/nodejs/node/pull/24153 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Rod Vagg authored
Was missed on original PR. Ref: https://github.com/nodejs/node/pull/23767 PR-URL: https://github.com/nodejs/node/pull/24240 Refs: https://github.com/nodejs/node/pull/23767 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Morgan Roderick authored
PR-URL: https://github.com/nodejs/node/pull/24188 Reviewed-By:
-
Dmitry Igrishin authored
PR-URL: https://github.com/nodejs/node/pull/24301 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/7.0.276.36...7.0.276.38 PR-URL: https://github.com/nodejs/node/pull/24271 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Michaël Zasso authored
Creating deprecated accessors each time an object is created is very time consuming. Refs: https://github.com/nodejs/node/pull/22747 Fixes: https://github.com/nodejs/node/issues/24266 PR-URL: https://github.com/nodejs/node/pull/24269 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Natalie Cluer authored
Ensure literal values are passed in as second argument PR-URL: https://github.com/nodejs/node/pull/24157 Reviewed-By:
-
Gerhard Stoebich authored
Correct the output of async_hooks samples * `TIMERWRAP` has been removed in #20894 * `console.log()` doesn't issue `TTYWRAP` nor `SIGNALWRAP` I don't know which PR caused that `console.log()` is no longer using `TTYWRAP` and `SIGNALWRAP`; I think it was between 8.4.0 and 8.5.0. PR-URL: https://github.com/nodejs/node/pull/24050 Refs: https://github.com/nodejs/node/pull/20894 Reviewed-By:
-
James Herrington authored
- test argument validation - test function throws if provided group is invalid PR-URL: https://github.com/nodejs/node/pull/24154 Reviewed-By:
-
Daniel Bevenius authored
This commit uses the BUILDTYPE for the benchmark targets that currently explicitly use Release as the build type. The motivation for this change is allows switching between debug builds and release builds using the bench-addons-clean/bench-addons-build targets. PR-URL: https://github.com/nodejs/node/pull/24033 Reviewed-By:
-
- Nov 11, 2018
-
-
Aivo Paas authored
This test case verifies that starting Node.js with the completion bash flag prints out the expected result and ends right after. PR-URL: https://github.com/nodejs/node/pull/24168 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
-
Yehiyam Livneh authored
PR-URL: https://github.com/nodejs/node/pull/24164 Reviewed-By:
-
Ouyang Yadong authored
PR-URL: https://github.com/nodejs/node/pull/24300 Fixes: https://github.com/nodejs/node/issues/23955 Reviewed-By:
-
Ulises Santana Suárez authored
PR-URL: https://github.com/nodejs/node/pull/24192 Reviewed-By:
-
John Mc Quillan authored
The arguments to assert.strictEqual in a number of calls were in the wrong order. It is preferred that literal values are in the second argument. Updates test/parallel/test-fs-readStream.js PR-URL: https://github.com/nodejs/node/pull/24172 Reviewed-By:
-
Marie Terrier authored
PR-URL: https://github.com/nodejs/node/pull/24189 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/24246 Reviewed-By:
-
Daniel Bevenius authored
This commit changes the code to use the maybe version. PR-URL: https://github.com/nodejs/node/pull/24246 Reviewed-By:
-
Richard Lau authored
Move the first commit message linting to a separate Travis job. Run the script in bash debug mode to capture any issues communicating with the GitHub API (e.g. network issues, rate limits). PR-URL: https://github.com/nodejs/node/pull/24254 Reviewed-By:
-
Rich Trott authored
Move benchmark tests (which are slow) out of the main test suite. We can hopefully add them to node-daily-master so that they are still run daily on CI. PR-URL: https://github.com/nodejs/node/pull/24265 Reviewed-By:
-
