- Sep 16, 2015
-
-
Ali Ijaz Sheikh authored
This brings in the patches from 4.5.103.30...4.5.103.33 fixing the issue with computed property names not working in nested literals. Full V8 4.5 commit log at: https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 Fixes: https://github.com/nodejs/node/issues/2507 PR-URL: https://github.com/nodejs/node/pull/2870 Reviewed-By:
indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
- Sep 15, 2015
-
-
Sakthipriyan Vairamani authored
In Python, the default values of parameters are evaluated only once during their declaration. So, whenever the default parameter is used the same object will be used. Since we use a list, which is a mutable object, this could lead to unexpected results. PR-URL: https://github.com/nodejs/node/pull/2553 Reviewed-By:
-
Rod Vagg authored
* buffer: Fixed a minor errors that was causing crashes (Michaël Zasso) #2635, * child_process: Fix error that was causing crashes (Evan Lucas) #2727 * crypto: Replace use of rwlocks, unsafe on Windows XP / 2003 (Ben Noordhuis) #2723 * libuv: Upgrade from 1.7.3 to 1.7.4 (Saúl Ibarra Corretgé) #2817 * node: Fix faulty process.release.libUrl on Windows (Rod Vagg) #2699 * node-gyp: Float v3.0.3 which has improved support for Node.js and io.js v0.10 to v4+ (Rod Vagg) #2700 * npm: Upgrade to version 2.14.3 from 2.13.3, includes a security update, see https://github.com/npm/npm/releases/tag/v2.14.2 for more details, (Kat Marchán) #2696. * timers: Improved timer performance from porting the 0.12 implementation, plus minor fixes (Jeremiah Senkpiel) #2540, (Julien Gilli) nodejs/node-v0.x-archive#8751 nodejs/node-v0.x-archive#8905 PR-URL: https://github.com/nodejs/node/pull/2698
-
Sakthipriyan Vairamani authored
As of v8 4.5, arrow functions are rolled out. This patch allows eslint to accept arrow functions as well. PR-URL: #2840 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Sakthipriyan Vairamani authored
Make `make clean` cleanup the generated tap file as well. Fixes: #2834 PR-URL: #2837 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
Sakthipriyan Vairamani authored
By default the logfile is opened in append mode. This commit makes sure that the file is opened in write-binary mode, so that the file will be created if it doesn't exist or overwrite if it exists. Fixes: #2834 PR-URL: #2837 Reviewed-By:
-
Brendan Ashworth authored
This commit refactors LazyTransform from the crypto implementation (lib/crypto.js) into an internal module (not publicy accessible) in internal/streams/lazy_transform.js. This promotes a more modular core design and removes code bloat in crypto, as LazyTransform didn't specifically have anything to do with cryptography, but rather a fast way to support two APIs on a stream. PR-URL: https://github.com/nodejs/node/pull/2566 Reviewed-By:
-
Fedor Indutny authored
Socket resume may happen on a next tick, and in following scenario: 1. `socket.resume()` 2. `socket._handle.close()` 3. `socket._handle = null;` The `_resume` will be invoked with empty `._handle` property. There is nothing bad about it, and we should just ignore the `resume`/`pause` events in this case. Same applies to the unconsuming of socket on adding `data` and/or `readable` event listeners. Fix: https://github.com/nodejs/node/issues/2821 PR-URL: https://github.com/nodejs/node/pull/2824 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Kat Marchán authored
No more cherry-picked io patches. hooray. PR-URL: https://github.com/nodejs/node/pull/2822 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/2822 Reviewed-By:
-
Yazhong Liu authored
PR-URL: https://github.com/nodejs/node/pull/2387 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ron Korving authored
Streams with writev allow many buffers to be pushed to underlying OS APIs in one batch, in this case improving write throughput by an order of magnitude. This is especially noticeable when writing many (small) buffers. PR-URL: https://github.com/nodejs/node/pull/2167 Reviewed-By:
-
Matt Loring authored
The polyfill is only needed if incorrect command line arguments are passed to the script so it was missed in initial testing. PR-URL: https://github.com/nodejs/node/pull/2694 Reviewed-By:
-
Matt Loring authored
Per the discussion on #2471, the JS symbols checked for by this test were occasionally too deep in the stack and were being ignored by the tick processor. I have addressed this by increasing the stack depth inspected by the tick processor and looking for the eval symbol which is more likely to be present. Additional flakiness was caused by occasional misses of the code creation event for the JS function being executed. I now have separate code snippets to test for JS and C++ symbols and if the code creation event is missed for the JS symbol test then I check for a percentage of UNKNOWN symbols in processed output. This is considered a success as the processing scripts in the node repository are still correctly processing the ticks recieved from the v8 scripts. Further investigation is needed into the v8 profiling scripts to determine why code creation events are being missed. PR-URL: https://github.com/nodejs/node/pull/2694 Reviewed-By:
-
Danny Nemer authored
PR-URL: https://github.com/nodejs/node/pull/2827 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Ionică Bizău authored
- Fixed typo: "insallation" -> "installation" - Added an "that" in a sentence where it was needed for clarity. PR-URL: https://github.com/nodejs/node/pull/2852 Reviewed-By:
-
Mike Tunnicliffe authored
Refs: https://github.com/nodejs/node/issues/2413 PR-URL: https://github.com/nodejs/node/pull/2826 Reviewed-By:
-
Roman Klauke authored
Other methods like `After` already use ZCtxt as the source for Enviroment/ v8::Isolate objects, this commit applies the same style to the other missing methods (`After sync` and `Write`) PR-URL: https://github.com/nodejs/node/pull/2547 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
-
- Sep 14, 2015
-
-
Rich Trott authored
Remove test file that has been in disabled from its very first commit (9ccf0e52) in 2011. It is a test for https://github.com/nodejs/node-v0.x-archive/issues/670 from 2011. There are no assertions in the test. In that regard, it is more debugging code than a test. PR-URL: https://github.com/nodejs/node/pull/2841 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com>
-
Jeremiah Senkpiel authored
`process.stdout` always blocks as of 20176a98 `WritableState.buffer` is `getBuffer()` as of 91586661 PR-URL: https://github.com/nodejs/node/pull/2549 Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Tristian Flanagan authored
Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2846
-
- Sep 13, 2015
-
-
Rich Trott authored
For whatever reason, the CI win2012 machine was timing out on the internet test-dns file. Split out ipv4 and ipv6 specific tests to separate files so tests do not time out. (Each file is given a 60 second timeout on CI. Tests within a file are run in sequence.) PR-URL: https://github.com/nodejs/node/pull/2802 Fixes: https://github.com/nodejs/node/issues/2468 Reviewed-By:
-
Rich Trott authored
test-dgram-broadcast-multi-process.js and test-dgram-multicast-multi-process.js were failing on Pi 1 because the test was timing out. Changed static 5000ms timeout to a dynamically determined timeout based on the processor using common.platformTimeout(). PR-URL: https://github.com/nodejs/node/pull/2808 Reviewed-By:
-
- Sep 12, 2015
-
-
Sakthipriyan Vairamani authored
As it is, the TAP result shows an extra hyphen in front of test names. Sample: ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/ This patch removes the extra hyphen. PR-URL: https://github.com/nodejs/node/pull/2718 Reviewed-By:
-
Oleksandr Chekhovskyi authored
Ensure that samples are evenly distributed, which is required for v8::CpuProfiler users to work correctly (v8-profiler / node-inspector). PR-URL: https://github.com/nodejs/node/pull/2324 Reviewed-By:
-
Saúl Ibarra Corretgé authored
PR-URL: https://github.com/nodejs/node/pull/2817 Reviewed-By:
-
- Sep 11, 2015
-
-
Minwoo Jung authored
"Calls" is used frequently throughout the docs except for this line. Use "Calls" over "Executes" to make it consistent. PR-URL: https://github.com/nodejs/node/pull/2800 Reviewed-By:
-
Rich Trott authored
Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: https://github.com/nodejs/node/issues/2468 PR-URL: https://github.com/nodejs/node/pull/2785 Reviewed-By:
-
Anne-Gaelle Colom authored
behaviour -> behavior PR-URL: https://github.com/nodejs/node/pull/2784 Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By:
-
Fedor Indutny authored
Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: https://github.com/nodejs/node/issues/2463 PR-URL: https://github.com/nodejs/node/pull/2801 Reviewed-By: -
Fedor Indutny authored
Do not let the module struct to be deallocated by `uv_dlclose` before reading data from it. PR-URL: https://github.com/nodejs/node/pull/2792 Reviewed-By:
-
- Sep 10, 2015
-
-
Anne-Gaelle Colom authored
PR-URL: https://github.com/nodejs/node/pull/2765 Reviewed-By:
-
Brian White authored
Fixes: https://github.com/nodejs/node/issues/2779 PR-URL: https://github.com/nodejs/node/pull/2781 Reviewed-By:
-
Sam Roberts authored
Reviewed-By:
-
- Sep 09, 2015
-
-
Rich Trott authored
FreeBSD does not support the V4MAPPED flag so expect an error. This is a partial fix for https://github.com/nodejs/node/issues/2468. It only fixes it on FreeBSD. Failures on other platforms are due to other reasons and need to be fixed separately. PR-URL: https://github.com/nodejs/node/pull/2724 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Rod Vagg authored
This list of changes is relative to the last io.js v3.x branch release, v3.3.0. Please see the list of notable changes in the v3.x, v2.x and v1.x releases for a more complete list of changes from 0.12.x. Note, that some changes in the v3.x series as well as major breaking changes in this release constitute changes required for full convergence of the Node.js and io.js projects. * child_process: ChildProcess.prototype.send() and process.send() operate asynchronously across all platforms so an optional callback parameter has been introduced that will be invoked once the message has been sent, i.e. .send(message[, sendHandle][, callback]) (Ben Noordhuis) #2620. * node: Rename "io.js" code to "Node.js" (cjihrig) #2367. * node-gyp: This release bundles an updated version of node-gyp that works with all versions of Node.js and io.js including nightly and release candidate builds. From io.js v3 and Node.js v4 onward, it will only download a headers tarball when building addons rather than the entire source. (Rod Vagg) #2700. * npm: Upgrade to version 2.14.2 from 2.13.3, includes a security update, see https://github.com/npm/npm/releases/tag/v2.14.2 for more details, (Kat Marchán) #2696. * timers: Improved timer performance from porting the 0.12 implementation, plus minor fixes (Jeremiah Senkpiel) #2540, (Julien Gilli) nodejs/node-v0.x-archive#8751 nodejs/node-v0.x-archive#8905 * util: The util.is*() functions have been deprecated, beginning with deprecation warnings in the documentation for this release, users are encouraged to seek more robust alternatives in the npm registry, (Sakthipriyan Vairamani) #2447. * v8: Upgrade to version 4.5.103.30 from 4.4.63.30 (Ali Ijaz Sheikh) #2632. - Implement new TypedArray prototype methods: copyWithin(), every(), fill(), filter(), find(), findIndex(), forEach(), indexOf(), join(), lastIndexOf(), map(), reduce(), reduceRight(), reverse(), slice(), some(), sort(). See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray for further information. - Implement new TypedArray.from() and TypedArray.of() functions. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray for further information. - Implement arrow functions. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions for further information. - Full ChangeLog available at https://github.com/v8/v8-git-mirror/blob/4.5.103/ChangeLog PR-URL: https://github.com/nodejs/node/pull/2742 Reviewed-By:
-
Rich Trott authored
This fixes a minor typographical error in the Assertion Testing doc. PR-URL: https://github.com/nodejs/node/pull/2728 Reviewed-By:
-
- Sep 08, 2015
-
-
Karl Skomski authored
It was previously ignored by features.gypi and therefore enabled by default for release builds. See https://code.google.com/p/chromium/issues/detail?id=318206 PR-URL: https://github.com/nodejs/node/pull/2731 Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2737 Reviewed-By:
-
Fedor Indutny authored
This a backport of the following commits from the v8's upstream: * 1a8c38c50513f9af07ada479629a653e1cf36ff3 * 206f12abee3f1e7eda8fc6521d48f3c319460ee1 * 9e3676da9ab1aaf7de3e8582cb3fdefcc3dbaf33 Original commit message: heap: make array buffer maps disjoint Remove intersection from the `std::map`s representing current live ArrayBuffers. While being simpler to understand, it poses significant performance issue for the active ArrayBuffer users (like node.js). Store buffers separately, and process them together during mark-sweep phase. The results of benchmarks are: $ ./node-slow bench && ./node-fast bench 4997.4 ns/op 4685.7 ns/op NOTE: `fast` - was a patched node.js, `slow` - unpatched node.js with vanilla v8. PR-URL: https://github.com/nodejs/node/pull/2732 Reviewed-By:
-
