- Aug 05, 2014
-
-
Julien Gilli authored
When backporting f8193ab3 into v0.10, a regression was introduced. Timers with non-integer timeout could trigger a infinite recursion with 100% cpu usage. This commit backports 93b06246 which fixes the regression. After backporting f8193ab3, instead of using Date.now(), timers would use Timer.now() to determine if they had expired. However, Timer.now() is based on loop->time, which is not updated when a timer's remaining time is > 0 and < 1. Timers would thus never timeout if their remaining time was at some point > 0 and < 1. With this commit, Timer.now() updates loop->time itself, and timers always timeout eventually. Fixes #8065 and #8068.
-
- Aug 02, 2014
-
-
Sam Roberts authored
Callbacks in node are usually asynchronous, and should never be sometimes synchronous, and sometimes asynchronous. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
James Halliday authored
A streams1 stream will have its falsy values such as 0, false, or "" eaten by the upgrade to streams2, even when objectMode is enabled. Include test for said cases. Reviewed-by:
isaacs <i@izs.me> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Aug 01, 2014
-
-
Jakob Gillich authored
Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
* uv: Upgrade to v0.10.28 * npm: Upgrade to v1.4.21 * v8: Interrupts must not mask stack overflow. * Revert "stream: start old-mode read in a next tick" (Fedor Indutny) * buffer: fix sign overflow in `readUIn32BE` (Fedor Indutny) * buffer: improve {read,write}{U}Int* methods (Nick Apperson) * child_process: handle writeUtf8String error (Fedor Indutny) * deps: backport 4ed5fde4f from v8 upstream (Fedor Indutny) * deps: cherry-pick eca441b2 from OpenSSL (Fedor Indutny) * lib: remove and restructure calls to isNaN() (cjihrig) * module: eliminate double `getenv()` (Maciej Małecki) * stream2: flush extant data on read of ended stream (Chris Dickinson) * streams: remove unused require('assert') (Rod Vagg) * timers: backport f8193ab3 (Julien Gilli) * util.h: interface compatibility (Oguz Bastemur) * zlib: do not crash on write after close (Fedor Indutny) -
Timothy J Fontaine authored
-
Fedor Indutny authored
Backport of https://codereview.chromium.org/339883002
-
Timothy J Fontaine authored
-
- Jul 31, 2014
-
-
Maciej Małecki authored
`process.env` access results in a synchronous `getenv` call. Cache the first result instead and save one syscall.
-
Rod Vagg authored
-
Julien Gilli authored
Original commit message: timers: use uv_now instead of Date.now This saves a few calls to gettimeofday which can be expensive, and potentially subject to clock drift. Instead use the loop time which uses hrtime internally. In addition to the backport, this commit: - keeps _idleStart timers' property which is still set to Date.now() to avoid breaking existing code that uses it, even if its use is discouraged. - adds automated tests. These tests use a specific branch of libfaketime that hasn't been submitted upstream yet. libfaketime is git cloned if needed when running automated tests. Signed-off-by:Timothy J Fontaine <tjfontaine@gmail.com>
-
Fedor Indutny authored
fix #8026 Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
- Jul 29, 2014
-
-
Fedor Indutny authored
`|` operation takes precendence on `+`, which will result in `new Buffer('ffffffff', 16).readUInt32BE(0)` returning `-1` instead of `ffffffff`.
-
- Jul 24, 2014
-
-
Fedor Indutny authored
-
Fedor Indutny authored
fix #7963
-
Sam Roberts authored
Documentation claimed it accepted a single label argument, as time and timeEnd do, which was incorrect. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
- Jul 23, 2014
-
-
Fedor Indutny authored
Expose missing constants and keep symbols on OSX.
-
- Jul 18, 2014
-
-
Fedor Indutny authored
Original commit message: Fix x64 MathMinMax for negative untagged int32 arguments. An untagged int32 has zeros in the upper half even if it is negative. Using cmpq to compare such numbers will incorrectly ignore the sign. BUG=164442 R=mvstanton@chromium.org Review URL: https://chromiumcodereview.appspot.com/11665007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@13273 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
- Jul 17, 2014
-
-
Fedor Indutny authored
Pass `-force_load` to linker when linking to `libv8_base` to preserve `v8dbg_` symbols, which are useful for debugging.
-
- Jul 15, 2014
-
-
Fedor Indutny authored
-
Chris Dickinson authored
A ReadableStream with a base64 StringDecoder backed by only one or two bytes would fail to output its partial data before ending. This fix adds a check to see if the `read` was triggered by an internal `flow`, and if so, empties any remaining data. fixes #7914. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
- Jul 12, 2014
-
-
Fedor Indutny authored
When handling `writeUtf8String` error, return after emitting it. Otherwise a runtime failure can occur. fix #7923
-
- Jul 10, 2014
-
-
cjihrig authored
Switch condition order to check for null before calling isNaN(). Also remove two unnecessary calls to isNaN() that are already covered by calls to isFinite(). This commit targets v0.10, as opposed to #7891, which targets master (suggested by @bnoordhuis). Closes #7840. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
- Jul 07, 2014
-
-
Maurice Butler authored
Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Sam Roberts authored
Documentation for console.assert incorrectly described message as a single message, but it is a format. Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
- Jul 03, 2014
-
-
Fedor Indutny authored
Original commit message: bn_exp.c: fix x86_64-specific crash with one-word modulus. PR: #3397 Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
V8 seems to ignore the default value for want_separate_host_toolset and would override it at build time. Instead always explicitly set the value. Fixes #7833
-
Brian White authored
Signed-off-by:Trevor Norris <trev.norris@gmail.com>
-
Fedor Indutny authored
It appears that it is defined unconditionally on all supported unixes. fix #7867 #7855 Signed-off-by:Trevor Norris <trev.norris@gmail.com>
-
Fedor Indutny authored
This reverts commit 00890e43 . Signed-off-by:
Trevor Norris <trev.norris@gmail.com>
-
Fedor Indutny authored
This reverts commit 885142a5 . Signed-off-by:
Trevor Norris <trev.norris@gmail.com>
-
- Jun 30, 2014
-
-
Fedor Indutny authored
This reverts commit 2efe4ab7.
-
- Jun 27, 2014
-
-
Fedor Indutny authored
fix #7767 Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
Oguz Bastemur authored
Signed-off-by:Fedor Indutny <fedor@indutny.com>
-
- Jun 24, 2014
-
-
Nick Apperson authored
Increase the performance and simplify the logic of Buffer#write{U}Int* and Buffer#read{U}Int* methods by placing the byte manipulation code directly inline. Also improve the speed of buffer-write benchmarks by creating a new call directly to each method by using Function() instead of calling by buff[fn]. Signed-off-by:Trevor Norris <trev.norris@gmail.com> Conflicts: lib/buffer.js
-
- Jun 23, 2014
-
-
Ben Noordhuis authored
It's possible to construct a typed array from a buffer but the buffer is treated as an array, not a byte array as one might expect. Fixes #7786. Signed-off-by:Trevor Norris <trev.norris@gmail.com>
-
- Jun 17, 2014
-
-
Timothy J Fontaine authored
fixes #7793
-
- Jun 14, 2014
-
-
Timothy J Fontaine authored
Building MSIs for different arch's can sometimes confuse MSBuild and Wix, isntead run the toolchain externally so we don't have to worry about which arch cmd.exe is running as.
-