- Dec 02, 2013
-
-
Timothy J Fontaine authored
Previously we were building the symbols, but the linker was garbage collecting the symbols because they weren't used. Inform the linker that we want to keep all symbols from v8 around.
-
- Nov 30, 2013
-
-
Yazhong Liu authored
-
- Nov 29, 2013
-
-
Michael Ridgway authored
-
Nikolai Vavilov authored
-
- Nov 27, 2013
-
-
Ben Noordhuis authored
Replace call to Number::New() with a call to Integer::NewFromUnsigned(). Profiling a Real World(TM) application with perf(1) suggests that the conversion of its argument from integer to double is disproportionally costly: over 60% of CPU cycles accountable to WriteStringImpl() are attributable to the conversion. After changing it to Integer::NewFromUnsigned(), WriteStringImpl() has dropped from the 'most costly functions' top ten altogether.
-
- Nov 26, 2013
-
-
isaacs authored
-
- Nov 23, 2013
-
-
Linus Unnebäck authored
Clarify that an 'error' event may or may not be followed by an 'exit' event and that it's not safe to make assumptions either way.
-
Jeremy Martin authored
Check that `listeners` is actually an array before trying to manipulate it because it won't be if no regular event listeners have been registered yet but there are 'removeListener' event listeners.
-
- Nov 21, 2013
-
-
Timothy J Fontaine authored
-
isaacs authored
-
- Nov 19, 2013
-
-
Fedor Indutny authored
Add NOTE section in documentation, mentioning that `randomBytes` won't block when entropy sources are drained. fix #6372
-
Fedor Indutny authored
-
Fedor Indutny authored
`Socket` no longer accepts `type` option, and also accepts `readable`, `writable` options. fix #6541
-
Fedor Indutny authored
v8's `messages.js` file's `CallSiteGetMethodName` is running through all object properties and getter to figure out method name of function that appears in stack trace. This run-through will also read `fd` property of `UDPWrap` instance's javascript object, making `UNWRAP()` fail. As a simple alternative to the test case above, one could just keep reference to the dgram handle and try accessing `handle.fd` after it has been fully closed. fix #6536
-
- Nov 15, 2013
-
-
Ben Noordhuis authored
Node.js. It's not just for SF hipsters anymore.
-
Ben Noordhuis authored
This commit introduces some long lines but it's HTML so it's okay.
-
- Nov 13, 2013
-
-
Fedor Indutny authored
-
Tim Wood authored
Emitting an event within a `EventEmitter#once` callback of the same event name will cause subsequent `EventEmitter#once` listeners of the same name to be called multiple times. var emitter = new EventEmitter(); emitter.once('e', function() { emitter.emit('e'); console.log(1); }); emitter.once('e', function() { console.log(2); }); emitter.emit('e'); // Output // 2 // 1 // 2 Fix the issue, by calling the listener method only if it was not already called. -
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
* npm: Upgrade to 1.3.14 * uv: Upgrade to v0.10.19 * child_process: don't assert on stale file descriptor events (Fedor Indutny) * darwin: Fix "Not Responding" in Mavericks activity monitor (Fedor Indutny) * debugger: Fix bug in sb() with unnamed script (Maxim Bogushevich) * repl: do not insert duplicates into completions (Maciej Małecki) * src: Fix memory leak on closed handles (Timothy J Fontaine) * tls: prevent stalls by using read(0) (Fedor Indutny) * v8: use correct timezone information on Solaris (Maciej Małecki)
-
Timothy J Fontaine authored
Fixes a 4 byte leak on handles closing. AKA The Walmart leak. MakeCallback doesn't have a HandleScope. That means the callers scope will retain ownership of created handles from MakeCallback and related. There is by default a wrapping HandleScope before uv_run, if the caller doesn't have a HandleScope on the stack the global will take ownership which won't be reaped until the uv loop exits. If a uv callback is fired, and there is no enclosing HandleScope in the cb, you will appear to leak 4-bytes for every invocation. Take heed. cc @hueniverse
-
Timothy J Fontaine authored
-
- Nov 12, 2013
-
-
yangguo@chromium.org authored
`timezone` variable contains the difference, in seconds, between UTC and local standard time (see `man 3 localtime` on Solaris). Call to `tzset` is required to apply contents of `TZ` variable to `timezone` variable. BUG=v8:2064 Review URL: https://chromiumcodereview.appspot.com/10967066 Patch from Maciej Małecki <me@mmalecki.com>. This is a back-port of upstream commit r12802 and a forward port of commit 9fa953d3 from the v0.8 branch. V8 3.22 in the master branch contains the patch so no further forward-porting is necessary.
-
Maciej Małecki authored
Fix invalid `hasOwnProperty` function usage. For example, before in the REPL: ``` > Ar<Tab> Array Array ArrayBuffer ``` Now: ``` > Ar<Tab> Array ArrayBuffer ``` Fixes #6255. Closes #6498.
-
- Nov 11, 2013
-
-
Timothy J Fontaine authored
-
- Nov 10, 2013
-
-
Ben Noordhuis authored
The security fix from commit 6b92a713 also back-ported the test case. Said test case relies on API that is only available in newer versions of V8 and, as a result, broke the `make native` and `make <arch.mode>` builds. This commit reverts that part of the back-port. Fixes the following build error: ../test/cctest/test-api.cc: In function ‘void TestRegress260106()’: ../test/cctest/test-api.cc:17712:34: error: ‘class v8::Context’ has no member named ‘GetIsolate’
-
- Nov 09, 2013
-
-
Fedor Indutny authored
Do not `.push()` the same data as just passed to `.ondata()`, it may be read by 'data' event listeners. fix #6277
-
isaacs authored
-
- Nov 08, 2013
-
-
Fedor Indutny authored
NOTE: it wasn't in 0.8 fixes #6386
-
- Nov 01, 2013
-
-
isaacs authored
Several names/urls were out of date, and some really awesome stuff was missing.
-
Sam Roberts authored
Partly lifted from uv.h, partly from observation of node.cc.
-
- Oct 31, 2013
-
-
Timothy J Fontaine authored
-
- Oct 29, 2013
-
-
Ben Noordhuis authored
Make it clear that the address argument is not really optional and fix some Engrish and long lines while we're here. Fixes #6433.
-
isaacs authored
-
- Oct 28, 2013
-
-
Phillip Alexander authored
-
- Oct 27, 2013
-
-
Ryan Graham authored
Expands on when to use module.exports vs. exports. This is a recurring question on mailing list and continues to confuse new devs.
-
- Oct 26, 2013
-
-
Sam Roberts authored
-
Brian White authored
-