- Aug 30, 2018
-
-
Sam Ruby authored
Parse source code using acorn; extracting exports. When producing documentation, match exports to headers. When a match is found, add a [src] link. This first commit handles simple exported classes and functions, and does so without requiring any changes to the source code or markdown. Subsequent commits will attempt to match more headers, and some of these changes are likely to require changes to the source code and/or markdown. PR-URL: https://github.com/nodejs/node/pull/22405 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Refael Ackermann authored
* extract the gist into common.pwdCommand * Merge test-child-process-buffering.js into test-child-process-stdio.js PR-URL: https://github.com/nodejs/node/pull/22522 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/22482 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/22477 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
- Aug 29, 2018
-
-
Ujjwal Sharma authored
Adds a method compileFunction to the vm module, which serves as a binding for v8::CompileFunctionInContext with appropriate args for specifying the details, and provide params for the wrapper. Eventually, we would be changing Module._compile to use this internally over the standard Module.wrap PR-URL: https://github.com/nodejs/node/pull/21571 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Vse Mozhet Byt authored
Some nits were also fixed in passing. PR-URL: https://github.com/nodejs/node/pull/22537 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Michaël Zasso authored
This overload was added in V8 6.9 and the one without the isolate parameter was removed in V8 7.0. Refs: https://github.com/v8/v8/commit/3dd5c6fe38355b8323597341409b37f931de5a85 PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Michaël Zasso authored
These overloads were added in V8 6.9 and the ones without the isolate parameter were removed in V8 7.0. Refs: https://github.com/v8/v8/commit/8a011b57d8b26e9cfe1c20a2ef26adb14be6ecc2 PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Michaël Zasso authored
This overload was added in V8 6.9 and the one without isolate was removed in V8 7.0. Refs: https://github.com/v8/v8/commit/8a011b57d8b26e9cfe1c20a2ef26adb14be6ecc2 PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/22564 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/22480 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
Lucas Woo authored
PR-URL: https://github.com/nodejs/node/pull/22430 Reviewed-By:
George Adams <george.adams@uk.ibm.com>
-
- Aug 28, 2018
-
-
Anna Henningsen authored
We generally add these to all headers that are considered internal to Node. These aren’t distributed as part of the headers tarball, so I think this does not have to be semver-major (and we have been changing the APIs in these headers freely anyway). PR-URL: https://github.com/nodejs/node/pull/22514 Reviewed-By:
-
Gireesh Punathil authored
charcter device streaming works just like any other streams, but hangs on the close callsite due to the worker thread being blocked on the read and main thread waiting for any async event that may not occur. Document this behavior and suggest a potential workaround. Fixes: https://github.com/nodejs/node/issues/15439 PR-URL: https://github.com/nodejs/node/pull/21212 Reviewed-By:
-
Michaël Zasso authored
Partially backport an upstream commit that deprecates String::Concat without the isolate parameter. This overload has already been removed in V8 7.0. PR-URL: https://github.com/nodejs/node/pull/22521 Refs: https://github.com/v8/v8/commit/8a011b57d8b26e9cfe1c20a2ef26adb14be6ecc2 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
-
Lars-Magnus Skog authored
The idle_running member variable in TsFn is always false and can therefore be removed. PR-URL: https://github.com/nodejs/node/pull/22520 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
-
Michael Dawson authored
PR-URL: https://github.com/nodejs/node/pull/21870 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/22465 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Yaniv Friedensohn authored
PR-URL: https://github.com/nodejs/node/pull/22444 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/22479 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
Sarat Addepalli authored
doc: Update child_process docs, stating typed arrays are allowed. error: Update error message for `ERR_INVALID_SYNC_FORK_INPUT` lib: Use isArrayBufferView instead of isUint8Array test: Update test-child-process-spawnsync-input to test for all typed arrays and data view. PR-URL: https://github.com/nodejs/node/pull/22409 Reviewed-By:
-
- Aug 27, 2018
-
-
Scott Van Gilder authored
Remove 3rd argument from assert.deepStrictEqual() in test/parallel/test-stream2-writable.js to allow for debugging to work properly. PR-URL: https://github.com/nodejs/node/pull/22512 Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/22268 PR-URL: https://github.com/nodejs/node/pull/22486 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Ruben Bridgewater authored
The stack was removed later on instead of never being attached in the first place. PR-URL: https://github.com/nodejs/node/pull/22436 Refs: https://github.com/nodejs/node/issues/20253 Reviewed-By:
-
Ruben Bridgewater authored
1) Currently extra properties on an error will be ignored, if thrown. This information will from now on be visible. 2) In case someone threw a non error object it would have resulted in `[object Object]`. Instead, the full object will now be visible. 3) Some cases were not detected properly as error before and "Thrown: " was visible before. That is now fixed. PR-URL: https://github.com/nodejs/node/pull/22436 Refs: https://github.com/nodejs/node/issues/20253 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22501 Fixes: https://github.com/nodejs/node/issues/22425 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22501 Reviewed-By:
-
Rich Trott authored
Remove `It is important to note that` and italics from `waitForTrailers` sentences. PR-URL: https://github.com/nodejs/node/pull/22541 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/22542 Reviewed-By:
-
Daniel Bevenius authored
This commit makes the async_wrap builtin an internal builtin, and changes usage of the builtin from using process.binding('async_wrap') to use internalBinding instead. Refs: https://github.com/nodejs/node/issues/22160 PR-URL: https://github.com/nodejs/node/pull/22469 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By: -
Sam Ruby authored
Imported from the tarball published on npm (https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz). Update to emcaScript version 10 in order to get support for binding-less catch statements. Also needed to parse node.js lib API in #22405. PR-URL: https://github.com/nodejs/node/pull/22488 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
-
- Aug 26, 2018
-
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/22525 Reviewed-By:
-
Anna Henningsen authored
The previous wording sounded like this was a necessary for contributing. This clarifies that it is not, and tells people what we do use their info for. PR-URL: https://github.com/nodejs/node/pull/22433 Reviewed-By:
-
Anna Henningsen authored
I, uhm, might have messed up by using a `substr(start, end)` signature when `std::string` actually uses `substr(start, len)`. Fix that. Fixes: https://github.com/nodejs/node/issues/22526 Refs: https://github.com/nodejs/node/pull/22392 PR-URL: https://github.com/nodejs/node/pull/22529 Reviewed-By:
-
Sarat Addepalli authored
PR-URL: https://github.com/nodejs/node/pull/22100 Fixes: https://github.com/nodejs/node/issues/22061 Refs: https://github.com/nodejs/node/pull/21491 Reviewed-By:
-
Sarat Addepalli authored
PR-URL: https://github.com/nodejs/node/pull/22100 Reviewed-By:
-
- Aug 25, 2018
-
-
Michaël Zasso authored
`npm ci` fails where there is no package-lock.json. Also add the `node_modules` directory to .gitignore. PR-URL: https://github.com/nodejs/node/pull/22500 Reviewed-By:
-
