- Dec 26, 2016
-
-
Vse Mozhet Byt authored
Replaced with an object shorthand and an arrow function. PR-URL: https://github.com/nodejs/node/pull/10244 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Vse Mozhet Byt authored
`eval` => `myEval` to not shadow the global `eval` PR-URL: https://github.com/nodejs/node/pull/10244 Reviewed-By:
-
Vse Mozhet Byt authored
Make `_` reassignment example match more with the current output. Extend the example for more clarity. PR-URL: https://github.com/nodejs/node/pull/10244 Reviewed-By:
-
Vse Mozhet Byt authored
Add an infix space in an argument list. Change `>` into `> ` in code bits and output examples. Explicitly clarify that default REPL prompt contains a trailing space. PR-URL: https://github.com/nodejs/node/pull/10244 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/10244 Reviewed-By:
-
cjihrig authored
This commit removes C++ checks from spawn() and spawnSync() that are duplicates of the JavaScript type checking. Fixes: https://github.com/nodejs/node/issues/8096 Fixes: https://github.com/nodejs/node/issues/8539 Refs: https://github.com/nodejs/node/issues/9722 PR-URL: https://github.com/nodejs/node/pull/8312 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
cjihrig authored
This commit applies stricter input validation in normalizeSpawnArguments(), which is run by all of the child_process methods. Additional checks are added for spawnSync() specific inputs. Fixes: https://github.com/nodejs/node/issues/8096 Fixes: https://github.com/nodejs/node/issues/8539 Refs: https://github.com/nodejs/node/issues/9722 PR-URL: https://github.com/nodejs/node/pull/8312 Reviewed-By:
-
cjihrig authored
This commit verifies that the child process handle is of the correct type before trying to close it in CloseHandlesAndDeleteLoop(). This catches the case where input validation failed, and the child process was never actually spawned. Fixes: https://github.com/nodejs/node/issues/8096 Fixes: https://github.com/nodejs/node/issues/8539 Refs: https://github.com/nodejs/node/issues/9722 PR-URL: https://github.com/nodejs/node/pull/8312 Reviewed-By:
-
- Dec 25, 2016
-
-
Junshu Okamoto authored
Currently, around line 417 lib/url.js is truncating hostname and put the rest of hostname to the path if hostname length after `.` is equal or more than 63. This behavior is different from browser behavior. I changed the code so that it doesn’t truncate. I also added the test example which has more than 63 length in after `.` in hostname in test url. PR-URL: https://github.com/nodejs/node/pull/9292 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
sarahmeyer authored
Currently, two of the guides in the `/doc/guides` directory are actually guides for working on the Nodei.js project. Of those, one is linked from this page. This change adds a note to point people to the other. PR-URL: https://github.com/nodejs/node/pull/10070 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
larissayvette authored
PR-URL: https://github.com/nodejs/node/pull/10359 Reviewed-By:
Julian Duque <julianduquej@gmail.com> Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
-
Joyee Cheung authored
Adds test for transcoding an empty buffer. PR-URL: https://github.com/nodejs/node/pull/10437 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Kailean Courtney authored
* Change vars to let/const * Add mustCall * equal -> strictEqual * remove timeout PR-URL: https://github.com/nodejs/node/pull/9931 Reviewed-By:
-
- Dec 24, 2016
-
-
malen authored
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: https://github.com/nodejs/node/pull/9990 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Jeremy Yallop authored
Extend `fs.realpathSync` to cache the results for paths that are not symlinks in addition to caching symlink mappings. PR-URL: https://github.com/nodejs/node/pull/10253 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10360 Reviewed-By:
-
This test runs based on a expectation that the stderr will get the string 'Debugger listening on port'. But the actual message printed to stderr has changed to 'Debugger listening on host:port'. So the the actuals tests did not even start and eventually timeout. Apart from that, changed `var`s to `let`s or `const`s. Refs: https://github.com/nodejs/node/issues/10361 PR-URL: https://github.com/nodejs/node/pull/10370 Reviewed-By:
-
René Schünemann authored
The destroy_ids_idle_handle_ needs to be closed on environment destruction. Not closing the handle leaves a dangling pointer in the used uv loop. This leads to undefined behavior when the uv loop is used after the environment has been destroyed. PR-URL: https://github.com/nodejs/node/pull/10385 Reviewed-By:
-
Christy Leung authored
* var -> const * add RegExp to assert.throws() to check error message PR-URL: https://github.com/nodejs/node/pull/10016 Reviewed-By:
-
Ken Russo authored
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument. PR-URL: https://github.com/nodejs/node/pull/9987 Reviewed-By:
-
Josh Mays authored
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: https://github.com/nodejs/node/pull/10054 Reviewed-By:
-
Brian Chirgwin authored
var -> let / const added common.mustCall() to callback assert.equal() -> assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/10017 Reviewed-By:
-
Harish Tejwani authored
change var to const and add mustCall PR-URL: https://github.com/nodejs/node/pull/9954 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
-
Amar Zavery authored
- `var` --> `const` as applicable - `assert.equal` --> `assert.strictEqual` - `assert(false, ..)` --> `common.fail()` - `common.mustCall` for functions that need to be called exactly once - modified an `assert(!signal, 'Worker exited by a signal');` call to `assert.strictEqual(signal, null);` call as that made more sense PR-URL: https://github.com/nodejs/node/pull/10049 Reviewed-By:
-
Kevin Cox authored
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output. PR-URL: https://github.com/nodejs/node/pull/9986 Reviewed-By:
-
Rich Trott authored
Remove `setTimeout()` in test and instead rely on `common.mustCall()` on a `timeout` event handler. The test was flaky on CI. The flakiness was replicable by running the test under load. This version, in contrast, is robust under load. Took the opportunity to do some `var` -> `const` while refactoring. PR-URL: https://github.com/nodejs/node/pull/10404 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Rico Cai authored
convert var to const PR-URL: https://github.com/nodejs/node/pull/9953 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Segu Riluvan authored
Use assert.strictEqual instead of assert.equal and assert.ok PR-URL: https://github.com/nodejs/node/pull/10420 Reviewed-By:
-
Wallace Zhang authored
Add a RegExp as a second argument to assert.throws(). PR-URL: https://github.com/nodejs/node/pull/10058 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/10390 Reviewed-By:
-
larissayvette authored
PR-URL: https://github.com/nodejs/node/pull/10417 Reviewed-By:
-
Troy Connor authored
Add configuration object createBenchmark object for buffer size & iteration in buffer-base64-encode & buffer-base64-decode.js. PR-URL: https://github.com/nodejs/node/pull/10175 Reviewed-By:
-
Myles Borins authored
Follow up from 8eb19c48. Lower case `return` was not updated PR-URL: https://github.com/nodejs/node/pull/10391 Ref: https://github.com/nodejs/node/pull/9554 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
- Dec 23, 2016
-
-
Adrian Estrada authored
* use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: https://github.com/nodejs/node/pull/10396 Reviewed-By:
-
1. Lot of repeating code has been refactored to a function 2. Errors in async calls are properly asserted 3. Fail the test if the callbacks are not fired PR-URL: https://github.com/nodejs/node/pull/10384 Reviewed-By:
-
sivaprasanna authored
* used let and const instead of var * used assert.strictEqual instead assert.equal PR-URL: https://github.com/nodejs/node/pull/10357 Reviewed-By:
-
Vicente Jimenez Aguilar authored
Change a single word in documentation with a more precise one. Native is a module compiled in machine "native" code. A module normally written in a compiled language, not in JavaScript. Core modules form Node's built-in "core" functionalities. You don't need to install them. They are included in every Node installation and documented in https://nodejs.org/api/ . PR-URL: https://github.com/nodejs/node/pull/10324 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Chase Starr authored
`./tools/macosx-firewall.sh` fails if run before build step. Since the suggestion comes before the build steps in the document, this change clarifies that the script should be run after building. PR-URL: https://github.com/nodejs/node/pull/10311 Reviewed-By:
-
Adrian Estrada authored
* use common.mustCall to control the functions execution automatically * use const instead of var * use assert.strictEqual instead assert.equal * use assert.ifError instead of throw error PR-URL: https://github.com/nodejs/node/pull/10297 Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com> Reviewed-By:
-
Adrian Estrada authored
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal PR-URL: https://github.com/nodejs/node/pull/10318 Reviewed-By:
-
