- Jan 12, 2016
-
-
Jeremiah Senkpiel authored
* http: - A new status code was added: 451 - "Unavailable For Legal Reasons" (Max Barinov) https://github.com/nodejs/node/pull/4377 - Idle sockets that have been kept alive now handle errors (José F. Romaniello) https://github.com/nodejs/node/pull/4482 * This release also includes several minor performance improvements: - assert: deepEqual is now speedier when comparing TypedArrays (Claudio Rodriguez) https://github.com/nodejs/node/pull/4330 - lib: Use arrow functions instead of bind where possible (Minwoo Jung) https://github.com/nodejs/node/pull/3622 - node: Improved accessor perf of process.env (Trevor Norris) https://github.com/nodejs/node/pull/3780 - node: Improved performance of process.hrtime() (Trevor Norris) https://github.com/nodejs/node/pull/3780, (Evan Lucas) https://github.com/nodejs/node/pull/4484 - node: Improved GetActiveHandles performance (Trevor Norris) https://github.com/nodejs/node/pull/3780 - util: Use faster iteration in util.form...
-
Rich Trott authored
Remove unnecessary `setImmediate()` that causes a minor race condition. Stop the test after 3 occurrences rather than 5 to allow for slower hosts running the test in parallel with other tests. Fixes: https://github.com/nodejs/node/issues/4559 PR-URL: https://github.com/nodejs/node/pull/4599 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
- Jan 11, 2016
-
-
Wyatt Preul authored
Fixes: https://github.com/nodejs/node/issues/4532 PR-URL: https://github.com/nodejs/node/pull/4535 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Feross Aboukhadijeh authored
These have been deprecated since Apr 27, 2013, and the plan was to remove them in "node v0.13". buffer.get(index) is superseded by buffer[index]. buffer.set(index, value) is superseded by buffer[index] = value. These have never been documented at any point in node's history. PR-URL: https://github.com/nodejs/node/pull/4594 Fixes: https://github.com/nodejs/node/issues/4587 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Sequoia McDowell authored
`Server`, `ServerResponse` etc. were marked as classes, this one class was overlooked. PR-URL: https://github.com/nodejs/node/pull/4589 Fixes: https://github.com/nodejs/node/issues/4576 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Sequoia McDowell authored
The server method returns `self` in order to allow chaining. PR-URL: https://github.com/nodejs/node/pull/4590 Fixes: https://github.com/nodejs/node/issues/4571 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Jan 09, 2016
-
-
James M Snell authored
Missed on the previous review, minor line wrapping nit PR-URL: https://github.com/nodejs/node/pull/4588 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Josh Dague authored
`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: https://github.com/nodejs/node/pull/4580 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Minwoo Jung authored
fix description about the latest LTS release download page to make it clear PR-URL: https://github.com/nodejs/node/pull/4583 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Jan 08, 2016
-
-
Santiago Gimeno authored
It avoids the creation of unnecessary handles. This issue is causing intermitent failures in `test-cluster-disconnect-race` on `FreeBSD` and `OS X`. The problem is that the `worker2.disconnect` is being called on the master before the `queryServer` is handled, causing the worker to be deleted, then the Server handle is created afterwards. Later on, when `removeWorker` is called from the `exit` handler, there are no workers left, but one handle, thus the `AssertionError`. Add a new `test/sequential/test-cluster-disconnect-leak` based on `test-cluster-disconnect-race` that creates lots of workers and fails consistently without this patch. PR-URL: https://github.com/nodejs/node/pull/4465 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Evan Lucas authored
Adds Evan Lucas and his public key to the README for releases PR-URL: https://github.com/nodejs/node/pull/4579 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Myles Borins authored
Adds Myles Borins and his public key to the README PR-URL: https://github.com/nodejs/node/pull/4578 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
- Jan 07, 2016
-
-
Fedor Indutny authored
Make default `clientError` behavior (close socket immediately) overridable. With this APIs it is possible to write a custom error handler, and to send, for example, a 400 HTTP response. http.createServer(...).on('clientError', function(err, socket) { socket.end('HTTP/1.1 400 Bad Request\r\n\r\n'); socket.destroy(); }); Fix: #4543 PR-URL: https://github.com/nodejs/node/pull/4557 Reviewed-By:Brian White <mscdex@mscdex.net>
-
Fedor Indutny authored
`clientError` will have `http.Server`-specific behavior, and we don't want to shadow it in `tls.Server`. PR-URL: https://github.com/nodejs/node/pull/4557 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
cjihrig authored
Refs: https://github.com/nodejs/node/issues/3254 PR-URL: https://github.com/nodejs/node/pull/4540 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Feross Aboukhadijeh authored
Fixes: #4517. PR-URL: https://github.com/nodejs/node/pull/4518 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Mathias Buus authored
PR-URL: https://github.com/nodejs/node/pull/4514 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
- Jan 06, 2016
-
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/4549 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
James M Snell authored
General improvements to crypto.markdown including new and revised examples. PR-URL: https://github.com/nodejs/node/pull/4435 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
Shigeki Ohtsu authored
The description of "[start[, end]]" in the doc shows warning of "invalid param" when parsing an optional parameter in the section. This fixes insufficient trimming of right square brackets. PR-URL: https://github.com/nodejs/node/pull/4537 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Shigeki Ohtsu authored
tools/doc/html.js in make doc throws an error in checking a heading level in the markdown file. PR-URL: https://github.com/nodejs/node/pull/4537 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/4536 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
Remove unused vars in tests PR-URL: https://github.com/nodejs/node/pull/4536 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Jan 05, 2016
-
-
Dave authored
PR-URL: https://github.com/nodejs/node/pull/4534 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Richard Sun authored
PR-URL: https://github.com/nodejs/node/pull/4538 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Julien Gilli authored
1c858499 "fixed" test-domain-exit-dispose-again by changing its logic to test that process.domain was cleared properly in case an error was thrown from a timer's callback. However, it became clear when reviewing a recent change that refactors lib/timers.js that it was not quite the intention of the original test. Thus, this change adds the original implementation of test-domain-exit-dispose-again back, with comments that make its implementation easier to understand. It also preserve the changes made by 1c858499, but it moves them to a new test file named test-timers-reset-process-domain-on-throw.js. PR: #4256 PR-URL: https://github.com/nodejs/node/pull/4256 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
Remove all remaining unused variables from tests in test/parallel. PR-URL: https://github.com/nodejs/node/pull/4511 Reviewed-By:
James M <Snell<jasnell@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Rich Trott authored
Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: https://github.com/nodejs/node/issues/3956 PR-URL: https://github.com/nodejs/node/pull/4510 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M <Snell<jasnell@gmail.com>
-
José F. Romaniello authored
This change adds a new event handler to the `error` event of the socket after it has been used by the http_client. The purpose of this change is to catch errors on *keep alived* connections from idle sockets that otherwise will cause an uncaugh error event on the application. Fix: #3595 PR-URL: https://github.com/nodejs/node/pull/4482 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Rich Trott authored
Use common.platformTimeout() to fix flaky test-stream2-readable-empty-buffer-no-eofi on Raspberry Pis. Fixes: https://github.com/nodejs/node/issues/4493 PR-URL: https://github.com/nodejs/node/pull/4516 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M <Snell<jasnell@gmail.com>
-
Rich Trott authored
Remove timeout delay causing flakiness on SmartOS. Fixes: https://github.com/nodejs/node/issues/4492 PR-URL: https://github.com/nodejs/node/pull/4524 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <r@va.gg> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Rich Trott authored
Three tests designated as flaky on Linux have not failed on the continuous integration server in a long time. Removing flaky designation for these tests. Fixes: https://github.com/nodejs/node/issues/4446 PR-URL: https://github.com/nodejs/node/pull/4519 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
James M Snell authored
General improvements to dgram.markdown copy PR-URL: https://github.com/nodejs/node/pull/4437 Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com> Reviewed-By:
Stephan Belanger <admin@stephenbelanger.com>
-
James M Snell authored
General improvements to errors.markdown including improved/revised examples PR-URL: https://github.com/nodejs/node/pull/4454 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com>
-
- Jan 04, 2016
-
-
Fedor Indutny authored
Adopt `MarkPopErrorOnReturn` from `node_crypto.cc`, and use it to clear errors after `SSL_read`/`SSL_write`/`SSL_shutdown` functions. See: https://github.com/nodejs/node/issues/4485 PR-URL: https://github.com/nodejs/node/pull/4515 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Martin Bark authored
If uv_interface_addresses() returns UV_ENOSYS then interfaces and count are uninitialised. This can cause a segmentation fault inside GetInterfaceAddresses when it tries to use the invalid interfaces[]. Fix the issue by returning from GetInterfaceAddresses on the UV_ENOSYS error. This issue was observed when using uCLibc-ng version 1.0.9 because uv_interface_addresses() in deps/uv/src/unix/linux-core.c incorrectly undefines HAVE_IFADDRS_H. Signed-off-by:
Martin Bark <martin@barkynet.com> PR-URL: https://github.com/nodejs/node/pull/4272 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Anna Henningsen authored
`setTimeout()`, `setInterval()` and `setIntermediate` currently throw errors when receiving non-function objects as their first argument, but only do so when trying to execute the callback, i.e. after the waited time has passed. This may complicate debugging when a lot of calls to `setTimeout()`/etc. are involved, so failing as early as possible seems like a good idea. `setTimeout()` historically ignored an falsy first argument, while the other functions do not and throw instead. This patch changes this behaviour to make all three match and adds remarks in the corresponding documentation. PR-URL: https://github.com/nodejs/node/pull/4362 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
jona authored
PR-URL: https://github.com/nodejs/node/pull/4357 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
- Jan 03, 2016
-
-
Rich Trott authored
test-child-process-fork-net2.js checks that things happen within certain time constraints, thus doubling as a benchmark test in addition to a functionality test. This change removes the time check, as it was causing the test to fail on SmartOS and Windows (and possibly elsewhere) when the tests were run in parallel on CI. There is no guarantee that other tests won't consume enough resources to slow this test down, so don't check the time constraints (beyond the generous timeout that the test is given by test.py in the first place, of course). If we want to do benchmark/performance tests, we should keep them separate from pure functionality tests. The time check may have been a remnant of the distant past when Node.js was much slower. It predates io.js Ref: https://github.com/nodejs/node/pull/4476 PR-URL: https://github.com/nodejs/node/pull/4494 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Rich Trott authored
Refactor test to remove unnecessary booleans and one unnecesary timer. Instead, throw Error objects where appropriate and rely on common.mustCall(). The timer seemed to be the source of an issue when parallelizing tests. Ref: https://github.com/nodejs/node/pull/4476#issuecomment-168080875 PR-URL: https://github.com/nodejs/node/pull/4490 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-