- May 28, 2017
-
-
cjihrig authored
This commit adds coverage for several edge cases related to util.format() format string placeholders. PR-URL: https://github.com/nodejs/node/pull/13159 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Daniel Bevenius authored
Currently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void ServerDone() { ^ ../src/inspector_socket_server.h:30:16: note: overridden virtual function is here virtual void ServerDone() = 0; ^ This commit marks ServerDone with override to get rid of the warning. PR-URL: https://github.com/nodejs/node/pull/13166 Reviewed-By:Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Calvin Metcalf authored
PR-URL: https://github.com/nodejs/node/pull/13216 Reviewed-By:
-
Rich Trott authored
* track callback invocations with common.mustCall() and common.mustNotCall() * remove test in test/internet/test-dns.js that is duplicated in test/parallel/test-dns.js * move tests that might perform a DNS query from test test/parallel/test-dns.js to test/internet/test-dns.js PR-URL: https://github.com/nodejs/node/pull/13163 Reviewed-By:
-
Rich Trott authored
Add `common.refreshTmpDir()` before using the tmp directory. fs.writeSync no longer requires an integer for the position argument, so change test from `assert.throws()` to `assert.doesNotThrow()`. The test now passes. Because it involves a 5 GB file, we're not going to activate the test, although that is possible if we add checking for appropriate available resources (definitely disk space, likely memory, maybe check that it's a 64-bit OS). PR-URL: https://github.com/nodejs/node/pull/13147 Reviewed-By:
-
Sam Roberts authored
Document --inspect-port, and fix the reporting for when it is misused. The option requires an argument, but when the argument was omitted, the error message incorrectly reported --inspect-port as being bad, as if was not supported at all: % node --inspect-port node: bad option: --inspect-port % node --none-such node: bad option: --none-such It is now correctly reported as requiring an argument: % ./node --inspect-port ./node: --inspect-port requires an argument PR-URL: https://github.com/nodejs/node/pull/12581 Reviewed-By: -
Jason Ginchereau authored
PR-URL: https://github.com/nodejs/node/pull/13200 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Michael Dawson <mhdawson@ibm.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com>
-
Daniel Bevenius authored
Really minor but I could not find an open PR for anything n-api where this could be changed, so creating this so that it is not forgotten. PR-URL: https://github.com/nodejs/node/pull/13190 Reviewed-By:
-
Calvin Metcalf authored
Adds the ability to for write streams to have an _final method which acts similarly to the _flush method that transform streams have but is called before the finish event is emitted and if asynchronous delays the stream from finishing. The `final` option may also be passed in order to set it. PR-URL: https://github.com/nodejs/node/pull/12828 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Matteo Collina authored
Fixed a regression that caused the callback passed to destroy() to not be called if the stream was already destroyed. This caused a regression on the ws module in CITGM introduced by https://github.com/nodejs/node/pull/12925. PR-URL: https://github.com/nodejs/node/pull/13156 Fixes: https://github.com/websockets/ws/issues/1118 Reviewed-By:
Calvin Metcalf <calvin.metcalf@gmail.com> Reviewed-By:
-
Matteo Collina authored
Adds destroy() and _destroy() methods to Readable, Writable, Duplex and Transform. It also standardizes the behavior and the implementation of destroy(), which has been inconsistent in userland and core. This PR also updates all the subsystems of core to use the new destroy(). PR-URL: https://github.com/nodejs/node/pull/12925 Reviewed-By:
-
Michael Dawson authored
Covert lib/dgram.js over to using lib/internal/errors.js for generating Errors. See [using-internal-errors.md](https://github.com/nodejs/node/blob/master/doc/guides/using-internal-errors.md) for more details. I have not addressed the cases that use errnoException() and exceptionWithHostPort() helper methods as changing these would require fixing the tests across all of the different files that use them. In addition, these helpers already add a `code` to the Error and we'll have to discuss how that interacts with the `code` used by lib/internal/errors.js. I believe we should convert all users of errnoException and exceptionWithHostPort in a PR dedicated to that conversion. PR-URL: https://github.com/nodejs/node/pull/12926 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben.bridgewater@fintura.de>
-
Rich Trott authored
test-stream2-basic runs in a few seconds. It can be moved to parallel. PR-URL: https://github.com/nodejs/node/pull/13146 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/13146 Reviewed-By:
-
Rich Trott authored
In test/pummel/test-stream2-basic.js, check that noop functions are called the expected number of times. PR-URL: https://github.com/nodejs/node/pull/13146 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/13145 Refs: http://eslint.org/docs/rules/no-useless-constructor Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/13138 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Alexey Orlenko authored
* Wrap text at 80 characters. * Use periods consistently. PR-URL: https://github.com/nodejs/node/pull/13135 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Alexey Orlenko authored
This commit fixes an incorrect keyboard shortcut in `doc/STYLE_GUIDE.md`: entering em-dashes is done via Alt+Shift+"-" on macOS, not via Ctrl+Alt+"-". Besides that, Option is more canonical name of Alt on Macs. PR-URL: https://github.com/nodejs/node/pull/13134 Reviewed-By:
-
Rich Trott authored
Use common.mustCall() in test-fs-makeStatsCallback to confirm that the callback is invoked. PR-URL: https://github.com/nodejs/node/pull/13132 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Rich Trott authored
When a no-op message event handler is used in a test, make it clear what is expected by using `common.mustCall()` and `common.mustNotCall()`. PR-URL: https://github.com/nodejs/node/pull/13125 Reviewed-By:
-
Michael Dawson authored
Add tests to validate that properties marked as static are available through the class as opposed to instances PR-URL: https://github.com/nodejs/node/pull/13124 Reviewed-By:
Jason Ginchereau <jasongin@microsoft.com> Reviewed-By:
Hitesh Kanwathirtha <digitalinfinity@gmail.com>
-
Michael Dawson authored
Fix mismatch in title for napi_get_value_string_utf16 Fixes: https://github.com/nodejs/abi-stable-node/issues/243 PR-URL: https://github.com/nodejs/node/pull/13123 Reviewed-By:
-
Marcel Laverdet authored
This fixes a race condition in the watchdog timer used for vm timeouts. The condition would terminate the main stack's execution instead of the code running under the sandbox. PR-URL: https://github.com/nodejs/node/pull/13074 Reviewed-By:
-
Marcel Laverdet authored
This option has been broken for almost a year when used with any of the vm.runIn.. family of functions, except for syntax errors. PR-URL: https://github.com/nodejs/node/pull/13074 Reviewed-By:
-
Sam Roberts authored
Use `file` as name of the argument, as the CLI documentation does. PR-URL: https://github.com/nodejs/node/pull/13120 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/13118 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/13113 Reviewed-By:
-
Ebrahim Byagowi authored
PR-URL: https://github.com/nodejs/node/pull/13012 Reviewed-By:
-
Rod Vagg authored
Fixes: https://github.com/nodejs/node/issues/12833 PR-URL: https://github.com/nodejs/node/pull/12957 Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
-
Anna Henningsen authored
Backport ABI-incompatible changes from dab18fb0bbcdd (“Make idle tasks optional in the default platform.”). Ref: https://codereview.chromium.org/2737743002 Ref: https://github.com/v8/v8/commit/dab18fb0bbcdd PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Jochen Eisinger authored
Original commit message: Add documentation for FunctionCallbackInfo R=verwaest@chromium.org,haraken@chromium.org,yukishiino@chromium.org BUG= Change-Id: I273f5ce305f80b2aa5e9c8c42a6e8e5afc51a0a7 Reviewed-on: https://chromium-review.googlesource.com/484422 Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#44927} Ref: https://github.com/v8/v8/commit/4fdf9fd4813 PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport API-incompatible changes from 2e4a68733803 (“[v8] v8::StackTrace::AsArray returns correct array”). Ref: https://codereview.chromium.org/2806373005 Ref: https://github.com/v8/v8/2e4a68733803 PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport ABI-incompatible changes from 94283dcf4459f (“[ESNext] Implement DynamicImportCall”). Ref: https://codereview.chromium.org/2703563002 Ref: https://github.com/v8/v8/commit/94283dcf4459f PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport ABI-incompatible changes from bf463c4dc080 (“[async-iteration] implement AsyncGenerator”) and dc662e5b740c (“[inspector] move console to builtins”). This also requires relaxing one of the V8 unit tests. Ref: https://chromium-review.googlesource.com/446961 Ref: https://github.com/v8/v8/commit/bf463c4dc080 Ref: https://codereview.chromium.org/2785293002 Ref: https://github.com/v8/v8/commit/dc662e5b740c PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport deprecation of `Context::EstimatedSize()` from da5b745dba387 (“[api] deprecate unused context size estimate”). Ref: https://github.com/v8/v8/commit/da5b745dba387d0afdb99cd385ba1467a3ca2831 PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport removed methods from 6226576efa82ee (“[wasm] Deleted old way of checking embedder limits on wasm size.”). Ref: https://codereview.chromium.org/2772203005 Ref: https://github.com/v8/v8/commit/6226576efa82ee PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport new virtual methods from 99743ad460e (“[wasm] Transferrable modules”). Ref: https://codereview.chromium.org/2748473004 Ref: https://github.com/v8/v8/commit/99743ad460e PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
jbroman authored
Original commit message: Give v8::Eternal a direct reference to the handle. This makes it more similar to other handle types (like PersistentBase), by simply storing an i::Object** cast to T*. This means that it is not necessary to look up the handle in the eternal handles table to access the underlying value. Like the built-in roots (null, etc.), an eternal handle can never be destroyed, so we don't even need to allocate a separate local handle. Instead, the Local<T> can point directly at the eternal reference. This makes Eternal<T>::Get trivial. Review-Url: https://codereview.chromium.org/2751263003 Cr-Commit-Position: refs/heads/master@{#43912} Ref: https://github.com/v8/v8/commit/4acdb5eec2c PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
