- Dec 19, 2020
-
-
ZiJian Liu authored
test new Worker() with invalid NODE_OPTIONS Refs: https://coverage.nodejs.org/coverage-743ee9d2c05efefe/lib/internal/worker.js.html#L179 PR-URL: https://github.com/nodejs/node/pull/36491 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Momtchil Momtchev authored
Add two important tips for novice Node.js contributors PR-URL: https://github.com/nodejs/node/pull/36452 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
- Dec 18, 2020
-
-
Beth Griggs authored
Notable Changes: Node.js v14.15.2 included a commit that has caused reported breakages when cloning request objects. This release reverts the commit that introduced the behaviour change. See https://github.com/nodejs/node/issues/36550 for more details. PR-URL: https://github.com/nodejs/node/pull/36555
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/36323 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36540 Refs: https://github.com/nodejs/node/pull/36123 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- Dec 17, 2020
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36525 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Rich Trott authored
Derek informed me that he intends to take a break from collaborator-ship. PR-URL: https://github.com/nodejs/node/pull/36514 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Daniele Belardi authored
Test uncaught exceptions when destroying IncomingMessage. PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By:
-
Daniele Belardi authored
Destroy the underlying socket only if it is not ready destroyed. Wait for the stream to finish in that case. PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By:
-
Daniele Belardi authored
Enable the default `autoDestroy: true` option in IncomingMessage. Refactor `_http_client` and `_http_server` to remove any manual destroying/closing of IncomingMessage. Refactor IncomingMessage `destroy` method to use the standard implementation of the stream module and move the early termination event emitting inside of it. PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/36523 Reviewed-By:
-
Myles Borins authored
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/36520 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36520 Reviewed-By:
-
Todd Short authored
Add support for BoringSSL QUIC APIs This is a cherry-pick of 2a4b03a306439307e0b822b17eda3bdabddfbb68 on the master-quic-support2 branch (2019-10-07) Which was a rebase/squash of master-quic-support: * 5aa62ce Add support for more secrets - Todd Short/Todd Short (master-quic-support) * 58e0643 Tweeks to quic_change_cipher_state() - Todd Short/Todd Short * 8169702 Move QUIC code out of tls13_change_cipher_state() - Todd Short/Todd Short * a08cfe6 Correctly disable middlebox compat - Todd Short/Todd Short * 3a9eabf Add OPENSSL_NO_QUIC wrapper - Todd Short/Todd Short * f550eca Add client early traffic secret storage - Todd Short/Todd Short * 1b787ae Quick fix: s2c to c2s for early secret - Todd Short/Todd Short * f97e6a9 Don't process an incomplete message - Todd Short/Todd Short * 81f0ce2 Reset init state in SSL_process_quic_post_handshake() - Todd Short/Todd Short * 5d59cf9 Fix quic_transport constructors/parsers - Todd Short/Todd Short * 5e5f91c Fix INSTALL nit. - Todd Short/Todd Short * bd290ab Fix duplicate word in docs - Todd Short/Todd Short * 699590b fixup! Handle partial handshake messages - Todd Short/Todd Short * a472a8d Handle partial handshake messages - Todd Short/Todd Short * 363cf3d fixup! Use proper secrets for handshake - Todd Short/Todd Short * b03fee6 Use proper secrets for handshake - Todd Short/Todd Short * 2ab1aa0 Move QUIC transport params to encrypted extensions - Todd Short/Todd Short * 0d16af9 Make temp secret names less confusing - Todd Short/Todd Short * abb6f39 New method to get QUIC secret length - Todd Short/Todd Short * 05fdae9 Add support for BoringSSL QUIC APIs - Todd Short/Todd Short This adds a compatible API for BoringSSL's QUIC support, based on the current |draft-ietf-quic-tls|. Based on BoringSSL commit 3c034b2cf386b3131f75520705491871a2e0cafe Based on BoringSSL commit c8e0f90f83b9ec38ea833deb86b5a41360b62b6a Based on BoringSSL commit 3cbb0299a28a8bd0136257251a78b91a96c5eec8 Based on BoringSSL commit cc9d935256539af2d3b7f831abf57c0d685ffd81 Based on BoringSSL commit e6eef1ca16a022e476bbaedffef044597cfc8f4b Based on BoringSSL commit 6f733791148cf8a076bf0e95498235aadbe5926d Based on BoringSSL commit 384d0eaf1930af1ebc47eda751f0c78dfcba1c03 Based on BoringSSL commit a0373182eb5cc7b81d49f434596b473c7801c942 Based on BoringSSL commit b1b76aee3cb43ce11889403c5334283d951ebd37 New method to get QUIC secret length Make temp secret names less confusing Move QUIC transport params to encrypted extensions Use proper secrets for handshake fixup! Use proper secrets for handshake Handle partial handshake messages fixup! Handle partial handshake messages Fix duplicate word in docs Fix INSTALL nit. Fix quic_transport constructors/parsers Reset init state in SSL_process_quic_post_handshake() Don't process an incomplete message Quick fix: s2c to c2s for early secret Add client early traffic secret storage Add OPENSSL_NO_QUIC wrapper Correctly disable middlebox compat Move QUIC code out of tls13_change_cipher_state() Create quic_change_cipher_state() that does the minimal required to generate the QUIC secrets. (e.g. encryption contexts are not initialized). Tweeks to quic_change_cipher_state() Add support for more secrets Fix resumption secret (cherry picked from commit 16fafdf4e0ec6cddd5705f407e5dca26cb30914d) QUIC: Handle EndOfEarlyData and MaxEarlyData QUIC: Increase HKDF_MAXBUF to 2048 Fall-through for 0RTT Some cleanup for the main QUIC changes Try to reduce unneeded whitespace changes and wrap new code to 80 columns. Reword documentation to attempt to improve clarity. Add some more sanity checks and clarifying comments to the code. Update referenced I-D versions. Prevent KeyUpdate for QUIC QUIC does not use the TLS KeyUpdate message/mechanism, and indeed it is an error to generate or receive such a message. Add the necessary checks (noting that the check for receipt should be redundant since SSL_provide_quic_data() is the only way to provide input to the TLS layer for a QUIC connection). Test KeyUpdate rejection For now, just test that we don't generate any, since we don't really expose the mechanics for encrypting one and the QUIC API is not integrated into the TLSProxy setup. Fix out-of-bounds read when TLS msg is split up into multiple chunks Previously, SSL_provide_quic_data tried to handle this kind of situation, but it failed when the length of input data is less than SSL3_HM_HEADER_LENGTH. If that happens, the code might get wrong message length by reading value from out-of-bounds region. Revert "Fix out-of-bounds read when TLS msg is split up into multiple chunks" This reverts commit 18f993cbdae498111c94a075fd9b115bd8367574. Test HKDF with empty IKM Add an extra EVP test that provides empty input key material. It currently fails, since attempting to set a zero-length key on an EVP_PKEY_CTX results in a call to OPENSSL_memdup() with length zero, which returns NULL and is detected as failure. Allow zero-length HKDF keys When making a copy to keep in the EVP_PKEY_CTX, allocate a single byte for the cached key instead of letting memdup return NULL and cause the call to fail. The length still gets set to zero properly, so we don't end up inspecting the allocated byte, but it's important to have a non-NULL pointer set. Buffer all provided quic data Make all data supplied via SSL_provide_quic_data() pass through an internal buffer, so that we can handle data supplied with arbitrary framing and only parse complete TLS records onto the list of QUIC_DATA managed by quic_input_data_head/quic_input_data_tail. This lets us remove the concept of "incomplete" QUIC_DATA structures, and the 'offset' field needed to support them. However, we've already moved the provided data onto the buffer by the time we can check for KeyUpdate messages, so defer that check to quic_get_message() (where it is adjacent to the preexisting ChangeCipherSpec check). To avoid extra memory copies, we also make the QUIC_DATA structures just store offsets into the consolidated buffer instead of having copies of the TLS handshake messages themselves. enforce consistent encryption level for handshake messages The QUIC-TLS spec requires that TLS handshake messages do not cross encryption level boundaries, but we were not previously enforcing this. PR-URL: https://github.com/nodejs/node/pull/36520 Reviewed-By:
-
Myles Borins authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1i.tar.gz $ mv openssl-1.1.1i openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/36520 Reviewed-By: -
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/36520 Reviewed-By:
-
nlf authored
Refs: https://github.com/npm/cli/pull/2358 PR-URL: https://github.com/nodejs/node/pull/36543 Reviewed-By:
Ruy Adorno <ruyadorno@github.com> Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/36543 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36099 Reviewed-By:
-
Chinmoy Chakraborty authored
The PR template should include a Reference isssue (Fixes #issue_number) so the PR can be tracked back to the issue easily.For a beginner trying to read PRs to become comfortable with the codebase,it is really helpful if one can directly reach the issue the PR fixes. Fixes: https://github.com/nodejs/node/issues/36338 PR-URL: https://github.com/nodejs/node/pull/36440 Reviewed-By:
-
Rock authored
Add missing 's' to example URL. PR-URL: https://github.com/nodejs/node/pull/36147 Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
-
- Dec 16, 2020
-
-
Danny Sonnenschein authored
PR-URL: https://github.com/nodejs/node/pull/36207 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Rich Trott authored
Be explicit about using `global.externalizeString()` etc. in test-fs-write instead of disabling the `no-undef` ESLint rule. PR-URL: https://github.com/nodejs/node/pull/36498 Reviewed-By:
-
Richard Lau authored
Add an explicit command to revert changes to `node_version.h` when cherry-picking the release commit to the `master` branch. PR-URL: https://github.com/nodejs/node/pull/36461 Refs: https://github.com/nodejs/node/pull/36460 Refs: https://github.com/nodejs/node/pull/36385 Reviewed-By:
Danielle Adams <adamzdanielle@gmail.com> Reviewed-By:
-
Beth Griggs authored
Notable Changes: - **deps**: - upgrade npm to 6.14.9 (Myles Borins) https://github.com/nodejs/node/pull/36450 - update acorn to v8.0.4 (Michaël Zasso) https://github.com/nodejs/node/pull/35791 - **doc**: add release key for Danielle Adams (Danielle Adams) https://github.com/nodejs/node/pull/35545 - **http2**: check write not scheduled in scope destructor (David Halls) https://github.com/nodejs/node/pull/36241 - **stream**: fix regression on duplex end (Momtchil Momtchev) https://github.com/nodejs/node/pull/35941 PR-URL: https://github.com/nodejs/node/pull/36476 -
FrankQiu authored
PR-URL: https://github.com/nodejs/node/pull/36278 Reviewed-By:
-
Zijian Liu authored
test invalid callback case for fs/dir read Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/internal/fs/dir.js.html#L91 PR-URL: https://github.com/nodejs/node/pull/36388 Reviewed-By:
-
- Dec 15, 2020
-
-
raisinten authored
The empty name check has been removed since this has landed: https://github.com/libuv/libuv/pull/2473 PR-URL: https://github.com/nodejs/node/pull/36133 Reviewed-By:
-
ZiJian Liu authored
Fixes: https://github.com/nodejs/node/issues/36437 PR-URL: https://github.com/nodejs/node/pull/36479 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Zijian Liu authored
Fixes: https://github.com/nodejs/node/issues/36301 PR-URL: https://github.com/nodejs/node/pull/36379 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36391 Reviewed-By:
-
Rich Trott authored
The test has not failed in quite some time (as far as I can tell) on CI. Optimistically removing it. Refs: https://github.com/nodejs/node/pull/29889 PR-URL: https://github.com/nodejs/node/pull/36496 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36457 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Ruy Adorno authored
Fixes running npm tests with `make test-npm` PR-URL: https://github.com/nodejs/node/pull/36369 Reviewed-By:
-
Danielle Adams authored
PR-URL: https://github.com/nodejs/node/pull/36456 Reviewed-By:
-
- Dec 14, 2020
-
-
Anna Henningsen authored
Make sure that `SharedArrayBuffer`s can be deserialized on multiple receiving ends. As a drive-by, also fix the condition of the internal assertion that should occur if there are transferables passed to multiple destinations. PR-URL: https://github.com/nodejs/node/pull/36501 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
