- Feb 27, 2016
-
-
Hugo Wood authored
This adds a paragraph in the Module Caching Caveats section about the behavior of require when Node is running on top of a file system (e.g. HFS) or operating system (e.g. Windows) that will not consider the case of file paths to find files. Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Tristan Slominski authored
Documents that creating a buffer from base64 encoded string transparently supports "URL and Filename Safe Alphabet" base64url encoding. PR-URL: https://github.com/nodejs/node/pull/5243 Reviewed-By:
Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By:
Benjamin Gruenbaum <inglor@gmail.com> Reviewed-By:
Alejandro Oviedo <alejandro.oviedo.g@gmail.com>
-
Jackson Tian authored
The description of httpVersionMajor & httpVersionMinor should have same context like httpVersion. PR-URL: https://github.com/nodejs/node/pull/5296 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Evan Lucas authored
They were not being processed as relative links. PR-URL: https://github.com/nodejs/node/pull/5358 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/5460 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
dcposch@dcpos.ch authored
This changes the doc generator to automatically link references such as `open(2)` to a man page on man7.org or freebsd.org PR-URL: https://github.com/nodejs/node/pull/5073 Reviewed-By:
Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Rafael Cepeda authored
`Cluster.setupMaster(options)` Options object was missing an `args` property on the example. PR-URL: https://github.com/nodejs/node/pull/5305 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Chris Dew authored
Corrected name of "msg" argument from "buf" to "msg". PR-URL: https://github.com/nodejs/node/pull/5449 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Alexander Makarenko authored
Fix missing links described in #5322. PR-URL: https://github.com/nodejs/node/pull/5364 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/5401 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Sam Roberts authored
ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: https://github.com/nodejs/node/pull/5463 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Sam Roberts authored
constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: https://github.com/nodejs/node/pull/5463 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Jeremiah Senkpiel authored
Describes the How and Why of the timers implementation, as well as adding comments in spots that should allow for an easier understanding about what is going on. The timers implementation is very efficient, at a cost. That cost is readable understandability, and this aims to improve that. PR-URL: https://github.com/nodejs/node/pull/4007 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Julien Gilli <jgilli@nodejs.org> Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
Jeremiah Senkpiel authored
Consolidates the implementation of regular and internal (_unrefActive) timers. Also includes a couple optimizations: - Isolates the try/catch from listOnTimeout() in a new tryOnTimeout(). - Uses a TimersList constructor as the base for linkedlists. Additionally includes other cleanup and clarification, such as a rename of "Timer" to "TimerWrap". PR-URL: https://github.com/nodejs/node/pull/4007 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Julien Gilli <jgilli@nodejs.org> Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/5427 Fixes: https://github.com/nodejs/node/issues/5424 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Stefan Budeanu authored
Append --node-args to existing list, don't overwrite arg list. Fixes: https://github.com/nodejs/node/issues/5442 PR-URL: https://github.com/nodejs/node/pull/5446 Reviewed-By:
Ben Noorhduis <info@bnoordhuis.nl> Reviewed-by:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Feb 26, 2016
-
-
Santiago Gimeno authored
Just send 10 messages recursively and check that the send calls are asynchronous by asserting that a `setImmediate` callback has been called in-between. It avoids a race condition in the test when the recursive limit is reached without having received at least 10 messages. Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/nodejs/node/pull/5079
-
Santiago Gimeno authored
This test was sometimes timing out in `OS X`. Remove the timeout and clean up the code. Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/5339
-
Andreas Madsen authored
PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Andreas Madsen authored
The benchmark runner spawns new processes for each configuration. The specific configuration is transfered by process.argv. This means that the values have to be parsed. As of right now only numbers and strings are parsed correctly. However other values such as objects where used. This fixes the benchmarks that used non-string/number values and prevents future issues by asserting the type. PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Andreas Madsen authored
url.js was broken since it didn't use the common.js runner. This fixes that issue by merging it with url-resolve.js, which also benchmarks url.resolve. PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Andreas Madsen authored
PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Phillip Johnsen authored
`vcbuild.bat` already supports both Visual Studio 2013 and 2015. PR-URL: https://github.com/nodejs/node/pull/5406 Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rich Trott authored
Remove out-of-date stability index material from `tools/doc/README.md`. The stability index is documented in `doc/api/documentation.markdown`. PR-URL: https://github.com/nodejs/node/pull/5421 Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Rich Trott authored
Add verbs to make sentence fragments less fragmentary. PR-URL: https://github.com/nodejs/node/pull/5399 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Stefan Budeanu authored
Default to FIPS off even in FIPS builds. Add JS API to check and control FIPS mode. Add command line arguments to force FIPS on/off. Respect OPENSSL_CONF variable and read the config. Add testing for new features. Fixes: https://github.com/nodejs/node/issues/3819 PR-URL: https://github.com/nodejs/node/pull/5181 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-by:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Stefan Budeanu authored
Add --node-args option that will pass arguments. PR-URL: https://github.com/nodejs/node/pull/5376 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Marc Cuva authored
Function name in code sample had the wrong capitalization. PR-URL: https://github.com/nodejs/node/pull/5306 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Chinedu Francis Nwafili authored
Previous example didn't account for the 1 byte offset PR-URL: https://github.com/nodejs/node/pull/5282 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Feb 25, 2016
-
-
cjihrig authored
Currently, there is a check to ensure that the user either provides an object or a string to repl.start(). The string case is used to set a REPL prompt. However, a default of '> ' already exists, so forcing the user to specify a prompt is a bit redundant. This commit removes this restriction. Fixes: https://github.com/nodejs/node/issues/5385 PR-URL: https://github.com/nodejs/node/pull/5388 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Julian Duque <julianduquej@gmail.com>
-
cjihrig authored
util.isError() is the only remaining util.is*() method that depends on Object.prototype.toString() behavior. This commit notes the limitations of isError() related to @@toStringTag. Refs: https://github.com/nodejs/node/pull/2201 PR-URL: https://github.com/nodejs/node/pull/5414 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/5418 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/5418 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/5418 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Dirceu Pereira Tiegs authored
Remove indications that an error argument is sent to the `listen()` callback. Fixes: https://github.com/nodejs/node/issues/5345 PR-URL: https://github.com/nodejs/node/pull/5353 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ron Korving authored
The APIs are implemented but currently not documented. PR-URL: https://github.com/nodejs/node/pull/5402 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Ben Noordhuis authored
It's documented as such but didn't actually behave that way. Bug introduced in commit 66fc8ca2 ("cluster: emit 'message' event on cluster master"), which is the commit that introduced the event. Fixes: https://github.com/nodejs/node/issues/5126 PR-URL: https://github.com/nodejs/node/pull/5361 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5275 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5276 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5277 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-