- Dec 10, 2020
-
-
cjihrig authored
Update ESLint to 7.15.0 PR-URL: https://github.com/nodejs/node/pull/36411 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
- Dec 09, 2020
-
-
raisinten authored
I would like to apply for the role of a triager in this project. My motivation to become a triager is to help with the issues in this repo and the help repo, as well as learn deeper internals of Node.js, and to eventually become a collaborator! I hearby declare that I have read and understood the Code of Conduct of the project and will adhere to that. PR-URL: https://github.com/nodejs/node/pull/36404 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/36395 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Danielle Adams authored
PR-URL: https://github.com/nodejs/node/pull/36435 Notable changes: * child_processes: * add AbortSignal support (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/36308) * deps: * update ICU to 68.1 (Michaël Zasso) (https://github.com/nodejs/node/pull/36187) * events: * support signal in EventTarget (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/36258) * graduate Event, EventTarget, AbortController (James M Snell) (https://github.com/nodejs/node/pull/35949) * http: * enable call chaining with setHeader() (pooja d.p) (https://github.com/nodejs/node/pull/35924) * module: * add isPreloading indicator (James M Snell) (https://github.com/nodejs/node/pull/36263) * stream: * support abort signal (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/36061) * add FileHandle support to Read/WriteStream (Momtchil Momtchev) (https://github.com/nodejs/node/pull/35922) * worker: * add experimental BroadcastChannel (James M Snell) (https://github.com/nodejs/node/pull/36271)
-
Rich Trott authored
The timeout is insufficient in CI (failures on Raspberry Pi) and I can reproduce locally (on macOS) with `tools/test.py -j 96 --repeat 192 test-repl`. Increase timeout drastically as it only is useful in an error condition. PR-URL: https://github.com/nodejs/node/pull/36415 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/36425 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Daniel Bevenius authored
This commit removes one of the V macros in IsolateData::MemoryInfo as they are identical as far as I can tell. PR-URL: https://github.com/nodejs/node/pull/36427 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/36365 Reviewed-By:
-
Benjamin Gruenbaum authored
We added an `AbortError` with the same code and name as the web's as part of the consensus in https://github.com/nodejs/node/issues/36084 but never actually documented the error in our error codes list. This PR adds the error code. PR-URL: https://github.com/nodejs/node/pull/36319 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/36407 Reviewed-By:
-
- Dec 08, 2020
-
-
Anna Henningsen authored
Add scopes that ensure that the context associated with the current Environment is always entered when working with it. PR-URL: https://github.com/nodejs/node/pull/36413 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
Add a test to check util.inspect()'s handling of a null prototype-of-an-iterable-prototype. This covers a previously uncovered code branch. Refs: https://coverage.nodejs.org/coverage-0fd121e00c9d5987/lib/internal/util/inspect.js.html#L597 PR-URL: https://github.com/nodejs/node/pull/36399 Reviewed-By:
-
Ash Cripps authored
PR-URL: https://github.com/nodejs/node/pull/36368 Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Santiago Gimeno authored
Make sure all the `wc` process stdout data is received before checking its validity. Fixes: https://github.com/nodejs/node/issues/25988 PR-URL: https://github.com/nodejs/node/pull/36366 Reviewed-By:
-
Michael Dawson authored
In the discussion of https://github.com/nodejs/node/pull/35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by:
Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/36201 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36314 Reviewed-By:
-
Michaël Zasso authored
Fixes: https://github.com/nodejs/node/issues/36246 PR-URL: https://github.com/nodejs/node/pull/36248 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36303 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36321 Fixes: https://github.com/ensure Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36393 Reviewed-By:
-
ExE Boss authored
Closes: https://github.com/nodejs/node/pull/32127 PR-URL: https://github.com/nodejs/node/pull/36329 Fixes: https://github.com/nodejs/node/issues/32127 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36357 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36358 Reviewed-By:
-
raisinten authored
PR-URL: https://github.com/nodejs/node/pull/36426 Reviewed-By:
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/36061 Reviewed-By:
Robert Nagy <ronagy@icloud.com>
-
- Dec 07, 2020
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36360 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/35881 PR-URL: https://github.com/nodejs/node/pull/36305 Reviewed-By:
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/36418 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36392 Reviewed-By:
Minwoo Jung <nodecorelab@gmail.com>
-
Zijian Liu authored
1. test call readline.Interface without new should return instance Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/readline.js.html#L101 2. test keypress ctrl + c should close readline interface Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/readline.js.html#L891 PR-URL: https://github.com/nodejs/node/pull/36389 Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/readline.js.html#L101 Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/readline.js.html#L891 Reviewed-By:
-
Michael Bashurov authored
Co-authored-by:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
- Dec 06, 2020
-
-
cjihrig authored
Refs: https://github.com/nodejs/node/pull/33950 PR-URL: https://github.com/nodejs/node/pull/36378 Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/36308 Reviewed-By:
-
Rich Trott authored
Cherry-pick 12c8b4d1 Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: https://github.com/nodejs/node/pull/17373 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Refs: https://github.com/nodejs/node/commit/12c8b4d15471cb6211b39c3a2ca5b10fa4b9f12b Cherry-pick fc81e801 Original commit message: Update cpplint.py to check for inline headers when the corresponding header is already included. PR-URL: https://github.com/nodejs/node/pull/21521 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> PR-URL: https://github.com/nodejs/node/pull/35569 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35719 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36235 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36324 Reviewed-By:
-
Anna Henningsen authored
Some embedders, like Electron, choose to start Node.js with `only_terminate_in_safe_scope` set to `true`. In those cases, parts of the API that expect execution termination to happen need to be marked as able to receive those events. In our case, this is the Ctrl+C support of the `vm` module (and Workers, but since we’re in control of creating the `Isolate` for them, that’s a non-concern there). Add those scopes and add a regression test. PR-URL: https://github.com/nodejs/node/pull/36344 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
- Dec 05, 2020
-
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/36385 Reviewed-By:
Ash Cripps <acripps@redhat.com> Reviewed-By:
-
Momtchil Momtchev authored
Support creating a Read/WriteStream from a FileHandle instead of a raw file descriptor Add an EventEmitter to FileHandle with a single 'close' event. Fixes: https://github.com/nodejs/node/issues/35240 PR-URL: https://github.com/nodejs/node/pull/35922 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36121 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36123 Reviewed-By:
-
