Commits · 513a979b4421490948b328ef2d36cfbbfbdd89ae · github.com / v8-riscv / node

Sep 09, 2021

deps: patch for v8 on windows · 513a979b

Jiawen Geng authored Sep 06, 2021

PR-URL: https://github.com/nodejs/node/pull/40010


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

513a979b

tools: update remark-html to v13.0.2 · 8c905b81

Michaël Zasso authored Sep 08, 2021

PR-URL: https://github.com/nodejs/node/pull/40043


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

8c905b81

repl: fix top level await with surrogate characters · addb30f0

Mestery authored Aug 29, 2021

Fixes: https://github.com/nodejs/node/issues/39929

PR-URL: https://github.com/nodejs/node/pull/39931


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

addb30f0

lib: use standard property names · 7d51c6a5

null authored Sep 03, 2021

The standard property names that aren't strings can be used where
appropiate, this is one of them.

PR-URL: https://github.com/nodejs/node/pull/39981


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>

7d51c6a5

doc: fix property name 'detail' of performanceEntry · 6e9a54c1

Christian Boehlke authored Sep 06, 2021

PR-URL: https://github.com/nodejs/node/pull/40019


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

6e9a54c1

Revert "src: skip test_fatal/test_threads for Debug builds" · 9f7412a6

Anna Henningsen authored Aug 31, 2021

This reverts commit 1fc4d43a.

PR-URL: https://github.com/nodejs/node/pull/39954


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

9f7412a6

src: use Isolate::TryGetCurrent where appropriate · 200ed078

Anna Henningsen authored Aug 31, 2021

In two places, we call `Isolate::GetCurrent()` even though that is
technically invalid usage of the function.
Now that V8 exposes `Isolate::TryGetCurrent()`, we can do this
in a proper way.

PR-URL: https://github.com/nodejs/node/pull/39954


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

200ed078

deps: update Acorn to v8.5.0 · 9f6fed7c

Michaël Zasso authored Sep 06, 2021

PR-URL: https://github.com/nodejs/node/pull/40015


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

9f6fed7c

errors: disp ver on fatal except that causes exit · 59d3d542

Divlo authored Sep 02, 2021

Display Node.js version at the end of stacktraces
on fatal exception that causes exit.
Easier for debugging so you don't have
to ask "what node version are you on?",
it is directly in the error the user
copy/paste from when asking for help.

Fixes: https://github.com/nodejs/node/issues/29731

PR-URL: https://github.com/nodejs/node/pull/38332


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

59d3d542

src: make napi_create_reference accept symbol · 33b5107d

JckXia authored Aug 28, 2021

PR-URL: https://github.com/nodejs/node/pull/39926


Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

33b5107d

Sep 08, 2021

doc: fix list indentation in corepack.md · 861c3e0f

Alexey Ten authored Sep 07, 2021

PR-URL: https://github.com/nodejs/node/pull/40029


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

861c3e0f

crypto: check webcrypto asymmetric key types during importKey · 5d34ef50
Filip Skokan authored Aug 31, 2021
```
PR-URL: https://github.com/nodejs/node/pull/39962


Reviewed-By: James M Snell <jasnell@gmail.com>
```
5d34ef50

Sep 07, 2021

stream: fix highwatermark threshold and add the missing error · 0c6f345c

Rongjian Zhang authored May 16, 2021



1. Fix highwatermark threshold: `< 1GiB` -> `<= 1GiB`
2. Add the missing error: Size out of range

Update test/parallel/test-streams-highwatermark.js

Co-authored-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/38700


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

0c6f345c

build: add YAML linting to GitHub Actions · b016d5df

Rich Trott authored Sep 05, 2021

PR-URL: https://github.com/nodejs/node/pull/40007


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

b016d5df

build: add YAML linting · 2b131a50

Rich Trott authored Sep 05, 2021

PR-URL: https://github.com/nodejs/node/pull/40007


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

2b131a50

tools,build: update YAML files in preparation for linting · 77c81cbc

Rich Trott authored Sep 05, 2021

Fix indentation, traiiling spaces, and missing newline issues in
preparation for linting.

PR-URL: https://github.com/nodejs/node/pull/40007


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

77c81cbc

build: run AUTHORS update weekly · 773a9897

Rich Trott authored Sep 05, 2021

PR-URL: https://github.com/nodejs/node/pull/40004


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

773a9897

test: make tests pass on Windows with Unix EOL · ff7a0df3

Michaël Zasso authored Sep 05, 2021

It is possible on Windows to configure Git to checkout line-endings
"as-is", which for Node.js means Unix-style.
This change makes the tests that rely on line endings pass in that case.

PR-URL: https://github.com/nodejs/node/pull/40002


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

ff7a0df3

src: fix C4805 MSVC warning · dadea4ab

Michaël Zasso authored Sep 05, 2021

'==' : unsafe mix of type 'bool' and type 'int' in operation

PR-URL: https://github.com/nodejs/node/pull/39998


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

dadea4ab

2021-09-07, Version 16.9.0 (Current) · 6211d935

Michaël Zasso authored Sep 06, 2021

Notable changes:

crypto:
  * (SEMVER-MINOR) add RSA-PSS params to asymmetricKeyDetails (Tobias Nießen) https://github.com/nodejs/node/pull/39851
deps:
  * (SEMVER-MINOR) add corepack (Maël Nison) https://github.com/nodejs/node/pull/39608
  * (SEMVER-MINOR) update V8 to 9.3.345.16 (Michaël Zasso) https://github.com/nodejs/node/pull/39947
module:
  * (SEMVER-MINOR) support pattern trailers (Guy Bedford) https://github.com/nodejs/node/pull/39635
stream:
  * (SEMVER-MINOR) add stream.compose (Robert Nagy) https://github.com/nodejs/node/pull/39029

PR-URL: https://github.com/nodejs/node/pull/40011

6211d935

lib,repl: ignore non-canBeRequiredByUsers built-in · c7222b35

XadillaX authored Aug 30, 2021

e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag
shouldn't be pre-required.

PR-URL: https://github.com/nodejs/node/pull/39942


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

c7222b35

meta: consolidate AUTHORS entries for mithunsasidharan · 8d5ed107

Rich Trott authored Sep 05, 2021

PR-URL: https://github.com/nodejs/node/pull/40003


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

8d5ed107

doc: fix history for `fs.WriteStream` `open` event · 3e774a05

Antoine du Hamel authored Sep 01, 2021

PR-URL: https://github.com/nodejs/node/pull/39972
Refs: https://github.com/nodejs/node/pull/33716
Refs: https://github.com/nodejs/node/pull/35993
Refs: https://github.com/nodejs/node/pull/35911


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

3e774a05

doc: fix missing history version in `fs.md` · 3f78545b

Antoine du Hamel authored Sep 01, 2021

Refs: https://github.com/nodejs/node/pull/33716
Refs: https://github.com/nodejs/node/pull/35993
Refs: https://github.com/nodejs/node/pull/35911

PR-URL: https://github.com/nodejs/node/pull/39972


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

3f78545b

Sep 06, 2021

src: register external references of PipeWrap for snapshot · 1c4df352

Joyee Cheung authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39961


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>

1c4df352

src: register external references of TTYWrap for snapshot · 6ddcdc31

Joyee Cheung authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39961


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>

6ddcdc31

src: register external references of TCPWrap for snapshot · 995f945e

Joyee Cheung authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39961


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>

995f945e

src: register external references of SignalWrap for snapshot · 3ec38f78

Joyee Cheung authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39961


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>

3ec38f78

src: register missing process methods external references · cca0305e

Joyee Cheung authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39961


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>

cca0305e

src: register missing stream wrap external references · cf11a2b0

Joyee Cheung authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39961


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>

cf11a2b0

src: register external references of BaseObject for snapshot · afc77605

Joyee Cheung authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39961


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>

afc77605

src: register external references of node-report for snapshot · b9ed7e55

Joyee Cheung authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39961


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>

b9ed7e55

src: register external references of dtrace for snapshot · ed132281

Joyee Cheung authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39961


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>

ed132281

Sep 05, 2021

meta: update AUTHORS · 80785f6e

Node.js GitHub Bot authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39957


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

80785f6e

crypto: add rsa-pss keygen parameters · c6b0ae83

Filip Skokan authored Aug 29, 2021

PR-URL: https://github.com/nodejs/node/pull/39927


Reviewed-By: James M Snell <jasnell@gmail.com>

c6b0ae83

build: preserves symbols during LTO with macOS linker · 338ab0df

Jesse Chan authored Aug 22, 2021



man ld -export_dynamic:

```
Preserves all global symbols in main executables during LTO.

Without this option, Link Time Optimization is allowed to inline
and remove global functions.

This option is used when a main executable may load a plug-in which
requires certain symbols from the main executable.
```

Bug: vercel/pkg#1155
Signed-off-by: Jesse Chan <jc@linux.com>

PR-URL: https://github.com/nodejs/node/pull/39839


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

338ab0df

Sep 03, 2021

tools: add support for import assertions in linter · f26c2ce0

Antoine du Hamel authored Aug 28, 2021

PR-URL: https://github.com/nodejs/node/pull/39924


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

f26c2ce0

src: remove usage of AllocatedBuffer from src/node_buffer.cc · 7cc96b2e

Darshan Sen authored Aug 30, 2021

Since AllocatedBuffer is just a thin wrapper around v8::BackingStore, we
should prefer using v8::BackingStore directly.

Refs: https://github.com/nodejs/node/blob/52abf271c563ddffdc93b444ea05e5347a7f2784/src/allocated_buffer.h#L30-L31



Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/39941


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

7cc96b2e

doc: add descriptions about when `options.mode` is ignored · 9fdb7262

Ray authored Aug 25, 2021

PR-URL: https://github.com/nodejs/node/pull/39881
Fixes: https://github.com/nodejs/node/issues/39859


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

9fdb7262

meta: remove duplicate AUTHORS entry for NigelKibodeaux · c68faa95

Rich Trott authored Aug 31, 2021

PR-URL: https://github.com/nodejs/node/pull/39967


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

c68faa95