- Apr 17, 2018
-
-
Anna Henningsen authored
Otherwise, potentially no output is shown for aborts. PR-URL: https://github.com/nodejs/node/pull/19990 Refs: https://github.com/nodejs/node/issues/19903 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Gurin, Sebastian authored
PR-URL: https://github.com/nodejs/node/pull/19967 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
buji authored
PR-URL: https://github.com/nodejs/node/pull/19909 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Gerhard Stoebich authored
http.setHeader() coerces input values. http.getHeader() returns the type as passed to setHeader(). PR-URL: https://github.com/nodejs/node/pull/19902 Fixes: https://github.com/nodejs/node/issues/13825 Reviewed-By:
Chen Gang <gangc.cxy@foxmail.com> Reviewed-By:
-
davidmarkclements authored
changes the base instance for ERR_HTTP2_INVALID_CONNECTION_HEADERS from Error to TypeError as a more accurate representation of the error. PR-URL: https://github.com/nodejs/node/pull/19807 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
ikasumiwt authored
PR-URL: https://github.com/nodejs/node/pull/19507 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
-
Ruben Bridgewater authored
This makes sure the actual and expected values on the error thrown by `assert.throws` etc. are always as they should be. PR-URL: https://github.com/nodejs/node/pull/19925 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure the input arguments get validated so implementation errors will be caught early. It also improves a couple of error messages by providing more detailed information and fixes errors detected by the new functionality. Besides that a error type got simplified and tests got refactored. PR-URL: https://github.com/nodejs/node/pull/19924 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Ruben Bridgewater authored
If none is provided, use zero as a default offset for all read/write operations on the buffer. PR-URL: https://github.com/nodejs/node/pull/19749 Refs: https://github.com/nodejs/node/pull/18395 Reviewed-By:
-
Ruben Bridgewater authored
One of the biggest downsides to the `assert.throws` API is that it does not check for the error message in case that is used as second argument. It will instead be used in case no error is thrown. This improves the situation by checking the actual error message against the provided one and throws an error in case they are identical. It is very unlikely that the user wants to use that error message as information instead of checking against that message. PR-URL: https://github.com/nodejs/node/pull/19867 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/20011 Refs: https://github.com/nodejs/node/pull/14485 Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19945 Refs: https://github.com/nodejs/node/pull/18138 Reviewed-By:
-
Ali Ijaz Sheikh authored
PR-URL: https://github.com/nodejs/node/pull/19992 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Trevor Norris authored
I'll still be around, but won't be able to contribute enough to merit TSC status. PR-URL: https://github.com/nodejs/node/pull/19985 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This makes Node pretty-print objects with color by default when `console.log()`-ing them. PR-URL: https://github.com/nodejs/node/pull/19372 Reviewed-By:
-
Anna Henningsen authored
Add a way to tell `Console` instances to either always use, never use or auto-detect color support and inspect objects accordingly. PR-URL: https://github.com/nodejs/node/pull/19372 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/19372 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/19372 Reviewed-By:
-
Anna Henningsen authored
Identical to `format()` except that it takes an options argument that is passed through to `inspect()`. PR-URL: https://github.com/nodejs/node/pull/19372 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/19956 Reviewed-By:
-
Anna Henningsen authored
Merge error handling for `net.Socket`s and `Http2Stream`s, and align the callback property names as `callback`. Refs: https://github.com/nodejs/node/issues/19060 PR-URL: https://github.com/nodejs/node/pull/19734 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Ayush Gupta authored
Passes the `message` parameter to `internalAssert` when `ERR_INVALID_ARG_TYPE` is thrown with invalid arguments. PR-URL: https://github.com/nodejs/node/pull/19908 Reviewed-By:
-
Daniel Bevenius authored
This commit adds includes for node_internal.h in source files that use arraysize but don't include this header. The motivation for this is to make refactoring easier (and is the reason I noticed this). PR-URL: https://github.com/nodejs/node/pull/19916 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Rich Trott authored
The errors thrown have changed in a few places. Update the comments to reflect the current errors. The `noAssert` option has been removed but it is still shown in sample code in a few places. Remove that sample code. PR-URL: https://github.com/nodejs/node/pull/19963 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Rich Trott authored
Remove unnecessary colons and wrap lines at 80 characters. PR-URL: https://github.com/nodejs/node/pull/19964 Reviewed-By:
-
Matei Copot authored
PR-URL: https://github.com/nodejs/node/pull/19968 Fixes: https://github.com/nodejs/node/issues/19796 Reviewed-By:
-
Ruben Bridgewater authored
In case a error is caught in `assert.doesNotThrow` or `assert.doesNotReject` it will now also indicate what the real error message was. PR-URL: https://github.com/nodejs/node/pull/19884 Reviewed-By:
-
Matteo Collina authored
Fixes: https://github.com/nodejs/node/issues/19905 PR-URL: https://github.com/nodejs/node/pull/19931 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19946 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19957 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19915 Reviewed-By:
-
Gerhard Stoebich authored
PR-URL: https://github.com/nodejs/node/pull/19910 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/19855 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rich Trott authored
Include the exit code in test failures. This will give us more information during the currently-puzzling failures that provide no information in CI such as: ``` 03:10:10 not ok 563 parallel/test-fs-truncate 03:10:10 --- 03:10:10 duration_ms: 1.119 03:10:10 severity: fail 03:10:10 stack: |- 03:10:10 ... ``` PR-URL: https://github.com/nodejs/node/pull/19855 Reviewed-By:
-
Rich Trott authored
Improve description of `encoding` option. (This change is also applied to `buf.indexOf()`.) Improve punctuation. Wrap at 80 characters. PR-URL: https://github.com/nodejs/node/pull/19904 Reviewed-By:
-
Shigeki Ohtsu authored
Instead of automatically falling back to openssl_no_asm with warning if no nasm is found during build on Windows, this stops vcbuild.bat and requires users to specify openssl_no_asm option explicitly. Fixes: https://github.com/nodejs/node/issues/19918 PR-URL: https://github.com/nodejs/node/pull/19943 Refs: https://github.com/nodejs/node/pull/19930 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19955 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19951 Reviewed-By:
-
Evan Lucas authored
I no longer have the time to dedicate to being on the TSC. I am still planning to contribute when time permits. PR-URL: https://github.com/nodejs/node/pull/19953 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
