- Mar 15, 2017
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/11810 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/11810 Reviewed-By:
-
Matej Krajčovič authored
Make sure test matches this specific error message. PR-URL: https://github.com/nodejs/node/pull/11815 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Italo A. Casas authored
Notable changes: * module: The [module loading global fallback] (https://nodejs.org/dist/latest-v6.x/docs/api/modules.html#modules_loading_from_the_global_folders) to the Node executable's directory now works correctly on Windows. (Richard Lau) [#9283](https://github.com/nodejs/node/pull/9283) * net: `Socket.prototype.connect` now once again functions without a callback. (Juwan Yoo) [#11762](https://github.com/nodejs/node/pull/11762) * url: `URL.prototype.origin` now properly specified an opaque return of `'null'` for `file://` URLs. (Brian White) [#11691](https://github.com/nodejs/node/pull/11691) PR-URL: https://github.com/nodejs/node/pull/11831
-
Joyee Cheung authored
Previously when the child dies with errors in this test, the parent will just hang and timeout, the errors in the child would be swallowed. This makes it fail so at least there is more information about why this test fails. Also removes the unnecessary child.kill() call. PR-URL: https://github.com/nodejs/node/pull/11684 Ref: https://github.com/nodejs/node/pull/11667 Reviewed-By:
-
Blake Embrey authored
Move the core logic from `LineParser` should fail handling into the recoverable error check for the REPL default eval. PR-URL: https://github.com/nodejs/node/pull/6171 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/11626 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Daijiro Wachi authored
Add a case to test an URL object that has no path at all for `url.resolveObject`. PR-URL: https://github.com/nodejs/node/pull/11811 Reviewed-By:
-
Daijiro Wachi authored
A module `assertPort` in `lib/internal/net.js` is not used anymore. Refs: https://github.com/nodejs/node/pull/11667 PR-URL: https://github.com/nodejs/node/pull/11812 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Alexey Orlenko authored
* Change var to const in an example of server creation. * Add missing semicolons. * Use `console` syntax highlighting in `telnet` and `nc` invocation examples and add shell prompt symbols to be consistent with the rest of the documentation. PR-URL: https://github.com/nodejs/node/pull/11786 Reviewed-By:
-
- Mar 14, 2017
-
-
Evan Lucas authored
When the release was cut, the changelog heading in CHANGELOG_V7 was accidentally omitted. PR-URL: https://github.com/nodejs/node/pull/11823 Fixes: https://github.com/nodejs/node/issues/11822 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Santiago Gimeno authored
It can happen that the connection and server is closed before the second reponse has been processed by server. In this case, the `res.setTimeout()` callback will never be called causing the test to fail. Fix this by only closing the connection and server when the 2nd has been received. PR-URL: https://github.com/nodejs/node/pull/11790 Fixes: https://github.com/nodejs/node/issues/11768 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Franziska Hinkelmann authored
Update the documentation to the correct V8 versions in the guide *Maintaining V8 in Node.js*. PR-URL: https://github.com/nodejs/node/pull/11787 Reviewed-By:
-
Daniel Bevenius authored
When configuring --without-ssl and then running make install openssl headers will be copied from deps/openssl to the target installation directory. This commit adds a check for is node_use_openssl is set in which case the headers are not copied. PR-URL: https://github.com/nodejs/node/pull/11766 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Rich Trott authored
`maxBuffer` information in child_process.md used atypical formatting. This uses a single consistent style for all instances of `maxBuffer` information. PR-URL: https://github.com/nodejs/node/pull/11791 Reviewed-By:
-
Rich Trott authored
test-child-process-fork-stdio-string-variant was only testing 'pipe' for its `stdio` value. Add `inherit` and `ignore`. Also added a `common.mustCall()` to verify that the `message` event is triggered. PR-URL: https://github.com/nodejs/node/pull/11783 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com>
-
Eugene Ostroukhov authored
JSON target list response will now return appropriate IP address for instances listening on 0.0.0.0. Refs: https://github.com/nodejs/node/issues/11591 PR-URL: https://github.com/nodejs/node/pull/11755 Reviewed-By:
-
- Mar 13, 2017
-
-
Bradley Farias authored
This behavior dates back to 2011 but was not documented. PR-URL: https://github.com/nodejs/node/pull/11581 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
-
Juwan Yoo authored
Arguments of Socket.prototype.connect should be also normalized, causing error when called without callback. Changed Socket.prototype.connect's code same as net.connect and added test. Fixes: https://github.com/nodejs/node/issues/11761 PR-URL: https://github.com/nodejs/node/pull/11762 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Joyee Cheung authored
Add checks for the built-in type tags to catch objects with faked prototypes. See https://tc39.github.io/ecma262/#sec-object.prototype.tostring for a partial list of built-in tags. Fixes: https://github.com/nodejs/node/issues/10258 PR-URL: https://github.com/nodejs/node/pull/10282 Reviewed-By:
-
- Mar 12, 2017
-
-
Richard Lau authored
Code was calculating $PREFIX/lib/node relative to process.execPath, but on Windows process.execPath is $PREFIX\node.exe whereas everywhere else process.execPath is $PREFIX/bin/node (where $PREFIX is the root of the installed Node.js). PR-URL: https://github.com/nodejs/node/pull/9283 Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
-
Richard Lau authored
Test executes with a copy of the node executable since $PREFIX/lib/node is relative to the executable location. PR-URL: https://github.com/nodejs/node/pull/9283 Reviewed-By:
-
Lukas Möller authored
PullRequest #5522 and #5500 described the change of the default encoding into UTF8 in crypto functions. This however was only changed for the non-streaming API. The streaming API still used binary as the default encoding. This commit will change the default streaming API encoding to UTF8 to make both APIs behave the same. It will also add tests to validate the behavior. Refs: https://github.com/nodejs/node/pull/5522 Refs: https://github.com/nodejs/node/pull/5500 PR-URL: https://github.com/nodejs/node/pull/8611 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
-
- Mar 11, 2017
-
-
Brian White authored
This commit consists of two changes: * Avoids returning request/id *just* for the debug() output * Returns `null` instead of an empty array for the list of paths PR-URL: https://github.com/nodejs/node/pull/10789 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Brian White authored
By avoiding JSON.stringify() and simply joining the strings with a delimiter that does not appear in paths, we can improve cached require() performance by at least 50%. Additionally, this commit removes the last source of permanent function deoptimization (const) for _findPath(). PR-URL: https://github.com/nodejs/node/pull/10789 Reviewed-By:
-
Brian White authored
Using a more "direct" method of function calling yields better performance. PR-URL: https://github.com/nodejs/node/pull/10789 Reviewed-By:
-
Brian White authored
hasOwnProperty() is known to be slow, do a direct lookup on a "clean" object instead. PR-URL: https://github.com/nodejs/node/pull/10789 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10789 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10789 Reviewed-By:
-
Brian White authored
Replacing the path separator-finding regexp with a custom function results in a measurable improvement in performance. PR-URL: https://github.com/nodejs/node/pull/10789 Reviewed-By:
-
Brian White authored
nullCheck() implicitly converts the argument to string when checking the value, so this commit avoids any unnecessary additional (Buffer) conversions to string. PR-URL: https://github.com/nodejs/node/pull/10789 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10789 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10789 Reviewed-By:
-
Timothy Gu authored
The ES addition operator calls the ToPrimitive() abstract operation without hint String, leading a subsequent OrdinaryToPrimitive() to call valueOf() first on an object rather than the desired toString(). Instead, use template literals which directly call ToString() abstract operation, per Web IDL spec. PR-URL: https://github.com/nodejs/node/pull/11737 Fixes: b610a4db "url: enforce valid UTF-8 in WHATWG parser" Refs: https://github.com/nodejs/node/commit/b610a4db1c2919f88711962f5797f25ecb1cd36b#commitcomment-21200056 Refs: https://tc39.github.io/ecma262/#sec-addition-operator-plus-runtime-semantics-evaluation Refs: https://tc39.github.io/ecma262/#sec-template-literals-runtime-semantics-evaluation Reviewed-By:
-
Joyee Cheung authored
* Improve description of socket.connect, net.connect, net.createConnection * Nest the overloaded signatures * Alias net.connect to net.createConnection * Add type annotations to the options * Make a separate section to explain IPC support and how to specify the path parameter. * General improvements to wording and explanation PR-URL: https://github.com/nodejs/node/pull/11700 Reviewed-By:
-
Timothy Gu authored
Previously all errors resulting from JSON.stringify were treated as a proof for circularity of the object structure. That is not the case if the `toJSON` method of the object throws an error. Explicitly check for the exact error message when determining the object structure's cyclicity. PR-URL: https://github.com/nodejs/node/pull/11708 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
James M Snell authored
A prior io.js era commit inappropriately removed the original copyright statements from the source. This restores those in any files still remaining from that edit. Ref: https://github.com/nodejs/TSC/issues/174 Ref: https://github.com/nodejs/node/pull/10599 PR-URL: https://github.com/nodejs/node/pull/10155 Note: This PR was required, reviewed-by and approved by the Node.js Foundation Legal Committee and the TSC. There is no `Approved-By:` meta data.
-
Benjamin Fleischer authored
Is a semver-breaking change Refs: https://github.com/nodejs/node/pull/11189#discussion_r99509433 PR-URL: https://github.com/nodejs/node/pull/11723 Reviewed-By:
-
- Mar 10, 2017
-
-
Junliang Yan authored
PR-URL: https://github.com/nodejs/node/pull/11730 Reviewed-By:
-
Shigeki Ohtsu authored
0-dns-cert.pem and 0-dns-key.pem were stored in `test/fixtures/key` directory, but the cert file cannot be created with the openssl command via Makefile. Added a script to create it with using `asn1.js` and `asn1.js-rfc5280` and moved them out of key directory and put into `test/fixtures/0-dns`. The domains listed in the cert were also changed into example.com and example.org to show the use for only testing. Fixes: https://github.com/nodejs/node/issues/10228 PR-URL: https://github.com/nodejs/node/pull/11579 Reviewed-By:
-
