- May 16, 2013
-
-
Ryuichi Okumura authored
-
Ryuichi Okumura authored
-
Ben Noordhuis authored
Test case: var t = setInterval(function() {}, 1); process.nextTick(t.unref); Output: Assertion failed: (args.Holder()->InternalFieldCount() > 0), function Unref, file ../src/handle_wrap.cc, line 78. setInterval() returns a binding layer object. Make it stop doing that, wrap the raw process.binding('timer_wrap').Timer object in a Timeout object. Fixes #4261. -
Ryan Graham authored
While they reference the same object, they are only interchangeable for updates, not assignment.
-
Ryan Graham authored
When exporting a single function you must use `module.exports` instead of the `exports` convenience reference.
-
- May 15, 2013
-
-
Bert Belder authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
* module: Deprecate require.extensions (isaacs) * stream: make Readable.wrap support objectMode, empty streams (Daniel Moore) * child_process: fix handle delivery (Ben Noordhuis) * crypto: Fix performance regression (isaacs) * src: DRY string encoding/decoding (isaacs)
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
This also templatizes the Buffer::*Slice functions, and the template function probably cannot be safely used outside of Node. However, it also SHOULD not be used outside of Node, so this is arguably a feature as well as a caveat.
-
isaacs authored
Bonus: this makes node::Encode actually work properly with base64, ucs2, hex, etc.
-
isaacs authored
-
isaacs authored
Four functions: - StringBytes::StorageSize() - StringBytes::Size() - StringBytes::Write() - StringBytes::Encode()
-
isaacs authored
We don't actually care about header order much, and since we never use stl classes, 'string' isn't an issue for node ever.
-
isaacs authored
Pretty much everything assumes strings to be utf-8, but crypto traditionally used binary strings, so we need to keep the default that way until most users get off of that pattern.
-
isaacs authored
If there is an encoding, and we do 'stream.push(chunk, enc)', and the encoding argument matches the stated encoding, then we're converting from a string, to a buffer, and then back to a string. Of course, this is a completely pointless bit of work, so it's best to avoid it when we know that we can do so safely.
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
- May 14, 2013
-
-
Benoit Vallée authored
Increasing the number of workers from 2 to 8 makes this test more likely to trigger race conditions. See #5330 for background.
-
Ben Noordhuis authored
-
Ben Noordhuis authored
Commit 9352c198 ("child_process: don't emit same handle twice") trades one bug for another. Before said commit, a handle was sometimes delivered with messages it didn't belong to. The bug fix introduced another bug that needs some explaining. On UNIX systems, handles are basically file descriptors that are passed around with the sendmsg() and recvmsg() system calls, using auxiliary data (SCM_RIGHTS) as the transport. node.js and libuv depend on the fact that none of the supported systems ever emit more than one SCM_RIGHTS message from a recvmsg() syscall. That assumption is something we should probably address someday for the sake of portability but that's a separate discussion. So, SCM_RIGHTS messages are never coalesced. SCM_RIGHTS and normal messages however _are_ coalesced. That is, recvmsg() might return this: recvmsg(); // { "message-with-fd", "message", "message" } The operating system implicitly breaks pending messages along SCM_RIGHTS boundaries. Most Unices break before such messages but Linux also breaks _after_ them. When the sender looks like this: sendmsg("message"); sendmsg("message-with-fd"); sendmsg("message"); Then on most Unices the receiver sees messages arriving like this: recvmsg(); // { "message" } recvmsg(); // { "message-with-fd", "message" } The bug fix in commit 9352c198 assumes this behavior. On Linux however, those messages can also come in like this: recvmsg(); // { "message", "message-with-fd" } recvmsg(); // { "message" } In other words, it's incorrect to assume that the file descriptor is always attached to the first message. This commit makes node wise up. Fixes #5330.
-
- May 10, 2013
-
-
isaacs authored
-
- May 09, 2013
-
-
Timothy J Fontaine authored
client sockets no longer emit 'connect' event inside the requestListener, update test-net-many-clients to reflect that
-
Robert Kowalski authored
Fixes #5255.
-
Daniel Moore authored
This makes Readable.wrap behave properly when the wrapped stream ends before emitting any data events.
-
Daniel Moore authored
Added a check to see if the stream is in objectMode before deciding whether to include or exclude data from an old-style wrapped stream.
-
- May 08, 2013
-
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
- May 07, 2013
-
-
Timothy J Fontaine authored
Preserve default install prefix seen in process.config, but use DESTDIR for installing to deliniate 32/64 versions, avoid conflicts with PREFIX settings in config.mk
-
- May 03, 2013
-
-
Kevin Locke authored
The stdio and customFds options are never used by exec or execFile, remove them from the documentation for these functions.
-
Miroslav Bajtoš authored
Change vcbuild.bat to ignore VCINSTALLDIR environment variable, always check for specific VS version and set GYP_MSVS_VERSION accordingly. Otherwise GYP generates project files in format that cannot be compiled by VS2012.
-
Sam Roberts authored
-