1. May 16, 2013
  2. May 15, 2013
  3. May 14, 2013
    • Benoit Vallée's avatar
      test: increase workers to 8 in cluster-disconnect · dbe9f8da
      Benoit Vallée authored
      Increasing the number of workers from 2 to 8 makes this test
      more likely to trigger race conditions. See #5330 for background.
      dbe9f8da
    • Ben Noordhuis's avatar
      doc: clarify subsystems in CONTRIBUTING.md · f13a3fd2
      Ben Noordhuis authored
      f13a3fd2
    • Ben Noordhuis's avatar
      child_process: fix handle delivery · 21bd4567
      Ben Noordhuis authored
      Commit 9352c198 ("child_process: don't emit same handle twice") trades
      one bug for another.
      
      Before said commit, a handle was sometimes delivered with messages it
      didn't belong to.
      
      The bug fix introduced another bug that needs some explaining. On UNIX
      systems, handles are basically file descriptors that are passed around
      with the sendmsg() and recvmsg() system calls, using auxiliary data
      (SCM_RIGHTS) as the transport.
      
      node.js and libuv depend on the fact that none of the supported systems
      ever emit more than one SCM_RIGHTS message from a recvmsg() syscall.
      That assumption is something we should probably address someday for the
      sake of portability but that's a separate discussion.
      
      So, SCM_RIGHTS messages are never coalesced. SCM_RIGHTS and normal
      messages however _are_ coalesced. That is, recvmsg() might return this:
      
        recvmsg();  // { "message-with-fd", "message", "message" }
      
      The operating system implicitly breaks pending messages along
      SCM_RIGHTS boundaries. Most Unices break before such messages but Linux
      also breaks _after_ them.  When the sender looks like this:
      
        sendmsg("message");
        sendmsg("message-with-fd");
        sendmsg("message");
      
      Then on most Unices the receiver sees messages arriving like this:
      
        recvmsg();  // { "message" }
        recvmsg();  // { "message-with-fd", "message" }
      
      The bug fix in commit 9352c198 assumes this behavior. On Linux however,
      those messages can also come in like this:
      
        recvmsg();  // { "message", "message-with-fd" }
        recvmsg();  // { "message" }
      
      In other words, it's incorrect to assume that the file descriptor is
      always attached to the first message. This commit makes node wise up.
      
      Fixes #5330.
      21bd4567
  4. May 10, 2013
  5. May 09, 2013
  6. May 08, 2013
  7. May 07, 2013
  8. May 03, 2013