1. Jun 07, 2013
    • Ben Noordhuis's avatar
      src: unexport node_isolate · 4bb4f734
      Ben Noordhuis authored
      Commit 0bba5902 accidentally (or maybe erroneously) added node_isolate
      to src/node.h and src/node_object_wrap.h.
      
      Undo that, said variable is not for public consumption. Add-on authors
      should use v8::Isolate::GetCurrent() instead.
      
      I missed that while reviewing. Mea culpa.
      
      Fixes #5639.
      4bb4f734
  2. Jun 06, 2013
    • isaacs's avatar
      Merge remote-tracking branch 'ry/v0.10' · 0882a750
      isaacs authored
      Conflicts:
      	ChangeLog
      	deps/uv/AUTHORS
      	deps/uv/ChangeLog
      	deps/uv/src/unix/linux-core.c
      	deps/uv/src/version.c
      	deps/uv/src/win/timer.c
      	lib/url.js
      	src/node_version.h
      	test/simple/test-url.js
      0882a750
  3. Jun 05, 2013
  4. Jun 04, 2013
    • Ben Noordhuis's avatar
      src: replace ngx-queue.h with queue.h · a7820a15
      Ben Noordhuis authored
      No functional changes, just one less entry in the LICENSE file.
      a7820a15
    • Nick Desaulniers's avatar
      src: wrap macros in `do {...} while (0)` · 72b92e92
      Nick Desaulniers authored
      Wrapped two macros in do {...} while (0) blocks and lined up
      backslashes.  Uses up semicolon in contexts where a dangling semicolon
      is erroneous.
      72b92e92
    • isaacs's avatar
      url: Set href to null by default · 5dd91b01
      isaacs authored
      5dd91b01
    • isaacs's avatar
      url: Properly parse certain oddly formed urls · 5dc51d4e
      isaacs authored
      In cases where there are multiple @-chars in a url, Node currently
      parses the hostname and auth sections differently than web browsers.
      
      This part of the bug is serious, and should be landed in v0.10, and
      also ported to v0.8, and releases made as soon as possible.
      
      The less serious issue is that there are many other sorts of malformed
      urls which Node either accepts when it should reject, or interprets
      differently than web browsers.  For example, `http://a.com*foo` is
      interpreted by Node like `http://a.com/*foo` when web browsers treat
      this as `http://a.com%3Bfoo/`.
      
      In general, *only* the `hostEndingChars` should be the characters that
      delimit the host portion of the URL.  Most of the current `nonHostChars`
      that appear in the hostname should be escaped, but some of them (such as
      `;` and `%` when it does not introduce a hex pair) should raise an
      error.
      
      We need to have a broader discussion about whether it's best to throw in
      these cases, and potentially break extant programs, or return an object
      that has every field set to `null` so that any attempt to read the
      hostname/auth/etc. will appear to be empty.
      5dc51d4e
    • isaacs's avatar
      stream: unshift('') is a noop · df6ffc01
      isaacs authored
      In some cases, the http CONNECT/Upgrade API is unshifting an empty
      bodyHead buffer onto the socket.
      
      Normally, stream.unshift(chunk) does not set state.reading=false.
      However, this check was not being done for the case when the chunk was
      empty (either `''` or `Buffer(0)`), and as a result, it was causing the
      socket to think that a read had completed, and to stop providing data.
      
      This bug is not limited to http or web sockets, but rather would affect
      any parser that unshifts data back onto the source stream without being
      very careful to never unshift an empty chunk.  Since the intent of
      unshift is to *not* change the state.reading property, this is a bug.
      
      Fixes #5557
      Fixes LearnBoost/socket.io#1242
      df6ffc01
  5. Jun 01, 2013
  6. May 31, 2013
    • Trevor Norris's avatar
      process: use Tock for nextTickQueue items · 4b31a2d8
      Trevor Norris authored
      v8 plays very well with constructed objects, so we're using one in the
      nextTickQueue.
      4b31a2d8
    • Trevor Norris's avatar
      src: remove old comment code · bcb85a1d
      Trevor Norris authored
      Now that maxTickDepth no longer exists there's no depth index on
      infoBox. Forgot to remove the comment about this.
      bcb85a1d
    • Trevor Norris's avatar
      process: remove spinner · b846842a
      Trevor Norris authored
      Remove the need to call start/stop the uv_idle spinner between
      MakeCallbacks. The one place where the tick processor needs to be kicked
      is where a user catches uncaughtException. For that we'll now use
      setImmediate, which accomplishes the same task.
      b846842a
    • isaacs's avatar
      Now working on v0.10.10 · ce54f4ae
      isaacs authored
      ce54f4ae
    • isaacs's avatar
      Merge branch 'v0.10.9-release' into v0.10 · 8c1a04db
      isaacs authored
      8c1a04db
    • isaacs's avatar
      2013.05.30, Version 0.10.9 (Stable) · 878ffdbe
      isaacs authored
      * npm: Upgrade to 1.2.24
      
      * uv: Upgrade to v0.10.9
      
      * repl: fix JSON.parse error check (Brian White)
      
      * tls: proper .destroySoon (Fedor Indutny)
      
      * tls: invoke write cb only after opposite read end (Fedor Indutny)
      
      * tls: ignore .shutdown() syscall error (Fedor Indutny)
      878ffdbe
    • isaacs's avatar
      npm: Upgrade to 1.2.24 · c86afa5d
      isaacs authored
      c86afa5d
    • Trevor Norris's avatar
      process: remove max tick check for domains · 9a6c0853
      Trevor Norris authored
      maxTickDepth checks have been removed for domains and replaced with a
      flag that checks if the last callback threw. If it did then execution of
      the remaining tickQueue is deferred to the spinner.
      
      This is to prevent domains from entering a continuous loop when an error
      callback also throws an error.
      9a6c0853
    • Trevor Norris's avatar
      process: remove maxTickDepth from _tickCallback · 0761c902
      Trevor Norris authored
      Removes the check for maxTickDepth for non-domain callbacks. So a user
      can starve I/O by setting a recursive nextTick.
      
      The domain case is more complex and will be addressed in another commit.
      0761c902
    • Trevor Norris's avatar
      process: relocate needSpinner calls · 5b636fea
      Trevor Norris authored
      It's only necessary to request the spinner once tickDone has been
      called, and not on every nextTick.
      5b636fea
  7. May 30, 2013