- Apr 21, 2016
-
-
Rich Trott authored
`assert.fail()` is often mistakenly used with a single argument even in Node.js core. (See fixes to previous instances in b7f4b1ba, 28e9a022. and 676e6187.) This commit adds a linting rule to identify instances of this issue. PR-URL: https://github.com/nodejs/node/pull/6261 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
`lib/internal/v8_prof_processor.js` was being excluded from linting, but the only lint issue it has is that it cannot run in strict mode. Disable the `strict` rule with a comment and remove the file from `.eslintignore`. PR-URL: https://github.com/nodejs/node/pull/6262 Reviewed-By:
Roman Klauke <romaaan.git@gmail.com> Reviewed-By:
-
Gibson Fahnestock authored
The tar-headers target tries to find and delete links in the tar folder, which fails as no links are found. Use rm -f to avoid this. Remove the config.gypi dependency, as the target runs configure itself. PR-URL: https://github.com/nodejs/node/pull/5978 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Josh Leder authored
See: https://github.com/nodejs/node/pull/6198 PR-URL: https://github.com/nodejs/node/pull/6279 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
-
Fedor Indutny authored
When handling a response to `CONNECT` request - skip message body and do not attempt to parse the next message. `CONNECT` requests are used in similar sense to HTTP Upgrade. Fix: https://github.com/nodejs/node/pull/6198 PR-URL: https://github.com/nodejs/node/pull/6279 Reviewed-By:
-
Fedor Indutny authored
Adds `2` as a return value of `on_headers_complete`, this mode will be used to fix handling responses to `CONNECT` requests. See: https://github.com/nodejs/node/pull/6198 PR-URL: https://github.com/nodejs/node/pull/6279 Reviewed-By:
-
James Reggio authored
Though not a POSIX signal, SIGINFO is supported by BSD systems (including Mac OS X) and is amongst the few signals that can be triggered in a terminal via a simple key combination (CTRL-T). On Linux, SIGINFO is an alias for SIGPWR; hence the defensive conditionals in src/node.cc. PR-URL: https://github.com/nodejs/node/pull/6093 Reviewed-By:
-
James M Snell authored
Adds additional `targetStart`, `targetEnd`, `sourceStart, and `sourceEnd` arguments to `Buffer.prototype.compare` to allow comparison of sub-ranges of two Buffers without requiring Buffer.prototype.slice() Fixes: https://github.com/nodejs/node/issues/521 PR-URL: https://github.com/nodejs/node/pull/5880 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Fedor Indutny authored
`Object.prototype.__defineGetter__` is deprecated now, use `Object.defineProperty` instead. PR-URL: https://github.com/nodejs/node/pull/6284 Reviewed-By:
-
Fedor Indutny authored
This will provide `bytesRead` data on consumed sockets. Fix: #3021 PR-URL: https://github.com/nodejs/node/pull/6284 Reviewed-By:
-
Fedor Indutny authored
When underlying `net.Socket` instance is consumed in http server - no `data` events are emitted, and thus `socket.setTimeout` fires the callback even if the data is constantly flowing into the socket. Fix this by calling `socket._unrefTimer()` on every `onParserExecute` call. Fix: #5899 PR-URL: https://github.com/nodejs/node/pull/6286 Reviewed-By:
-
Rich Trott authored
The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. PR-URL: https://github.com/nodejs/node/pull/6205 Fixes: https://github.com/nodejs/node/issues/6201 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Alexander Gromnitsky authored
PR-URL: https://github.com/nodejs/node/pull/6100 Reviewed-By:
-
Brian White authored
Moving the `message` event listener from the cluster object to each worker object allows easier backporting of the recent jslint changes since v5.x and older do not have v6.x's `worker` parameter in the cluster object's `message` event. PR-URL: https://github.com/nodejs/node/pull/6212 Reviewed-By:
-
John Eversole authored
This change was to add upon the algorithm description of path.format by adding examples for unix systems that clarified behavior in various scenarios. PR-URL: https://github.com/nodejs/node/pull/5838 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Santiago Gimeno authored
The only test with modifications is `test-stdin-child-proc` that was passing when it should not because the exit code of the child process was not being checked. PR-URL: https://github.com/nodejs/node/pull/6087 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com>
-
Santiago Gimeno authored
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: https://github.com/nodejs/node/pull/6246 Reviewed-By:
-
Johan Bergström authored
Run tests in parallel if the environment variable JOBS (which should contain a number of parallel jobs) is set. PR-URL: https://github.com/nodejs/node/pull/6208 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Brian White authored
This commit switches from the eslint command-line tool to a custom tool that uses eslint programmatically in order to perform linting in parallel and to display linting results incrementally instead of buffering them until the end. Fixes: https://github.com/nodejs/node/issues/5596 PR-URL: https://github.com/nodejs/node/pull/5638 Reviewed-By:
-
Rich Trott authored
Enforce alignment/indentation on variable assignments that span multiple lines. PR-URL: https://github.com/nodejs/node/pull/6242 Reviewed-By:
-
Rich Trott authored
Correct alignment on variable assignments that span multiple lines in preparation for lint rule to enforce such alignment. PR-URL: https://github.com/nodejs/node/pull/6242 Reviewed-By:
-
silverwind authored
PR-URL: https://github.com/nodejs/node/pull/6132 Reviewed-By:
-
silverwind authored
PR-URL: https://github.com/nodejs/node/pull/6132 Reviewed-By:
-
Santiago Gimeno authored
Make the servers listen on a free port number picked by the OS to avoid rare `EADDRINUSE` errors on `SmartOS`. Fixes: https://github.com/nodejs/node/issues/6197 PR-URL: https://github.com/nodejs/node/pull/6248 Reviewed-By:
-
Santiago Gimeno authored
Wait for the data to be received by the socket before creating the clean-up timer. This way, a possible (though unlikely) `ECONNRESET` error can be avoided. PR-URL: https://github.com/nodejs/node/pull/6166 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Ilya Shaisultanov authored
Special handling to detect when user has supplied a custom message. Added a test for user message. When testing if `actual` value is an error use `util.isError` instead of `instanceof`. Fixes: https://github.com/nodejs/node/issues/2385 PR-URL: https://github.com/nodejs/node/pull/2407 Reviewed-By:
-
abouthiroppy authored
PR-URL: https://github.com/nodejs/node/pull/6203 Reviewed-By:
-
William Kapke authored
PR-URL: https://github.com/nodejs/node/pull/6257 Reviewed-By:
-
Matthew Douglass authored
Removes the options block from the http 'response' event and attaches it to Agent#getName where it belongs. Removes socketPath and documents localAddress option. PR-URL: https://github.com/nodejs/node/pull/5993 Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/6020 Reviewed-By:
-
Steven R. Loomis authored
* Modify tools/license-builder.sh to support ICU 57.1's plain text license. (Separate issue to add ICU 57.1 in #6058) * Update/regenerate LICENSE to include ICU 57.1's license * Note that because the tool was rerun, the change in #6065 is already included here. PR-URL: https://github.com/nodejs/node/pull/6068 Reviewed-By:
-
Mike Kaufman authored
This is created by vs 2015 for user & machine-specific files and should be ignored by git. PR-URL: https://github.com/nodejs/node/pull/6070 Reviewed-By:
-
Mike Kaufman authored
These files are created by VS 2015 and should be ignored by git. PR-URL: https://github.com/nodejs/node/pull/6070 Reviewed-By:
-
James M Snell authored
Provide an example for implementing browser like behavior for console.assert. This "fixes" https://github.com/nodejs/node/issues/5340 by providing an alternative to changing Node.js' implemented behavior. Instead, we document the differences and show how to work around them if browser like semantics are desired. Fixes: https://github.com/nodejs/node/issues/5340 PR-URL: https://github.com/nodejs/node/pull/6169 Reviewed-By:
Robert Jefe Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By: Jeff Harris <@techjeffharris>
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/6196 Reviewed-By:
-
Bryan English authored
Clarify in docs for require.cache that reloading native modules isn't supported. Related: #6160 PR-URL: https://github.com/nodejs/node/pull/6168 Reviewed-By:
-
Rich Trott authored
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module. PR-URL: https://github.com/nodejs/node/pull/6211 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Alexander Makarenko authored
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`, `TypeError`, `URIError` to list of global types. Fix errors.markdown copy accordingly. Fixes: https://github.com/nodejs/node/issues/5325. PR-URL: https://github.com/nodejs/node/pull/5329 Reviewed-By:
-
Joran Dirk Greef authored
On Linux and OS X systems, `fs.watch()` resolves the watched path to an inode. This clarifies that `fs.watch()` watches the inode and not the path. If the inode of the path subsequently changes, `fs.watch()` will continue watching the original inode and events for the path will no longer be emitted. This is expected behavior. Fixes: https://github.com/nodejs/node/issues/5039 PR-URL: https://github.com/nodejs/node/pull/6099 Reviewed-By:
-
Rich Trott authored
Some vm tests are not in strict mode because they need to create and use global variables. By using `global.foo` instead of just `foo`, we can still enable strict mode. PR-URL: https://github.com/nodejs/node/pull/6209 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
