- Feb 06, 2019
-
-
Anna Henningsen authored
This function is not only helpful for debugging crashes, but can also be used as an ad-hoc debugging statement. PR-URL: https://github.com/nodejs/node/pull/25905 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/25910 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Anna Henningsen authored
The Windows ETW code is not written to be compatible with multi threading, and in particular it relies on global state like a single static `uv_async_t`. Adding that to multiple threads would corrupt the corresponding loops' handle queues. This addresses the flakiness of at least `test-worker-exit-code` and very likely other flaky tests that relate to Worker threads on Windows as well. Fixes: https://github.com/nodejs/node/issues/25847 Fixes: https://github.com/nodejs/node/issues/25702 Fixes: https://github.com/nodejs/node/issues/24005 Fixes: https://github.com/nodejs/node/issues/23873 PR-URL: https://github.com/nodejs/node/pull/25907 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
- Feb 05, 2019
-
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/25900 Fixes: https://github.com/nodejs/node/issues/25843 Reviewed-By:
-
David Benjamin authored
Use MaybeLocal::ToLocal and don't crash X509ToObject on error. PR-URL: https://github.com/nodejs/node/pull/25717 Reviewed-By:
-
David Benjamin authored
EC_KEY_key2buf returns an OPENSSL_malloc'd pointer so it shouldn't be passed into Buffer::New, which expect a libc malloc'd pointer. Instead, factor out the ECDH::GetPublicKey code which uses EC_POINT_point2oct. This preserves the existing behavior where encoding failures are silently ignored, but it is probably safe to CHECK fail them instead. PR-URL: https://github.com/nodejs/node/pull/25717 Reviewed-By:
-
Yang Guo authored
Chromium's ICU considers "latin1" and "ascii" to mean Windows-1252, which is consistent with [WHATWG spec](https://encoding.spec.whatwg.org/#names-and-labels). If linked against Chromium's ICU, Node.js therefore fails `test/parallel/test-icu-transcode`. PR-URL: https://github.com/nodejs/node/pull/25866 Refs: https://github.com/nodejs/node/issues/25851 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Jeremy Apthorp authored
Electron uses this because Chromium builds with symbols hidden by default. Refs:https://github.com/electron/node/commit/ 88b494191c2a5b50b01dab80cd61ba3c0e0fbeb9 Refs: https://github.com/electron/node/commit/ 1293d1d7d0c33d3925da11ceccdce4eb2e927a43 PR-URL: https://github.com/nodejs/node/pull/25893 Reviewed-By:
Gus Caplan <me@gus.host>
-
Rich Trott authored
Improve the material in the Collaborator Guide on unintended breaking changes. PR-URL: https://github.com/nodejs/node/pull/25887 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Sam Roberts authored
OpenSSL is packaging its git and travis configuration files. Remove them, Node.js has its own. PR-URL: https://github.com/nodejs/node/pull/25689 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
Anna Henningsen authored
Libuv does not guarantee that handles have their close callbacks called in the order in which they were added (and in fact, currently calls them in reverse order). This patch ensures that the `flush_signal_` handle is no longer in use (i.e. its close callback has already been run) when we signal to the main thread that `~NodeTraceBuffer` may be destroyed. The same applies for `~NodeTraceWriter`. Credit for debugging goes to Gireesh Punathil. Fixes: https://github.com/nodejs/node/issues/25512 Co-authored-by:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com>
-
Yang Guo authored
PR-URL: https://github.com/nodejs/node/pull/25868 Refs: https://github.com/nodejs/node/issues/25867 Reviewed-By:
-
Sam Roberts authored
Don't throw on invalid property access if options is not provided, and ensure callback is a function. PR-URL: https://github.com/nodejs/node/pull/25876 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
- Feb 04, 2019
-
-
gengjiawen authored
Signed-off-by:
gengjiawen <technicalcute@gmail.com> PR-URL: https://github.com/nodejs/node/pull/25732 Reviewed-By:
-
gengjiawen authored
Signed-off-by:
-
Daniel Bevenius authored
Currently, this test fails when configured --without-ssl: === release test-worker-cleanexit-with-moduleload === Path: parallel/test-worker-cleanexit-with-moduleload events.js:173 throw er; // Unhandled 'error' event ^ internal/util.js:101 throw new ERR_NO_CRYPTO(); ^ Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support This commit as a check for crypto so that this test is skipped if there is no crypto support. PR-URL: https://github.com/nodejs/node/pull/25811 Reviewed-By: -
Rich Trott authored
For `globals`, booleans are deprecated in favor strings `'readable'`/`'writeable'`. PR-URL: https://github.com/nodejs/node/pull/25877 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/25877 Reviewed-By:
-
Rich Trott authored
Version 2.1.0 of dmn will get rid of .map and .ts files. PR-URL: https://github.com/nodejs/node/pull/25877 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25823 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Anna Henningsen authored
There are no non-internal builtin modules left, so this should be safe to remove to a large degree. PR-URL: https://github.com/nodejs/node/pull/25829 Reviewed-By:
-
Anna Henningsen authored
Report the actual source code when running with `--eval` and `--inspect-brk`, by telling the vm module to break on the first line of the script being executed rather than wrapping the source code in a function. PR-URL: https://github.com/nodejs/node/pull/25832 Reviewed-By:
-
Anna Henningsen authored
Handle situations where accessing `.name` or `.stack` on an object fails. Fixes: https://github.com/nodejs/node/issues/25718 PR-URL: https://github.com/nodejs/node/pull/25834 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Anna Henningsen authored
This just makes the code a bit more obvious (subjectively). PR-URL: https://github.com/nodejs/node/pull/25869 Reviewed-By:
-
- Feb 03, 2019
-
-
Raido Kuli authored
`os.userInfo()` throws an exception which was not documented in environments like: `docker run --user $(id -u): $(id -g)`. PR-URL: https://github.com/nodejs/node/pull/25724 Fixes: https://github.com/nodejs/node/issues/25714 Reviewed-By:
-
Rich Trott authored
Files in benchmark/assert/* were sometimes using trailing commas for multi-line objects and sometimes not, mixing the approaches in the same file sometimes. Standardize these files to always use trailing commas in multi-line objects. Additionally, remove some unnecessary line-wrapping (so that there are fewer multi-line objects). PR-URL: https://github.com/nodejs/node/pull/25865 Reviewed-By:
-
Rich Trott authored
The prerequisistes for test-all-suites were running some tests themselves. When one of those tests failed during a coverage run, it resulted in artificially low coverage. Fix the prerequisites to only build stuff, not test. PR-URL: https://github.com/nodejs/node/pull/25892 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/25855 Refs: https://github.com/nodejs/node/pull/25755 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
- Feb 02, 2019
-
-
Rich Trott authored
Remove bullet points about how breaking changes are handled in Current and LTS branches. * This information is covered in https://github.com/nodejs/Release#release-plan. * Having it here and in the above link means that the two may get out of sync, resulting in confusion. * The above link appears later in the doc in the LTS section. * Most Collaborators should not land *anything* in LTS branches and will almost never have a reason to land things into Current branches. They land stuff on the master branch. Adding this material here is confusing because it implies that Collaborators do land stuff on those branches. Save talk about those branches and how they're managed for later in the LTS section where it can be made clear that most Collaborators should not be landing code there anyway. PR-URL: https://github.com/nodejs/node/pull/25842 Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/build/issues/1676#issuecomment-459218651 PR-URL: https://github.com/nodejs/node/pull/25841 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
-
Luigi Pinca authored
Fix flakyness caused by usage of a non-routable IP address. Refs: https://github.com/nodejs/node/pull/25488#issuecomment-459385146 PR-URL: https://github.com/nodejs/node/pull/25854 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Sam Roberts authored
OpenSSL has supported async notification of sessions and tickets since 1.1.0 using SSL_CTX_sess_set_new_cb(), for all versions of TLS. Using the async API is optional for TLS1.2 and below, but for TLS1.3 it will be mandatory. Future-proof applications should start to use async notification immediately. In the future, for TLS1.3, applications that don't use the async API will silently, but gracefully, fail to resume sessions and instead do a full handshake. See: https://wiki.openssl.org/index.php/TLS1.3#Sessions PR-URL: https://github.com/nodejs/node/pull/25831 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Rich Trott authored
There is currently no Makefile target that runs every test suite. This adds one. PR-URL: https://github.com/nodejs/node/pull/25799 Reviewed-By:
-
PR-URL: https://github.com/nodejs/node/pull/25767 Reviewed-By:
cclauss <cclauss@me.com> Reviewed-By:
-
gengjiawen authored
Signed-off-by:
-
gengjiawen authored
Signed-off-by:
-
Joyee Cheung authored
This has already been practically end-of-life since `node --debug` alone would exit the process. This patch drops support of `node --inspect --debug-brk` as well. `node --inspect --debug-brk` has been deprecated since v8, it has been maintained so that vendors can target Node.js v6 and above without detecting versions. The support of `--inspect`, which starts from v6, will reach end-of-life in April 2019, it should be safe to drop the support of `--inspect --debug-brk` altogether in v12. Also removes `process._deprecatedDebugBrk` PR-URL: https://github.com/nodejs/node/pull/25828 Refs: https://github.com/nodejs/node/pull/12949 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Joyee Cheung authored
Moves the exit of `--debug` and `--debug-brk` earlier, that is, after the option parsing is done in the C++ land. Also removes `process._invalidDebug`. PR-URL: https://github.com/nodejs/node/pull/25828 Refs: https://github.com/nodejs/node/pull/12949 Reviewed-By:
-
Michael Dawson authored
Exclude async-hooks/test-callback-error as it seems to fail consistently when run with coverage on the docker ubuntu16 machines we plan to run the coverage sanity test on. PR-URL: https://github.com/nodejs/node/pull/25833 Reviewed-By:
-
Joyee Cheung authored
This patch moves the part in the report initialization that mutates the process object into bootstrap/node.js so it's easier to tell the side effect of the initialization on the global state during bootstrap. PR-URL: https://github.com/nodejs/node/pull/25821 Reviewed-By:
-
