- Aug 12, 2014
-
-
seishun authored
Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
- Aug 11, 2014
-
-
Alexis Campailla authored
Fix https://github.com/joyent/node/issues/2341 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Aug 09, 2014
-
-
cjihrig authored
Regression occurred that prevented the variable "family" from being set properly when the lookup() function's "options" parameter was passed a number instead of an object. Also included a sanity check by setting the default value of "family" to a value that will not pass verification. Fixes: e643fe4c "dns: fix GetAddrInfo assert" Reviewed-by:
Alexis Campailla <alexis@janeasystems.com> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Fedor Indutny authored
Original source: http://openssl.6102.n7.nabble.com/PATCH-s-client-Fix-keypress-requirement-with-redirected-input-on-Windows-td46787.html Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Aug 08, 2014
-
-
Thorsten Lorenz authored
Linking CoreFoundation for OSX is needed for OSX debugging features to function properly. For instance Instruments cannot record Heap Allocations if the CoreFoundation is not linked. Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Alexis Campailla authored
Disabling the part of the test that relies on dispatching SIGHUP, because sending SIGHUP is not supported on Windows. Signed-off-by:Timothy J Fontaine <tjfontaine@gmail.com>
-
Jackson Tian authored
Signed-off-by:Timothy J Fontaine <tjfontaine@gmail.com>
-
Timothy J Fontaine authored
Conflicts: ChangeLog Makefile deps/uv/ChangeLog deps/uv/build.mk deps/uv/src/unix/darwin.c deps/uv/src/unix/getaddrinfo.c deps/uv/src/version.c deps/v8/src/checks.h deps/v8/src/isolate.h lib/cluster.js lib/module.js lib/timers.js lib/tls.js src/node_version.h
-
Julien Gilli authored
Send messages until both the parent and the child process have received at least one message. If at least one of them doesn't receive any message, the test runner will make the test timeout. Fixes #8046.
-
Maciej Małecki authored
Fixes #6361.
-
Jackson Tian authored
-
- Aug 07, 2014
-
-
Saúl Ibarra Corretgé authored
Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Alexis Campailla authored
This is the Node side of the fix for Node's cluster module on Windows. https://github.com/joyent/node/issues/7691 The other required part is https://github.com/joyent/libuv/pull/1384 Windows and Unix return certain socket errors (i.e. EADDRINUSE) at different times: bind on Windows, and listen on Unix. In an effort to hide this difference, libuv on Windows stores such errors in the bind_error field of uv_tcp_t, to defer raising it at listen time. This worked fine except for the case in which a socket is shared in a Node cluster and a bind error occurs. A previous attempt to fix this ( https://github.com/joyent/libuv/commit/d1e6be1460f555a1f8a4063d7642696aa7238769 https://github.com/joyent/node/commit/3da36fe00e5d85414031ae812e473f16629d8645 ) was flawed becaused in an attempt to relay the error at the JS level it caused the master to start accepting connections. With this new approach, libuv itself is relaying the bind errors, providing for a uniform behavior of uv_tcp_listen. Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
-
Fedor Indutny authored
-
Kevin Simper authored
-
- Aug 05, 2014
-
-
Jackson Tian authored
Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
The method GetAddrInfo() is used by more than just dns.lookup(), and in those cases a third argument isn't passed. This caused the following check to abort: assert(args[3]->IsInt32()); Fixes: 43067864 "net: don't prefer IPv4 addresses during resolution" Signed-off-by:
Trevor Norris <trev.norris@gmail.com>
-
cjihrig authored
Currently the address resolution family defaults to IPv4. Instead remove the preference and instead resolve to a family suitable for the host. Expose the getaddrinfo flags and allow them to be passed. Add documentation about new flags. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Timothy J Fontaine authored
Supresses a very loud warning from GCC 4.8 about unused typedefs Original url https://codereview.chromium.org/69413002
-
Julien Gilli authored
Do not use first socket in second socket's connect handler. Probably a copy/paste mistake. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Herman Lee authored
On Windows, path.isAbsolute() returns an empty string on failed cases. This forces the return value to always be boolean. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Julien Gilli authored
When backporting f8193ab3 into v0.10, a regression was introduced. Timers with non-integer timeout could trigger a infinite recursion with 100% cpu usage. This commit backports 93b06246 which fixes the regression. After backporting f8193ab3, instead of using Date.now(), timers would use Timer.now() to determine if they had expired. However, Timer.now() is based on loop->time, which is not updated when a timer's remaining time is > 0 and < 1. Timers would thus never timeout if their remaining time was at some point > 0 and < 1. With this commit, Timer.now() updates loop->time itself, and timers always timeout eventually. Fixes #8065 and #8068.
-
- Aug 03, 2014
-
-
Jackson Tian authored
Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
- Aug 02, 2014
-
-
Fedor Indutny authored
fix #8023
-
Sam Roberts authored
Callbacks in node are usually asynchronous, and should never be sometimes synchronous, and sometimes asynchronous. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Lucio M. Tato authored
Internal function trim(arr). 2nd parameter of slice() should be slice's end index (not included). Because of function normalize() (called before trim()), "start" is always zero so the bug -for now- has no effect, but its a bug waiting to happen. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Sam Roberts authored
See joyent/node#8043, test passed on v0.11 already, but this makes the test stronger. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
James Halliday authored
A streams1 stream will have its falsy values such as 0, false, or "" eaten by the upgrade to streams2, even when objectMode is enabled. Include test for said cases. Reviewed-by:
isaacs <i@izs.me> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Aug 01, 2014
-
-
Jackson Tian authored
Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
cjihrig authored
This commit moves some common Worker code into the constructor via support for an options argument. Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Jakob Gillich authored
Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Gabriel Wicke authored
This patch adds a fast path for parsing of simple path-only URLs, as commonly found in HTTP requests received by a server. Benchmark results [ms], before / after patch: /foo/bar 0.008956 0.000418 (fast path used) http://example.com/ 0.011426 0.011437 (normal slow path, no change) In a simple 'ab' benchmark of a single-threaded web server, this patch increases the request rate from around 6400 to 7400 req/s. Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
* uv: Upgrade to v0.10.28 * npm: Upgrade to v1.4.21 * v8: Interrupts must not mask stack overflow. * Revert "stream: start old-mode read in a next tick" (Fedor Indutny) * buffer: fix sign overflow in `readUIn32BE` (Fedor Indutny) * buffer: improve {read,write}{U}Int* methods (Nick Apperson) * child_process: handle writeUtf8String error (Fedor Indutny) * deps: backport 4ed5fde4f from v8 upstream (Fedor Indutny) * deps: cherry-pick eca441b2 from OpenSSL (Fedor Indutny) * lib: remove and restructure calls to isNaN() (cjihrig) * module: eliminate double `getenv()` (Maciej Małecki) * stream2: flush extant data on read of ended stream (Chris Dickinson) * streams: remove unused require('assert') (Rod Vagg) * timers: backport f8193ab3 (Julien Gilli) * util.h: interface compatibility (Oguz Bastemur) * zlib: do not crash on write after close (Fedor Indutny) -
Timothy J Fontaine authored
-
Fedor Indutny authored
Backport of https://codereview.chromium.org/339883002
-
Timothy J Fontaine authored
-
- Jul 31, 2014
-
-
Maciej Małecki authored
`process.env` access results in a synchronous `getenv` call. Cache the first result instead and save one syscall.
-