- May 14, 2020
-
-
Richard Lau authored
XCode builds on macOS do not appear to inherit the `cflags` setting. Signed-off-by:
Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33357 Refs: https://github.com/nodejs/node/pull/32685 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
- May 13, 2020
-
-
Joyee Cheung authored
- Print test results as soon as they are available, instead of until after all the tests are complete. This helps us printing tests whose completion callback is not called because of failures. - Run the scripts specified by `// META: script=` one by one instead of concatenating them first for better error stack traces. - Print a status summary when the test process is about to exit. This can be used as reference for updating the status file. For example the stderr output of `out/Release/node test/wpt/test-console.js` would be: ``` { 'idlharness.any.js': { fail: { expected: [ 'assert_equals: operation has wrong .length expected 1 but got 0' ] } } } Ran 4/4 tests, 0 skipped, 3 passed, 1 expected failures, 0 unexpected failures ``` PR-URL: https://github.com/nodejs/node/pull/33297 Reviewed-By:Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Joyee Cheung authored
This commit updates the interfaces to https://github.com/web-platform-tests/wpt/tree/8ada332aea/interfaces and updates the hr-time test status: - `window-worker-timeOrigin.window.js` should be skipped because we don't implement `Blob` - `idlharness.any.js` should be skipped since the IDL parser needs to be updated, but the parser update would also result in an update of the test harness which in turn requires updates of other tests. We need to fix the URL implementation first, and then update the harness and all the tests. PR-URL: https://github.com/nodejs/node/pull/33297 Reviewed-By:
-
Daniel Bevenius authored
This commit adds the primordials argument to the comment of arguments passed to bootstrap/node.js. PR-URL: https://github.com/nodejs/node/pull/33318 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/33261 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Paolo Insogna authored
PR-URL: https://github.com/nodejs/node/pull/33308 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
- May 12, 2020
-
-
Michaël Zasso authored
V8 does not support the flag on this architecture anymore. PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Matheus Marchini authored
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/1997438 Ref: https://chromium-review.googlesource.com/c/v8/v8/+/2010107 Ref: https://github.com/nodejs/node-v8/issues/144 Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Shu-yu Guo authored
PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Michaël Zasso authored
Original commit message: FreeBSD: add missing include of pthread_np.h This is necessary for the pthread_attr_get_np function. Change-Id: I01cfe075a7c86909e8cf37eb7f7c5d44fa044975 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2188310 Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Michaël Zasso <mic.besace@gmail.com> Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67660} Refs: https://github.com/v8/v8/commit/74d50c5063b39ac97ad4a032d333493882d72c41 PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [arraybuffer] Clean up BackingStore even if it pointer to nullptr For a zero-length BackingStore allocation, it is valid for the underlying memory to be a null pointer. However, some cleanup is still necessary, since the BackingStore may hold a reference to the allocator itself, which needs to be released when destroying the `BackingStore` instance. Change-Id: I1f168079d39e4592d2fde31fbe5f705586690e85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169646 Reviewed-by: -
Michaël Zasso authored
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67027} Refs: https://github.com/v8/v8/commit/3f8dc4b2e5baf77b463334c769af85b79d8c1463 PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Milad Farazmand authored
Original commit message: Fix compilation error with devtoolset-8 We are compiling V8 using devtoolset-8 and it is generating a new compilation error related to String Truncation: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated copying between 1 and 15 bytes from a string of length 15 [-Werror=stringop-truncation] strncpy(buffer, unicode_utf8, i); Which basically means the null terminating character was not added to the end of the buffer: https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/ This CL will changes 2 uses of "strncpy" to "memcpy" as strings are being copied partially and `\n` being added at a later stage. Change-Id: I3656afb00463d70ddb8700a487a1978b793e1d09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2155038 Reviewed-by:Andreas Haas <ahaas@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67277} Refs: https://github.com/v8/v8/commit/e1eac1b16c966879102c2310d7649637227eaa02 PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Matheus Marchini authored
Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Joao Reis authored
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Refael Ackermann authored
This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Refael Ackermann authored
Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Ujjwal Sharma authored
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Refael Ackermann authored
Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.3. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/33358 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1 PR-URL: https://github.com/nodejs/node/pull/33324 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com>
-
Daniel Bevenius authored
This commit suggest using MaybeLocal.ToLocal and passing in the Local<Function> fn. The motivation for doing this is that the following MaybeLocal.ToLocalChecked call can then be avoided. PR-URL: https://github.com/nodejs/node/pull/33312 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
This commit fixes what I think is a typo, even though the section in question does talk about a environment (env). PR-URL: https://github.com/nodejs/node/pull/33319 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/33350 Reviewed-By:
-
Rich Trott authored
Repeat writes until data is queued in memory, rather than assuming that it will happen by a certain point. Fixes: https://github.com/nodejs/node/issues/33135 PR-URL: https://github.com/nodejs/node/pull/33329 Reviewed-By:
-
Robert Nagy authored
Calling destroy() on a completed ClientRequest, i.e. once 'close' will be emitted should be a noop. Also before emitting 'close' destroyed === true. Fixes: https://github.com/nodejs/node/issues/32851 PR-URL: https://github.com/nodejs/node/pull/33120 Reviewed-By:
-
- May 11, 2020
-
-
Robert Nagy authored
Server requests aka. IncomingMessage emits 'aborted' instead of 'error' which causes confusion when the object is used as a regular stream, i.e. if functions working on streams are passed a server request object they might not work properly unless they take this into account. Refs: https://github.com/nodejs/web-server-frameworks/issues/41 PR-URL: https://github.com/nodejs/node/pull/33172 Fixes: https://github.com/nodejs/node/issues/28172 Refs: https://github.com/nodejs/node/pull/28677 Reviewed-By:
-
cjihrig authored
Update ESLint to 7.0.0 PR-URL: https://github.com/nodejs/node/pull/33316 Reviewed-By:
-
- May 10, 2020
-
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/33301 Reviewed-By:
-
Anna Henningsen authored
These calls are unnecessary in Release mode but would still have been included, so move them to the `DebugSealHandleScope` constructor. PR-URL: https://github.com/nodejs/node/pull/33298 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
These rules only apply for the test folder and will already be checked for. PR-URL: https://github.com/nodejs/node/pull/32161 Refs: https://github.com/nodejs/node/pull/32078 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure all usages of `util.debuglog()` must contain the string 'test' as argument. PR-URL: https://github.com/nodejs/node/pull/32161 Refs: https://github.com/nodejs/node/pull/32078 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/nodejs/node/pull/32790 PR-URL: https://github.com/nodejs/node/pull/33287 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
