Commits · 38f0e382f7b431620323a3bb9cac052d3e7a539d · github.com / v8-riscv / node

Apr 03, 2019

doc: remove unnecessary intro in governance doc · 38f0e382

Rich Trott authored Mar 31, 2019

The introductory paragraph in GOVERNANCE.md does not add anything that
isn't obvious from the document itself. Remove it.

PR-URL: https://github.com/nodejs/node/pull/27036


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

38f0e382

report: add cwd to report · d5a5b99e

cjihrig authored Mar 30, 2019

The diagnostic report currently contains command line
information, and the environment, which contains the PWD
environment variable. This combination covers the majority
of cases, but it would be useful to have the result of
uv_cwd() as an additional data point. This commit adds that
information.

PR-URL: https://github.com/nodejs/node/pull/27022


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

d5a5b99e

process: run RunBootstrapping in CreateEnvironment · 19442656

Joyee Cheung authored Mar 20, 2019

Also creates `CreateMainEnvironment` to encapsulate the code
creating the main environment from the provided Isolate data
and arguments.

PR-URL: https://github.com/nodejs/node/pull/26788


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

19442656

doc: remove old system_errors · e02f511d

Minwoo Jung authored Mar 29, 2019

Remove old errors_system_errors, any useful information
in it moved into the SystemError class docs.

Fixes: https://github.com/nodejs/node/issues/26861
PR-URL: https://github.com/nodejs/node/pull/27037


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

e02f511d

path: refactor for less indentation · dd0d6df9

Ruben Bridgewater authored Mar 26, 2019

This just switches the statements in a way that it reduces the
overall indentation. The function has a very deep indentation in
general and this should improve the readability.

PR-URL: https://github.com/nodejs/node/pull/26917


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

dd0d6df9

util: improve error property inspection · f7c96856

Ruben Bridgewater authored Mar 29, 2019

This makes sure that errors that contain extra properties show those
properties on a separate line.

PR-URL: https://github.com/nodejs/node/pull/26984


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

f7c96856

util: improve `inspect()` compact number mode · 14b2db01

Ruben Bridgewater authored Mar 29, 2019

This fixes a proportion calculation for lots of short array entries
with at least one bigger one that alone makes up for more than one
fifth of all other entries together.

PR-URL: https://github.com/nodejs/node/pull/26984


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

14b2db01

module: mark DEP0019 as End-of-Life · 75007d64

Ruben Bridgewater authored Mar 29, 2019

In certain cases, `require('.')` could resolve outside the package
directory. This behavior has been removed.

PR-URL: https://github.com/nodejs/node/pull/26973
Refs: https://github.com/nodejs/node/pull/3384


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

75007d64

test: simplify date inspection tests · 666c67e0

Ruben Bridgewater authored Mar 26, 2019

The code duplicated a lot of logic that was already abstracted. Use
the abstraction instead to remove code overhead.

PR-URL: https://github.com/nodejs/node/pull/26922


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

666c67e0

util: `inspect()` should not exceed `breakLength` · e1e9f1e9

Ruben Bridgewater authored Mar 26, 2019

Using `util.inspect()` with the `compact` option set to a number
could result in output that exceeded the `breakLength` option. This
change makes sure that limit is taken into account.

PR-URL: https://github.com/nodejs/node/pull/26914


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

e1e9f1e9

doc: unify link formatting in buffer.md · 7aa7971e

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

7aa7971e

doc: unify periods in comments in buffer.md · 35d83d51

Vse Mozhet Byt authored Mar 30, 2019

"Prints: ..." comments were excepted to avoid confusion.

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

35d83d51

doc: add notes about negative offsets in buffer.md · 2de67343

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

2de67343

doc: mark optional parameters in buffer.md · 82a95fed

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

82a95fed

doc: add note about Buffer octets integer coercion · 0e803d1d

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

0e803d1d

doc: fix error notes in `Buffer.from()` variants · e4c6c3bf

Vse Mozhet Byt authored Mar 30, 2019

Make notes about `TypeError` conditions in `Buffer.from()` variants
more accurate.

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

e4c6c3bf

doc: unify number/integer types in buffer.md · 2f338f3f

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

2f338f3f

doc: add missing types in buffer.md · 3c11f64e

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

3c11f64e

doc: fix possible typo in buffer.md · f89568e8

Vse Mozhet Byt authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

f89568e8

doc: remove description duplication in buffer.md · 1dd9662e

Vse Mozhet Byt authored Mar 30, 2019

PR-URL: https://github.com/nodejs/node/pull/27030


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1dd9662e

src: replace c-style cast · 4d273945

gengjiawen authored Mar 24, 2019

PR-URL: https://github.com/nodejs/node/pull/26888


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

4d273945

Apr 02, 2019

test: remove test-trace-events-api-worker-disabled from flaky · da79d30c

Rich Trott authored Mar 30, 2019

PR-URL: https://github.com/nodejs/node/pull/27020


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

da79d30c

tools: fix `test.py --time` · 8bfce899

Richard Lau authored Mar 30, 2019

PR-URL: https://github.com/nodejs/node/pull/27007


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8bfce899

fs: remove experimental warning for fs.promises · 5583d4d7

Anna Henningsen authored Mar 11, 2019

This has been warning for long enough, without any API changes
in the last few months.

PR-URL: https://github.com/nodejs/node/pull/26581


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

5583d4d7

test: move test that creates 1Gb file to pummel · 82bf240e

Rich Trott authored Apr 01, 2019

Fixes: https://github.com/nodejs/node/issues/16601

PR-URL: https://github.com/nodejs/node/pull/27053


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

82bf240e

doc: improve the doc of the 'information' event · 0a5a762a

Luigi Pinca authored Mar 30, 2019

- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

PR-URL: https://github.com/nodejs/node/pull/27009
Fixes: https://github.com/nodejs/node/issues/26905


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

0a5a762a

src: remove internal includes from node_crypto.h · dada2eba

Sam Roberts authored Mar 28, 2019

Remove headers used by node_crypto.cc that were included in
node_crypto.h. The header file should only include what it uses itself.

PR-URL: https://github.com/nodejs/node/pull/26966


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

dada2eba

build,meta: tweak Travis config · 7bf51715

Refael Ackermann authored Mar 28, 2019

* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`

PR-URL: https://github.com/nodejs/node/pull/26969


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

7bf51715

test: add IPv6 brackets but no port to test-dns · 8afab1a5

Rich Trott authored Mar 29, 2019

Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: https://github.com/nodejs/node/pull/27006


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8afab1a5

dns: refactor lib/internal/dns/utils.js · c88d9577

Rich Trott authored Mar 29, 2019

* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: https://github.com/nodejs/node/pull/27006


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

c88d9577

doc: move "Prints: ..." under the code · c6faf5b6

simon3000 authored Apr 01, 2019

PR-URL: https://github.com/nodejs/node/pull/27035


Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

c6faf5b6

doc: add information about modules cache behavior · 6eae4148

Ruben Bridgewater authored Mar 29, 2019

This publicly documents that adding native module names will resolve
the added entry instead of the native module.

It also updates the description why extensions are deprecated.

PR-URL: https://github.com/nodejs/node/pull/26971
Refs: https://github.com/nodejs/node/pull/25362


Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

6eae4148

Apr 01, 2019

doc: list when promiseResolve hook was added to async_hooks · fcdee743

Thomas Watson authored Mar 29, 2019

PR-URL: https://github.com/nodejs/node/pull/26978
Refs: https://github.com/nodejs/node/pull/15296


Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

fcdee743

crypto: use EVP_PKEY_X448 in GetEphemeralKeyInfo · 05bd6071

cjihrig authored Mar 29, 2019

PR-URL: https://github.com/nodejs/node/pull/26988


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

05bd6071

crypto: use EVP_PKEY_X25519 in GetEphemeralKeyInfo · 6ac692a3

cjihrig authored Mar 29, 2019

PR-URL: https://github.com/nodejs/node/pull/26988


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

6ac692a3

tools: update ESLint to 5.16.0 · bf347f53

cjihrig authored Mar 30, 2019

Update ESLint to 5.16.0

PR-URL: https://github.com/nodejs/node/pull/27005


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

bf347f53

test: remove unused triggerAsyncId param in test · 518d2b6e

Juan José Arboleda authored Mar 20, 2019

PR-URL: https://github.com/nodejs/node/pull/26800


Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

518d2b6e

crypto: don't crash on unknown asymmetricKeyType · 7c1fc93e

Filip Skokan authored Mar 19, 2019

PR-URL: https://github.com/nodejs/node/pull/26786
Fixes: https://github.com/nodejs/node/issues/26775


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

7c1fc93e

src: fix warning on mismatched fn signature · 66b95362

Sam Roberts authored Mar 27, 2019

Add the missing `void* priv` to node_report's Initialize().

PR-URL: https://github.com/nodejs/node/pull/26950


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

66b95362

test: fix error code typo · e5733949

cjihrig authored Mar 31, 2019

PR-URL: https://github.com/nodejs/node/pull/27024


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

e5733949