- Dec 18, 2015
-
-
Trevor Norris authored
process.hrtime() was performing too many operations in C++ that could be done faster in JS. Move those operations over by creating a length 4 Uint32Array and perform bitwise operations on the seconds so that it was unnecessary for the native API to do any object creation or set any fields. This has improved performance from ~350 ns/op to ~65 ns/op. Light benchmark included to demonstrate the performance change. PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
Improve performance of process._getActiveHandles by sending handles in batches to JS to be set on the passed Array. Add test to check proper active handles are returned. Alter implementation of GetActiveRequests to match GetActiveHandles' implementation. PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
Improve performance by pushing directory entries to returned array in batches of 8 using pushValueToArray() in JS. Add benchmarks to demonstrate this improvement. PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
For performance add headers to the headers Array by pushing them on from JS. Benchmark added to demonstrate this case. PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
The initial implementation of setPropByIndex() set the value of an Array by index during development. Though the final form of the function simply pushes passed values to an array as passed by arguments. Thus the functions have been renamed to pushValueToArray() and push_values_to_array_function() respectively. Also add define for maximum number of arguments should be used before hitting the limit of performance increase. Fixes: 494227bb "node: improve GetActiveRequests performance" PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
Do not emit `upgrade` if the server is just advertising its protocols support as per RFC 7230 Section 6.7. A server MAY send an Upgrade header field in any other response to advertise that it implements support for upgrading to the listed protocols, in order of descending preference, when appropriate for a future request. Fix: https://github.com/nodejs/node/issues/4334 PR-URL: https://github.com/nodejs/node/pull/4337 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl>
-
Brian White authored
This fixes breakage introduced in 94b9948d when writing the max EventEmitter listeners warning to stderr. PR-URL: https://github.com/nodejs/node/pull/4279 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/4325 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
Fix a segmentation fault when the debug message handler was called from a context without an associated `node::Environment`. Fixes: https://github.com/nodejs/node/issues/4261 Fixes: https://github.com/nodejs/node/issues/4322 PR-URL: https://github.com/nodejs/node/pull/4328 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Bo Borgerson authored
This just removes an assignment to `ret` of a value that's not used before it's overwritten. Immediately following the assigment is an `if/else` in which both branches assign to `ret` without using it. PR-URL: https://github.com/nodejs/node/pull/4323 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
* Use single quotes consistently * Modernize examples to use template strings and arrow funcs * Fix a few typos * Example edits for consistency PR-URL: https://github.com/nodejs/node/pull/4282 Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Dec 17, 2015
-
-
chrisjohn404 authored
The buffer's write function is documented below the buf.toString function and all of the docs reference "buf" instead of "buffer". PR-URL: https://github.com/nodejs/node/pull/4324 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Nicholas Young authored
Update link from github.com/rvagg to github.com/nodejs PR-URL: https://github.com/nodejs/node/pull/4331 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Minwoo Jung authored
use `arrow functions` instead of `bind(this)` in order to improve performance through optimizations. PR-URL: https://github.com/nodejs/node/pull/3622 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Xotic750 authored
Fix: https://github.com/nodejs/node/issues/4314 PR-URL: https://github.com/nodejs/node/pull/4318 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
cjihrig authored
Notable changes: * buffer: - Buffer.prototype.includes() has been added to keep parity with TypedArrays. (Alexander Martin) #3567. * domains: - Fix handling of uncaught exceptions. (Julien Gilli) #3654. * https: - Added support for disabling session caching. (Fedor Indutny) #4252. * repl: - Allow third party modules to be imported using require(). This corrects a regression from 5.2.0. (Ben Noordhuis) #4215. * deps: - Upgrade libuv to 1.8.0. (Saúl Ibarra Corretgé) #4276. PR-URL: https://github.com/nodejs/node/pull/4281 Conflicts: src/node_version.h -
Jackson Tian authored
PR-URL: https://github.com/nodejs/node/pull/4285 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Dec 16, 2015
-
-
Ben Noordhuis authored
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: https://github.com/nodejs/node/pull/4310 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Jan Schär authored
The backlog parameter is supported by all variations of net.Server.listen(), but wasn't consistently documented. This commit brings the documentation into a more consistent state. Refs: https://github.com/nodejs/node/pull/4056 PR-URL: https://github.com/nodejs/node/pull/4025 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
ronkorving authored
This helps editors (see http://editorconfig.org/#download) to apply the right indentation and encoding rules to files by default. PR-URL: https://github.com/nodejs/node/pull/2993 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com>
-
cjihrig authored
This commit adds a regression test for debugging of single line files. Refs: https://github.com/nodejs/node/issues/4297 PR-URL: https://github.com/nodejs/node/pull/4298 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
cjihrig authored
In b799a747 and dfee4e37 the module wrapping mechanism was changed for better error reporting. However, the changes causes issues with debuggers and profilers. This commit reverts the wrapping changes. Fixes: https://github.com/nodejs/node/issues/4297 PR-URL: https://github.com/nodejs/node/pull/4298 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
ronkorving authored
When a string is passed to udpsock.send, it is automatically converted to a Buffer. In that case, it is no longer needed to test whether or not the argument is a Buffer or not. PR-URL: https://github.com/nodejs/node/pull/4301 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Dec 15, 2015
-
-
Ben Noordhuis authored
Not supported by apple-gcc and I'm not convinced it's worth adding more preprocessor hacks when it should be easy as pie for the compiler to to optimize the byteswap. If it doesn't, fix the compiler. Fixes: https://github.com/nodejs/node/issues/4284 PR-URL: https://github.com/nodejs/node/pull/4290 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Ben Noordhuis authored
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: https://github.com/nodejs/node/pull/4290 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Evan Lucas authored
It does not currently have any explicit tests to verify the behavior. PR-URL: https://github.com/nodejs/node/pull/4283 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
Update AUTHORS list using tools/update-authors.sh PR-URL: https://github.com/nodejs/node/pull/4183 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Nelson Pecora authored
IRC (general questions): irc.freenode.net #node.js IRC (node core development): irc.freenode.net #node-dev PR-URL: https://github.com/nodejs/node/pull/2743 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Bryan English authored
* Document that Symbol can used as event names. * Add test for using Symbol as event names PR-URL: https://github.com/nodejs/node/pull/4151 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Lenny Markus authored
Make it clear that error with throw if error listener is not registered. PR-URL: https://github.com/nodejs/node/pull/4275 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Hideki Yamamura authored
Refs: https://github.com/nodejs/node-v0.x-archive/pull/25471 Refs: https://github.com/nodejs/node-v0.x-archive/issues/8443 PR-URL: https://github.com/nodejs/node/pull/4263 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/3661 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
cjihrig authored
In dfee4e37, the module wrapper and line offset used when wrapping module code was changed to better report errors on the first line of modules. However, that commit did not update the runInThisContext() call used to execute the core modules, so their error line numbers have been off by one. This commit provides the correct lineOffset for core modules. Refs: https://github.com/nodejs/node/pull/2867 PR-URL: https://github.com/nodejs/node/pull/4254 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Fedor Indutny authored
Original commit message: [heap] fix crash during the scavenge of ArrayBuffer Scavenger should not attempt to visit ArrayBuffer's storage, it is a user-supplied pointer that may have any alignment. Visiting it, may result in a crash. BUG= R=jochen Review URL: https://codereview.chromium.org/1406133003 Cr-Commit-Position: refs/heads/master@{#31611} PR-URL: https://github.com/nodejs/node/pull/4259 Reviewed-By:Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Saúl Ibarra Corretgé authored
Fixes: https://github.com/nodejs/node/issues/3718 PR-URL: https://github.com/nodejs/node/pull/4276 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Fedor Indutny authored
`WrapperInfo` casts pointer in JS object's internal field to `AsyncWrap`. This approach fails miserably for `TLSWrap` because it was inhereted from the `StreamBase` first, creating different kind of `vtable` for the whole class. Reorder parent classes to put `AsyncWrap` first. Fix: https://github.com/nodejs/node/issues/4250 PR-URL: https://github.com/nodejs/node/pull/4268 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Yazhong Liu authored
PR-URL: https://github.com/nodejs/node/pull/4264 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Martin von Gagern authored
Fix copy paste error in deprecation message PR-URL: https://github.com/nodejs/node/pull/4269 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Rod Vagg <r@va.gg>
-
Jeremiah Senkpiel authored
Refs: https://github.com/nodejs/node/pull/2224#issuecomment-127356413 PR-URL: https://github.com/nodejs/node/pull/4247 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jeremiah Senkpiel authored
ARMv8 machines are typically quite fast and likely may not need extended timeout times. PR-URL: https://github.com/nodejs/node/pull/4248 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-