- Sep 22, 2018
-
-
Daniel Bevenius authored
This commit adds a CheckOptions function that the options classes can optionally implement to check that options specified are correct (dependencies between options are met or options that are mutually exclusive). In the process of doing this the error pointer passed to Parse was changed to be of type vector so that potentially multiple options check failures can be reported. PR-URL: https://github.com/nodejs/node/pull/22943 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Alexander Mills authored
PR-URL: https://github.com/nodejs/node/pull/22950 Fixes: https://github.com/nodejs/node/issues/22916 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Rich Trott authored
common.leakedGlobals() was exposed only to test its logic. The logic can instead be tested by running a fixture file that leaks a global and seeing if `common` causes an AssertionError on exit. This way, the entire functionality of leak detection is tested rather than just the leakedGlobals() function. It also reduces API surface area for the common monolith by one function. PR-URL: https://github.com/nodejs/node/pull/22965 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Mohammed Essehemy authored
PR-URL: https://github.com/nodejs/node/pull/23006 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Rich Trott authored
Add links to the class definition for repl.ReplServer in places where it would be helpful. PR-URL: https://github.com/nodejs/node/pull/23005 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/22956 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/22935 Reviewed-By:
-
Rich Trott authored
Provide a test to cover adding setting `onmessage` to a non-function. This provides previously-missing coverage for an else block in the `onmessage` setter. PR-URL: https://github.com/nodejs/node/pull/22942 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/22928 Reviewed-By:
-
- Sep 21, 2018
-
-
Tobias Nießen authored
Calling setAuthTag multiple times can result in hard to detect bugs since to the user, it is unclear which invocation actually affected OpenSSL. PR-URL: https://github.com/nodejs/node/pull/22931 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
Daniel Bevenius authored
This commit adds a --completion-bash option to node which can be sourced to provide bash code completion for node options. Usage: $ node --completion-bash > node_bash_completion $ source node_bash_completion $ node --[tab] PR-URL: https://github.com/nodejs/node/pull/20713 Reviewed-By:
-
Michaël Zasso authored
Replace references to the outdated `update-v8` tool to its replacement in `node-core-utils` PR-URL: https://github.com/nodejs/node/pull/22913 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Ruben Bridgewater authored
Currently the documentation is not specific how fast-tracking should be applied. This specifies exactly how things should be done to prevent confusion. PR-URL: https://github.com/nodejs/node/pull/22929 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
George Adams <george.adams@uk.ibm.com>
-
Hitesh Kanwathirtha authored
PR-URL: https://github.com/nodejs/node/pull/22984 Reviewed-By:
-
Tobias Nießen authored
There is a very small chance (about 0.4%) that OpenSSL will successfully decrypt a key without the correct passphrase and will then fail while parsing its ASN.1 structure. In those rare cases, the error message will be different. PR-URL: https://github.com/nodejs/node/pull/22980 Fixes: https://github.com/nodejs/node/issues/22978 Reviewed-By:
-
Rich Trott authored
common.hasSmallICU is used in only one test and is a one-liner. Move into the test where it is used to chip away at the `common` monolith. PR-URL: https://github.com/nodejs/node/pull/22937 Reviewed-By:
-
Jeremy Apthorp authored
This fixes an error when compiling with clang-cl on Windows: ``` src/node.cc(2437,5): error: jump from this goto statement to its label is a Microsoft extension [-Werror,-Wmicrosoft-goto] goto out; ^ src/node.cc(2441,9): note: jump bypasses variable initialization DWORD pid = args[0].As<Integer>()->Value(); ^ ``` PR-URL: https://github.com/nodejs/node/pull/22961 Reviewed-By: -
Joyee Cheung authored
The `name`, `message` and `code` attributes of the DOMException interface should be enumerable and configurable. Aligning the definition with the Web allows us to use it when running the Web Platform Tests. Refs: https://heycam.github.io/webidl/#idl-DOMException PR-URL: https://github.com/nodejs/node/pull/22550 Refs: https://github.com/web-platform-tests/wpt/commit/125950d10a346482075c55d27f61a1021ca68d68 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
- Sep 20, 2018
-
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/22933 Refs: https://github.com/nodejs/node/pull/22550 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22660 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Tobias Nießen authored
This adds support for RSA, DSA and EC key pair generation with a variety of possible output formats etc. PR-URL: https://github.com/nodejs/node/pull/22660 Fixes: https://github.com/nodejs/node/issues/15116 Reviewed-By:
-
Michaël Zasso authored
Notable changes: * fs * Fixed fsPromises.readdir `withFileTypes`. https://github.com/nodejs/node/pull/22832 * http2 * Added `http2stream.endAfterHeaders` property. https://github.com/nodejs/node/pull/22843 * util * Added `util.types.isBoxedPrimitive(value)`. https://github.com/nodejs/node/pull/22620 * Added new collaborators: * boneskull (https://github.com/boneskull) - Christopher Hiller * The Technical Steering Committee has new members: * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof PR-URL: https://github.com/nodejs/node/pull/22932 -
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/22643 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Masashi Hirano authored
Added tests to check error in dns.lookupService to increase coverage. PR-URL: https://github.com/nodejs/node/pull/22908 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/22898 Refs: https://github.com/v8/v8/compare/6.9.427.22...6.9.427.23 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22949 Refs: https://github.com/nodejs/node/pull/21616 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22949 Refs: https://github.com/nodejs/node/pull/21875 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22949 Refs: https://github.com/nodejs/node/pull/14731 Reviewed-By:
-
Mark Abel authored
Fixes: https://github.com/nodejs/node/issues/22472 Co-authored-by:
-
Tobias Nießen authored
I assume that permitting digest === null was unintentional when digest === undefined was deprecated since their behavior was equivalent. The sha1 default for digest === null has somehow made it through refactoring of the PBKDF2 module multiple times, even though digest === undefined has been EOL for some time now. This change deprecates setting digest to null so we can fix the behavior in Node.js 12 or so. PR-URL: https://github.com/nodejs/node/pull/22861 Reviewed-By:
-
Ruben Bridgewater authored
The executed command is very verbose and removing that from the output improves the overall experience. PR-URL: https://github.com/nodejs/node/pull/22904 Reviewed-By:
-
- Sep 19, 2018
-
-
Matteo Collina authored
Fixes: https://github.com/nodejs/node/issues/22855 PR-URL: https://github.com/nodejs/node/pull/22896 Reviewed-By:
-
João Reis authored
Refs: https://github.com/nodejs/node/issues/20750 Refs: https://github.com/nodejs/node/issues/22327 Refs: https://github.com/nodejs/node/issues/22762 Refs: https://github.com/nodejs/reliability/issues/16 PR-URL: https://github.com/nodejs/node/pull/22941 Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/22886 Refs: https://github.com/nodejs/node/issues/21773 Reviewed-By:
-
Ruben Bridgewater authored
The output is now a tiny bit improved by sorting object properties when inspecting the values that are compared with each other. That reduces the overall diff for identical objects with a different property insertion order. PR-URL: https://github.com/nodejs/node/pull/22788 Refs: https://github.com/nodejs/node/issues/22763 Reviewed-By:
-
Ruben Bridgewater authored
The order option can be used to sort the inspected values in case they do not rely on their order as arrays. That way the output is stable no matter of the object property inspection order. PR-URL: https://github.com/nodejs/node/pull/22788 Refs: https://github.com/nodejs/node/issues/22763 Reviewed-By:
-
James M Snell authored
To support Performance Counters on Windows, a number of global `COUNTER_` methods were added that are undocumented and really only intended to be used internally by Node.js. Unfortunately, the perfctr support apparently hasn't even worked for quite a while and no one has even complained. This removes the perfctr support and replaces the global functions with deprecated non-ops for now, with the intent of removing those outright in the next major release cycle. PR-URL: https://github.com/nodejs/node/pull/22485 Reviewed-By:
João Reis <reis@janeasystems.com>
-
Bartosz Sosnowski authored
PR-URL: https://github.com/nodejs/node/pull/22817 Fixes: https://github.com/nodejs/node/issues/22799 Reviewed-By:
-
isurusiri authored
Currently the documentation for Wrapping C++ Objects doesn't explain how to destruct an object by explicitly invoking the garbage collector. This commit includes a modification to docs that explains how to force the garbage collector to clear objects using V8's command line flags. Fixes: https://github.com/nodejs/node/issues/19876 PR-URL: https://github.com/nodejs/node/pull/20431 Reviewed-By:
Yang Guo <yangguo@chromium.org>
-
Anna Henningsen authored
This may fix some flakiness with tests that use `worker.terminate()`. In particular, the following failure seems like it could be related (no consistent reproduction available, though): ``` 15:30:14 not ok 187 parallel/test-heapdump-worker 15:30:14 --- 15:30:14 duration_ms: 2.499 15:30:14 severity: fail 15:30:14 exitcode: 134 15:30:14 stack: |- 15:30:14 npm[6904]: src\inspector_agent.cc:729: Assertion `(client_) != nullptr' failed. ``` From https://ci.nodejs.org/job/node-test-binary-windows/20041/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=2/console Refs: https://github.com/nodejs/node/pull/22769 PR-URL: https://github.com/nodejs/node/pull/22927 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com>
-
