- Oct 19, 2017
-
-
Ali Ijaz Sheikh authored
This change fixes a potential segfault in the sampling heap profiler. This landed as part of a larger change upstream [1]. This is the minimal backport that avoids the segfault. [1]: https://git.io/vdTYL PR-URL: https://github.com/nodejs/node/pull/15498 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Anna Henningsen authored
Original commit message: [api] Add optional data pointer to GC callbacks This can be useful when there may be multiple callbacks attached by code that's not directly tied to a single isolate, e.g. working on a per-context basis. This also allows rephrasing the global non-isolate APIs in terms of this new API, rather than working around it inside `src/heap`. TBR=hpayer@chromium.org Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I2e490ec40d1a34ea812f25f41ef9741d2116d965 Reviewed-on: https://chromium-review.googlesource.com/647548 Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47923} PR-URL: https://github.com/nodejs/node/pull/15391 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Michaël Zasso authored
Original commit message: [build] Introduce an embedder version string Sometimes, the embedder might want to merge a fix to an abandoned branch or to a supported branch but the fix is not relevant to Chromium. This adds a new version string that the embedder can set at compile time and that will be appended to the official V8 version. The separator must be provided in the string. For instance, to have a full version string like "6.0.287.53-emb.1", the embedder must set V8_EMBEDDER_STRING to "-emb.1". Related Node.js issue: https://github.com/nodejs/node/pull/9754 BUG=v8:5740 R=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ifa2d9bd213795e6d54886436f8c3787ac6162823 Reviewed-on: https://chromium-review.googlesource.com/690475 Reviewed-by:Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
geek authored
PR-URL: https://github.com/nodejs/node/pull/15362 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
geek authored
PR-URL: https://github.com/nodejs/node/pull/15362 Reviewed-By:
-
Michaël Zasso authored
With V8 6.2 there is one line less in the promise trace. PR-URL: https://github.com/nodejs/node/pull/15362 Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.2. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/15362 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/15362 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/16259 Fixes: https://github.com/nodejs/node/issues/16077 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Myles Borins authored
This commit updates the comment for Module Version to document the history of the Module Version number across the various release of Node.js. PR-URL: https://github.com/nodejs/node/pull/16303 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
cjihrig authored
In spawn_sync.cc, two consecutive loops are used to convert data to strings, and compute the size of the data. This commit merges the two independent loops into one. Refs: https://github.com/nodejs/node/pull/15380 PR-URL: https://github.com/nodejs/node/pull/16247 Reviewed-By:
-
cjihrig authored
Refs: https://github.com/nodejs/node/pull/15380 PR-URL: https://github.com/nodejs/node/pull/16247 Reviewed-By:
-
cjihrig authored
Refs: https://github.com/nodejs/node/pull/15380 PR-URL: https://github.com/nodejs/node/pull/16247 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/16302 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Rich Trott authored
Allow zero operations for short buffer benchmark tests. PR-URL: https://github.com/nodejs/node/pull/16296 Reviewed-By:
-
zhangzifa authored
When there are at least 2 timers set by setInterval whose callback execution are longer than interval, the eventloop will be blocked. This commit fix the above bug. PR-URL: https://github.com/nodejs/node/pull/15072 Fixes: https://github.com/nodejs/node/issues/15068 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Evan Lucas authored
macOS requires passing the --coverage flag in OTHER_LDFLAGS and OTHER_CFLAGS in xcode_settings. PR-URL: https://github.com/nodejs/node/pull/16163 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Lance Ball authored
Make sure contributors know to cc @nodejs/build when submitting issues that are build related (in addition to whatever platform are relevant). PR-URL: https://github.com/nodejs/node/pull/16298 Ref: https://github.com/nodejs/node/pull/15754#issuecomment-337622625 Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Jon Moss authored
PR-URL: https://github.com/nodejs/node/pull/16277 Reviewed-By:
-
Michaël Zasso authored
After this commit, `process.versions.v8` will look like: "6.0.287.53-node.0". The goal is that everytime we apply a non-official patch to `deps/v8`, we increment our own number instead of V8's patch level. This number must be set back to 0 after major V8 updates. Fixes: https://github.com/nodejs/node/issues/15698 PR-URL: https://github.com/nodejs/node/pull/15785 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [build] Introduce an embedder version string Sometimes, the embedder might want to merge a fix to an abandoned branch or to a supported branch but the fix is not relevant to Chromium. This adds a new version string that the embedder can set at compile time and that will be appended to the official V8 version. The separator must be provided in the string. For instance, to have a full version string like "6.0.287.53-emb.1", the embedder must set V8_EMBEDDER_STRING to "-emb.1". Related Node.js issue: https://github.com/nodejs/node/pull/9754 BUG=v8:5740 R=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ifa2d9bd213795e6d54886436f8c3787ac6162823 Reviewed-on: https://chromium-review.googlesource.com/690475 Reviewed-by:
-
- Oct 18, 2017
-
-
Nikki St Onge authored
PR-URL: https://github.com/nodejs/node/pull/15998 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. PR-URL: https://github.com/nodejs/node/pull/16087 Ref: https://github.com/nodejs/node/pull/16038 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Bryan English authored
The comment suggests that the subsequent code could by DRYed up, due to simply passing arguments along. However, in the commits since then, this no longer appears to apply, and so the comment is now confusing with respect to the current code. PR-URL: https://github.com/nodejs/node/pull/16285 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Luigi Pinca authored
Use `common.mustCall()` instead of `called` variable. PR-URL: https://github.com/nodejs/node/pull/16236 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Robert Nagy authored
Emit close event after all other events in the client, e.g. error will be emitted before close. PR-URL: https://github.com/nodejs/node/pull/15588 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/16208 Fixes: https://github.com/nodejs/build/issues/887 Reviewed-By:
-
Joyee Cheung authored
Implement common.projectDir which points to the project directory. PR-URL: https://github.com/nodejs/node/pull/16208 Fixes: https://github.com/nodejs/build/issues/887 Reviewed-By:
-
Anna Henningsen authored
Modify passing of the `internalBinding` function so that it’s easier for core modules to adopt, and also not even accessible through `--expose-internals`. This also splits the module wrapper into a separate version for internal bindings and for CJS modules, which seems like a good idea given the different semantics. PR-URL: https://github.com/nodejs/node/pull/16218 Reviewed-By:
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/16175 PR-URL: https://github.com/nodejs/node/pull/16201 Reviewed-By:
-
Luke Childs authored
Original text implied it returns physical cpu cores. This is misleading as `os.cpus().length` is often used to get the CPU core count in Node.js. In reality that will return the thread count which may not be what the user intended. PR-URL: https://github.com/nodejs/node/pull/16282 Fixes: https://github.com/nodejs/node/issues/16279 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
-
Rich Trott authored
The inspector tests should not be in the parallel directory as they likely all (or certainly almost all) use static ports, so port collisions will happen. This moves them all to sequential. We can move them back on a case-by-case basis. They were run sequentially when they were in the inspector directory which they were only moved from very recently. PR-URL: https://github.com/nodejs/node/pull/16281 Reviewed-By:
-
Jon Moss authored
* remove inspector directory artifacts PR-URL: https://github.com/nodejs/node/pull/16197 Reviewed-By:
-
- Oct 17, 2017
-
-
Trivikram Kamat authored
This commit add test case where priority() throws ERR_INVALID_OPT_VALUE when stream depends on itself Refs: https://github.com/nodejs/node/issues/14985 PR-URL: https://github.com/nodejs/node/pull/16224 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/16244 Reviewed-By:
-
Trivikram Kamat authored
Refs: https://github.com/nodejs/node/issues/14985 PR-URL: https://github.com/nodejs/node/pull/16096 Reviewed-By:
-
Trivikram Kamat authored
This commit tests use case when emitGoAway is called when client is shutting down but is not destroyed. Refs: https://github.com/nodejs/node/issues/14985 PR-URL: https://github.com/nodejs/node/pull/16215 Reviewed-By:
-
David8472 authored
Replace common.fixturesDir with fixtures in test-http2-respond-file-errors.js. PR-URL: https://github.com/nodejs/node/pull/16004 Reviewed-By:
-
Michael Rueppel authored
Changed test-http2-respond-file-range to use fixtures.path directly instead of passing through the common module. PR-URL: https://github.com/nodejs/node/pull/15852 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
This commit adds support to run the linter without running any other targets. This commit also makes the lint task a little more quite and more inline with the output on other operating systems. Below is an example of running (with a lint error to show that it is not so quite that errors are hidden): C:\Users\danbev\working\node>vcbuild.bat lint running lint-cpp 'src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h' src\env.h:24: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 "C:\Python27\python.exe" tools/check-imports.py running lint-js The help message now looks like: C:\Users\danbev\working\node>vcbuild.bat /? vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/ test-inspector/test-internet/test-pummel/test-simple/test-message/ test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/ test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module] Examples: vcbuild.bat : builds release build vcbuild.bat debug : builds debug build vcbuild.bat release msi : builds release build and MSI installer package vcbuild.bat test : builds debug build and runs tests vcbuild.bat build-release : builds the release distribution as used by nodejs.org vcbuild.bat enable-vtune : builds nodejs with Intel VTune profiling support to profile JavaScript vcbuild.bat link-module my_module.js : bundles my_module as built-in module vcbuild.bat lint : runs the C++ and JavaScript linter PR-URL: https://github.com/nodejs/node/pull/16176 Reviewed-By:
-
