Commits · 32ade6997ba05de1d5bf7510c71db85eb61ae77d · github.com / v8-riscv / node

Apr 29, 2021

doc: mark querystring api as legacy · 32ade699

James M Snell authored Apr 27, 2021



Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: https://github.com/nodejs/node/issues/38231

PR-URL: https://github.com/nodejs/node/pull/38436


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

32ade699

doc: update node-api support matrix · c791019b

Michael Dawson authored Apr 26, 2021



Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/38424


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

c791019b

doc: add arguments for stream event of Http2Server and Http2SecureServer · 50307ed4

Qingyu Deng authored Mar 24, 2021

PR-URL: https://github.com/nodejs/node/pull/37892


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

50307ed4

doc: indicate that abort tests do not generate core files · d037039a

Rich Trott authored Apr 26, 2021

The key thing about the tests in `test/abort` is that tests in that
directory do not generate core files (thanks to testcfg.py). Make a note
of that in the test README.

PR-URL: https://github.com/nodejs/node/pull/38422


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

d037039a

doc: add try/catch in http2 respondWithFile example · 1adcae96

Matteo Collina authored Apr 26, 2021

PR-URL: https://github.com/nodejs/node/pull/38410


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

1adcae96

deps: patch V8 to 9.0.257.24 · 8b603697

Michaël Zasso authored Apr 26, 2021

Refs: https://github.com/v8/v8/compare/9.0.257.21...9.0.257.24

PR-URL: https://github.com/nodejs/node/pull/38423


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8b603697

lib: harden lint checks for globals · 7919ced0

Antoine du Hamel authored Apr 26, 2021

PR-URL: https://github.com/nodejs/node/pull/38419


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

7919ced0

src: fix validation of negative offset to avoid abort · 4af15df0

James M Snell authored Apr 26, 2021

Fixes: https://github.com/nodejs/node/issues/24640


Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/38421


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

4af15df0

tools: remove fixer for non-ascii-character ESLint custom rule · 896e5af1

Rich Trott authored Apr 26, 2021

The fixer for non-ascii-character does not typidally do the right thing.
It removes the entire node, not the offending character. I discovered
this when it removed the entire contents of a file and I wasn't sure
which auto-fix rule was doing it.

This commit adds a minimal test for the rule. The tests require that
auto-fix results be supplied, so if someone wants to re-add auto-fixing
to the rule, we'll have tests that it does the right thing.

PR-URL: https://github.com/nodejs/node/pull/38413


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

896e5af1

repl: document top level await limitation with const/let · 346f0e99

James M Snell authored Apr 27, 2021

Fixes: https://github.com/nodejs/node/issues/17669


Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/38449


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

346f0e99

Apr 28, 2021

debugger: apply automatic lint fixes for inspect_repl.js · bdb6c597

Rich Trott authored Apr 26, 2021

For issues that ESLint can fix automatically, fix them.

PR-URL: https://github.com/nodejs/node/pull/38411


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

bdb6c597

debugger: apply automatic lint fixes for _inspect.js · ea47bd21

Rich Trott authored Apr 26, 2021

For issues that ESLint can fix automatically, fix them.

PR-URL: https://github.com/nodejs/node/pull/38411


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

ea47bd21

tools: fix doc generation when version info is not available · 3d070d00

Antoine du Hamel authored Apr 25, 2021

Fixes: https://github.com/nodejs/node/issues/38391

PR-URL: https://github.com/nodejs/node/pull/38398


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

3d070d00

typings: add JSDoc typings for fs · 32404359

Voltrex authored Apr 20, 2021

Added JSDoc typings for the `fs` lib module.

PR-URL: https://github.com/nodejs/node/pull/38306


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

32404359

tools: add _depot_tools to PATH (for V8 tests) · 6e3ce658

DeeDeeG authored Apr 19, 2021

Ensures the `_depot_tools` dir bootstrapped during this script
is added to the PATH, before `ninja` is executed,
as `_depot_tools` already has a copy of `ninja` in it.
This means one less system requirement to be able to run this script.

(It seems like this was already intended to be on the PATH?)

Note: This script is used by the `test-v8` Makefile target.

PR-URL: https://github.com/nodejs/node/pull/38299


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

6e3ce658

doc: note the system requirements for V8 tests · d14d9f9e

DeeDeeG authored Apr 20, 2021

The `test-v8` Makefile target still requires Python 2,
and it requires a full Xcode install on macOS.

Refs: https://github.com/nodejs/node/pull/36691

PR-URL: https://github.com/nodejs/node/pull/38319


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

d14d9f9e

doc: minor clarification to pathObject · 5a0ed51a

James M Snell authored Apr 27, 2021



Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: https://github.com/nodejs/node/issues/36582

PR-URL: https://github.com/nodejs/node/pull/38437


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

5a0ed51a

doc: clarify that fs.Dir async iterator closes automatically · 87aca074

James M Snell authored Apr 27, 2021



Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: https://github.com/nodejs/node/issues/35148

PR-URL: https://github.com/nodejs/node/pull/38438


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

87aca074

crypto: don't crash with some selfsigned certs · fa6d084d

Nils Dralle authored Mar 30, 2021

Refs: https://github.com/nodejs/node/issues/37757
Refs: https://github.com/nodejs/node/issues/37889

PR-URL: https://github.com/nodejs/node/pull/37990
Fixes: https://github.com/nodejs/node/issues/37757


Reviewed-By: James M Snell <jasnell@gmail.com>

fa6d084d

doc: document new TCP_KEEPCNT and TCP_KEEPINTVL socket option defaults · b607373e

Arnold Zokas authored Apr 20, 2021

PR https://github.com/nodejs/node/pull/32204 introduced new defaults for
the TCP keep-alive socket options (see deps/uv/src/unix/tcp.c):
- "TCP_KEEPCNT" now defaults to 10 on all platforms
- "TCP_KEEPINTVL" now defaults to 1 on all platforms

Previously, "TCP_KEEPCNT" and "TCP_KEEPINTVL" were not set explicitly
and OS-default values were used.

Fixes: https://github.com/nodejs/node/issues/38298
Refs: https://github.com/nodejs/node/pull/32204

PR-URL: https://github.com/nodejs/node/pull/38313


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

b607373e

doc: do not mention TCP in the allowHalfOpen option description · d432386f

Luigi Pinca authored Apr 22, 2021

The `allowHalfOpen` option works in the same way for both TCP and IPC
connections.

PR-URL: https://github.com/nodejs/node/pull/38360
Fixes: https://github.com/nodejs/node/issues/38307


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

d432386f

doc: update message to match actual output · 50bbc4e4

Rich Trott authored Sep 19, 2020

PR-URL: https://github.com/nodejs/node/pull/35271


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

50bbc4e4

Apr 27, 2021

debugger: remove unused function argument · 751d215e

Rich Trott authored Dec 11, 2020

The `{colors: true}` removed here is ignored by the function it is being
sent to.

PR-URL: https://github.com/nodejs/node/pull/38400


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

751d215e

debugger: align message with Node.js standard · 01e0e321

Rich Trott authored Sep 19, 2020

Node.js uses (or will use) _Ctrl+C_ with no spaces. To unify the
messages from inspect with other messages from the REPL and elsewhere,
make that change in node-inspect too.

PR-URL: https://github.com/nodejs/node/pull/38400


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

01e0e321

debugger: add usage example for `--port` · 302cc9e9

Rafael Gonzaga authored Jul 27, 2020

PR-URL: https://github.com/nodejs/node/pull/38400


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

302cc9e9

perf_hooks: fix PerformanceObserver 'gc' crash · ea015481

James M Snell authored Apr 26, 2021



Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: https://github.com/nodejs/node/issues/38412

PR-URL: https://github.com/nodejs/node/pull/38414


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

ea015481

test: move abort test from pummel to abort directory · 6f296b57

Rich Trott authored Apr 24, 2021

test-abort-fatal-error is not resource intensive and would be better in
the abort directory than the pummel directory.

PR-URL: https://github.com/nodejs/node/pull/38396


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

6f296b57

benchmark: avoid using `console.log()` · 0c879cb7

Antoine du Hamel authored Apr 23, 2021

PR-URL: https://github.com/nodejs/node/pull/38370


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

0c879cb7

src: use %progbits instead of @progbits · 47207e59

Stephen Gallagher authored Apr 20, 2021

While @progbits is preferred for most architectures, there are some
(notably 32-bit ARM) for which it does not. %progbits is effective
everywhere.

See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more
details.

Related: https://github.com/nodejs/node/issues/17933
Related: https://github.com/nodejs/node/pull/37688



Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>

PR-URL: https://github.com/nodejs/node/pull/38312


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

47207e59

doc: request default snap track be updated for LTS · 9b878eca

Rod Vagg authored Mar 11, 2021

PR-URL: https://github.com/nodejs/node/pull/37708
Refs: https://github.com/nodejs/snap/pull/4


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

9b878eca

test: move slower tests into pummel and skip on slow devices · 7f56307a

Rich Trott authored Apr 24, 2021

Move slower tests to pummel and skip on Raspberry Pi devices in CI.

Refs: https://github.com/nodejs/node/pull/34289#issuecomment-823655915

PR-URL: https://github.com/nodejs/node/pull/38395


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

7f56307a

test: skip some pummel tests on slower machines · 4dc8e769

Rich Trott authored Apr 24, 2021

Skipped the longest-running pummel tests on the Raspberry Pi devices in
CI.

Refs: https://github.com/nodejs/node/pull/34289#issuecomment-823354459

PR-URL: https://github.com/nodejs/node/pull/38394


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

4dc8e769

crypto: fix generateKeyPair type checks · 09c97b81

Nitzan Uziely authored Apr 23, 2021

Change saltLength, divisorLength, primeLength and generator
checks in generateKeyPair to int32 from uint32, to align
with c++ code.

fixes: https://github.com/nodejs/node/issues/38358

PR-URL: https://github.com/nodejs/node/pull/38364
Fixes: https://github.com/nodejs/node/issues/38358


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

09c97b81

deps: patch V8 to 9.0.257.21 · 3b86138f

Michaël Zasso authored Apr 21, 2021

Refs: https://github.com/v8/v8/compare/9.0.257.19...9.0.257.21

PR-URL: https://github.com/nodejs/node/pull/38333


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

3b86138f

lib: fix and improve os typings · 00b6feec

Akhil Marsonya authored Apr 20, 2021

1. marked optional params as such
2. assigned default values using jsdoc conventions.

PR-URL: https://github.com/nodejs/node/pull/38316


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

00b6feec

fs: aggregate errors in fsPromises to avoid error swallowing · f27b7cf9

Nitzan Uziely authored Apr 16, 2021

Add AggregateError support to fsPromises, instead of
swallowing errors if fs.close throws.

PR-URL: https://github.com/nodejs/node/pull/38259


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

f27b7cf9

async_hooks,doc: replace process.stdout.fd with 1 · 91d1b60d

Darshan Sen authored Apr 24, 2021

This stops "RangeError: Maximum call stack size exceeded".

PR-URL: https://github.com/nodejs/node/pull/38382


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

91d1b60d

crypto: fix scrypt keylen validation · 27beb386

Antoine du Hamel authored Apr 24, 2021

Fixes: https://github.com/nodejs/node/issues/38381

PR-URL: https://github.com/nodejs/node/pull/38385


Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

27beb386

tools: update ESLint to 7.25.0 · 59db84ab

cjihrig authored Apr 24, 2021

Update ESLint to 7.25.0

PR-URL: https://github.com/nodejs/node/pull/38378


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

59db84ab

doc: mark `process.hrtime()` as legacy · 8c990450

Antoine du Hamel authored Apr 23, 2021

PR-URL: https://github.com/nodejs/node/pull/38371


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

8c990450