- Mar 11, 2020
-
-
Denys Otrishko authored
This issue is unfixable with the current implementations of V8 and Node.js. Changes to make this fixable are unlikely to happen in the foreseeable future. The test itself is flaky and skipped. It serves as a demonstration of the issue only. PR-URL: https://github.com/nodejs/node/pull/31980 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Gerhard Stoebich authored
Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: https://github.com/nodejs/node/pull/32061 Refs: https://github.com/nodejs/node/pull/31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Robert Nagy authored
Added .destroyed property to OutgoingMessage and ClientRequest to align with streams. Fixed ClientRequest.destroy to dump res and re-use socket in agent pool aligning it with abort. PR-URL: https://github.com/nodejs/node/pull/32148 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Matheus Marchini authored
gclient doesn't support Python 3 yet. To workaround that problem, add an enviroment variable to override the Python version used by ./configure. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32140 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Christian Clauss <cclauss@me.com>
-
- Mar 10, 2020
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ash Cripps <ashley.cripps@ibm.com> Signed-off-by:
Rod Vagg <rod@vagg.org>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Refs: https://github.com/sindresorhus/macos-term-size/pull/3 Reviewed-By:
-
Rod Vagg authored
Includes hardened-runtime patch from gdams from https://github.com/nodejs/node/issues/29216#issuecomment-546932966 PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By:
-
Sam Roberts authored
Fixes warning on clang 11: In file included from ../../src/node_http2.cc:6: ../../src/node_http2.h:508:15: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage] typedef struct { ^ SessionJSFields ../../src/node_http2.h:512:33: note: type is not C-compatible due to this default member initializer uint32_t max_invalid_frames = 1000; ^~~~ ../../src/node_http2.h:514:3: note: type is given name 'SessionJSFields' for linkage purposes by this typedef declaration } SessionJSFields; ^ PR-URL: https://github.com/nodejs/node/pull/32134 Reviewed-By:Tobias Nießen <tniessen@tnie.de> Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Rich Trott authored
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Rich Trott authored
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By:
-
Rich Trott authored
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By:
-
Rich Trott authored
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: https://github.com/nodejs/node/pull/32142 Reviewed-By:
-
Rich Trott authored
test-debug-usage fails if run with `--trace-warnings` because the regular expression checking does not allow for the resulting stack trace from the deprecation warning. The test also only tests two parts of the three-part usage message. Improve the test so that it passes with `--trace-warnings` and verifies all three parts of the usage message. Signed-off-by:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Joyee Cheung authored
This patch adds a per-process native Debug() printer that can be called when an Environment is not available. PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Joyee Cheung authored
Move the debug category parsing into a new EnabledDebugList class, so that it can be reused outside of Environment. PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Joyee Cheung authored
aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: https://github.com/nodejs/node/pull/31884 Reviewed-By:
-
Ruben Bridgewater authored
This reverts commit 7cfbc9f9. PR-URL: https://github.com/nodejs/node/pull/31755 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This reverts commit aa0a01bd. PR-URL: https://github.com/nodejs/node/pull/31755 Reviewed-By:
-
Ruben Bridgewater authored
This reverts commit 4671d551 and contains a fix to the issue raised for the revert. PR-URL: https://github.com/nodejs/node/pull/31755 Reviewed-By:
-
Ruben Bridgewater authored
This reverts commit 5b0308cd. PR-URL: https://github.com/nodejs/node/pull/31755 Reviewed-By:
-
Andrew Neitsch authored
This work is modeled on #30094 which allowed `--disallow-code-generation-from-strings` in `NODE_OPTIONS`. The `--jitless` v8 option has been supported since 12.0.0. As a v8 option, node automatically picks it up, but there have been a few issues that were resolved by simply telling users about the option: #26758, This PR: - allows `--jitless` in `NODE_OPTIONS` - documents `--jitless` - moves `--experimental-loader=module` to locally restore alphabetical order in option documentation Refs: https://github.com/nodejs/node/pull/30094 Refs: https://github.com/nodejs/node/issues/26758 Refs: https://github.com/nodejs/node/issues/28800 PR-URL: https://github.com/nodejs/node/pull/32100 Reviewed-By:Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Matheus Marchini authored
If the subprocess being inspected hard crashes, there will be no information on the log, and the parent process will just wait until timeout. Logging the error signal when it happens can help developers understand failures faster. Signed-off-by:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Gabriel Schulhof authored
Mark all N-APIs that have been added since version 5 as stable. PR-URL: https://github.com/nodejs/node/pull/32058 Fixes: https://github.com/nodejs/abi-stable-node/issues/393 Co-Authored-By:
legendecas <legendecas@gmail.com> Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Stephen Belanger authored
This allows transitioning the entire following sync and async execution sub-tree to the given async storage context. With this one can be sure the context binding will remain for any following sync activity and all descending async execution whereas the `run*(...)` methods must wrap everything that is intended to exist within the context. This is helpful for scenarios such as prepending a `'connection'` event to an http server which binds everything that occurs within each request to the given context. This is helpful for APMs to minimize the need for patching and especially adding closures. PR-URL: https://github.com/nodejs/node/pull/31945 Reviewed-By:
-
- Mar 09, 2020
-
-
Rich Trott authored
* Simplify introductory sentence. * Remove some passive voice. * Make style in bulleted list a little more consistent. * Remove superfluous list entry. PR-URL: https://github.com/nodejs/node/pull/32136 Reviewed-By:
-
Ruben Bridgewater authored
This increases the waiting time for each event from 500 to 750 ms. The former timeout could be hit on very slow machines with high load. PR-URL: https://github.com/nodejs/node/pull/31716 Reviewed-By:
-
Harshitha KP authored
Convert hard assertion into a throw with a useful error message in src/module_wrap.cc. PR-URL: https://github.com/nodejs/node/pull/31899 Reviewed-By:
-
Ben Noordhuis authored
Verify that the module loader uses index.js when the "main" property of package.json is the empty string. Refs: https://github.com/nodejs/node/issues/32013 PR-URL: https://github.com/nodejs/node/pull/32040 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
ProdipRoy89 authored
PR-URL: https://github.com/nodejs/node/pull/32045 Reviewed-By:
-
André Draszik authored
brotli is available as a shared library since 2016, so it makes sense to allow its use as a system-installed version. Some of the infrastructure was in place already (node.gyp and node.gypi), but some bits in the configure script here were missing. Add them, keeping the default as before, to use the bundled version. Refs: https://github.com/google/brotli/pull/421 Signed-off-by:
André Draszik <git@andred.net> PR-URL: https://github.com/nodejs/node/pull/32046 Reviewed-By:
-
André Draszik authored
Sometimes it's necessary to pass multiple library names to pkg-config, e.g. the brotli shared libraries can be pulled in with pkg-config libbrotlienc libbrotlidec Update the code to handle both, strings (as used so far), and lists of strings. Signed-off-by: -
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/32065 PR-URL: https://github.com/nodejs/node/pull/32088 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Vita Batrla authored
Test test-net-dns-error.js causes assertion failure on SunOS, test expects ENOTFOUND, but OS returns EAI_FAIL. Maximum length of a host name is 63 characters. Test test-net-dns-error.js makes a connection attempt to invalid host name (longer than maximum). Such connection attempt on SunOS returns permanent failure (EAI_FAIL) as invalid hostname won't be ever resolved. PR-URL: https://github.com/nodejs/node/pull/31780 Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/31773 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Denys Otrishko authored
This adds `const char*` based APIs to KVStore to avoid multiple string conversions (char -> Utf8 -> Local -> char etc.) when possible. PR-URL: https://github.com/nodejs/node/pull/31773 Reviewed-By:
-
legendecas authored
Although these `using`s can derived from other header files, it will be better to be self-contained. PR-URL: https://github.com/nodejs/node/pull/32117 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/31732 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/31694 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Gil Tayar authored
Added a section for "Self-referencing a package using its name" that documents importing a package's own exports (this was missed when adding the feature). PR-URL: https://github.com/nodejs/node/pull/31680 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
