- Apr 28, 2020
-
-
Nick Schonning authored
PR-URL: https://github.com/nodejs/node/pull/32676 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Daniel Estiven Rico Posada authored
PR-URL: https://github.com/nodejs/node/pull/32631 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Milad Farazmand authored
Original commit message: Fix compilation error with devtoolset-8 We are compiling V8 using devtoolset-8 and it is generating a new compilation error related to String Truncation: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated copying between 1 and 15 bytes from a string of length 15 [-Werror=stringop-truncation] strncpy(buffer, unicode_utf8, i); Which basically means the null terminating character was not added to the end of the buffer: https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/ This CL will changes 2 uses of "strncpy" to "memcpy" as strings are being copied partially and `\n` being added at a later stage. Change-Id: I3656afb00463d70ddb8700a487a1978b793e1d09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2155038 Reviewed-by:Andreas Haas <ahaas@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67277} Refs: https://github.com/v8/v8/commit/e1eac1b16c966879102c2310d7649637227eaa02 PR-URL: https://github.com/nodejs/node/pull/32974 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org>
-
Prosper Opara authored
PR-URL: https://github.com/nodejs/node/pull/32931 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Gireesh Punathil authored
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: https://github.com/nodejs/node/pull/32732 Refs: https://github.com/nodejs/diagnostics/issues/369 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Rich Trott authored
tools/doc/html.js includes code that looks for comments with `start-include` and `end-include` for file inclusion. This seems to be legacy code that is no longer used. The code only appears in the table-of-contents generation function. The strings `start-include` and `end-include` appear nowhere else in our tools and nowhere at all in our docs. PR-URL: https://github.com/nodejs/node/pull/32913 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32843 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
daemon1024 authored
PR-URL: https://github.com/nodejs/node/pull/32896 Fixes: https://github.com/nodejs/node/issues/32871 Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com>
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/32958 Fixes: https://github.com/nodejs/node/issues/32922 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/32838 Reviewed-By:
Jan Krems <jan.krems@gmail.com>
-
Myles Borins authored
For targets that are strings that do not start with `./` or `/` the error will now have additional information about what the programming error is. Closes: https://github.com/nodejs/node/issues/32034 PR-URL: https://github.com/nodejs/node/pull/32052 Fixes: https://github.com/nodejs/node/issues/32034 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Signed-off-by:
Myles Borins <myles.borins@gmail.com>
-
James M Snell authored
Make it so that the allow unauthorized warning can be easily reused by the QUIC impl once that lands. Extracted from https://github.com/nodejs/node/pull/32379 Signed-off-by:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Myles Borins authored
This removes `--experimental-modules` from showing up in `node -h` and also removes the documentation from the man pages. It will still work as a no-op, and is still included in cli.md Refs: https://github.com/nodejs/modules/issues/502 PR-URL: https://github.com/nodejs/node/pull/32915 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Edward Elric authored
PR-URL: https://github.com/nodejs/node/pull/32926 Reviewed-By:
-
Matt Kulukundis authored
An empty buffer can have a null environment. Previously, we were getting away with with this, but -fsanitize=null in clang caught it. PR-URL: https://github.com/nodejs/node/pull/32892 Reviewed-By:
-
William Armiros authored
PR-URL: https://github.com/nodejs/node/pull/32847 Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32950 Refs: https://github.com/nodejs/node/issues/32863 Reviewed-By:
-
karan singh virdi authored
This commit fixes the interchangeably usage of "folder" and "directory" terms in fs.md Fixes: https://github.com/nodejs/node/issues/32902 PR-URL: https://github.com/nodejs/node/pull/32919 Reviewed-By:
-
雨夜带刀 authored
PR-URL: https://github.com/nodejs/node/pull/32901 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32640 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32910 Reviewed-By:
-
cjihrig authored
Notable changes: - The UV_UDP_RECVMMSG flag has been added. This flag is now required in order to utilize recvmmsg(). This was added in response to a regression introduced in 1.35.0 and 1.36.0. PR-URL: https://github.com/nodejs/node/pull/32866 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
cjihrig authored
Notable changes: - gyp support has been removed. - recvmmsg messages are returned in the correct order. - IBMi cmake support has been added. - uv_fs_lutime() has been added. - uv_fs_statfs() on Windows properly handles file paths. PR-URL: https://github.com/nodejs/node/pull/32866 Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/nodejs.org/pull/3106#issuecomment-614258785 PR-URL: https://github.com/nodejs/node/pull/32903 Reviewed-By:
-
Juan José Arboleda authored
Based on https://github.com/nodejs/help/issues/2600#issuecomment-612857153 the condition (amount < 0) won't be possible. PR-URL: https://github.com/nodejs/node/pull/32818 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
Jesus Hernandez authored
PR-URL: https://github.com/nodejs/node/pull/32662 Reviewed-By:
-
David Daza authored
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary. PR-URL: https://github.com/nodejs/node/pull/32644 Reviewed-By:
-
Vadzim Zieńka authored
Call iterator.return() if not all of its values are consumed. Fixes: https://github.com/nodejs/node/issues/32842 PR-URL: https://github.com/nodejs/node/pull/32844 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32886 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32832 Reviewed-By:
-
Nimit authored
Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required. PR-URL: https://github.com/nodejs/node/pull/32875 Reviewed-By:
-
Nimit authored
elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: https://github.com/nodejs/node/pull/32872 Reviewed-By:
-
Anna Henningsen authored
This fixes the following crash on Windows for me. I don't know why this I only started to see this now, but anyway, the new timeout value is still longer than a week and a half. File "tools/test.py", line 1725, in <module> sys.exit(Main()) File "tools/test.py", line 1701, in Main if RunTestCases(cases_to_run, options.progress, \ options.j, options.flaky_tests): File "tools/test.py", line 923, in RunTestCases return progress.Run(tasks) File "tools/test.py", line 145, in Run thread.join(timeout=10000000) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1015, in join self._wait_for_tstate_lock(timeout=max(timeout, 0)) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1027, in _wait_for_tstate_lock elif lock.acquire(block, timeout): OverflowError: timeout value is too large PR-URL: https://github.com/nodejs/node/pull/32868 Reviewed-By:Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32854 Reviewed-By:
-
Michael Dawson authored
We missed adding version 6 to the compatibility table when we defined version 6. Add it along with the versions that we know will include version 6. PR-URL: https://github.com/nodejs/node/pull/32829 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32906 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/31974 Reviewed-By:
-
William Bonawentura authored
PR-URL: https://github.com/nodejs/node/pull/32657 Reviewed-By:
-
Qinhui Chen authored
Delete useless module in parent module: parent.children array when error occurs, so that it can be garbage collected. Fixes: https://github.com/nodejs/node/issues/32836 PR-URL: https://github.com/nodejs/node/pull/32837 Reviewed-By:
-
Daniel Bevenius authored
This commit removes unused using declarations in src/node_worker.cc. PR-URL: https://github.com/nodejs/node/pull/32840 Reviewed-By:
-
