- Jul 17, 2020
-
-
Rich Trott authored
Refs: https://github.com/nodejs/node/pull/33764#issuecomment-653667275 PR-URL: https://github.com/nodejs/node/pull/34197 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
test-repl-history-navigation fails with NODE_PENDING_DEPRECATION=1. Replace deprecated repl.inputStream with repl.input. PR-URL: https://github.com/nodejs/node/pull/34199 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34198 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/34167 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Nikola Glavina authored
C++ linter fails because of unused ArrayBuffer namespace member PR-URL: https://github.com/nodejs/node/pull/34212 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
ERR_FEATURE_UNAVAILABLE_ON_PLATFORM is incorrectly included in the list of errors that have never been released. It was added in 67e067eb and included in every release in the 14.x line. PR-URL: https://github.com/nodejs/node/pull/34196 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Rich Trott authored
Had an email exchange with Hitesh where he indicated that it was a fine time to move him to emeritus. PR-URL: https://github.com/nodejs/node/pull/34191 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Rich Trott authored
Asked Gibson in email if he should be moved to emeritus and he indicated it was a good idea. PR-URL: https://github.com/nodejs/node/pull/34190 Reviewed-By:
-
James M Snell authored
Alternative to https://github.com/nodejs/node/pull/33841 Co-authored-by:
zombieleet <zombieleetnca@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34188 Reviewed-By:
-
Rich Trott authored
The explanation that the HTTP requests include `\r\n` is true but not important or relevant in these two specific contexts. PR-URL: https://github.com/nodejs/node/pull/34178 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Rich Trott authored
Remove stability indicators from errors that only existed on the master branch and are not in the release. PR-URL: https://github.com/nodejs/node/pull/33764 Reviewed-By:
-
Michael Dawson authored
We have this guidance for contributing to N-API: https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md It makes sense to have one of the N-API team sign off on commits that changes N-API Signed-off-by:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/33856 Reviewed-By:
-
Rich Trott authored
lint-js.js was implemented before ESLint had a caching feature. It is now only used in CI. Let's remove it on the following grounds: * It results in occasional (and puzzling) yellow CI runs for node-test-linter because the tap file is corrupted somehow. Interleaved maybe? I don't know, but a simple solution is removing it and running ESLint directly. * On my local laptop, it reduces the linting from about 75 seconds to about 55 seconds. This kind of savings is not worth the added complexity and the instability noted above. PR-URL: https://github.com/nodejs/node/pull/30955 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Julien Poissonnier authored
PR-URL: https://github.com/nodejs/node/pull/34119 Reviewed-By:
-
Luigi Pinca authored
Clarify that the `ctx` argument of the `SNICallback` callback is optional. Fixes: https://github.com/nodejs/node/issues/34085 PR-URL: https://github.com/nodejs/node/pull/34097 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
-
Mateusz Krawczuk authored
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: https://github.com/nodejs/node/pull/34050 Reviewed-By:
-
Sam Roberts authored
Node.js hasn't touched the cve-management repo since the Feb 2019 security release, we've used the HackerOne CVE allocation process. Maintaining our status as a CNA is not zero cost, there is some routine adminstration that is requested (see this doc for details). As we no longer use the CVE management process, I propose removing it. If this lands, I will go through the interactions with Mitre so that Node.js is no longer a CNA and cleanup related resources (email aliases, archive the cve-management repo, whatever else I find). PR-URL: https://github.com/nodejs/node/pull/33639 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
Saleem authored
Consistency of method naming referred to as readable.push several other times in transform documentation and also documented under readable, so makes sense to just stick with readable.push PR-URL: https://github.com/nodejs/node/pull/30506 Reviewed-By:
-
Anentropic authored
document more clearly that stdin will emit multiple readable events PR-URL: https://github.com/nodejs/node/pull/27350 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Gabriel Schulhof authored
Remove text regarding copying, because `napi_create_external_buffer` does not copy. Fixes: https://github.com/nodejs/node/issues/33471 PR-URL: https://github.com/nodejs/node/pull/34125 Reviewed-By:
Mathias Buus <mathiasbuus@gmail.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Rodion Abdurakhimov authored
Prior to this commit, [src] link overlapped sharped (#) sub-header link PR-URL: https://github.com/nodejs/node/pull/33664 Reviewed-By:
-
Denys Otrishko authored
* use writeFile(1) everywhere to log * prettify execution id graph * add clearer explanation for TickObject presence * add causation graph via triggerAsyncId PR-URL: https://github.com/nodejs/node/pull/33730 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/34139 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Derek Lewis authored
This commit clarifies the behavior of a couple aspects of conditional exports that may have been difficult to grasp from the prose alone. PR-URL: https://github.com/nodejs/node/pull/33886 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/34013 Refs: https://github.com/nodejs/node/pull/33617 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/34153 Reviewed-By:
-
Rich Trott authored
Remove a double negative and many superfluous sentences. The sentiment in the removed material is good, but we already tell people that discussion should be focused, helpful, and professional. Having two extra paragraphs greatly reduces the likelihood that people will read the material. PR-URL: https://github.com/nodejs/node/pull/34164 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34155 Reviewed-By:
-
Xu Meng authored
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program. This leads to timing issues and ECONNRESET failures in some test cases. Refs: https://github.com/libuv/libuv/pull/2782 PR-URL: https://github.com/nodejs/node/pull/34118 Reviewed-By:
-
Anna Henningsen authored
This makes the function more robust against V8 inlining. Fixes: https://github.com/nodejs/node/issues/34073 PR-URL: https://github.com/nodejs/node/pull/34141 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Richard Lau authored
Add a custom message to parallel/test-dgram-error-message-address so that the actual error code that doesn't match the allowed errors is output on assertion failure. PR-URL: https://github.com/nodejs/node/pull/34134 Reviewed-By:
-
Rich Trott authored
"would be considered a `TypeError`" -> "would be a `TypeError`". Using "considered" introduces unnecessary ambiguity. Is is not actually a TypeError but merely "considered" one? Why is that? We don't say. Simplify to "is a TypeError". PR-URL: https://github.com/nodejs/node/pull/34152 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
-
Rich Trott authored
"should always be considered" -> "indicate" PR-URL: https://github.com/nodejs/node/pull/34151 Reviewed-By:
-
Derek Lewis authored
Prior to this commit, http request message code blocks in Markdown files were not being highlighted correctly. This has been corrected by adding the new grammar to the bundle, removing the CRLFs (`\r\n`) from these code samples, adding a reminder to re-add them, and tuning the syntax theme to support attribute highlighting. PR-URL: https://github.com/nodejs/node/pull/33785 Reviewed-By:
-
Sam Roberts authored
I don't have enough time to remain active in the TSC, so I will step down. PR-URL: https://github.com/nodejs/node/pull/34095 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
This changes "considered" experimental" to "experimental" in the n-api.md file and introduces some additional brevity. PR-URL: https://github.com/nodejs/node/pull/34129 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Rich Trott authored
Change "no longer considered experimental" to "no longer experimental" in cli.md. PR-URL: https://github.com/nodejs/node/pull/34128 Reviewed-By:
-
falguniraina authored
PR-URL: https://github.com/nodejs/node/pull/33973 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Robert Nagy authored
Wrapped streams are expected to behave the same as socket with handle. Remove unnecessary difference in handling. PR-URL: https://github.com/nodejs/node/pull/34105 Reviewed-By:
-
