- Mar 26, 2015
-
-
Fedor Indutny authored
Always call `Done` on the WriteWrap, and ensure that `EncOut` will consume all data in clear_in_ and invoke queued callbacks. Fix: https://github.com/iojs/io.js/issues/1075 PR-URL: https://github.com/iojs/io.js/pull/1244 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Fedor Indutny authored
Fix: https://github.com/iojs/io.js/issues/1075 PR-URL: https://github.com/iojs/io.js/pull/1244 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Vladimir Kurchatkin authored
Internal modules can be used to share private code between public modules without risk to expose private APIs to the user. PR-URL: https://github.com/iojs/io.js/pull/848 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Mar 25, 2015
-
-
Brendan Ashworth authored
Only objects and symbols use `util.inspect`, others are simply concatenated. Fixes: https://github.com/iojs/io.js/issues/935 PR-URL: https://github.com/iojs/io.js/pull/1255 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Brian White authored
By limiting property getting/setting to only where they are absolutely necessary, we can achieve greater performance especially with small utf8 inputs and any size base64 inputs. PR-URL: https://github.com/iojs/io.js/pull/1209 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Nicu Micleușanu <micnic90@gmail.com> Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
Bert Belder authored
On Windows, when node or io.js attempts to dynamically load a compiled addon, the compiled addon tries to load node.exe or iojs.exe again - depending on which import library the module used when it was linked. This makes it impossible to rename node.exe or iojs.exe, because when that happens the module can't find its dependencies. With this patch, a delay-load hook is added to all modules that are compiled with node-gyp. The delay-load hook ensures that whenever a module tries to load imports from node.exe/iojs.exe, it'll just refer back to the process image, thus making it possible to rename the iojs/node binary. Bug: https://github.com/iojs/io.js/issues/751 Bug: https://github.com/iojs/io.js/issues/965 Upstream PR: https://github.com/TooTallNate/node-gyp/pull/599 PR-URL: https://github.com/iojs/io.js/pull/1251 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Olov Lassus authored
1. writeFileSync bumps position incorrectly, causing it to drift in iteration three and onwards. 2. Append mode files will get corrupted in the middle if writeFile or writeFileSync iterates multiple times, unless running on Linux. position starts out as null so first write is OK, but then position will refer to a location inside an existing file, corrupting that data. Linux ignores position for append mode files so it doesn't happen there. This commit fixes these two related issues by bumping position correctly and by always using null as the position argument to write/writeSync for append mode files. PR-URL: https://github.com/iojs/io.js/pull/1063 Reviewed-By:
Bert Belder <bertbelder@gmail.com>
-
Roman Reiss authored
CONTRIBUTING.md didn't make our rule for requiring real names from contributors clear enough. This commit shall clarify that part. Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> PR-URL: https://github.com/iojs/io.js/pull/1250
-
Roman Reiss authored
Fixes: https://github.com/iojs/io.js/issues/992 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com> PR-URL: https://github.com/iojs/io.js/pull/1249
-
Mayhem authored
Not including `new` adds a useless frame and removes a potentially useful frame. PR-URL: https://github.com/iojs/io.js/pull/1246 Reviewed-By:
Petka Antonov <petka_antonov@hotmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com>
-
- Mar 24, 2015
-
-
Alex Yursha authored
Delegate buffer equality check to `buffer.equals()` PR-URL: https://github.com/iojs/io.js/pull/1171 Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By:
Christian Vaagland Tellnes <christian@tellnes.com>
-
cjihrig authored
Every npm version bump requires a few patches to be floated on node-gyp for io.js compatibility. These patches are found in 03d19927, 5de334c2, and da730c76. This commit squashes them into a single commit. PR-URL: https://github.com/iojs/io.js/pull/990 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Forrest L Norvell authored
PR-URL: https://github.com/iojs/io.js/pull/1219 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
- Mar 23, 2015
-
-
Ben Noordhuis authored
Remove some unnecessary environment lookups and delete a few superfluous HandleScope variables. PR-URL: https://github.com/iojs/io.js/pull/1238 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Ben Noordhuis authored
It's possible for an accessor or named interceptor to get called with a different execution context than the one it lives in, see the test case for an example using the debug API. This commit fortifies against that by passing the environment as a data property instead of looking it up through the current context. Fixes: https://github.com/iojs/io.js/issues/1190 (again) PR-URL: https://github.com/iojs/io.js/pull/1238 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Rod Vagg authored
-
Rod Vagg authored
Notable Changes: * Windows: The ongoing work in improving the state of Windows support has resulted in full test suite passes once again. As noted in the release notes for v1.4.2, CI system and configuration problems prevented it from properly reporting problems with the Windows tests, the problems with the CI and the codebase appear to have been fully resolved. * FreeBSD: A kernel bug impacting io.js/Node.js was discovered and a patch has been introduced to prevent it causing problems for io.js (Fedor Indutny) #1218. * module: you can now require('.') instead of having to require('./'), this is considered a bugfix (Michaël Zasso) #1185. * v8: updated to 4.1.0.25 including patches for --max_old_space_size values above 4096 and Solaris support, both of which are already included in io.js. -
Connor Peet authored
PR-URL: https://github.com/iojs/io.js/pull/1240 Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By:
Petka Antonov <petka_antonov@hotmail.com>
-
Johan Bergström authored
PR-URL: https://github.com/iojs/io.js/pull/1224 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ben Noordhuis authored
Move sequential/test-signal-unregister to test/parallel, it doesn't need to run in sequential mode. PR-URL: https://github.com/iojs/io.js/pull/1227 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Ben Noordhuis authored
Change sequential/test-signal-unregister so it doesn't use fixed timeouts for sending the signal and expecting the child to quit. Fixes: https://github.com/iojs/io.js/issues/1223 PR-URL: https://github.com/iojs/io.js/pull/1227 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Ben Noordhuis authored
Ensure that the debug context has an Environment assigned in case a fatal error is raised. The fatal exception handler in node.cc is not equipped to deal with contexts that don't have one and can't easily be taught that due to a deficiency in the V8 API: there is no way for the embedder to tell if the data index is in use. Fixes: https://github.com/iojs/io.js/issues/1190 PR-URL: https://github.com/iojs/io.js/pull/1229 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Mar 22, 2015
-
-
Rod Vagg authored
Update AUTHORS file using tools/update-authors.sh PR-URL: https://github.com/iojs/io.js/pull/1234 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Mathieu Darse authored
PR-URL: https://github.com/iojs/io.js/pull/1230 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Fedor Indutny authored
Stdin is purely read-only stream. Although, `net.Socket` might be used to create it if stdin is in fact a Pipe or TCP socket, the `stream.Duplex` should not try to call `.end()` on it. Fix: https://github.com/iojs/io.js/issues/1068 PR-URL: https://github.com/iojs/io.js/pull/1233 Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
Brendan Ashworth authored
This commit fixes a small bug introduced in 671fbd5a that caused the test to not be run. crypto was properly checked, but since tls was not imported, a TypeError would be thrown in the `try {} catch {}` block and falsely reported as no crypto. This is now fixed. PR-URL: https://github.com/iojs/io.js/pull/1141 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
- Mar 21, 2015
-
-
Ben Noordhuis authored
It's good practice now to call JS functions that don't execute in a specific scope with v8::Null() as the receiver. Update the addons documentation. PR-URL: https://github.com/iojs/io.js/pull/1125 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
Wholesale importing an entire namespace with `using namespace` is a bad practice. Remove it from the addons documentation and replace it with proper `using` directives. Wrap code in a namespace while we are here. PR-URL: https://github.com/iojs/io.js/pull/1125 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
v8::Handle is on its way out, to be replaced with v8::Local. Update the addons documentation accordingly. PR-URL: https://github.com/iojs/io.js/pull/1125 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
Remove unnecessary v8::HandleScope uses from the addons documentation. C++ API callbacks run in an implicit v8::HandleScope, there is no need to declare one in the callback function. PR-URL: https://github.com/iojs/io.js/pull/1125 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
v8::Isolate::GetCurrent() is slated for deprecation. Replace its uses in the addons documentation with v8::Object::GetIsolate(), etc. PR-URL: https://github.com/iojs/io.js/pull/1125 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
It turns out we have little to no test coverage for setTimeout() and setInterval() calls with optional arguments. Now we do. PR-URL: https://github.com/iojs/io.js/pull/1221 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
The common case is where setInterval() is called with two arguments, the callback and the timeout. Specifying optional arguments in the parameter list forces common case calls to go through an arguments adaptor stack frame. PR-URL: https://github.com/iojs/io.js/pull/1221 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
The common case is where setTimeout() is called with two arguments, the callback and the timeout. Specifying optional arguments in the parameter list forces common case calls to go through an arguments adaptor stack frame. PR-URL: https://github.com/iojs/io.js/pull/1221 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Fedor Indutny authored
FreeBSD has a nasty bug with SA_RESETHAND reseting the SA_SIGINFO, that is in turn set for a libthr wrapper. This leads to a crash. Work around the issue by manually setting SIG_DFL in the signal handler. Fix: https://github.com/joyent/node/issues/9326 PR-URL: https://github.com/iojs/io.js/pull/1218 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Michaël Zasso authored
Previously, the minimal argument to require the current directory was require('./'). This commits allows to skip the trailing slash. Fixes: https://github.com/iojs/io.js/issues/1178 PR-URL: https://github.com/iojs/io.js/pull/1185 Reviewed-By:Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By:
Christian Tellnes <christian@tellnes.no> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Mar 20, 2015
-
-
Rod Vagg authored
-
Rod Vagg authored
Notable Changes: * path: New type-checking on path.resolve() <https://github.com/iojs/io.js/pull/1153> uncovered some edge-cases being relied upon in the wild, most notably path.dirname(undefined). Type-checking has been loosened for path.dirname(), path.basename(), and path.extname(), (Colin Ihrig) <https://github.com/iojs/io.js/pull/1216>. * querystring: Internal optimizations in querystring.parse() and querystring.stringify() <https://github.com/iojs/io.js/pull/847> prevented Number literals from being properly converted via querystring.escape() <https://github.com/iojs/io.js/pull/1208>, exposing a blind-spot in the test suite. The bug and the tests have now been fixed (Jeremiah Senkpiel) <https://github.com/iojs/io.js/pull/1213>.
-
Jeremiah Senkpiel authored
stringifyPrimitive has always failed to stringify numbers since its introduction in 422d3c93. This went uncaught due to encodeURIComponent's string coercion. Fixes: https://github.com/iojs/io.js/issues/1208 PR-URL: https://github.com/iojs/io.js/pull/1213 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Jeremiah Senkpiel authored
Fixes a number parsing regression introduced in 85a92a37 Fixes: https://github.com/iojs/io.js/issues/1208 PR-URL: https://github.com/iojs/io.js/pull/1213 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Brian White <mscdex@mscdex.net>
-