- Mar 31, 2016
-
-
Trevor Norris authored
Rather than abort if the init/pre/post/final/destroy callbacks throw, force the exception to propagate and not be made catchable. This way the application is still not allowed to proceed but also allowed the location of the failure to print before exiting. Though the stack itself may not be of much use since all callbacks except init are called from the bottom of the call stack. /tmp/async-test.js:14 throw new Error('pre'); ^ Error: pre at InternalFieldObject.pre (/tmp/async-test.js:14:9) PR-URL: https://github.com/nodejs/node/pull/5756 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Andreas Madsen <amwebdk@gmail.com>
-
Trevor Norris authored
The second argument of the post callback is a boolean indicating whether the callback threw and was intercepted by uncaughtException or a domain. Currently node::MakeCallback has no way of retrieving a uid for the object. This is coming in a future patch. PR-URL: https://github.com/nodejs/node/pull/5756 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Andreas Madsen <amwebdk@gmail.com>
-
Trevor Norris authored
The number of callbacks accepted to setupHooks was getting unwieldy. Instead change the implementation to accept an object with all callbacks PR-URL: https://github.com/nodejs/node/pull/5756 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Andreas Madsen <amwebdk@gmail.com>
-
Trevor Norris authored
Make comment clear that Undefined() is returned for legacy compatibility. This will change in the future as a semver-major change, but to be able to port this to previous releases it needs to stay as is. PR-URL: https://github.com/nodejs/node/pull/5756 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Andreas Madsen <amwebdk@gmail.com>
-
Trevor Norris authored
Now that HTTPParser uses MakeCallback it is unnecessary to manually process the nextTickQueue. The KickNextTick function is now no longer needed so code has moved back to node::MakeCallback to simplify implementation. Include minor cleanup moving Environment::tick_info() call below the early return to save an operation. PR-URL: https://github.com/nodejs/node/pull/5756 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Andreas Madsen <amwebdk@gmail.com>
-
James M Snell authored
Now that the CTC has expanded, this PR calls for a vote of the CTC to reinstate Michael Dawson (@mhdawson) as a full voting member. Voted on and approved by the CTC on 2016-03-23 PR-URL: https://github.com/nodejs/node/pull/5633 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Mar 25, 2016
-
-
James M Snell authored
This backports the new `Buffer.alloc()`, `Buffer.allocUnsafe()`, and `Buffer.from()` APIs for v5. Also included in this backport is the change that allows fill('') to zero-fill (as opposed to doing nothing) and the additional `byteOffset` and `length` arguments for `Buffer(arrayBuffer)` and `Buffer.from(arrayBuffer)`. This backport includes the new test cases. This backport *does not* update all of the internal uses of the existing `Buffer()` constructor. This backport also *does not* include the soft deprecation of the existing `Buffer()` constructor. PR-URL: https://github.com/nodejs/node/pull/5763 Reviewed-By:Trevor Norris <trev.norris@gmail.com>
-
James M Snell authored
This backports the --zero-fill-buffers command line flag introduced in master. When used, all Buffer and SlowBuffer instances will zero fill by default. This does *not* backport any of the other Buffer API or behavior changes. PR-URL: https://github.com/nodejs/node/pull/5744 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
- Mar 23, 2016
-
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/5831
-
Jeremiah Senkpiel authored
Notable changes: * buffer: Now properly throws RangeErrors on out-of-bounds writes (Matt Loring) https://github.com/nodejs/node/pull/5605 - This effects write{Float|Double} when the noAssert option is not used. * timers: - Returned timeout objects now have a Timeout constructor name (Jeremiah Senkpiel) https://github.com/nodejs/node/pull/5793 - Performance of Immediate processing is now ~20-40% faster (Brian White) https://github.com/nodejs/node/pull/4169 * vm: Fixed a contextify regression introduced in v5.9.0 (Ali Ijaz Sheikh) https://github.com/nodejs/node/pull/5800 PR-URL: https://github.com/nodejs/node/pull/5831
-
Benjamin Gruenbaum authored
Prefer the use of template string literals over string concatenation in the dns module, makes dns consistent with other modules basically doing https://github.com/nodejs/node/pull/5778 for it. PR-URL: https://github.com/nodejs/node/pull/5809 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jérémy Lal authored
PR-URL: https://github.com/nodejs/node/pull/5813 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Conflicts: test/parallel/test-zlib-params.js
-
Jérémy Lal authored
Fixes: https://github.com/nodejs/node/issues/5749 PR-URL: https://github.com/nodejs/node/pull/5813 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Matt Loring authored
The check to determine whether `noAssert` was set to true and thus whether RangeErrors should be thrown was happening after the write was truncated to the available size of the buffer. These checks now occur in the correct order. Fixes: https://github.com/nodejs/node/issues/5587 PR-URL: https://github.com/nodejs/node/pull/5605 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
4d78121b had lint errors that went undetected. This fixes them. PR-URL: https://github.com/nodejs/node/pull/5840 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Santiago Gimeno authored
It's possible that the `end` event is emitted after the timeout fires causing the test to fail. Just remove the timer. If for some reason the `end` would never fire, the test will fail with a timeout. PR-URL: https://github.com/nodejs/node/pull/5129 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Santiago Gimeno authored
It checks that `eval` is called with `.scope` as an input string. PR-URL: https://github.com/nodejs/node/pull/5534 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Bill Automata authored
[Diffie-Hellman](https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation) keys are composed of a `generator` a `prime` a `secret_key` and the `public_key` resulting from the math operation: ``` (generator ^ secret_key) mod prime = public_key ``` Diffie-Hellman keypairs will compute a matching shared secret if and only if the generator and prime match for both recipients. The generator is usually **2** and the prime is what is called a [Safe Prime](https://en.wikipedia.org/wiki/Safe_prime). Usually this matching is accomplished by using [standard published groups](http://tools.ietf.org/html/rfc3526). We expose access those groups with the `crypto.getDiffieHellman` function. `createDiffieHellman` is trickier to use. The original example had the user creating 11 bit keys, and creating random groups of generators and primes. 11 bit keys are very very small, can be cracked by a single person on a single sheet of paper. A byproduct of using such small keys were that it was a high likelihood that two calls of `createDiffieHellman(11)` would result in using the same 11 bit safe prime. The original example code would fail when the safe primes generated at 11 bit lengths did not match for alice and bob. If you want to use your own generated safe `prime` then the proper use of `createDiffieHellman` is to pass the `prime` and `generator` to the recipient's constructor, so that when they compute the shared secret their `prime` and `generator` match, which is fundamental to the algorithm. PR-URL: https://github.com/nodejs/node/pull/5505 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jackson Tian authored
use String.prototype.repeat() to simplify code, less code, more semantically. PR-URL: https://github.com/nodejs/node/pull/5359 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/5273 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/5272 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jackson Tian authored
Remove unnecessary `self = this`. PR-URL: https://github.com/nodejs/node/pull/5231 Reviewed-By:
James M Snell <jasnell@gmail.com> Conflicts: lib/domain.js
-
Wolfgang Steiner authored
Added a hint saying that node uses the default "Cannot find module" error when requiring a module for which the "main" file specified in the package.json is missing. PR-URL: https://github.com/nodejs/node/pull/5812 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jeremiah Senkpiel authored
This page is mostly a mirror of the updated manual page. PR-URL: https://github.com/nodejs/node/pull/5787 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Robert Lindstädt <robert.lindstaedt@gmail.com>
-
Michael Dawson authored
Improve the robustness of test-net-connect-options-ipv6.js PPC Suse build team encountered intermittent failures related to dns. Improve test to make it more robust in the face of intermittent dns issues. PR-URL: https://github.com/nodejs/node/pull/5791 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jeremiah Senkpiel authored
Fixes: https://github.com/nodejs/node/issues/5823 Refs: https://github.com/nodejs/node/pull/5793 PR-URL: https://github.com/nodejs/node/pull/5825 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Mithun Patel authored
PR-URL: https://github.com/nodejs/node/pull/5700 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Conflicts: doc/api/path.markdown
-
Santiago Gimeno authored
Don't check that the `disconnect` event is emitted before the `exit` event as the order is not guaranteed. PR-URL: https://github.com/nodejs/node/pull/5814 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Claudio Rodriguez authored
Test was flaky on centos7-64 due to an uncaught ECONNRESET on the worker code. This catches the error so the process will exit with code 0. Fixes: https://github.com/nodejs/node/issues/5604 PR-URL: https://github.com/nodejs/node/pull/5802 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Benjamin Gruenbaum authored
Currently the DNS module imports isIP from both cares and `net` and uses both of them both throughout the code base. This PR removes the direct dependency `dns` has on `net` and uses `isIp` from c-ares all the time. Note that both functions do the same thing. PR-URL: https://github.com/nodejs/node/pull/5804 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Conflicts: lib/dns.js
-
Rich Trott authored
Reduce resoures required by test. Clarify comment explaining source of test and what the test is looking for. Fixes: https://github.com/nodejs/node/issues/5725 PR-URL: https://github.com/nodejs/node/pull/5728 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jeremiah Senkpiel authored
Refs: https://github.com/nodejs/node/pull/5792 PR-URL: https://github.com/nodejs/node/pull/5793 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Conflicts: test/message/timeout_throw.out
-
Ben Noordhuis authored
Refs: https://github.com/nodejs/node/issues/5615 PR-URL: https://github.com/nodejs/node/pull/5619 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Bryan English authored
Added appropriate in-document links. Clarified a bit of `setImmediate`, including a quick grammar fix (plural possessive apostrophe). PR-URL: https://github.com/nodejs/node/pull/5792 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Rich Trott authored
Convert string concatenation to template literals. Enforce with lint rule. PR-URL: https://github.com/nodejs/node/pull/5778 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Conflicts: src/.eslintrc src/node.js
-
Benjamin Gruenbaum authored
Removed an unused `var self = this` that is no longer required. PR-URL: https://github.com/nodejs/node/pull/5224 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Stefano Vozza authored
Brings tls.markdown into alignment with the node.js styleguide, specifically regarding the use of personal pronouns. Also, fixes various typos, punctuation errors, missing definite/indefinite articles and other minor grammatical issues. PR-URL: https://github.com/nodejs/node/pull/5706 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Conflicts: doc/api/tls.markdown
-
Jarrett Widman authored
The need for an overview of blocking vs non-blocking was identified in the docs WG Q1 roadmap. As there are several topics also pending creation, this one tries to hit the correct level of detail based on completion of the others. One which is referenced is https://github.com/nodejs/node/pull/4936/files and URLs within this PR need to change based on where that will land on the node website. PR-URL: https://github.com/nodejs/node/pull/5326 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
Matt Loring authored
test-repl-tab-complete includes tests that ensure that certain keys do not appear in tab completions or that completion does not crash the repl. It performed these tests by comparing completion output to a hardcoded list of expected keys. This list is made incorrect by any api changes that occur when new versions of V8 are introduced. With this change, we assert that the specific keys to be avoided are not present in the output instead. PR-URL: https://github.com/nodejs/node/pull/5772 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Conflicts: test/parallel/test-repl-tab-complete.js
-
Brian White authored
This commit improves setImmediate() performance by moving the try-finally block that wraps callback execution into a separate function because currently v8 never tries to optimize functions that contain try-finally blocks. With this change, there is a ~20-40% improvement in the included setImmediate() depth benchmarks. The breadth benchmarks show a slight improvement. PR-URL: https://github.com/nodejs/node/pull/4169 Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-