- Jan 22, 2019
-
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25480 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Tim De Pauw authored
Originally discovered and resolved by @szmarczak. PR-URL: https://github.com/nodejs/node/pull/25536 Fixes: https://github.com/nodejs/node/issues/25499 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25627 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Anna Henningsen authored
This call was introduced in 827ee498 to avoid a crash in a later `Neuter()` call that has later been removed in ebbbc5a7, rendering the original call unnecessary. Refs: https://github.com/nodejs/node/pull/3624 Refs: https://github.com/nodejs/node/pull/5204 PR-URL: https://github.com/nodejs/node/pull/25479 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/25615 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
Anna Henningsen authored
The documentation of `SSL_get_certificate` states that it returns an internal pointer that must not be freed by the caller. Therefore, using a smart pointer to take ownership is incorrect. Refs: https://man.openbsd.org/SSL_get_certificate.3 Refs: https://github.com/nodejs/node/pull/24261 Fixes: https://github.com/nodejs-private/security/issues/217 PR-URL: https://github.com/nodejs/node/pull/25490 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Anna Henningsen authored
- Generate and use a list of suppressions that reduce noisiness for known (non-)issues. - Use `--zero-fill-buffers` for tests, as they sometimes use `Buffer.allocUnsafe()` and valgrind reports that as usage of uninitialized memory. PR-URL: https://github.com/nodejs/node/pull/25498 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Benjamin authored
Calling env->EmitProcessEnvWarning() prevents additional warnings from being set it should therefore be called only if a warning will emit. PR-URL: https://github.com/nodejs/node/pull/25575 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
- Jan 21, 2019
-
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/25571 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com>
-
yathamravali authored
PR-URL: https://github.com/nodejs/node/pull/25441 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/25507 Reviewed-By:
-
Daniel Bevenius authored
This commit updates the named curves P-192 (prime192v1), and secp192k1 to 256 bit versions. The motivation for this is that in Red Hat Enterprise Linux (RHEL) all ECC curves < 224 bits are removed from OpenSSL provided by the system. I'm not sure if other distributions do this but these 256 bit curves are availalbe in OpenSSL 1.1.0j (current version on master) and OpenSSL 1.1.1 so as far as I can tell it should be safe change to make. PR-URL: https://github.com/nodejs/node/pull/25564 Reviewed-By:
-
Daniel Bevenius authored
This commit updates option ciphers from 'RC4' to 'no-such-cipher' in test/parallel/test-tls-handshake-error.js. The motivation for this change is that this test is verifying that a 'no ciphers match' error be thrown, but 'RC4' might be among the ciphers supported by the OpenSSL version when dynamically linking. I ran into this specific issue when dynamically linking against OpenSSL 1.1.1 on RHEL8 using https://github.com/nodejs/node/pull/25381. PR-URL: https://github.com/nodejs/node/pull/25534 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
cjihrig authored
Update ESLint to 5.12.1 PR-URL: https://github.com/nodejs/node/pull/25573 Reviewed-By:
Wyatt Preul <wpreul@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com>
-
Benjamin Coe authored
PR-URL: https://github.com/nodejs/node/pull/25157 Reviewed-By:
-
Daniel George Holz authored
I was implementing a Writable stream and misunderstood `decodeStrings` to mean 'will decode `Buffer`s into `string`s before calling `_write`'. This change adds a little more detail to the description of `decodeStrings` to clarify its effect on a Writable stream & what gets passed to `_write`. Changing the name of the option to `encodeStrings` would make it much easier to understand, but the name was chosen in 2012 and the option used in many projects (22k mentions of 'decodeStringsr in JS projects in GitHub). Deprecating the old name & rolling out a replacement is beyond my capabilities as a first-time contributor. PR-URL: https://github.com/nodejs/node/pull/25468 Fixes: https://github.com/nodejs/node/issues/25464 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/25566 Reviewed-By:
-
- Jan 20, 2019
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/25585 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
Luigi Pinca authored
If specified, and only when a socket is created internally, the option will make `socket.setTimeout()` to be called on the created socket with the given timeout. This is consistent with the `timeout` option of `net.connect()` and prevents the `timeout` option of the `https.Agent` from being ignored when a socket is created. PR-URL: https://github.com/nodejs/node/pull/25517 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Gireesh Punathil authored
In parallel/test-fs-read-stream-concurrent-reads.js the number of data chunks used is being tested when few concurrent reads are performed. The number of chunks can fluctuate based on the number of concurrent reads as well as the data that was read in one shot. Accommodate these variations in the test. Fixes: https://github.com/nodejs/node/issues/22339 PR-URL: https://github.com/nodejs/node/pull/25415 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/25547 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
- Jan 19, 2019
-
-
Myles Borins authored
v11.6.0 ended up shipping with an npm version `6.5.0-next.0`. This test should avoid it happening in the future. PR-URL: https://github.com/nodejs/node/pull/25538 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com>
-
- Jan 18, 2019
-
-
Michael Dawson authored
Coverage report for src/node_i18n.cc shows that the Has() method is not covered. This test adds coverage for that method. PR-URL: https://github.com/nodejs/node/pull/25428 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/25562 Reviewed-By:
-
Ruben Bridgewater authored
Notable Changes * compression / zlib: * Added brotli support (Anna Henningsen and Zach Vacura) https://github.com/nodejs/node/pull/24938 * console: * Added `inspectOptions` option (Ruben Bridgewater) https://github.com/nodejs/node/pull/24978 * crypto: * Always accept private keys as public keys (Tobias Nießen) https://github.com/nodejs/node/pull/25217 * deps: * Upgrade npm to v6.5.0 (Jordan Harband) https://github.com/nodejs/node/pull/25234 * fs: * Use internalBinding('fs') internally instead of process.binding('fs') (Masashi Hirano) https://github.com/nodejs/node/pull/22478 * http(s): * Support overriding http\\s.globalAgent (Roy Sommer) https://github.com/nodejs/node/pull/25170 * util: * Inspect ArrayBuffers contents closely (Ruben Bridgewater) https://github.com/nodejs/node/pull/25006 * worker: * Expose workers by default and remove `--experimental-worker` flag (Anna Henningsen) https://github.com/nodejs/node/pull/25361 PR-URL: https://github.com/nodejs/node/pull/25537 -
Daniel Bevenius authored
Currently the following compiler warnings is generated: ../src/node_report.cc:778:43: warning: format specifies type 'unsigned long' but the argument has type 'rlim_t' (aka 'unsigned long long') [-Wformat] snprintf(buf, sizeof(buf), "%lu", limit.rlim_max); ~~~ ^~~~~~~~~~~~~~ %llu 1 warning generated. This commit changes the format specifier to $llu. PR-URL: https://github.com/nodejs/node/pull/25557 Reviewed-By: -
Daniel Bevenius authored
Currently, test-cli-node-print-help uses common.hasFipsCrypto to determine if the test should check for the existence of FIPS related options (--enable-fips, and --force-fips). The FIPS options are available when node has been compiled against an OpenSSL library with FIPS support in which case the test would verify that these options are available. But by using crypto.fips (which uses crypto.getFips()) this would only be checked when fips has been enabled, but these options are available regardless if FIPS is enabled or disabled. This commit updates the test to use fipsMode from config to determine if the FIPS options existence should be checked. PR-URL: https://github.com/nodejs/node/pull/25510 Reviewed-By:
-
Ruben Bridgewater authored
The fallback should only be taken for a null prototype. If an iterable data type (e.g., Array) has a prototype without `Symbol.iterator`, just try the best to visualize it as object. PR-URL: https://github.com/nodejs/node/pull/25457 Fixes: https://github.com/nodejs/node/issues/25451 Reviewed-By:
-
Anna Henningsen authored
Only use the amount of data that was actually read from the test file. Otherwise, there is a small risk of getting false positives, and generally reading uninitialized memory makes using automated memory error detection tools harder. PR-URL: https://github.com/nodejs/node/pull/25475 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
LakshmiSwethaG authored
One test per each API, so that additional tests in future are modular. test/common/report.js contain common functions that tests leverage. PR-URL: https://github.com/nodejs/node/pull/22712 Reviewed-By:
-
Vipin Menon authored
a separate section added for node-report at top level main documentation added to doc/api/report.md API documentation added to doc/api/process.md PR-URL: https://github.com/nodejs/node/pull/22712 Reviewed-By:
-
Gireesh Punathil authored
Make node-report part of core runtime because: 1. When enabled, node-report significantly helps root cause various types of problems, including support issues sent to the various repos of the Node.js organization. 2. The requirement of explicitly adding the dependency to node-report in user applications often represents a blocker to adoption. Major deviation from the module version of the node-report is that the report is generated in JSON format, as opposed to human readable text. No new functionalities have been added, changes that are required for melding it as a built-in capability has been affected on the module version of node-report (https://github.com/nodejs/node-report ) Co-authored-by:
Bidisha Pyne <bidipyne@in.ibm.com> Co-authored-by:
Howard Hellyer <hhellyer@uk.ibm.com> Co-authored-by:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Co-authored-by:
Julian Alimin <dmastag@yahoo.com> Co-authored-by:
Lakshmi Swetha Gopireddy <lakshmigopireddy@in.ibm.com> Co-authored-by:
Manusaporn Treerungroj <m.treerungroj@gmail.com> Co-authored-by:
Richard Chamberlain <richard_chamberlain@uk.ibm.com> Co-authored-by:
Vipin Menon <vipinmv1@in.ibm.com> PR-URL: https://github.com/nodejs/node/pull/22712 Reviewed-By:
-
Yael Hermon authored
This PR adds the ability to provide Workers with their own execArgv flags in replacement of the main thread's execArgv. Only per-Isolate/per-Environment options are allowed. Per-Process options and V8 flags are not allowed. Passing an empty execArgv array will reset per-Isolate and per-Environment options of the Worker to their defaults. If execArgv option is not passed, the Worker will get the same flags as the main thread. Usage example: ``` const worker = new Worker(__filename, { execArgv: ['--trace-warnings'], }); ``` PR-URL: https://github.com/nodejs/node/pull/25467 Reviewed-By: -
H1Gdev authored
PR-URL: https://github.com/nodejs/node/pull/25544 Reviewed-By:
-
Rich Trott authored
Reduce the time it takes to run test/pummel/test-hash-seed by switching from spawnSync() to spawn(). On my computer, this reduces the runtime from about 80 seconds to about 40 seconds. This test is not (yet) run regularly on CI, but when it was run recently, it timed out. PR-URL: https://github.com/nodejs/node/pull/25522 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Rich Trott authored
Replace min() function with Math.min(...). PR-URL: https://github.com/nodejs/node/pull/25522 Reviewed-By:
-
Rich Trott authored
test/pummel/test-keep-alive.js requires `wrk` to be installed. Check if it is, and skip the test if it isn't. This is yet another step in preparation for running pummel tests in CI daily. PR-URL: https://github.com/nodejs/node/pull/25516 Reviewed-By:
-
Michael Dawson authored
Fixes: https://github.com/nodejs/TSC/issues/650 PR-URL: https://github.com/nodejs/node/pull/25535 Reviewed-By:
-
cjihrig authored
Refs: https://github.com/nodejs/node/issues/25448 PR-URL: https://github.com/nodejs/node/pull/25526 Reviewed-By:
-
Michael Dawson authored
This reverts commit f216d5bb. Seems like it breaks the nightly job so reverting until we figure that out. PR-URL: https://github.com/nodejs/node/pull/25543 Reviewed-By:
-
