- Jun 24, 2016
-
-
Rod Vagg authored
This is a security release. All Node.js users should consult the security release summary at https://nodejs.org/en/blog/vulnerability/june-2016-security-releases/ for details on patched vulnerabilities. Notable changes: * libuv: (CVE-2014-9748) Fixes a bug in the read/write locks implementation for Windows XP and Windows 2003 that can lead to undefined and potentially unsafe behaviour. More information can be found at https://github.com/libuv/libuv/issues/515 or at https://nodejs.org/en/blog/vulnerability/june-2016-security-releases/. * V8: (CVE-2016-1669) Fixes a potential Buffer overflow vulnerability discovered in V8, more details can be found in the CVE at https://www.cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-1669 or at https://nodejs.org/en/blog/vulnerability/june-2016-security-releases/. PR-URL: https://github.com/nodejs/node-private/pull/53
-
Rod Vagg authored
Original commit message: unix, win: consolidate mutex trylock errors Fold EAGAIN into EBUSY, and make it the only acceptable error. PR-URL: https://github.com/libuv/libuv/pull/535 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node-private/pull/54 Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com>
-
Rod Vagg authored
Original commit message: unix: consolidate rwlock tryrdlock trywrlock errors Fold EAGAIN and EBUSY into EBUSY. This makes it consistent across all Unix platforms and Windows. Refs: https://github.com/libuv/libuv/pull/525 PR-URL: https://github.com/libuv/libuv/pull/535 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node-private/pull/54 Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com>
-
Rod Vagg authored
Original commit message: win: don't fetch function pointers to SRWLock APIs They're no longer needed, since the Windows-native SRWLock functions are no longer used. PR-URL: https://github.com/libuv/libuv/pull/525 Reviewed-By:Saúl Ibarra Corretgé <saghul@gmail.com> PR-URL: https://github.com/nodejs/node-private/pull/54 Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com>
-
Rod Vagg authored
Original commit message: win: redo/fix the uv_rwlock APIs Previously, on Windows Vista and later, we'd use the Windows native SRWLock APIs. However they turned out to be semantically incompatible with pthread read-write locks and/or plain buggy. This patch makes sure that the custom implementation that was previously only used on old Windows versions is now used everywhere. This patch fixes a number of issues with the old fallback implementation. Specifically: * The reader count would not be incremented when a thread successfully acquired a read lock while another thread *also* held a read lock. * `uv_rwlock_tryrdlock()` and `uv_rwlock_trywrlock()` now consistently return UV_EBUSY when a lock couldn't be acquired. * Any unexpected errors now cause libuv to abort, with the exception of `uv_rwlock_init()`. See also https://github.com/libuv/libuv/issues/515. PR-URL: https://github.com/libuv/libuv/pull/525 Reviewed-By:Saúl Ibarra Corretgé <saghul@gmail.com> PR-URL: https://github.com/nodejs/node-private/pull/54 Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com>
-
Rod Vagg authored
Original commit message: win: fix unsavory rwlock fallback implementation Before this patch an uv_mutex_t (backed by a critical section) could be released by a tread different from the thread that acquired it, which is not allowed. This is fixed by using a semaphore instead. Note that the affected code paths were used on Windows XP and Windows Server 2003 only. Fixes: https://github.com/libuv/libuv/issues/515 PR-URL: https://github.com/libuv/libuv/pull/516 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com> PR-URL: https://github.com/nodejs/node-private/pull/54 Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com>
-
- Jun 23, 2016
-
-
Ben Noordhuis authored
Original commit message: Fix overflow issue in Zone::New When requesting a large allocation near the end of the address space, the computation could overflow and erroneously *not* grow the Zone as required. BUG=chromium:606115 LOG=y Review-Url: https://codereview.chromium.org/1930873002 Cr-Commit-Position: refs/heads/master@{#35903} PR-URL: https://github.com/nodejs/node-private/pull/44 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Ben Noordhuis authored
Back-port commit 76f40f77 ("test: stronger crypto in test fixtures") from the master branch. Pushes back the expiration date of test/fixtures/keys/ca2-crl.pem to 2018, fixing a CRL_HAS_EXPIRED error in simple/test-tls-server-verify. Fixes: https://github.com/nodejs/node/issues/7194 PR-URL: https://github.com/nodejs/node/pull/7195 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- May 06, 2016
-
-
Rod Vagg authored
-
Rod Vagg authored
Notable changes: * npm: Correct erroneous version number in v2.15.1 code (Forrest L Norvell) https://github.com/nodejs/node/pull/5988 * openssl: Upgrade to v1.0.1t, addressing security vulnerabilities (Shigeki Ohtsu) https://github.com/nodejs/node/pull/6553 - Fixes CVE-2016-2107 "Padding oracle in AES-NI CBC MAC check" - Fixes CVE-2016-2105 "EVP_EncodeUpdate overflow" - See https://nodejs.org/en/blog/vulnerability/openssl-may-2016/ for full details
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/5988 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Forrest L Norvell authored
PR-URL: https://github.com/nodejs/node/pull/5988 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- May 05, 2016
-
-
Shigeki Ohtsu authored
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. (cherry picked from commit 9f0f7c38e6df975dd39735d0e9ef968076369c74) Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25368
-
Shigeki Ohtsu authored
Regenerate asm files with Makefile without CC and ASM envs. Fixes: https://github.com/nodejs/node/issues/6458 PR-URL: https://github.com/nodejs/node/pull/6553 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Shigeki Ohtsu authored
reapply b9106137 PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: https://github.com/joyent/node/pull/25523 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: https://github.com/joyent/node/pull/25654 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Fedor Indutny authored
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: https://github.com/joyent/node/pull/25523 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: https://github.com/joyent/node/pull/25654 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Shigeki Ohtsu authored
sha256-x86_64.pl does not exist in the origin openssl distribution. It was copied from sha512-x86_64.pl and both sha256/sha512 scripts were modified so as to generates only one asm file specified as its key hash length. PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: https://github.com/joyent/node/pull/25523 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: https://github.com/joyent/node/pull/25654 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Shigeki Ohtsu authored
All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Fixes: https://github.com/nodejs/node/issues/6458 PR-URL: https://github.com/nodejs/node/pull/6553 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Shigeki Ohtsu authored
This just replaces all sources of openssl-1.0.1t.tar.gz into deps/openssl/openssl. Fixes: https://github.com/nodejs/node/issues/6458 PR-URL: https://github.com/nodejs/node/pull/6553 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Apr 01, 2016
-
-
Rod Vagg authored
-
Rod Vagg authored
Notable changes: * npm: Upgrade to v2.15.1. Fixes a security flaw in the use of authentication tokens in HTTP requests that would allow an attacker to set up a server that could collect tokens from users of the command-line interface. Authentication tokens have previously been sent with every request made by the CLI for logged-in users, regardless of the destination of the request. This update fixes this by only including those tokens for requests made against the registry or registries used for the current install. (Forrest L Norvell) https://github.com/nodejs/node/pull/5967 * openssl: OpenSSL v1.0.1s disables the EXPORT and LOW ciphers as they are obsolete and not considered safe. This release of Node.js turns on `OPENSSL_NO_WEAK_SSL_CIPHERS` to fully disable the 27 ciphers included in these lists which can be used in SSLv3 and higher. Full details can be found in our LTS discussion on the matter (https://github.com/nodejs/LTS/issues/85). (Shigeki Ohtsu) https://github.com/nodejs/node/pull/5712 PR-URL: https://github.com/nodejs/node/pull/5967
-
Forrest L Norvell authored
PR-URL: https://github.com/nodejs/node/pull/5967
-
- Mar 17, 2016
-
-
Gibson Fahnestock authored
PR-URL: https://github.com/nodejs/node/pull/5621 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
- Mar 15, 2016
-
-
Shigeki Ohtsu authored
DES-CBC-SHA is LOW cipher and disabled by default and it is used in tests of hornorcipherorder. They are changed as to - use RC4-SHA instead of DES-CBC-SHA. - add ECDHE-RSA-AES256-SHA to entries to keep the number of ciphers. - remove tests for non-default cipher because only SEED and IDEA are available in !RC4:!HIGH:ALL. Fixes: https://github.com/nodejs/LTS/issues/85 PR-URL: https://github.com/nodejs/node/pull/5712 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Shigeki Ohtsu authored
openssl-1.0.1s disables EXPORT and LOW ciphers by default. They are obsoleted ciphers and not safe for the current use. Node LTS also deprecates them. Fixes: https://github.com/nodejs/LTS/issues/85 PR-URL: https://github.com/nodejs/node/pull/5712 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Mar 14, 2016
-
-
Michael Dawson authored
backport fix for test-http-get-pipeline-problem.js from master to 0.12.X. We've been seeing an intermittent failure in runs for zLinux with SLES 12. We confirmed that this fix resolves the issue so would like it in 0.12.X The original commit does not apply cleanly as the paths were changed, but the actual change is identical. The original commit was: https://github.com/nodejs/node/commit/3ba4f71fc4a1b3acdcaaa250bc5ba81442257e09 PR-URL: https://github.com/nodejs/node/pull/3013 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Mar 11, 2016
-
-
João Reis authored
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/5627
-
- Mar 09, 2016
-
-
Rod Vagg authored
-
- Mar 08, 2016
-
-
Rod Vagg authored
Notable changes: * openssl: Fully remove SSLv2 support, the `--enable-ssl2` command line argument will now produce an error. The DROWN Attack (https://drownattack.com/) creates a vulnerability where SSLv2 is enabled by a server, even if a client connection is not using SSLv2. The SSLv2 protocol is widely considered unacceptably broken and should not be supported. More information is available at https://www.openssl.org/news/vulnerabilities.html#2016-0800 Note that the upgrade to OpenSSL 1.0.1s in Node.js v0.12.11 removed internal SSLv2 support. The change in this release was originally intended for v0.12.11. The `--enable-ssl2` command line argument now produces an error rather than being a no-op.
-
- Mar 04, 2016
-
-
Ben Noordhuis authored
Remove support for SSLv2 because of DROWN (CVE-2016-0800). Use of the `--enable-ssl2` flag is now an error; node will print an error message and exit. PR-URL: https://github.com/nodejs/node/pull/5536 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rod Vagg authored
-
- Mar 03, 2016
-
-
Rod Vagg authored
Notable changes: * http_parser: Update to http-parser 2.3.2 to fix an unintentionally strict limitation of allowable header characters. (James M Snell) https://github.com/nodejs/node/pull/5241 * domains: - Prevent an exit due to an exception being thrown rather than emitting an 'uncaughtException' event on the `process` object when no error handler is set on the domain within which an error is thrown and an 'uncaughtException' event listener is set on `process`. (Julien Gilli) https://github.com/nodejs/node/pull/3885 - Fix an issue where the process would not abort in the proper function call if an error is thrown within a domain with no error handler and `--abort-on-uncaught-exception` is used. (Julien Gilli) https://github.com/nodejs/node/pull/3885 * openssl: Upgrade from 1.0.2f to 1.0.2g (Ben Noordhuis) https://github.com/nodejs/node/pull/5509 - Fix a double-free defect in parsing malformed DSA keys that may potentially be used for DoS or memory corruption attacks. It is likely to be very difficult to use this defect for a practical attack and is therefore considered low severity for Node.js users. More info is available at https://www.openssl.org/news/vulnerabilities.html#2016-0705 - Fix a defect that can cause memory corruption in certain very rare cases relating to the internal `BN_hex2bn()` and `BN_dec2bn()` functions. It is believed that Node.js is not invoking the code paths that use these functions so practical attacks via Node.js using this defect are _unlikely_ to be possible. More info is available at https://www.openssl.org/news/vulnerabilities.html#2016-0797 - Fix a defect that makes the CacheBleed Attack (https://ssrg.nicta.com.au/projects/TS/cachebleed/) possible. This defect enables attackers to execute side-channel attacks leading to the potential recovery of entire RSA private keys. It only affects the Intel Sandy Bridge (and possibly older) microarchitecture when using hyper-threading. Newer microarchitectures, including Haswell, are unaffected. More info is available at https://www.openssl.org/news/vulnerabilities.html#2016-0702
-
Shigeki Ohtsu authored
Doc descriptions related to SSLv2 are no longer needed. Fixes: https://github.com/nodejs/node/pull/5529 PR-URL: https://github.com/nodejs/node/pull/5541 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/5401 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
- Mar 02, 2016
-
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/5509 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Feb 24, 2016
-
-
James M Snell authored
Fixes http-parser regression with IS_HEADER_CHAR check Add test case for obstext characters (> 0x80) in header PR-URL: https://github.com/nodejs/node/pull/5241 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
- Feb 12, 2016
-
-
Rich Trott authored
It is possible that the internal handleMessage() might try to send to a channel that has been closed. The result can be an AssertionError. Guard against this. Fixes: https://github.com/nodejs/node/issues/4205 PR-URL: https://github.com/nodejs/node/pull/5153 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rich Trott authored
It is possible to cause a resource leak in SharedHandle. This commit fixes the leak. Fixes: https://github.com/nodejs/node/issues/2510 PR-URL: https://github.com/nodejs/node/pull/5152 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Brian White authored
This commit prevents child process stdio streams from being automatically flushed on child process exit/close if a 'readable' event handler has been attached at the time of exit. Without this, child process stdio data can be lost if the process exits quickly and a `read()` (e.g. from a 'readable' handler) hasn't had the chance to get called yet. Fixes: https://github.com/nodejs/node/issues/5034 PR-URL: https://github.com/nodejs/node/pull/5037 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Julien Gilli authored
Fix node exiting due to an exception being thrown rather than emitting an 'uncaughtException' event on the process object when: 1. no error handler is set on the domain within which an error is thrown 2. an 'uncaughtException' event listener is set on the process Also fix an issue where the process would not abort in the proper function call if an error is thrown within a domain with no error handler and --abort-on-uncaught-exception is used. Fixes #3607 and #3653. PR: #3885 PR-URL: https://github.com/nodejs/node/pull/3885 Reviewed-By:
James M Snell <jasnell@gmail.com>
-