- Dec 24, 2016
-
-
Rico Cai authored
convert var to const PR-URL: https://github.com/nodejs/node/pull/9953 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Segu Riluvan authored
Use assert.strictEqual instead of assert.equal and assert.ok PR-URL: https://github.com/nodejs/node/pull/10420 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Wallace Zhang authored
Add a RegExp as a second argument to assert.throws(). PR-URL: https://github.com/nodejs/node/pull/10058 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/10390 Reviewed-By:
Julian Duque <julianduquej@gmail.com> Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
-
larissayvette authored
PR-URL: https://github.com/nodejs/node/pull/10417 Reviewed-By:
-
Troy Connor authored
Add configuration object createBenchmark object for buffer size & iteration in buffer-base64-encode & buffer-base64-decode.js. PR-URL: https://github.com/nodejs/node/pull/10175 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Myles Borins authored
Follow up from 8eb19c48. Lower case `return` was not updated PR-URL: https://github.com/nodejs/node/pull/10391 Ref: https://github.com/nodejs/node/pull/9554 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
- Dec 23, 2016
-
-
Adrian Estrada authored
* use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: https://github.com/nodejs/node/pull/10396 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
1. Lot of repeating code has been refactored to a function 2. Errors in async calls are properly asserted 3. Fail the test if the callbacks are not fired PR-URL: https://github.com/nodejs/node/pull/10384 Reviewed-By:
-
sivaprasanna authored
* used let and const instead of var * used assert.strictEqual instead assert.equal PR-URL: https://github.com/nodejs/node/pull/10357 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Vicente Jimenez Aguilar authored
Change a single word in documentation with a more precise one. Native is a module compiled in machine "native" code. A module normally written in a compiled language, not in JavaScript. Core modules form Node's built-in "core" functionalities. You don't need to install them. They are included in every Node installation and documented in https://nodejs.org/api/ . PR-URL: https://github.com/nodejs/node/pull/10324 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Chase Starr authored
`./tools/macosx-firewall.sh` fails if run before build step. Since the suggestion comes before the build steps in the document, this change clarifies that the script should be run after building. PR-URL: https://github.com/nodejs/node/pull/10311 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Adrian Estrada authored
* use common.mustCall to control the functions execution automatically * use const instead of var * use assert.strictEqual instead assert.equal * use assert.ifError instead of throw error PR-URL: https://github.com/nodejs/node/pull/10297 Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com> Reviewed-By:
-
Adrian Estrada authored
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal PR-URL: https://github.com/nodejs/node/pull/10318 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Evan Lucas authored
Previously, autocompletion of scoped packages was not supported by the repl due to not including the `@` character in the regular expression. PR-URL: https://github.com/nodejs/node/pull/10296 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
test-whatwg-url-parsing file violates the linter rule changes in https://github.com/nodejs/node/pull/10213. This patch makes the linter happy. PR-URL: https://github.com/nodejs/node/pull/10421 Reviewed-By:
-
Michaël Zasso authored
This is to be consistent with the other operators and helps understanding the context when the code is grepped. PR-URL: https://github.com/nodejs/node/pull/10213 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
-
Daniel Sims authored
In this test, I changed the var declarations to be either a let or a const. For some of the callbacks, I added a mustCall check to ensure that the functions have run. I also changed assert.equal() to assert.strictEqual(). PR-URL: https://github.com/nodejs/node/pull/9962 Reviewed-By:
-
Bartosz Sosnowski authored
Adds flags that marks WinCtrlCHandlerRoutine as disabled instead of removing it. Trying to remove the controller from the controller handle itself leads to deadlock. PR-URL: https://github.com/nodejs/node/pull/10248 Reviewed-By:
-
Avery, Frank authored
In this change, I've added the regex pattern to the assert.throws() in order to provide the validation argument for the call. PR-URL: https://github.com/nodejs/node/pull/9918 Reviewed-By:
-
Christopher Rokita authored
- Using assert.strictEqual instead assert.equal PR-URL: https://github.com/nodejs/node/pull/9956 Reviewed-By:
-
Travis Bretton authored
- Updated assert.equal to assert.strictEqual - Updated 'var' to 'const' - Using template literals PR-URL: https://github.com/nodejs/node/pull/10036 Reviewed-By:
-
Emanuel Buholzer authored
- var -> const where possible - assert.equal -> assert.strictEqual - passed the setTimeout function a second parameter for readability - used assert.strictEqual for assert(!c) as it is expected to be 0 and not some other value PR-URL: https://github.com/nodejs/node/pull/10321 Reviewed-By:
-
Kevin Zurawel authored
This commit adds a description of `process.versions.modules`, based on the comment in `src/node_version.h` lines 47-50. PR-URL: https://github.com/nodejs/node/pull/9901 Reviewed-By:
-
Rich Trott authored
test-timers-same-timeout-wrong-list-deleted was flaky under load because there is no guarantee that a timer will fire within a given period of time. It had an exit handler that checked that the process was finishing in less than twice as much as a timer was set for. Under load, the timer could take over 200ms to fire even if it was set for 100ms, so this was causing the test to be flaky on CI from time to time. However, that timing check is unnecessary to identify the regression that the test was written for. When run with a version of Node.js that does not contain the fix that accompanied the test in its initial commit, an assertion indicating that there were still timers in the active timer list fired. So, this commit removes the exit handler timing check and relies on the existing robust active timers list length check. This allows us to move the test back to parallel because it does not seem to fail under load anymore. The test was refactored slightly, removing duplicated code to a function, using `assert.strictEqual()` instead of `assert.equal()`, changing a 10ms timer to 1ms, and improving the messages provided by assertions. Fixes: https://github.com/nodejs/node/issues/8459 PR-URL: https://github.com/nodejs/node/pull/10362 Reviewed-By:
-
Rich Trott authored
* add duration to setTimeout() * assert.equal() -> assert.strictEqual() * remove unused function arguments * normalize indentation PR-URL: https://github.com/nodejs/node/pull/10353 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Roman Reiss authored
- add missing environment variables to --help - add missing flags to man page - sort environment variables alphabetically - add some highlighting to the man page - remove stops from descriptions in --help for consistency - few other minor tweaks to --help PR-URL: https://github.com/nodejs/node/pull/10157 Reviewed-By:
-
- Dec 22, 2016
-
-
Joyee Cheung authored
Adds/mentions: - Link to glossary - Commit squashing and CI run - 48/72 hour wait and PR review feature - Extra notes section - "Landed in <sha>" comment PR-URL: https://github.com/nodejs/node/pull/10202 Ref: https://github.com/nodejs/node/pull/10151 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Trevor Norris authored
After processing all the callbacks in the destroy_ids vector make sure to clear() it otherwise the DestroyIdsCb() won't run again. PR-URL: https://github.com/nodejs/node/pull/10400 Fixes: b49b496a "async_wrap: call destroy() callback in uv_idle_t" Reviewed-By:
-
Vse Mozhet Byt authored
- Fixes https://github.com/nodejs/node/issues/10255 - It also will be consistent with a previous code example. - `cluster.workers` iteration: `Object.keys().forEach` -> `for`...`in` PR-URL: https://github.com/nodejs/node/pull/10270 Reviewed-By:
-
Joyee Cheung authored
The original test lauches 10 child processes at once and bypass `test.py`'s process regulation. This PR reduces the unmanaged parallelism and is a temporary workaround for #9979 (not a real fix). PR-URL: https://github.com/nodejs/node/pull/10329 Reviewed-By:
-
Richard Karmazin authored
* var -> const, let * assert.equal() -> assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/9948 Reviewed-By:
-
Segu Riluvan authored
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: https://github.com/nodejs/node/pull/10047 Reviewed-By:
-
Jason Wohlgemuth authored
change equal to strictEqual and var to const PR-URL: https://github.com/nodejs/node/pull/9941 Reviewed-By:
-
Ashita Nagesh authored
PR-URL: https://github.com/nodejs/node/pull/9988 Reviewed-By:
-
Sam Shull authored
Creating a buffer from a number should throw an error with a message that describes the issue. PR-URL: https://github.com/nodejs/node/pull/10038 Reviewed-By:
-
Adrian Estrada authored
* use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: https://github.com/nodejs/node/pull/10350 Reviewed-By:
-
CodeVana authored
Use assert.strictEqual instead of assert.equal. PR-URL: https://github.com/nodejs/node/pull/9950 Reviewed-By:
-
Neeraj Sharma authored
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was used. This commit changes use of assert.equal to assert.strictEqual. PR-URL: https://github.com/nodejs/node/pull/9952 Reviewed-By:
-
Duy Le authored
* var -> const/let * assert.equal() -> assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/9903 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
