- Mar 06, 2018
-
-
Joyee Cheung authored
- Moves the creation of `process.binding()`, `process._linkedBinding()` `internalBinding()` and `NativeModule` into a separate file `lib/internal/bootstrap_loaders.js`, and documents them there. This file will be compiled and run before `bootstrap_node.js`, which means we now bootstrap the internal module & binding system before actually bootstrapping Node.js. - Rename the special ID that can be used to require `NativeModule` as `internal/bootstrap_loaders` since it is setup there. Also put `internalBinding` in the object exported by `NativeModule.require` instead of putting it inside the `NativeModule.wrapper` - Use the original `getBinding()` to get the source code of native modules instead of getting it from `process.binding('native')` so that users cannot fake native modules by modifying the binding object. - Names the bootstrapping functions so their names show up in the stack trace. PR-URL: https://github.com/nodejs/node/pull/19112 Reviewed-By:Anna Henningsen <anna@addaleax.net> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
Matteo Collina authored
See: https://github.com/nodejs/node/pull/18438 PR-URL: https://github.com/nodejs/node/pull/19169 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Mathias Buus authored
This improves error handling for streams in a few ways. 1. It ensures that no user defined methods (_read, _write, ...) are run after .destroy has been called. 2. It introduces an explicit error to tell the user if they are write to write, etc to the stream after it has been destroyed. 3. It makes streams always emit close as the last thing after they have been destroyed 4. Changes the default _destroy to not gracefully end streams. It also updates net, http2, zlib and fs to the new error handling. PR-URL: https://github.com/nodejs/node/pull/18438 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
Currently test-http2-client-write-empty-string.js will throw "Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support" when configured --without-ssl. This commit moves the require of http2 to after the crypto check to avoid this error. PR-URL: https://github.com/nodejs/node/pull/19111 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Jon Moss <me@jonathanmoss.me>
-
Ben Noordhuis authored
Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument. PR-URL: https://github.com/nodejs/node/pull/19087 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19087 Reviewed-By:
-
Rich Trott authored
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: https://github.com/nodejs/node/pull/19125 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com>
-
Rich Trott authored
There are some uses of "in general" that are unnecessary. (We don't need to be tentative about the fact that tests should pass, for example.) PR-URL: https://github.com/nodejs/node/pull/19123 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Rich Trott authored
Update default files to be linted with ESLint to include .eslintrc.js. PR-URL: https://github.com/nodejs/node/pull/19122 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/19099 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Sarat Addepalli authored
PR-URL: https://github.com/nodejs/node/pull/19088 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
Allow users to switch to the table of contents for older versions of Node.js. This gets rid of the "Failed to add alternative version link" warnings when building docs. PR-URL: https://github.com/nodejs/node/pull/19113 Reviewed-By:
-
Jakob Kummerow authored
Original commit message: Introduce --disallow-code-generation-from-strings Exposing the existing Context::AllowCodeGenerationFromStrings(false) API to the command line. Bug: v8:7134 Change-Id: I062ccff0b03c5bcf6878c41c455c0ded37a1d743 Reviewed-on: https://chromium-review.googlesource.com/809631 Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49911} PR-URL: https://github.com/nodejs/node/pull/18212 Refs: https://github.com/v8/v8/commit/0bcb1d6f2de9b278b1de7de1b5333e7f47fdce8e Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Rich Trott authored
I have never found it useful that the ESLint rules (in the configuration file) are organized by the categorization the rules are given in the ESLint documentation. It has only been a source of annoyance as one has to look up where the rule is in the docs to figure out where it should go in the configuration file. This change re-orders the rules so they are in alphabetical order. Simple! PR-URL: https://github.com/nodejs/node/pull/19100 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Michael Dawson authored
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: https://github.com/nodejs/node/pull/19098 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
punteek authored
Added a simple example showing how to rename a file. Refs: https://github.com/nodejs/node/issues11135 PR-URL: https://github.com/nodejs/node/pull/18812 Reviewed-By:
-
Michaël Zasso authored
This is a first batch of updates that touches non-underscored modules in lib. PR-URL: https://github.com/nodejs/node/pull/19034 Reviewed-By:
-
Bradley Farias authored
ensures that instantiation result is only used during initial loading PR-URL: https://github.com/nodejs/node/pull/18965 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/18415 PR-URL: https://github.com/nodejs/node/pull/19149 Reviewed-By:
-
Anna Henningsen authored
Provide public APIs for native typechecking that is actually useful. The motivation for this is providing alternatives to userland modules that would currently rely on `process.binding('util')`. PR-URL: https://github.com/nodejs/node/pull/18415 Reviewed-By:Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/18415 Reviewed-By:
-
Michael Dawson authored
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: https://github.com/nodejs/node/pull/19094 Reviewed-By:
-
- Mar 05, 2018
-
-
Yuta Hiroto authored
PR-URL: https://github.com/nodejs/node/pull/19056 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/18852 Reviewed-By:
-
Anna Henningsen authored
This might otherwise result in a hard crash when trying to write to a socket after a sudden disconnect. Note that the test here uses an aborted `h2load` run to create the failing requests; That’s far from ideal, but it provides a reasonably reliably reproduction at this point. PR-URL: https://github.com/nodejs/node/pull/18987 Fixes: https://github.com/nodejs/node/issues/18973 Reviewed-By:
-
Anna Henningsen authored
Make the script not error out immediately because of a missing pseudo-global. (Note that it seems like tests are still broken on `master`.) PR-URL: https://github.com/nodejs/node/pull/19059 Fixes: https://github.com/nodejs/node/issues/19044 Refs: https://github.com/nodejs/node/pull/18623 Reviewed-By:
-
Anna Henningsen authored
This is pretty useful when trying to inspect the last error caught by a REPL, and is made to be analogous to `_`, which contains the last successful completion value. PR-URL: https://github.com/nodejs/node/pull/18919 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Emit the `TimeoutOverflowWarning` synchronously, even when still connecting, to get a better stack trace. With thanks to Anatoli Papirovski for providing helpful tips when writing the test. PR-URL: https://github.com/nodejs/node/pull/18906 Reviewed-By:
-
Gabriel Schulhof authored
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. PR-URL: https://github.com/nodejs/node/pull/19086 Reviewed-By:
-
Anna Henningsen authored
Show the stack trace for the `eventemitter.emit('error')` call in the case of an uncaught exception. Previously, there would be no clue in Node’s output about where the actual `throw` comes from. PR-URL: https://github.com/nodejs/node/pull/19003 Reviewed-By:
-
- Mar 04, 2018
-
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18746 Reviewed-By:
-
Anna Henningsen authored
Display the constant name instead of a stream error code in the error message, because the numerical codes give absolutely no clue about what happened when an error is emitted. PR-URL: https://github.com/nodejs/node/pull/18966 Reviewed-By:
-
Luigi Pinca authored
The listener does not do anything if `allowHalfOpen` is enabled. Add it only when `allowHalfOpen` is disabled. PR-URL: https://github.com/nodejs/node/pull/18953 Reviewed-By:
-
Anna Henningsen authored
This fixes a crash that occurred when a `Http2Stream` write is completed after it is already destroyed. Instead, don’t destroy the stream in that case and wait for GC to take over. PR-URL: https://github.com/nodejs/node/pull/19002 Fixes: https://github.com/nodejs/node/issues/18973 Reviewed-By:
-
Trivikram authored
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError PR-URL: https://github.com/nodejs/node/pull/19061 Fixes: https://github.com/nodejs/node/issues/18855 Reviewed-By:
-
Ben Noordhuis authored
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: https://github.com/nodejs/node/pull/19046 Fixes: https://github.com/nodejs/node/issues/18983 Reviewed-By:
-
Сковорода Никита Андреевич authored
For tests / benchmarks that are creating Buffer instances for any reason other than to test Buffer constructor, use the new Buffer.alloc/Buffer.from API instead of the deprecated API. PR-URL: https://github.com/nodejs/node/pull/18980 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Zeke Sikelianos authored
PR-URL: https://github.com/nodejs/node/pull/18888 Fixes: https://github.com/nodejs/node/issues/18887 Reviewed-By:
-
Santiago Gimeno authored
So it does not use `common.PORT` anymore. PR-URL: https://github.com/nodejs/node/pull/18727 Reviewed-By:
-
Anna Henningsen authored
The error emitted when a connection is closed before the TLS handshake completes seemed rather unspefic by just saying `socket hang up`. Use a more verbose message, that also indicates that this is a purely client-side error, and remove a misleading comment. PR-URL: https://github.com/nodejs/node/pull/18989 Reviewed-By:
-
