- Sep 08, 2015
-
-
Karl Skomski authored
It was previously ignored by features.gypi and therefore enabled by default for release builds. See https://code.google.com/p/chromium/issues/detail?id=318206 PR-URL: https://github.com/nodejs/node/pull/2731 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2737 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Fedor Indutny authored
This a backport of the following commits from the v8's upstream: * 1a8c38c50513f9af07ada479629a653e1cf36ff3 * 206f12abee3f1e7eda8fc6521d48f3c319460ee1 * 9e3676da9ab1aaf7de3e8582cb3fdefcc3dbaf33 Original commit message: heap: make array buffer maps disjoint Remove intersection from the `std::map`s representing current live ArrayBuffers. While being simpler to understand, it poses significant performance issue for the active ArrayBuffer users (like node.js). Store buffers separately, and process them together during mark-sweep phase. The results of benchmarks are: $ ./node-slow bench && ./node-fast bench 4997.4 ns/op 4685.7 ns/op NOTE: `fast` - was a patched node.js, `slow` - unpatched node.js with vanilla v8. PR-URL: https://github.com/nodejs/node/pull/2732 Reviewed-By:Rod Vagg <rod@vagg.org> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Fedor Indutny authored
Allow listening on reused dgram ports in cluster workers. Fix: https://github.com/joyent/node/issues/9261 PR-URL: https://github.com/nodejs/node/pull/2548 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2717 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Rod Vagg authored
* support process.release * support all io.js versions * support node v4+ including new download locations * enable delay-load hook by default by default * download header-only tarballs instead of full source See https://github.com/nodejs/node-gyp/pull/711 for full details PR-URL: https://github.com/nodejs/node/pull/2700 Reviewed-By:
Forrest L Norvell <forrest@npmjs.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2699 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
Evan Lucas authored
Previously, in _validateStdio we were using stdio.fd || stdio. If stdio.fd was falsy (or 0 in the case of stdin), then the entire stdio object would be passed which could cause a crash. Fixes: https://github.com/nodejs/node/issues/2721 PR-URL: https://github.com/nodejs/node/pull/2727 Reviewed-By:
silverwind - Roman Reiss <me@silverwind.io> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
indutny - Fedor Indutny <fedor.indutny@gmail.com>
-
Ben Noordhuis authored
It was pointed out by Zhou Ran that the Windows XP implementation of uv_rwlock_rdlock() and friends may unlock the inner write mutex on a different thread than the one that locked it, resulting in undefined behavior. The only place that uses rwlocks is the crypto module. Make that use normal (simple) mutexes instead. OpenSSL's critical sections are generally very short, with exclusive access outnumbering shared access by a factor of three or more, so it's not as if using rwlocks gives a decisive performance advantage. PR-URL: https://github.com/nodejs/node/pull/2723 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Sep 07, 2015
-
-
Rod Vagg authored
Update AUTHORS list using tools/update-authors.sh
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2701 Reviewed-By:
Joao Reis <reis@janeasystems.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
- Sep 06, 2015
-
-
Ben Noordhuis authored
cpplint uses the top-level .git directory to determine what the root is for #include guards. If it doesn't find a .git directory, it walks up all the way to the system root and subsequently complains that guards must be written as HOME_USER_SRC_NODE_SRC_FILENAME_H_. This commit replaces the .git-based path munging with a fixed root path relative to the location of the cpplint script, making it possible to successfully run `make test` from an extracted tarball. Fixes: https://github.com/nodejs/node/issues/2693 PR-URL: https://github.com/nodejs/node/pull/2710 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Kat Marchán authored
This patch should make the tests pass on the downstreamed npm. PR-URL: https://github.com/nodejs/node/pull/2696 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/2696 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
saper authored
Note: When this was cherry-picked for v8 v4.4 (landed in nodejs#2636), test-heap.cc:1989 chunk did not exist. It now exists in v8 v4.5.103.30. This PR completes the cherry pick of the whole commit from v8. PR-URL: https://github.com/nodejs/node/pull/2692 Reviewed-By:
ofrobots - Ali Ijaz Sheikh <ofrobots@google.com> Original commit message: Use static_cast<> for NULL (clang 3.7) The following errors come up when compiling v8 with clang 3.7 on FreeBSD/amd64: src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Smi *' is not allowed local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:131:20: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Object *' is not allowed Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from 'nullptr_t' to 'Address' (aka 'unsigned char *') is not allowed Address base = reinterpret_cast<Address>(NULL); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +add myself to the AUTHORS file. BUG= Review URL: https://codereview.chromium.org/1277353002 Cr-Commit-Position: refs/heads/master@{#30103}
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2687 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2674 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Roman Reiss authored
- Added NODE_REPL_HISTORY to the environment variables in the --help and made all descriptions start with lower case for consistency. - Added NODE_REPL_HISTORY and NODE_ICU_DATA to the man page. PR-URL: https://github.com/nodejs/node/pull/2690 Reviewed-By:
fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
evanlucas - Evan Lucas <evanlucas@me.com>
-
Karl Skomski authored
The version used before returned -1 on truncation which does not conform to the standard. PR-URL: https://github.com/nodejs/node/pull/2404 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Karl Skomski authored
Long exception lines resulted in a stack buffer overflow or assertion because it was assumed snprintf not counts discarded chars or the assertion itself was incorrect: `(off) >= sizeof(arrow)` PR-URL: https://github.com/nodejs/node/pull/2404 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Sakthipriyan Vairamani authored
Recursive file watching is supported by libuv since 1.7.0. Refer https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L126. This patch notes that in the docs and enables testing this feature. It also adds proper TAP plugin parsable message for other platforms. PR-URL: https://github.com/nodejs/node/pull/2649 Fixes: https://github.com/nodejs/node/issues/375 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
silverwind - Roman Reiss <me@silverwind.io>
-
Michaël Zasso authored
Fixes a regression that appeared with the new Buffer implementation in v3. Without this change, calling the SlowBuffer constructor with something else than a number would abort on the C++ side. This makes sure that the length argument is coerced to number or is 0. Fixes: https://github.com/nodejs/node/issues/2634 PR-URL: https://github.com/nodejs/node/pull/2635 Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2685 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Ali Ijaz Sheikh authored
Pick up https://github.com/v8/v8-git-mirror/commit/f9a0a1636a4623a5522c33674e110b346d085340 Commit log at https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 PR-URL: https://github.com/nodejs/node/pull/2632 Reviewed-By:
targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org>
-
Michaël Zasso authored
Ref: https://github.com/nodejs/node/issues/1376 Ref: https://github.com/nodejs/node/pull/1398 Issue fixed in V8: https://chromium.googlesource.com/v8/v8/+/81703350bbb9923d211fe5b79e90bd458b0916e2 V8-Bug: https://code.google.com/p/v8/issues/detail?id=4019 PR-URL: https://github.com/nodejs/node/pull/2592 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Ali Ijaz Sheikh authored
The flag is no longer supported by V8 4.5, and the original issue [1] on ARMv6 no longer manifests with (at least) 4.5.103.20. [1] See https://code.google.com/p/v8/issues/detail?id=4338 PR-URL: https://github.com/nodejs/node/pull/2509 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Michaël Zasso authored
v8::Handle is deprecated: https://codereview.chromium.org/1224623004 PR-URL: https://github.com/nodejs/io.js/pull/2202 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ben Noordhuis authored
Turn on V8 API deprecation warnings. Fix up the no-arg Isolate::New() calls in src/node.cc and src/debug-agent.cc. PR-URL: https://github.com/nodejs/io.js/pull/2091 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ali Ijaz Sheikh authored
The list of Array properties needed to be updated to match the new ones added in V8 4.5. PR-URL: https://github.com/nodejs/node/pull/2509 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Fedor Indutny authored
The `context_` is not initialized until the `CreateV8Context` will return. Make sure that it will be empty (by moving away initialization from constructor) at start, and ignore getter callbacks until it will have some value. PR-URL: https://github.com/nodejs/io.js/pull/2091 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ali Ijaz Sheikh authored
Apply the src/node_contextify.cc and lib/module.js fixups from @bnoordhuis https://github.com/nodejs/node/commit/41e63fb088a29fa05e16fb0d997255678134c043 PR-URL: https://github.com/nodejs/node/pull/2509 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ali Ijaz Sheikh authored
Upgrade to the latest branch-head for V8 4.5. For the full commit log see https://github.com/v8/v8-git-mirror/commits/4.5.103.24 PR-URL: https://github.com/nodejs/node/pull/2509 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Jeremiah Senkpiel authored
Now parts of our public and public-ish APIs fall back to old-style listenerCount() if the emitter does not have a listenerCount function. Fixes: https://github.com/nodejs/node/issues/2655 Refs: 8f58fb92 PR-URL: https://github.com/nodejs/node/pull/2661 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Karl Skomski authored
PR-URL: https://github.com/nodejs/node/pull/2376 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
James M Snell authored
Port of joyent/node commits: * https://github.com/nodejs/node-v0.x-archive/commit/e17c5a72b23f920f291d61f2780068c18768cb92 * https://github.com/nodejs/node-v0.x-archive/commit/70dafa7b624abd43432e03304d65cc527fbecc11 Pull over test-child-process-spawn-typeerror.js from v0.12, replacing the existing test in master. The new test includes a broader set of tests on the various arg choices and throws. Reviewed-By:
trevnorris - Trevor Norris <trevnorris@nodejs.org> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani PR-URL: https://github.com/nodejs/node/pull/2667 Fixes: https://github.com/nodejs/node/issues/2515
-
Rich Trott authored
This retains the key elements of test-child-process-fork-getconnections (forks a child process, sends a bunch of sockets, uses getConnections() to enumerate them) but contains some code to work around an apparent intermittent bug that occurs on OS X where a socket seems to close itself unexpectedly. https://github.com/nodejs/node/issues/2610 was opened for the bug that was causing the problem in the first place. PR-URL: https://github.com/nodejs/node/pull/2609 Fixes: https://github.com/nodejs/node/issues/1100 Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com>
-
Jeremiah Senkpiel authored
Fixes: https://github.com/nodejs/node/issues/2113 Ref: 17a379ec PR-URL: https://github.com/nodejs/node/pull/2605 Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
mscdex - Brian White <mscdex@mscdex.net>
-
Johan Bergström authored
Fixes: https://github.com/nodejs/node/issues/1972 PR-URL: https://github.com/nodejs/node/pull/2322 Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Alexis Campailla authored
This test has failed recently during a PR test in Jenkins, for reasons seemingly not related to the change in the PR. PR-URL: https://github.com/nodejs/node/pull/2648 Reviewed-By:
evanlucas - Evan Lucas <evanlucas@me.com>
-
Ben Noordhuis authored
Add an optional callback parameter to `ChildProcess.prototype.send()` that is invoked when the message has been sent. Juggle the control channel's reference count so that in-flight messages keep the event loop (and therefore the process) alive until they have been sent. `ChildProcess.prototype.send()` and `process.send()` used to operate synchronously but became asynchronous in commit libuv/libuv@393c1c5 ("unix: set non-block mode in uv_{pipe,tcp,udp}_open"), which landed in io.js in commit 07bd05ba ("deps: update libuv to 1.2.1"). Fixes: https://github.com/nodejs/node/issues/760 PR-URL: https://github.com/nodejs/node/pull/2620 Reviewed-By:trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com>
-