- Oct 03, 2016
-
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/8878 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Ben Noordhuis authored
ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: https://github.com/nodejs/node/issues/8867 PR-URL: https://github.com/nodejs/node/pull/8886 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
-
Bryan English authored
The comment here was misleading, implying that the property was being copied as a read-only, when in fact it's just a shallow copy. This serves the purpose of providing the array for introspection, but it isn't read-only. PR-URL: https://github.com/nodejs/node/pull/8887 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/8890 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/8877 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Franziska Hinkelmann authored
Refactor various functions that read values from the contextify options object. Rather than passing args and the index, pass the value at that index. We use env->isolate() rather than args.GetIsolate(), but since env was constructed from args, this is the same isolate. PR-URL: https://github.com/nodejs/node/pull/8850 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Clean up test-timers-immediate. Use of `let` also requires a tweak to ESLint rules (but it's one that we should do as timers is pretty much the reason it exists). PR-URL: https://github.com/nodejs/node/pull/8857 Reviewed-By:
-
Daniel Stenberg authored
Incorrect string length calculation when passing escaped dot. - CVE: CVE-2016-5180 - Upstream bug: https://c-ares.haxx.se/adv_20160929.html PR-URL: https://github.com/nodejs/node/pull/8849 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
- Oct 02, 2016
-
-
Daniel Bevenius authored
Currently the readable and writable arguments are not specified in the req.oncomplete method. Adding and asserting that they are always true (which is always the case for TCP). This might seem unnecessary but it can't hurt to have them to pickup any breaking modifications made to ConnectionWrap::AfterConnect in the future. PR-URL: https://github.com/nodejs/node/pull/8815 Reviewed-By:
-
- Oct 01, 2016
-
-
Brian White authored
This commit improves timers performance by making functions inlineable and avoiding the creation of extra closures/functions. This commit also makes setTimeout/Interval argument handling consistent with that of setImmediate. These changes give ~22% improvement in the existing 'breadth' timers benchmark. PR-URL: https://github.com/nodejs/node/pull/8661 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Mike Woods authored
Replaced `==` with `=== Replaced `indexOf(...) !== -1` with `includes()` PR-URL: https://github.com/nodejs/node/pull/8761 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Madhav Gharmalkar authored
In e26622bd, a comment was incorrectly moved from the code it was describing. Fixes: https://github.com/nodejs/node/issues/8856 PR-URL: https://github.com/nodejs/node/pull/8860 Reviewed-By:
-
Daniel Bevenius authored
The list.length argument is missing from the comment and just adding this for clarity. PR-URL: https://github.com/nodejs/node/pull/8816 Reviewed-By:
-
Lydia Kats authored
Changed `var` to `const`, strings to template literals, and assert.equal to assert.strictEqual where appropriate. PR-URL: https://github.com/nodejs/node/pull/8841 Reviewed-By:
-
Lydia Kats authored
These were missed from 52bae222 PR-URL: https://github.com/nodejs/node/pull/8841 Reviewed-By:
-
Italo A. Casas authored
PR-URL: https://github.com/nodejs/node/pull/8778 Ref: https://github.com/nodejs/node/issues/8686 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
- Sep 30, 2016
-
-
Franziska Hinkelmann authored
Add example to show what running Node.js with `--inspect` should look like. Some IDEs do not show the link when running with `--inspect`. This example hints to what the full output looks like. PR-URL: https://github.com/nodejs/node/pull/8845 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Bartosz Sosnowski authored
This adds note to README.md about Unix tools being required by some benchmarks PR-URL: https://github.com/nodejs/node/pull/8788 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Franziska Hinkelmann authored
PR-URL: https://github.com/nodejs/node/pull/8826 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Reintroduce a realpath cache with the same mechanisms which existed before b488b19e (`fs: optimize realpath using uv_fs_realpath()`), but only for the synchronous version and with the cache being passed as a hidden option to make sure it is only used internally. The cache is hidden from userland applications because it has been decided that fully reintroducing as part of the public API might stand in the way of future optimizations. PR-URL: https://github.com/nodejs/node/pull/8100 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
yorkie authored
PR-URL: https://github.com/nodejs/node/pull/8800 Reviewed-By:
-
Italo A. Casas authored
Improve message when tranform._transform() method is not implemented Improve error message when Readable._read() is not implemented Remove extra word in err msg when Writable._write() when not implemented Remove extra word in err msg when Transform._transform() when not implemented PR-URL: https://github.com/nodejs/node/pull/8801 Reviewed-By:
-
- Sep 29, 2016
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/8835 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Myles Borins authored
When V8 was updated on master to 5.4 there were ABI breaking changes. In the past we have not landed these types of changes before a release, and as such have only bumped the NODE_MODULE_VERSION number in the release commit. Since we are going to be keeping the V8 5.4 beta on master and in the v7 betas I think it makes sense for us to bump the module number prior to a release commit being made. It is possible that this commit should be reverted prior to v7.0.0 being cut. Alternatively we may want to modify our release process for V8 to include a NODE_MODULE_VERSION bump before landing on master when applicable. NODE_MODULE_VERSION is being bumped to 51 instead of 49 to avoid conflicts with NODE_MODULE_VERSIONs being used in electron. Ref: https://github.com/electron/electron/issues/5851#issuecomment-246920775 Ref: https://github.com/nodejs/node/pull/8317 PR-URL: https://github.com/nodejs/node/pull/8808 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
-
Jeremiah Senkpiel authored
This test was recently (at the time of writing) introduced in 151d316b and could be cleaned up a bit. Refs: https://github.com/nodejs/node/pull/7602 PR-URL: https://github.com/nodejs/node/pull/7773 Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Call `v8::Isolate::GetCurrent()->LowMemoryNotification()` when an allocation fails to give V8 a chance to clean up and return memory before retrying (and possibly giving up). PR-URL: https://github.com/nodejs/node/pull/8482 Reviewed-By:
-
Anna Henningsen authored
Provide shortcut `node::CheckedMalloc()` and friends that replace `node::Malloc()` + `CHECK_NE(·, nullptr);` combinations in a few places. PR-URL: https://github.com/nodejs/node/pull/8482 Reviewed-By:
-
Anna Henningsen authored
Pass the desired return type directly to the allocation functions, so that the resulting `static_cast` from `void*` becomes unneccessary and the return type can be use as a reasonable default value for the `size` parameter. PR-URL: https://github.com/nodejs/node/pull/8482 Reviewed-By:
-
Anna Henningsen authored
Adds an optional second parameter to `node::Malloc()` and an optional third parameter to `node::Realloc()` giving the size/number of items to be allocated, in the style of `calloc(3)`. Use a proper overflow check using division; the previous `CHECK_GE(n * size, n);` would not detect all cases of overflow (e.g. `size == SIZE_MAX / 2 && n == 3`). PR-URL: https://github.com/nodejs/node/pull/8482 Reviewed-By:
-
Akito Ito authored
Refactored test: - 'var' to 'const' - functon to arrow function - using common.mustCall() and common.fail() PR-URL: https://github.com/nodejs/node/pull/8586 Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By:
-
Luigi Pinca authored
Specify that commit subject line must be made of only lowercase words and should start with an imperative verb. PR-URL: https://github.com/nodejs/node/pull/8546 Reviewed-By:
-
Rich Trott authored
In the onboarding document, add a note to ask the new Collaborator if they are using two-factor authentication on their GitHub account. If they are not, suggest that they enable it as their account will have elevated privileges in many of the Node.js repositories. PR-URL: https://github.com/nodejs/node/pull/8776 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By:
-
Rich Trott authored
Include information on how to force push to the contributor's own branch so that pull requests show as merged in GitHub interface. PR-URL: https://github.com/nodejs/node/pull/8774 Reviewed-By:
-
Richard Hong authored
replace indexOf with includes replace assert.equal with assert.strictEqual add common.mustCall replace throw error with assert.ifError PR-URL: https://github.com/nodejs/node/pull/8766 Reviewed-By:
-
Christopher Fujino authored
Updated BUILDING.md, removing workaround for Python conflicts that didn't work. PR-URL: https://github.com/nodejs/node/pull/8763 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
-
- Sep 28, 2016
-
-
Ben Noordhuis authored
Rename CHECK_NOT_OOB() to THROW_AND_RETURN_IF_OOB() because the old name suggests it asserts and aborts when it is really a control flow macro. PR-URL: https://github.com/nodejs/node/pull/8784 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Сковорода Никита Андреевич authored
This makes sure that no uninitialized bytes are leaked when the specified `totalLength` input value is greater than the actual total length of the specified buffers array, e.g. in Buffer.concat([Buffer.alloc(0)], 100). PR-URL: https://github.com/nodejs/node-private/pull/64 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node-private/pull/75 Reviewed-By:
-
Ben Noordhuis authored
Compile out hardware engines. Most are stubs that dynamically load the real driver but that poses a security liability when an attacker is able to create a malicious DLL in one of the default search paths. PR-URL: https://github.com/nodejs/node-private/pull/73 Reviewed-By:
-
Evan Lucas authored
Previously, the reason argument passed to ServerResponse#writeHead was not being properly validated. One could pass CRLFs which could lead to http response splitting. This commit changes the behavior to throw an error in the event any invalid characters are included in the reason. CVE-2016-5325 PR-URL: https://github.com/nodejs/node-private/pull/60 Reviewed-By:
-
