- Jul 15, 2021
-
-
James M Snell authored
Experimental as part of the web streams implementation Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39347 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
- Jul 14, 2021
-
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/38334 Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Rich Trott authored
In email, John-David Dalton confirmed that it was appropriate to move to emeritus at this time. PR-URL: https://github.com/nodejs/node/pull/39380 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
-
Rich Trott authored
GitHub Action workflows can be told to clone a certain number of commits or else everything. Change find-inactive-collaborators to take a number of commits to examine rather than a date range so that the parameter can be used in GitHub Actions. PR-URL: https://github.com/nodejs/node/pull/39362 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Rich Trott authored
find-inactive-collaborators.mjs works fine with Node.js 16.x, but GitHub Actions currently use 14.x by default. PR-URL: https://github.com/nodejs/node/pull/39362 Reviewed-By:
-
Robert Nagy authored
Refs: https://github.com/nodejs/node/issues/39356 PR-URL: https://github.com/nodejs/node/pull/39364 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Robert Nagy authored
Adds readableDidRead to streams and applies usage to http, http2 and quic. PR-URL: https://github.com/nodejs/node/pull/36820 Reviewed-By:
-
Michaël Zasso authored
Notable changes: deps: * upgrade npm to 7.19.1 (npm team) https://github.com/nodejs/node/pull/39225 fs: * (SEMVER-MINOR) allow empty string for temp directory prefix (Voltrex) https://github.com/nodejs/node/pull/39028 stream: * (SEMVER-MINOR) implement Web Streams API (James M Snell) https://github.com/nodejs/node/pull/39062 PR-URL: https://github.com/nodejs/node/pull/39373
-
himself65 authored
GYP uses the system path when parsing node.gyp; However, if system python is different from our gyp runtime python, like '2.7', gyp would crash. Co-authored-by:
Joyee Cheung <joyeec9h3@gmail.com>
-
Rich Trott authored
For lint exceptions that are universal or near universal for `test/common`, put the exceptions in a config file rather than disabling the ESLint rules at the top of each file. PR-URL: https://github.com/nodejs/node/pull/39358 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
* Replace _PR_ with Pull Request * Make some content more concise PR-URL: https://github.com/nodejs/node/pull/39359 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
James M Snell authored
Fixup the definitions of the properties to avoid the possibility of prototype polution on the object definitions. Signed-off-by:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
James M Snell authored
Experimental adapters for the webstreams API Signed-off-by:
-
- Jul 13, 2021
-
-
James M Snell authored
Refs: https://github.com/nodejs/node/issues/39368 Signed-off-by:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/39351 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/39352 Reviewed-By:
-
Danielle Adams authored
PR-URL: https://github.com/nodejs/node/pull/39186 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
-
Rich Trott authored
This also changes a line in the man page to be sentence case. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/special-characters PR-URL: https://github.com/nodejs/node/pull/39345 Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
-
Rich Trott authored
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/special-characters PR-URL: https://github.com/nodejs/node/pull/39344 Reviewed-By:
-
Rich Trott authored
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/bits-bytes-terms PR-URL: https://github.com/nodejs/node/pull/39343 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39277 Reviewed-By:
-
- Jul 12, 2021
-
-
Rich Trott authored
Currently, we say "listening" when we are ending the server. Change it to "ending". Fixes: https://github.com/nodejs/node/issues/39272 PR-URL: https://github.com/nodejs/node/pull/39334 Reviewed-By:
Yash Ladha <yash@yashladha.in>
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/39342 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/39346 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [mips][wasm][liftoff] Fix compile failed Port 2b77ca200c56667c68895e49c96c10ff77834f09 Bug: v8:11809 Change-Id: Idbbbc10d1339d6c8463686b6e701fb601a217cab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931557 Reviewed-by:Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#74934} Refs: https://github.com/v8/v8/commit/5c76da8ddcf89297a8dc2606b68da97d7a5329cb PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [riscv64] Fix build failed Port 2b77ca200c56667c68895e49c96c10ff77834f09 Change-Id: Ie953a1d54f5529423ae35d1b1cd3ca25e8101c6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931577 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Reviewed-by:Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/master@{#74937} Refs: https://github.com/v8/v8/commit/359d44df4cdd9cdb40cb683b47c2bea6bb7609f6 PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: PPC/s390: [wasm][liftoff] Always zero-extend 32 bit offsets Port 2b77ca200c56667c68895e49c96c10ff77834f09 Original Commit Message: The upper 32 bits of the 64 bit offset register are not guaranteed to be cleared, so a zero-extension is needed. We already do the zero-extension in the case of explicit bounds checking, but this should also be done if the trap handler is enabled. R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ife3ae4f93b85fe1b2c76fe4b98fa408b5b51ed71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929661 Reviewed-by:Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74886} Refs: https://github.com/v8/v8/commit/3805a698f7b6803dd6ee002cfdda71296c71b30b PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [wasm][arm64] Always zero-extend 32 bit offsets, for realz We've already been zero-extending 32-bit offset registers since https://chromium-review.googlesource.com/c/v8/v8/+/2917612, but that patch only covered the case where offset_imm == 0. When there is a non-zero offset, we need the same fix. Bug: chromium:1224882,v8:11809 Change-Id: I1908f735929798f411346807fc4f3c79d8e04362 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2998582 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75500} Refs: https://github.com/v8/v8/commit/56fe020eec0c35e9816590114b1d80836a504156 Fixes: https://github.com/nodejs/node/issues/39327 PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [wasm][liftoff] Always zero-extend 32 bit offsets The upper 32 bits of the 64 bit offset register are not guaranteed to be cleared, so a zero-extension is needed. We already do the zero-extension in the case of explicit bounds checking, but this should also be done if the trap handler is enabled. R=clemensb@chromium.org CC=jkummerow@chromium.org Bug: v8:11809 Change-Id: I21e2535c701041d11fa06c176fa683d82db0a3f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2917612 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: -
Michaël Zasso authored
Original commit message: [liftoff] Handle constant memory indexes specially This adds detection for constant memory indexes which can statically be proven to be in-bounds (because the effective offset is within the minimum memory size). In these cases, we can skip the bounds check and the out-of-line code for the trap-handler. This often saves 1-2% of code size. R=ahaas@chromium.org Bug: v8:11802 Change-Id: I0ee094e6f1f5d132af1d6a8a7c539a4af6c3cb5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919827 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74825} Refs: https://github.com/v8/v8/commit/53784bdb8f01a6ff76fc3acd3aec4d605cb3bfcc PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: Reland "[liftoff][arm64] Use 64 bit offset reg in mem op" This is a reland of f645d0b857bc669271adcbe95cf25e1554347dd4 The issue was that converting an i64 to an i32 didn't clear the upper bits on arm64. This was not necessary before because we did the zero extension as part of the load operand, but this is required now that we use the full register. Original change's description: > [liftoff][arm64] Use 64 bit offset reg in mem op > > Accessing the Wasm memory with a 64 bit offset was truncated to 32 bit, > which is fine if we check bounds first, but not if we rely on the > trap handler to catch the OOB. > > R=clemensb@chromium.org > > Bug: v8:11587 > Change-Id: I82a3a2906e55d9d640c30e770a5c93532e3a442c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808942 > Reviewed-by: -
Rich Trott authored
Add a GitHub Action for find-inactive-collaborators.mjs that will run it and list collaborators who have been inactive for more than a year. It will run when manually triggered by a collaborator and on a schedule of once a month. PR-URL: https://github.com/nodejs/node/pull/39335 Reviewed-By:
-
Richard Lau authored
Update the version of `gcovr` used for C++ coverage from 3.4 to 4.2 for compatibility with gcc/g++ 8. PR-URL: https://github.com/nodejs/node/pull/39326 Refs: https://github.com/nodejs/node/issues/39303 Refs: https://github.com/gcovr/gcovr/pull/228 Refs: https://github.com/nodejs/build/pull/2705 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/39355 Reviewed-By:
-
Robert Nagy authored
Cleanup async stream method handling. PR-URL: https://github.com/nodejs/node/pull/39329 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/39332 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/39333 Reviewed-By:
-
- Jul 11, 2021
-
-
Robert Nagy authored
Unify stream helps into utils. PR-URL: https://github.com/nodejs/node/pull/39294 Reviewed-By:
-
nerdthatnoonelikes authored
PR-URL: https://github.com/nodejs/node/pull/38953 Reviewed-By:
-
Lu Yahan authored
PR-URL: https://github.com/nodejs/node/pull/39004 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
