- Aug 26, 2015
-
-
James M Snell authored
per: https://github.com/joyent/node/pull/8708 A modified version of the original PR submitted by @builtbylane. Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/8778 originally submitted by @reggi Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/14352 originally submitted by @AlexKVal Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
Per: https://github.com/jorrit/node/commit/54a7f79a4a2ecb9c6f235a03287fe2992f19f0bb Fixes: https://github.com/joyent/node/issues/6149 Originally submitted by @jorrit Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
Rich Trott authored
There's a bunch of stuff in test-child-process-spawnsync.js that seems designed to test that it is in fact blocking/synchronous. However, that code really just tests the OS sleep command. Change `sleep 1` to `sleep 0` and shave about one second off the test run.` We check the return status to confirm the command is successful. The tests in this file in general would not work if spawnSync() were asynchronous. That includes this one, as a return status would not be available if the command where asynchronous. PR-URL: https://github.com/nodejs/node/pull/2542 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Jeremiah Senkpiel authored
Explicitly note that these modules should not be used outside of core. PR-URL: https://github.com/nodejs/node/pull/2523 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Rich Trott authored
The test had checked that a timer fired within a period after spawnSync() returns. The result was a test that sometimes was flaky. Because there's no guarantee of how long a timer will take before running, remove the check. There is a check that the timer runs after spawnSync() so that is sufficient. PR-URL: https://github.com/nodejs/node/pull/2535 Fixes: https://github.com/nodejs/node/issues/2470 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ben Noordhuis authored
Make the tool that generates add-ons from doc/api/addons.markdown print the names of the files it writes out. Before this commit, it printed a rather unhelpful "Done." PR-URL: https://github.com/nodejs/node/pull/2428 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Ben Noordhuis authored
Make `make test-addons` part of the `make test-ci` target. Use order-only prerequisites to make generating and building the add-ons concurrency-safe when $JOBS > 1 and fudge the dependency on $(NODE_EXE) so that add-ons are only rebuilt when needed instead of all the time. PR-URL: https://github.com/nodejs/node/pull/2428 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
- Aug 25, 2015
-
-
Rod Vagg authored
-
Rod Vagg authored
Notable changes: * events: Added EventEmitter#listenerCount(event) as a replacement for EventEmitter.listenerCount(emitter, event), which has now been marked as deprecated in the docs. (Sakthipriyan Vairamani) #2349 * module: Fixed an error with preloaded modules when the current working directory doesn't exist. (Bradley Meck) #2353 * node: Startup time is now about 5% faster when not passing V8 flags. (Evan Lucas) #2483 * repl: Tab-completion now works better with arrays. (James M Snell) #2409 * string_bytes: Fixed an unaligned write in the handling of UCS2 encoding. (Fedor Indutny) #2480 * tls: Added a new --tls-cipher-list flag that can be used to override the built-in default cipher list. (James M Snell) #2412
-
Rich Trott authored
This refactoring: * eliminates the need for the external `curl` command * speeds the test by running the two test requests simultaneously * checks the type of error in the test that expects a failure (previously, any error type would cause the test to pass) PR-URL: https://github.com/nodejs/node/pull/2433 Reviewed-By:Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Evan Lucas authored
The introduction of libuv 1.6.0 broke the android-configure script by not specifying the correct platform. uv_os_homedir uses getpwuid_r which was not made public until API level 21 on android. The regression was introduced in a804026c...b5cd2f09 PR-URL: https://github.com/nodejs/node/pull/2501 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ben Noordhuis authored
roundUpToNextPowerOf2() does more than just rounding up to the next power of two. Rename it to computeNewHighWaterMark(). PR-URL: https://github.com/nodejs/node/pull/2479 Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Ben Noordhuis authored
Don't iterate over all 32 bits, use some hacker's delight bit twiddling to compute the next power of two. The logic can be reduced to `n = 1 << 32 - Math.clz32(n)` but then it can't easily be backported to v2.x; Math.clz32() was added in V8 4.3. PR-URL: https://github.com/nodejs/node/pull/2479 Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Ben Noordhuis authored
The high watermark is capped at 8 MB, not 128 MB like the comment in lib/_stream_readable.js said. PR-URL: https://github.com/nodejs/node/pull/2479 Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Roman Reiss authored
Removes the known issue about known memory leaks. This was originally changed in the commit that synced the changelog to master: https://github.com/nodejs/node/commit/cded6e7993284c734d2ae9244dfc1e5c4cd4d976 PR-URL: https://github.com/nodejs/node/pull/2524 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rockemail.com>
-
- Aug 24, 2015
-
-
Bradley Meck authored
Fixes a regression from 5759722c that prevented modules from being preloaded if the cwd does not exist. Absolute and builtin modules now preload correctly again. Refs: https://github.com/nodejs/node/issues/1803 PR-URL: https://github.com/nodejs/node/pull/2353 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rockemail.com>
-
João Reis authored
According to the documentation, "io.js makes no guarantees about the exact timing of when the callback will fire" (https://iojs.org/api/timers.html#timers_settimeout_callback_delay_arg), hence this test is not necessary. PR-URL: https://github.com/nodejs/node/pull/2458 Reviewed-By:
Ben Noordhuis <ben@strongloop.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com>
-
João Reis authored
This is a port of joyent/node@e192f61514cd1500de895cb10128d412f842d7d0 . Original commit message: Older WiX versions included a header with extern "C" declaration, hence the custom action source must be C++. Reviewed-By:
João Reis <reis@janeasystems.com> PR-URL: https://github.com/joyent/node/pull/25569 PR-URL: https://github.com/nodejs/node/pull/2365 Reviewed-By:
Alexis Campailla <alexis@janeasystems.com>
-
Julien Gilli authored
This is a port of joyent/node@16bcd68dc5f449c331499ced22aa626dbb2cdefc . Original commit message: The original change that added support for running custom actions during the install process (joyent/node@e7c84f82c730bddb7450dc56065aab11b93ffd30) assumed that Visual Studio 2013 is used to generate the installer file. However, that is not always the case, and older versions of Visual Studio should allow users to generate Windows installer files. This change makes the custom actions visual studio project use the visual studio version that is found by vcbuild.bat. Reviewed-By:
João Reis <reis@janeasystems.com> PR-URL: https://github.com/joyent/node/pull/25569 PR-URL: https://github.com/nodejs/node/pull/2365 Reviewed-By:
Alexis Campailla <alexis@janeasystems.com>
-
Sakthipriyan Vairamani authored
The deprecation messages in the documentations should be in the format Stability: 0 - Deprecated: Use [alternate] instead. so that they will be consistent. PR-URL: https://github.com/nodejs/node/pull/2450 Reviewed-By:Roman Reiss <me@silverwind.io> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Use reserved IP in test-net-connect-timeout.js rather than arbitrary IP. PR-URL: https://github.com/nodejs/node/pull/2257 Fixes: https://github.com/nodejs/node/issues/2469 Reviewed By: Ben Noordhuis <ben@strongloop.com>
-
Minwoo Jung authored
fixed grammatically wrong expressions to make it clear Reviewed By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2490 PR-URL: https://github.com/nodejs/node/pull/2489
-
James M Snell authored
Per: https://github.com/joyent/node/pull/6962 This applies only the first commit from https://github.com/joyent/node/pull/6962. /cc @bnoorduis Reviewed By: Ben Noordhuis <ben@strongloop.com> PR-URL: https://github.com/nodejs/node/pull/2386
-
James M Snell authored
This adds a new `--tls-cipher-list` command line switch that can be used to override the built-in default cipher list. The intent of this is to make it possible to enforce an alternative default cipher list at the process level. Overriding the default cipher list is still permitted at the application level by changing the value of `require('tls').DEFAULT_CIPHERS`. As part of the change, the built in default list is moved out of tls.js and into node_constants.h and node_constants.cc. Two new constants are added to require('constants'): * defaultCipherList (the active default cipher list) * defaultCoreCipherList (the built-in default cipher list) A test case and doc changes are included. A new NODE_DEFINE_STRING_CONSTANT macro is also created in node_internals.h When node_constants is initialized, it will pick up either the passed in command line switch or fallback to the default built-in suite. Within joyent/node, this change had originaly been wrapped up with a number of other related commits involving the removal of the RC4 cipher. This breaks out this isolated change. /cc @mhdawson, @misterdjules, @trevnorris, @indutny, @rvagg Reviewed By: Ben Noordhuis <ben@strongloop.com> PR-URL: https://github.com/nodejs/node/pull/2412 -
hackerjs authored
Adds mention of response.finished to http.markdown Originally submitted by @hackerjs. The original commit needed a bit of cleanup on grammar. Reviewed By: James M Snell <jasnell@gmail.com> Reviewed By: Michaël Zasso <mic.besace@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2414
-
- Aug 23, 2015
-
-
Rod Vagg authored
Update AUTHORS list using tools/update-authors.sh Fix @muddletoes' .mailmap entry PR-URL: https://github.com/nodejs/node/pull/2505 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Brendan Ashworth authored
Requires that you do: if (x) { ... } Rather than: if(x) { ... } -
Brendan Ashworth authored
eg changes: if(x) { ... } to: if (x) { ... } -
Roman Klauke authored
Instead of throwing an error with `Bad arguments` the fs methods return a concrete error message. If an argument is missing, the methods throw an error with the information, what is missing. In case of a type mismatch, they throw an error with some hints, what datatype is expected. PR-URL: https://github.com/nodejs/node/pull/2495 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Sakthipriyan Vairamani authored
When an anchor tag is used within a pre tag, the link is not distinguishable. This patch makes sure that the links are highlighted by underlining them. PR-URL: https://github.com/nodejs/node/pull/2491 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Aug 22, 2015
-
-
Rod Vagg authored
Update AUTHORS list using tools/update-authors.sh PR-URL: https://github.com/nodejs/node/pull/2318 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2437 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2460 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2453 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rod Vagg authored
nodejs/node -> nodejs/node-convergence-archive PR-URL: https://github.com/nodejs/node/pull/2454 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rod Vagg authored
nodejs/node -> nodejs/node-convergence-archive PR-URL: https://github.com/nodejs/node/pull/2454 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2454 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
Refactored version of https://github.com/joyent/node/pull/25819 Removes integer keys (and keys starting with numbers) from candidate list on repl tab complete. Refactored the originally submitted change to simplify and ensure that the integer keys do not show up on objects either. Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2409
-