- Jul 17, 2020
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/34117 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com>
-
Benjamin Coe authored
Original commit message: [coverage] remove the last continuation range before synthetic return Rather than only removing the continuation range for the last return statement prior to a synthetic return statement, remove the continuation tracking for whatever statement occurs prior to the synthetic return. Bug: v8:10628 Change-Id: Ieb8e393479c9811cf1b9756840bbfdbe7f44a1b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280585 Commit-Queue: Benjamin Coe <bencoe@google.com> Reviewed-by:Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#68719} Refs: https://github.com/v8/v8/commit/2d5017a0fc0203c9657394e7f86158bac8440ba4 PR-URL: https://github.com/nodejs/node/pull/34272 Refs: https://github.com/bcoe/c8/issues/229 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/29739 PR-URL: https://github.com/nodejs/node/pull/34222 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/22804 PR-URL: https://github.com/nodejs/node/pull/34221 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/29714 PR-URL: https://github.com/nodejs/node/pull/34223 Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/8569 PR-URL: https://github.com/nodejs/node/pull/34227 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/32431 PR-URL: https://github.com/nodejs/node/pull/34220 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/31244 PR-URL: https://github.com/nodejs/node/pull/34225 Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/31279 PR-URL: https://github.com/nodejs/node/pull/34226 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/34143 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34228 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com>
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/34156 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Xu Meng authored
Due to some unknown system configuration, the code `socket_ipv6.bind(0, 111::1)` does not throw the expected error EADDRNOTAVAIL on some IBM i systems. This issue is still being investigated. To get the IBM i CI passing, skip it for now. PR-URL: https://github.com/nodejs/node/pull/34209 Reviewed-By:
-
Anna Henningsen authored
Add a test for a regression that occurs when transferring some `Buffer` objects that were created from C++ to a parent thread. Fixes: https://github.com/nodejs/node/issues/34126 PR-URL: https://github.com/nodejs/node/pull/34140 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Anna Henningsen authored
V8 will not exit the process after handling --help anymore: https://chromium-review.googlesource.com/c/v8/v8/+/2276276 As a drive-by fix, correctly return in the `print_bash_completion` case as well. Refs: https://github.com/nodejs/node/pull/34135 Co-authored-by:
Ulan Degenbaev <ulan@chromium.org> PR-URL: https://github.com/nodejs/node/pull/34136 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Anna Henningsen authored
646e5a47 changed the way that the domain hook callback is called. Previously, the callback was only used in the case that async_hooks were *not* being used (since domains already integrate with async hooks the way they should), and the corresponding deprecation warning also only emitted in that case. However, that commit didn’t move that condition along when the code was ported from C++ to JS. As a consequence, the domain hook callback was used when it wasn’t necessary to use it, and the deprecation warning emitted accidentally along with it. Refs: https://github.com/nodejs/node/commit/646e5a471766e27e8317bb54d1fd1d2c72cffb69#diff-9f21ce1b9d6d46fdd07b969e8a04e140L192 Refs: https://github.com/nodejs/node/commit/646e5a471766e27e8317bb54d1fd1d2c72cffb69#diff-e6db408e12db906ead6ddfac3de15a6fR119 Refs: https://github.com/nodejs/node/pull/33801#issuecomment-654744913 PR-URL: https://github.com/nodejs/node/pull/34245 Fixes: https://github.com/nodejs/node/issues/34069 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
Daniel Bevenius authored
This commit adds a local variable named encoding_type which is set to the value of the Maybe using ToChecked(). The motivation for this is the code for ToChecked() could be executed multiple times depending on path taken at runtime. I also think this improves readability, or at least it is as readable as before this change. PR-URL: https://github.com/nodejs/node/pull/34181 Reviewed-By:
David Carlier <devnexen@gmail.com>
-
sapics authored
PR-URL: https://github.com/nodejs/node/pull/34158 Reviewed-By:
-
sapics authored
PR-URL: https://github.com/nodejs/node/pull/34158 Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/node/pull/33764#issuecomment-653667275 PR-URL: https://github.com/nodejs/node/pull/34197 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Rich Trott authored
test-repl-history-navigation fails with NODE_PENDING_DEPRECATION=1. Replace deprecated repl.inputStream with repl.input. PR-URL: https://github.com/nodejs/node/pull/34199 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34198 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/34167 Reviewed-By:
-
Nikola Glavina authored
C++ linter fails because of unused ArrayBuffer namespace member PR-URL: https://github.com/nodejs/node/pull/34212 Reviewed-By:
-
Rich Trott authored
ERR_FEATURE_UNAVAILABLE_ON_PLATFORM is incorrectly included in the list of errors that have never been released. It was added in 67e067eb and included in every release in the 14.x line. PR-URL: https://github.com/nodejs/node/pull/34196 Reviewed-By:
-
Rich Trott authored
Had an email exchange with Hitesh where he indicated that it was a fine time to move him to emeritus. PR-URL: https://github.com/nodejs/node/pull/34191 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Rich Trott authored
Asked Gibson in email if he should be moved to emeritus and he indicated it was a good idea. PR-URL: https://github.com/nodejs/node/pull/34190 Reviewed-By:
-
James M Snell authored
Alternative to https://github.com/nodejs/node/pull/33841 Co-authored-by:
zombieleet <zombieleetnca@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34188 Reviewed-By:
-
Rich Trott authored
The explanation that the HTTP requests include `\r\n` is true but not important or relevant in these two specific contexts. PR-URL: https://github.com/nodejs/node/pull/34178 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Rich Trott authored
Remove stability indicators from errors that only existed on the master branch and are not in the release. PR-URL: https://github.com/nodejs/node/pull/33764 Reviewed-By:
-
Michael Dawson authored
We have this guidance for contributing to N-API: https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md It makes sense to have one of the N-API team sign off on commits that changes N-API Signed-off-by:
Rich Trott <rtrott@gmail.com>
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/33856 Reviewed-By:
-
Rich Trott authored
lint-js.js was implemented before ESLint had a caching feature. It is now only used in CI. Let's remove it on the following grounds: * It results in occasional (and puzzling) yellow CI runs for node-test-linter because the tap file is corrupted somehow. Interleaved maybe? I don't know, but a simple solution is removing it and running ESLint directly. * On my local laptop, it reduces the linting from about 75 seconds to about 55 seconds. This kind of savings is not worth the added complexity and the instability noted above. PR-URL: https://github.com/nodejs/node/pull/30955 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Julien Poissonnier authored
PR-URL: https://github.com/nodejs/node/pull/34119 Reviewed-By:
-
Luigi Pinca authored
Clarify that the `ctx` argument of the `SNICallback` callback is optional. Fixes: https://github.com/nodejs/node/issues/34085 PR-URL: https://github.com/nodejs/node/pull/34097 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
-
Mateusz Krawczuk authored
Some of the SSL_OP_* constants are missing description in the documentation. Instead of rewriting the description from OpenSSL's wiki, I have decided to put a link to a detailed list in the 'OpenSSL Options' section. I see no point of doing both - adding a reference to the wiki and adding constant descriptions - but I might do if presented with convincing arguments. This is a follow-up to #33929. PR-URL: https://github.com/nodejs/node/pull/34050 Reviewed-By:
-
Sam Roberts authored
Node.js hasn't touched the cve-management repo since the Feb 2019 security release, we've used the HackerOne CVE allocation process. Maintaining our status as a CNA is not zero cost, there is some routine adminstration that is requested (see this doc for details). As we no longer use the CVE management process, I propose removing it. If this lands, I will go through the interactions with Mitre so that Node.js is no longer a CNA and cleanup related resources (email aliases, archive the cve-management repo, whatever else I find). PR-URL: https://github.com/nodejs/node/pull/33639 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
Saleem authored
Consistency of method naming referred to as readable.push several other times in transform documentation and also documented under readable, so makes sense to just stick with readable.push PR-URL: https://github.com/nodejs/node/pull/30506 Reviewed-By:
-
Anentropic authored
document more clearly that stdin will emit multiple readable events PR-URL: https://github.com/nodejs/node/pull/27350 Reviewed-By:
-
Gabriel Schulhof authored
Remove text regarding copying, because `napi_create_external_buffer` does not copy. Fixes: https://github.com/nodejs/node/issues/33471 PR-URL: https://github.com/nodejs/node/pull/34125 Reviewed-By:
Mathias Buus <mathiasbuus@gmail.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
