Commits · 1ac331b29fc0d0eab4fdfd6e47155b2936e8f100 · github.com / v8-riscv / node

May 03, 2017

readline: fix permanent deoptimizations · 1ac331b2

Brian White authored Apr 24, 2017

PR-URL: https://github.com/nodejs/node/pull/12456


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1ac331b2

net: fix permanent deoptimizations · 4a082889

Brian White authored Apr 24, 2017

PR-URL: https://github.com/nodejs/node/pull/12456


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

4a082889

process: fix permanent deoptimizations · b573f77b

Brian White authored Apr 24, 2017

PR-URL: https://github.com/nodejs/node/pull/12456


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

b573f77b

cluster: fix permanent deoptimizations · 933b6b57

Brian White authored Apr 24, 2017

PR-URL: https://github.com/nodejs/node/pull/12456


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

933b6b57

fs: fix permanent deoptimizations · 84484b70

Brian White authored Apr 24, 2017

PR-URL: https://github.com/nodejs/node/pull/12456


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

84484b70

stream: fix permanent deoptimizations · 7d0adc6d

Brian White authored Apr 24, 2017

PR-URL: https://github.com/nodejs/node/pull/12456


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

7d0adc6d

build: add target for checking for perm deopts · caf6506f

Brian White authored Apr 17, 2017

PR-URL: https://github.com/nodejs/node/pull/12456


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

caf6506f

test: fix test filenames · 9da719ab

Brian White authored Apr 17, 2017

PR-URL: https://github.com/nodejs/node/pull/12456


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

9da719ab

process: cast promise rejection reason to string · cd542084

Cameron Little authored Mar 13, 2017

The unhandled promise rejection warning uses a template literal and
prints the reason a promise was rejected. If rejecting with a symbol,
the symbol failed to convert to a string and the process crashed. Now,
symbols are casted to strings and the process does not crash.

Fixes: https://github.com/nodejs/node/issues/11637
PR-URL: https://github.com/nodejs/node/pull/11640


Reviewed-By: Anna Henningsen <anna@addaleax.net>

cd542084

test: support multiple warnings in checkWarning · d78adccc

Cameron Little authored Mar 13, 2017

This allows the common.checkWarning() test method to accept a map of
warning names to description(s), to allow testing code that generates
multiple types of warnings.

PR-URL: https://github.com/nodejs/node/pull/11640


Reviewed-By: Anna Henningsen <anna@addaleax.net>

d78adccc

doc: fixup the collaborators list · f60a2e95

Alexey Orlenko authored Apr 30, 2017

* Add the personal pronoun for @aqrln.
* Fix incorrectly ordered @lucamaraschi entry.

PR-URL: https://github.com/nodejs/node/pull/12750


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

f60a2e95

test: improve test-tcp-wrap-listen · 819c131f

alohaglenn authored Apr 22, 2017

PR-URL: https://github.com/nodejs/node/pull/12599


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

819c131f

test,doc: document `crashOnUnhandledRejection()` · 90bba9fd

Anna Henningsen authored Apr 27, 2017

Add documentation for `common.crashOnUnhandledRejection()`.

Ref: https://github.com/nodejs/node/pull/12489/files/a9c2078a60bc3012dc6156df19772697a56a2517#r113737423
PR-URL: https://github.com/nodejs/node/pull/12699


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

90bba9fd

benchmark: terminate child process on Windows · 224fd3af

Rich Trott authored Apr 25, 2017

test-benchmark-child-process failures reveal that
child-process-exec-stdout benchmark sometimes leaves around a stray
yes.exe process. Add code to terminate the process.

PR-URL: https://github.com/nodejs/node/pull/12658
Ref: https://github.com/nodejs/node/issues/12560


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

224fd3af

doc: fix examples in repl.md · 360efe48

Vse Mozhet Byt authored Apr 27, 2017

* Update an example according to an actual REPL session.
* Replace an arrow function with a common function to hold `this`.

PR-URL: https://github.com/nodejs/node/pull/12684


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

360efe48

benchmark: add benchmark for v8.getHeap*Statistics · 373e9f08

James M Snell authored Apr 26, 2017

PR-URL: https://github.com/nodejs/node/pull/12681


Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

373e9f08

doc: add Added-in metadata for WHATWG URL · 395380a1

Timothy Gu authored Apr 26, 2017

PR-URL: https://github.com/nodejs/node/pull/12683


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

395380a1

doc: document url.domainTo* methods separately · fc96d1a5

Timothy Gu authored Apr 26, 2017

PR-URL: https://github.com/nodejs/node/pull/12683


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

fc96d1a5

test: remove eslint comments from test-util.js · 79dff994

cjihrig authored Apr 26, 2017

PR-URL: https://github.com/nodejs/node/pull/12669


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

79dff994

test: remove eslint comments · dd1dced4

cjihrig authored Apr 26, 2017

This commit refactors test-whatwg-url-tojson.js to remove
ESLint comments.

PR-URL: https://github.com/nodejs/node/pull/12669


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

dd1dced4

test: use common.mustCall in test-https-strict · 3e9e6afd

weewey authored Apr 26, 2017

PR-URL: https://github.com/nodejs/node/pull/12668


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

3e9e6afd

test: cleanup test-util-inherits.js · 75e053be

RobotMermaid authored Apr 22, 2017

Replaced constructor with regular expression for assert.throw().

PR-URL: https://github.com/nodejs/node/pull/12602


Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

75e053be

build: use do_not_edit variable where possible · 212475b4

Ruslan Bekenev authored Apr 23, 2017

We should not use hardcoded string to warn users about
file was generated by configure script. Since we already
have do_not_edit variable we can use it

PR-URL: https://github.com/nodejs/node/pull/12610


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

212475b4

test: use common.js to check platform · 745dea99

Ruslan Bekenev authored Apr 25, 2017

PR-URL: https://github.com/nodejs/node/pull/12629


Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

745dea99

url: always show password for URL instances · 60daaaef

Brian White authored Apr 15, 2017

This matches browser behavior.

PR-URL: https://github.com/nodejs/node/pull/12420


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

60daaaef

deps: remove **/node_modules/form-data/README.md · d154aafe

Jeremiah Senkpiel authored Apr 25, 2017

Having multiple files with the same name but different casings causes
problems on lots of OS-s.

Refs: https://github.com/nodejs/node/issues/12624
Refs: https://github.com/nodejs/node/pull/11085
Refs: https://github.com/nodejs/node/pull/11020

PR-URL: https://github.com/nodejs/node/pull/12643


Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

d154aafe

test: improve test-process-kill-pid · 8e6d4402

alohaglenn authored Apr 22, 2017

PR-URL: https://github.com/nodejs/node/pull/12588


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

8e6d4402

test: improved type checking with regex · 660e58c7

coreybeaumont authored Apr 22, 2017

Replaced TypeError with a regular expression of the actual error.

PR-URL: https://github.com/nodejs/node/pull/12591


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

660e58c7

test: cleanup test-fs-watch.js · e36a256c

RobotMermaid authored Apr 22, 2017

Reversed "actual" and "expected" arguments for assert.strictEqual().

Replaced constructor with regular expression for assert.throws().

PR-URL: https://github.com/nodejs/node/pull/12595


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

e36a256c

test: add mustCall in test-timers-clearImmediate · d15b1c44

Zahidul Islam authored Apr 22, 2017

PR-URL: https://github.com/nodejs/node/pull/12598


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

d15b1c44

tools: use no-useless-concat ESLint rule · 46a7c297

Vse Mozhet Byt authored Apr 24, 2017

* Add `no-useless-concat: error` to .eslintrc.yaml.
* Apply no-useless-concat rule to tests.

PR-URL: https://github.com/nodejs/node/pull/12613


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

46a7c297

doc: fix an unclear wording in readline.md · 45facc88

Vse Mozhet Byt authored Apr 23, 2017

PR-URL: https://github.com/nodejs/node/pull/12605


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

45facc88

src: remove invalid comment · da01ff75

cjihrig authored Apr 25, 2017

PR-URL: https://github.com/nodejs/node/pull/12645


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

da01ff75

doc: improve randomfill and fix broken link · 1316c77b

Sakthipriyan Vairamani (thefourtheye) authored Apr 20, 2017

This patch replaces the word `buf` with `buffer` and fixes the broken
link to `randomfill`.

PR-URL: https://github.com/nodejs/node/pull/12541


Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1316c77b

src: expose V8's IsNativeError() in util bindings · 744ed947

cjihrig authored Apr 20, 2017

Refs: https://github.com/nodejs/node/pull/12400
PR-URL: https://github.com/nodejs/node/pull/12546


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

744ed947

meta: update authors list · 51eafe8f

Aashil Patel authored Feb 25, 2017

PR-URL: https://github.com/nodejs/node/pull/11533


Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

51eafe8f

tools: enable no-useless-return eslint rule · 258eeaa5

cjihrig authored Apr 21, 2017

PR-URL: https://github.com/nodejs/node/pull/12577


Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

258eeaa5

url: update WHATWG URL API to latest spec · ac529233

Timothy Gu authored Apr 19, 2017

- Update to spec
  - Add opaque hosts
  - File state did not correctly deal with lack of base URL
  - Cleanup API for file and non-special URLs
  - Allow % and IPv6 addresses in non-special URL hosts
  - Use specific names for percent-encode sets
  - Add empty host concept for file and non-special URLs
  - Clarify IPv6 serializer
- Fix existing mistakes
  - Add missing ':' to forbidden host code point list.
  - Correct IPv4 parser empty label behavior
- Maintain type equivalence in URLContext with spec
  - scheme, username, and password should always be strings
  - host, port, query, and fragment may be strings or null
  - Align scheme state more closely with the spec
  - Make sure the `special` variable is always synced with
    URL_FLAG_SPECIAL.

PR-URL: https://github.com/nodejs/node/pull/12523
Fixes: https://github.com/nodejs/node/issues/10608
Fixes: https://github.com/nodejs/node/issues/10634
Refs: https://github.com/whatwg/url/pull/185
Refs: https://github.com/whatwg/url/pull/225
Refs: https://github.com/whatwg/url/pull/224
Refs: https://github.com/whatwg/url/pull/218
Refs: https://github.com/whatwg/url/pull/243
Refs: https://github.com/whatwg/url/pull/260
Refs: https://github.com/whatwg/url/pull/268


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

ac529233

doc: prepare js code for eslint-plugin-markdown · 313b2058

Vse Mozhet Byt authored Apr 21, 2017

This is an initial step to eliminate most of parsing errors.

PR-URL: https://github.com/nodejs/node/pull/12563
Refs: https://github.com/nodejs/node/pull/12557#issuecomment-296015032


Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

313b2058

lib: fix typo in comments in module.js · cbdf9a90

WORMSS authored Apr 20, 2017

A minor typo in comments, no logic changes.

PR-URL: https://github.com/nodejs/node/pull/12528


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>

cbdf9a90