- Mar 24, 2020
-
-
cjihrig authored
This commit removes all #ifdef NODE_REPORT checks in the src directory. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Gabriel Schulhof authored
Use `dl_iterate_phdr(3)` to find the mapping containing `__node_text_start` instead of parsing `/proc/self/maps`. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Co-Authored-By:
Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/32244 Reviewed-By:
-
Matheus Marchini authored
`test-inspector-multisession-ws` and `test-inspector-break-when-eval` will be affected by an upstream bug when we upgrade V8 to 8.1. The bug is caused when the Inspector sets a pause at the start of a function compiled with `CompileFunctionInContext`, but that function hasn't been executed yet. On both tests, this issue is triggered by pausing while in C++ executing LookupAndCompile, which is called by requiring internal modules while running `console.log`. To eliminate this issue in both tests, we add an extra `console.log` to ensure we only pause we required all internal modules we need. On `test-inspector-break-when-eval`, we also need to start the child process with `--inspect-brk` instead of `--inspect` to ensure the test is predictable (this test would occasianlly fail on slower machines, when console.log doesn't run fast enough to finish after emitting `Runtime.consoleAPICalled` and before the parent process sending `Runtime.evaluate` message. Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10287 PR-URL: https://github.com/nodejs/node/pull/32234 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10287 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
cjihrig authored
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: https://github.com/nodejs/node/pull/32241 Refs: https://github.com/nodejs/node/pull/31972 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Matheus Marchini authored
The current test relies on undeterministic behavior from V8 GC, and on newer versions of V8 this test ocasionally fails because that behavior changed. Prevent that from happening using --predictable-gc-schedule. If this test fails in the future, it should fail consistently instead of ocasionally, which should help debug. Ref: https://github.com/nodejs/node-v8/issues/144#issuecomment-597945219 Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32239 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Rich Trott authored
Update acorn to 7.1.1 in the dev dependencies for the markdown linter. Refs: https://app.snyk.io/vuln/SNYK-JS-ACORN-559469 Signed-off-by:
Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32259 Reviewed-By:
-
cjihrig authored
Notable changes: - The UV_UDP_MMSG_CHUNK UDP flag has been added. - Support has been dropped for FreeBSD < 10. - The FreeBSD and Linux system call logic has been simplified to assume the presence of features covered by libuv's minimum system requirements. - Listening on IPC pipes is no longer allowed. - Fix iOS and Android builds. PR-URL: https://github.com/nodejs/node/pull/32204 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
cjihrig authored
This commit adds a test to verify that exceptions thrown from a WASI application are properly caught and rethrown. This also gets the code coverage in lib/wasi.js back to 100%. PR-URL: https://github.com/nodejs/node/pull/32157 Reviewed-By:
-
Anna Henningsen authored
There is no reason for this to be in C++. Using JavaScript means that the code is more accessible to more developers, which is important for any Node.js feature. This also simplifies the code significantly in some areas. On the technical side, this potentially also enables making some of the file system operations that are involved asynchronous. PR-URL: https://github.com/nodejs/node/pull/32201 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com>
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/32203 Fixes: https://github.com/nodejs/node/issues/32199 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Matheus Marchini authored
Original commit message: Fix scanner-level error reporting for hashbang When the file begins with a hashbang, the scanner is in a failed state when SkipHashbang() is called. This is usually not an issue but when the parser encounters an ILLEGAL token, it will reset the SyntaxError location because of it. Bug: v8:10110 Change-Id: I1c7344bf5ad20079cff80130c991f3bff4d7e9a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995312 Reviewed-by:Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66038} Refs: https://github.com/v8/v8/commit/f9257802c1c0a0663a1d05bacf662283f6bd9050 Fixes: https://github.com/nodejs/node/issues/31284 Signed-off-by:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Harshitha KP authored
Add a new scenario of multiple clients sharing a single data callback function managing their response data through AsyncLocalStorage APIs Refs: https://github.com/nodejs/node/pull/32063 Refs: https://github.com/nodejs/node/issues/32060 Refs: https://github.com/nodejs/node/issues/32062#issuecomment-593957787 Co-authored-by:
-
Mateusz Krawczuk authored
This change is to prevent potential bugs - e.g., someone might automatically use the variable `k` instead of `key`, that is used in vicinity of this loop. Also changed postincrement to preincrement in iteration steps. It is probably done by the optimizer anyway, but otherwise it will save an opcode each iteration. And it is a good practice. PR-URL: https://github.com/nodejs/node/pull/32012 Reviewed-By:
-
Harshitha KP authored
The test wanted to cut huge string into 1KB strings, for which a new line character was inserted at appropriate places. The value is different in Windows (10, 13). Make it portable, by making use of os.EOL semantics Refs: https://github.com/nodejs/node/issues/25988 PR-URL: https://github.com/nodejs/node/pull/32104 Reviewed-By:
-
Antoine du HAMEL authored
The explicit goal is to let users use `import.meta.url` to re-load thecurrent module inside a Worker instance. Fixes: https://github.com/nodejs/node/issues/30780 PR-URL: https://github.com/nodejs/node/pull/31664 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Guy Bedford authored
Co-Authored-By:
Geoffrey Booth <GeoffreyBooth@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/32098 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Ruben Bridgewater authored
Use an object to indicate which part belongs to the input and which to the output. On top of that this also simplifies the expected output by automatically inserting the default repl line for previews and by automatically checking for the correct output line length. PR-URL: https://github.com/nodejs/node/pull/32154 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This adds preview output for input that may not be wrapped. PR-URL: https://github.com/nodejs/node/pull/32154 Reviewed-By:
-
Bartosz Sosnowski authored
Document Windows specific fs.watch caveats. Fixes: https://github.com/nodejs/node/issues/31702 PR-URL: https://github.com/nodejs/node/pull/32176 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
ExE Boss authored
Define `util.promisify.custom` as `Symbol.for("nodejs.util.inspect.custom")`, rather than as `Symbol("util.inspect.custom")`. This allows custom `promisify` wrappers to easily/safely be defined in non‑Node.js environments. Fixes: https://github.com/nodejs/node/issues/31647 PR-URL: https://github.com/nodejs/node/pull/31672 Reviewed-By: -
Ben Noordhuis authored
Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: https://github.com/nodejs/node/issues/30056 PR-URL: https://github.com/nodejs/node/pull/30147 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32125 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Harshitha KP authored
Make sure longer strings are written up to the buffer end Refs: https://github.com/nodejs/node/pull/32119 PR-URL: https://github.com/nodejs/node/pull/32123 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/32087 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
-
Eric Bickle authored
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: https://github.com/nodejs/node/issues/32072 PR-URL: https://github.com/nodejs/node/pull/32073 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32037 Reviewed-By:
-
Michael Dawson authored
Signed-off-by:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Rich Trott authored
I sent an email to inactive collaborators (in the previous 6 months at the time, no commits, no PRs reviewed, and no commits landed) asking if it was time to move to emeritus. Some replied affirmatively and I have moved those people to emeritus. Others replied indicating a desire to remain collaborators, and I left them as collaborators. The remaining folks are being moved to emeritus in this change. Signed-off-by:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- Mar 12, 2020
-
-
Myles Borins authored
Missing from release, apologies. PR-URL: https://github.com/nodejs/node/pull/32218 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/32185
-
Myles Borins authored
Notable changes: * async_hooks: - add sync enterWith to ALS (Stephen Belanger) https://github.com/nodejs/node/pull/31945 * cli: - allow --jitless V8 flag in NODE\_OPTIONS (Andrew Neitsch) https://github.com/nodejs/node/pull/32100 * fs: - return first folder made by mkdir recursive (Benjamin Coe) https://github.com/nodejs/node/pull/31530 * n-api: - define release 6 (Gabriel Schulhof) https://github.com/nodejs/node/pull/32058 * src: - create a getter for kernel version (Juan José Arboleda) https://github.com/nodejs/node/pull/31732 * wasi: - add returnOnExit option (Colin Ihrig) https://github.com/nodejs/node/pull/32101 PR-URL: https://github.com/nodejs/node/pull/32185 -
Robert Nagy authored
User might still want to be able to use the writable side of src. This is in the case where e.g. the Duplex input is not directly connected to its output. Such a case could happen when the Duplex is reading from a socket and then echos the data back on the same socket. Backport-PR-URL: https://github.com/nodejs/node/pull/32212 PR-URL: https://github.com/nodejs/node/pull/32198 Refs: https://github.com/nodejs/node/commit/4d93e105bfad79ff6c6f01e4b7c2fdd70caeb43b#commitcomment-37751035 Reviewed-By:
-
Robert Nagy authored
http1 objects are coupled with their corresponding res/req and cannot be treated independently as normal streams. Add a special exception for this in the pipeline cleanup. Fixes: https://github.com/nodejs/node/issues/32184 Backport-PR-URL: https://github.com/nodejs/node/pull/32212 PR-URL: https://github.com/nodejs/node/pull/32197 Reviewed-By:
-
Andrey Pechkurov authored
Both http and https modules have server.timeout property in public API. This commit adds documentation section and test for server.timeout in http2 module, so it becomes consistent with http and https. Also improves description of callback argument in documentation for server.setTimeout(). PR-URL: https://github.com/nodejs/node/pull/31693 Reviewed-By:
-
Ben Noordhuis authored
Factor out the common logic into a template function. Removes approximately six instances of copy/pasted code. PR-URL: https://github.com/nodejs/node/pull/31767 Reviewed-By:
-
Ben Noordhuis authored
Use `StringBytes::InlineDecoder` to decode strings inputs in C++ land instead of decoding them to buffers in JS land before passing them on to the C++ layer. This is what the other update() methods already did. PR-URL: https://github.com/nodejs/node/pull/31767 Reviewed-By:
-
Ben Noordhuis authored
We might not have sufficient privileges to signal the child process so don't make assumptions about the return value of `uv_process_kill()`. Example: node -e 'child_process.spawnSync("sudo", ["ls"], { maxBuffer: 1 })' No test because: 1. The test needs to run as root (can't invoke sudo), and 2. The parent needs to drop privileges but can't, because then the child process won't have sufficient privileges. Fixes: https://github.com/nodejs/node/issues/31747 PR-URL: https://github.com/nodejs/node/pull/31768 Reviewed-By: -
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/31952 Reviewed-By:
-
Gerhard Stoebich authored
Wrap reused read_wrap in a unique async resource to ensure that executionAsyncResource() is not ambiguous. PR-URL: https://github.com/nodejs/node/pull/31972 Refs: https://github.com/nodejs/node/pull/30959 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
Joe Pea authored
PR-URL: https://github.com/nodejs/node/pull/32152 Reviewed-By:
-
