Commits · 17857d4fc97d03020d3012ed890da509b294d0d2 · github.com / v8-riscv / node

Oct 09, 2017

test: use common.fixtures in tls test · 17857d4f

Ben Michel authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15965


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

17857d4f

test: replace error msg w/ template literal · 3953164e

Sushil Tailor authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15910


Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

3953164e

test: add NODE_UNIQUE_ID value to err message · 0662ebee

Daniele Lisi authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15914


Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

0662ebee

test: replace string concatenation with template · 66a990b5

Rob Paton authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15915


Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

66a990b5

test: change concatenation to template literal · d4fbffde

nodexpertsdev authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15916


Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

d4fbffde

test: improve asset msg in test · c80d9d6a

Gene Wu authored Oct 06, 2017

Add result to part of assert message.

PR-URL: https://github.com/nodejs/node/pull/15918


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

c80d9d6a

test: replace fixturesDir with fixtures module · 261ae7f5

penDerGraft authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15919


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

261ae7f5

test: remove message from asserts · 721f6df7

Justin Lee authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15920


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

721f6df7

test: improve an error message · 0fbe0a02

Pavel Pomerantsev authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15921


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

0fbe0a02

test: added string_decoder.js a parallel test · b8b248a9

Uttam Pawar authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15923


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

b8b248a9

test: use fixtures module instead of common · c4178abc

Joe Grace authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15925


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

c4178abc

test: replace fixtureDir with fixtures module · 56c0e7d1

Charlie Duong authored Oct 06, 2017

This commit replaces the usage of common.fixturesDir with
fixtures.path.

PR-URL: https://github.com/nodejs/node/pull/15823


Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

56c0e7d1

doc: fix macosx-firewall suggestion BUILDING · e8bf4d5d

suraiyah authored Oct 06, 2017

Adding back the changes made by commit# 791d560b, that suggests running
macosx-firewall.sh script after bulid step. These changes were deleted
by commit# fc102d01, but they are still applicable.

PR-URL: https://github.com/nodejs/node/pull/15829


Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

e8bf4d5d

test: replaced fixturesDir with fixtures module · 0e1a9faf

Alex McKenzie authored Oct 06, 2017

This was an assigned task at Node.js Interactive North America 2017.
This replaced the fixturesDir exported by the common module with
the fixturesDir on the common/fixtures module.

PR-URL: https://github.com/nodejs/node/pull/15881


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

0e1a9faf

test: use common.fixtures module · b5e8ae4f

Christopher Choi authored Oct 06, 2017

Replace common.fixturesDir with usage of the common.fixtures module.

PR-URL: https://github.com/nodejs/node/pull/15891


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

b5e8ae4f

test: replaced literals in errors with templates · 7a8d51c0

Paul Milham authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15911


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

7a8d51c0

test: display better error message for assertion · beb23570

Russell Dempsey authored Oct 06, 2017

This commit makes understanding assertion failures easier by
displaying the values that failed the assertion.

PR-URL: https://github.com/nodejs/node/pull/15883


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

beb23570

test: changed buffer-zero output · 3f95a8a6

heeeunkimmm authored Oct 06, 2017

Added interpolated strings to display the error value

PR-URL: https://github.com/nodejs/node/pull/15926


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

3f95a8a6

test: replaced fixturesDir with fixtures module · 8baa3251

Alex McKenzie authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15927


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

8baa3251

test: remove literal error messages · ba6049f7

Faisal Yaqoob authored Oct 06, 2017

Assertions will now print the values that caused the assertions
to fail.

PR-URL: https://github.com/nodejs/node/pull/15928


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

ba6049f7

test: refactor test to use the fixtures module · 96221c24

Daniel Kostro authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15934


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

96221c24

test: replace fixturesDir with fixtures module · 2bf182dc

Greg Matthews authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15932


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

2bf182dc

test: modify test messages to template literals · f96745a4

Alice Tsui authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15931


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

f96745a4

test: replace common.fixturesDir with fixture · 3f5f847e

BradLarson authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15940


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

3f5f847e

test: changes to use template literal · 31ab2ebb

joanne-jjb authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15937


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

31ab2ebb

tools: use more template literals · dd159202

Govee91 authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15942


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

dd159202

test: replace fixturesDir with fixtures · 3a265556

Mujtaba Al-Tameemi authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15949


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

3a265556

test: remove common.fixturesDir · fcb0079c

Luis Del Águila authored Oct 06, 2017

Replace `common.fixturesDir` with usage of the `common.fixtures` module

PR-URL: https://github.com/nodejs/node/pull/15950


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

fcb0079c

test: remove template literal · e6e58fde

Emily Ford authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15953


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

e6e58fde

test: removed string from assert message arg · 582749e3

dpaulino authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15954


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

582749e3

tools: use template literals · 28a5fd05

Sarah Meyer authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15956


Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

28a5fd05

test: replace literal with template string · b08ae3a8

Brant Barger authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15957


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

b08ae3a8

test: upgrade from fixturesDir to fixtures.path · ca4e5494

jacjam authored Oct 06, 2017

The common/fixtures module provides convenience methods
for working with files in the test/fixtures directory.

PR-URL: https://github.com/nodejs/node/pull/15960


Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

ca4e5494

doc: add clearer setup description · 3f263403

Emily Platzer authored Oct 06, 2017

Updated console example to follow style of rest of the examples

PR-URL: https://github.com/nodejs/node/pull/15962


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

3f263403

test: use defaultHistoryPath instead of path.join · ab3c84fc

Chris Budy authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15969


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

ab3c84fc

test: replace fixturesDir with fixtures module · 37681b5e

BinarySo1o authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15961


Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

37681b5e

test: replaced fixturesDir with common.fixtures · 0dbff4c8

jopann authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15971


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

0dbff4c8

test: improve assert messages · 55bb9c41

Eric Pemberton authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15972


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

55bb9c41

test: replacing assert message with template · 96eba098

Barry Tam authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15974


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

96eba098

test: use common.fixtures module in test-preload · 0d38e6d0

Laura Cabrera authored Oct 06, 2017

PR-URL: https://github.com/nodejs/node/pull/15975


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

0d38e6d0