- Nov 01, 2018
-
-
Ruben Bridgewater authored
Throw a TypeError in case a error message is provided in the second argument and a third argument is present as well. This is clearly a mistake and should not be done. Backport-PR-URL: https://github.com/nodejs/node/pull/23223 PR-URL: https://github.com/nodejs/node/pull/17585 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Ruben Bridgewater authored
The stack frames from .throws and .doesNotThrow got included even though that was not intended. Backport-PR-URL: https://github.com/nodejs/node/pull/23223 PR-URL: https://github.com/nodejs/node/pull/17703 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
Right now it is difficult to know what argument stands for what property. By refactoring the arguments into a object it is clear what stands for what. Backport-PR-URL: https://github.com/nodejs/node/pull/23223 PR-URL: https://github.com/nodejs/node/pull/17582 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Ruben Bridgewater authored
assert.throws and assert.doesNotThrow set the operator to a internal function. That was by accident and originally the operator was undefined. This changes it to show "throws" or "doesNotThrow". Backport-PR-URL: https://github.com/nodejs/node/pull/23223 PR-URL: https://github.com/nodejs/node/pull/17575 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
Requireing the strict version will allow to use `assert.equal`, `assert.deepEqual` and there negated counterparts to be used with strict comparison instead of using e.g. `assert.strictEqual`. The API is identical to the regular assert export and only differs in the way that all functions use strict compairson. Backport-PR-URL: https://github.com/nodejs/node/pull/23223 PR-URL: https://github.com/nodejs/node/pull/17002 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Anatoli Papirovski authored
The current check for socket.server[kIncomingMessage] does not account for the possibility of a socket.server that doesn't have that property defined. Fix it. Backport-PR-URL: https://github.com/nodejs/node/pull/22880 PR-URL: https://github.com/nodejs/node/pull/20029 Fixes: https://github.com/nodejs/node/issues/19231 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Ben Newman authored
The upstream V8 commit a8f68691 was originally cherry-picked onto nodejs/node master as commit bb357524, then backported to v10.x-staging and released in Node.js v10.10.0 as 5e9ed6d9. This commit cherry-picks that commit back to the v8.x-staging branch. Additionally this commit supports optional boolean argument to DisableBreak constructor. This allows a stack-allocated DisableBreak object to re-enable breakpoints temporarily, rather than always disabling them. This functionality anticipates an upstream change that will be introduced in V8 6.7.176: https://github.com/v8/v8/commit/cc9736a1c0f409bf26d35653358a7b14212d2435 Original commit message: [debug] Fully implement Debug::ArchiveDebug and Debug::RestoreDebug. I have a project that embeds V8 and uses a single `Isolate` from multiple threads. The program runs just fine, but sometimes the inspector doesn't stop on the correct line after stepping over a statement that switches threads behind the scenes, even though the original thread is restored by the time the next statement is executed. After some digging, I discovered that the `Debug::ArchiveDebug` and `Debug::RestoreDebug` methods, which should be responsible for saving/restoring this `ThreadLocal` information when switching threads, currently don't do anything. This commit implements those methods using MemCopy, in the style of other Archive/Restore methods in the V8 codebase. Related: https://groups.google.com/forum/#!topic/v8-users/_Qf2rwljRk8 R=yangguo@chromium.org,jgruber@chromium.org CC=info@bnoordhuis.nl Bug: v8:7230 Change-Id: Id517c873eb81cd53f7216c7efd441b956cf7f943 Reviewed-on: https://chromium-review.googlesource.com/833260 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54902} PR-URL: https://github.com/nodejs/node/pull/22714 Refs: https://github.com/v8/v8/commit/a8f6869177685cfb9c199c454a86f4698c260515 Refs: https://github.com/nodejs/node/pull/22122 Refs: https://github.com/nodejs/node/commit/bb3575242cc87f59882bbcefa253353313f5606b Refs: https://github.com/nodejs/node/commit/5e9ed6d924db97462fb208e7ad8f32acce2a9bf3 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
- Oct 31, 2018
-
-
Yang Guo authored
This serves as mitigation for the so-called HashWick vulnerability. Original commit messages: commit d5686a74d56fbb6985b22663ddadd66eb7b91519 Author: Yang Guo <yangguo@chromium.org> Date: Mon Jul 16 11:19:42 2018 Extend hash seed to 64 bits R=bmeurer@chromium.org, ulan@chromium.org Bug: chromium:680662 Change-Id: I5e1486ad2a42db2998d5485a0c4e711378678e6c Reviewed-on: https://chromium-review.googlesource.com/1136034 Reviewed-by:Marja Hölttä <marja@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54460} commit 3833fef57368c53c6170559ffa524c8c69f16ee5 Author: Yang Guo <yangguo@chromium.org> Date: Thu Sep 20 11:43:13 2018 Refactor integer hashing function names We now clearly differentiate between: - unseeded hash for 32-bit integers - unseeded hash for 64-bit integers - seeded hash for 32-bit integers - seeded hash for strings R=bmeurer@chromium.org Bug: chromium:680662 Change-Id: I7459958c4158ee3501c962943dff8f33258bb5ce Reviewed-on: https://chromium-review.googlesource.com/1235973 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#56271} Refs: https://github.com/nodejs/node/issues/23259 PR-URL: https://github.com/nodejs/node/pull/23274 Reviewed-By:
-
- Oct 30, 2018
-
-
Gibson Fahnestock authored
This is already true in practice. Backport-PR-URL: https://github.com/nodejs/node/pull/23275 PR-URL: https://github.com/nodejs/node/pull/19164 Fixes: https://github.com/nodejs/build/issues/1164 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
jn99 authored
Refs: https://github.com/nodejs/node/issues/21679 PR-URL: https://github.com/nodejs/node/pull/23550 Reviewed-By:
George Adams <george.adams@uk.ibm.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
- Oct 27, 2018
-
-
Rich Trott authored
The test uses both `assert()` and `assert.ok()`. Use just `assert.ok()`. Remove a comment that does not appear to match the code and does not seem to explain much beyond the bare code itself. PR-URL: https://github.com/nodejs/node/pull/19404 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Rich Trott authored
The test is unreliable on some Windows platforms in its current form. Make it more robust by using `setInterval()` to repeat the flooding until an error is triggered. PR-URL: https://github.com/nodejs/node/pull/19395 Reviewed-By:
-
- Oct 18, 2018
-
-
Daniel Bevenius authored
Currently, there is an AsyncWrap constructor that is only used by PromiseWrap. This constructor has a body which is very similar to the other AsyncWrap constructor. This commit suggests updating the private constructor that is used by PromiseWrap and also have the second constructor delegate to this one to avoid the code duplication. PR-URL: https://github.com/nodejs/node/pull/19366 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Rich Trott authored
The test is unreliable on some Windows platforms in its current form. Make it more robust by using `setInterval()` to repeat the flooding until an error is triggered. Fixes: https://github.com/nodejs/node/issues/18251 PR-URL: https://github.com/nodejs/node/pull/19349 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19342 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19340 Reviewed-By:
-
Daniel Bevenius authored
Currently PromiseHook extracts the PromiseWrap from a Local<Promise> in two places. This commit extracts that code into a function instead. PR-URL: https://github.com/nodejs/node/pull/19340 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19315 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
`vcbuild help` just outputs help info and exits. If a user calls this command not from a project root, the directory change can be unexpected and unwanted. PR-URL: https://github.com/nodejs/node/pull/19291 Reviewed-By:
-
Rich Trott authored
* easily -> easy * was -> is * add a missing comma PR-URL: https://github.com/nodejs/node/pull/19313 Reviewed-By:
-
Yuta Hiroto authored
PR-URL: https://github.com/nodejs/node/pull/19338 Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By:
-
- Oct 17, 2018
-
-
James M Snell authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22466 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
In test-http2-session-timeout, provide the number of requests that occurred when the test fails. Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/23058 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
In test-http2-session-timeout, setImmediate() is used to wrap makeReq(). makeReq() is asynchronous and setImmediate() is not necessary. Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/23058 Reviewed-By:
-
James M Snell authored
Add a `Http2Session` event whenever a non-ack `PING` is received. Fixes: https://github.com/nodejs/node/issues/18514 Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/23009 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Anatoli Papirovski authored
A push stream should have its writable side closed upon receipt, to avoid emitting the 'aborted' event when the readable side is closed. Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22878 Fixes: https://github.com/nodejs/node/issues/22851 Reviewed-By:
-
James M Snell authored
v8.x Backport Note -- as V8 doesn't expose an overload of String::WriteOneByte in Node 8 that accepts an isolate argument, the Origins constructor has been changed to not accept an isolate. Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22956 Reviewed-By:
-
Matteo Collina authored
Fixes: https://github.com/nodejs/node/issues/22855 Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22896 Reviewed-By:
-
James M Snell authored
Indicates is the END_STREAM flag was set on the received HEADERS frame Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22843 Fixes: https://github.com/nodejs/node/issues/22497 Reviewed-By:
-
Sagi Tsofan authored
New default timeout values of "2 minutes" were added into documentation inside 2 classes under "Event: 'timeout'": 1) Class: Http2SecureServer 2) Class: Http2Server New sections for `.setTimeout()` method were added inside `Http2SecureServer` & `Http2Server` docs. Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22798 Reviewed-By:
-
Szymon Marczak authored
Refs: https://github.com/nodejs/node/pull/22486 Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22650 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0 Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22649 Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/22268 Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22486 Reviewed-By:
-
Rich Trott authored
Remove `It is important to note that` and italics from `waitForTrailers` sentences. Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22541 Reviewed-By:
-
MaleDong authored
We don't know what will return when successful or failure for the callback of the function. So this commit makes it more detailled. Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22366 Refs: https://github.com/nodejs/node/issues/22322 Reviewed-By:
-
James M Snell authored
v8.x Backport Note: The timeout has been increased to 10ms. Fixes: https://github.com/nodejs/node/issues/20079 Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22252 Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/19095 Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22245 Reviewed-By:
-
James M Snell authored
Refs: https://github.com/nodejs/node/issues/19141 Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22254 Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/21416 Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22256 Reviewed-By:
-
James M Snell authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/22247 Fixes: https://github.com/nodejs/node/issues/21434 Reviewed-By:
-
