Ignore cases where the handle is already gone, like we do in
`handle_wrap.cc`. It should be safe to close handle and then call some
binding methods on it, since the internal handle may be shared between
`_tls_wrap.js` and `net.js` modules.

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/node-forward/node/pull/37

It's not supported in VS2013.

PR-URL: https://github.com/node-forward/node/pull/38


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This commit drops the semaphore in exchange for a second condition
variable and makes the task ring an array member instead of allocating
it on the heap.  That in turn makes size calculations a little easier
because of the array's fixed size.

PR-URL: https://github.com/node-forward/node/pull/34


Reviewed-By: Fedor Indutny <fedor@indutny.com>

The elements of the heap-allocated TaskQueue::ring_ array in
src/node_v8_platform.cc were compared against without being
initialized first.

Fixes node-forward/node#33.

PR-URL: https://github.com/node-forward/node/pull/34


Reviewed-By: Fedor Indutny <fedor@indutny.com>

The latest V8 upgrade and the C++11-ification of the source code in src/
requires a recent compiler.  Update the requirements in the README.

Fixes node-forward/node#35.

PR-URL: https://github.com/node-forward/node/pull/36


Reviewed-By: Fedor Indutny <fedor@indutny.com>

PR-URL: https://github.com/node-forward/node/pull/32


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Conflicts:
	src/cares_wrap.cc
	src/env-inl.h
	src/env.h
	src/node.cc
	src/node.h
	src/node_crypto.cc

The previous commits fixed oversights in destructors that should have
been marked virtual but weren't.  This commit marks destructors from
derived classes with the override keyword.

Like the previous commit but this time for the SSLWrap destructor.

Like the previous commit but this time for the BaseObject destructor.

Make AsyncWrap::~AsyncWrap() virtual, otherwise it is unsafe to delete
a derived class through a pointer to AsyncWrap.  Fortunately, we don't
do that anywhere right now; this commit is merely a preemptive bug fix.

Mark empty destructors as having a default no-op implementation.
Remove a few unused constructors and destructors while we are here.

Mark the matrix of copy/move constructor/assignment operator as deleted.
Prevents the object from being copied around (the macro already did that
pre-C++11), but also from being moved out.

Add `override` keywords where appropriate.  Makes maintenance easier
because the compiler will shout at you when a base class changes in
an incompatible way.

This macro does not not rightfully belong in node.h, remove it.
Replace the one use site with a C++11 `static_assert` construct.

Now that we are building with C++11 features enabled, replace use
of NULL with nullptr.

The benefit of using nullptr is that it can never be confused for
an integral type because it does not support implicit conversions
to integral types except boolean - unlike NULL, which is defined
as a literal `0`.

make path.resolve work the same as path.normalize

PR-URL: https://github.com/node-forward/node/pull/27


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor@indutny.com>

Add optional env var $NODE_COMMON_PIPE for setting common.PIPE to
manually deal with maximum path lengths for unix sockets.

PR-URL: https://github.com/node-forward/node/pull/26


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Now that V8 requires a compiler with decent C++11 support, there is no
reason to keep supporting old versions of gcc.  Remove workarounds for
bugs in gcc 4.4 and older.

This coincidentally makes it easier to build with clang 3.3 + address
sanitizer because clang no longer chokes on the `-fno-tree-vrp` switch.

PR-URL: https://github.com/node-forward/node/pull/24


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Make it possible to build node against Address Sanitizer.  Enable with:

    $ make -f Makefile.build asan=clang++ CC=clang CC_host=clang

PR-URL: https://github.com/node-forward/node/pull/24


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Make `python tools/test.py --arch=ia32,x64 --mode=debug,release` work.
The test runner looks for the `node` binary in `out/${arch}.${mode}/`.

Running tools/test.py without --arch makes it use `out/Release/node` or
`out/Debug/node` like before.

This commit removes `test/simple/test-executable-path.js` because the
assumptions it makes about the locations of the debug and release
binaries are now outdated.

PR-URL: https://github.com/node-forward/node/pull/24


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Make `make -f Makefile.build ia32.release x64.debug` work.  It's not
perfect yet: it requires running `./configure` first and the generated
`config.gypi` is shared across builds.

PR-URL: https://github.com/node-forward/node/pull/24


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Will be used as the template for a multi-arch, multi-mode build system.

PR-URL: https://github.com/node-forward/node/pull/24


Reviewed-By: Fedor Indutny <fedor@indutny.com>

This commit adds preliminary x32 support.  Configure with:

    $ ./configure --dest-cpu=x32

PR-URL: https://github.com/node-forward/node/pull/24


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Fix double definition errors in the libv8_base.a library target by
compiling out stub functions when building for x32.

This fix is incomplete because, although V8 now builds, it makes a
number of bad assumptions about the size of stack slots, see
https://code.google.com/p/v8/issues/detail?id=3630.

PR-URL: https://github.com/node-forward/node/pull/24


Reviewed-By: Fedor Indutny <fedor@indutny.com>

The test implicitly assumed that crypto operations complete in the same
order as they are started but, because they go round-trip through the
thread pool, there is no such guarantee.  Enforce proper sequencing.

Fixes node-forward/node#22.

PR-URL: https://github.com/node-forward/node/pull/23


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Attach the per-context execution environment directly to API functions.
Rationale:

 * Gets node one step closer to multi-isolate readiness.

 * Avoids multi-context confusion, e.g. when the caller and callee live
   in different contexts.

 * Avoids expensive calls to pthread_getspecific() on platforms where
   V8 does not know how to use the thread-local storage directly.
   (Linux, the BSDs.)

PR-URL: https://github.com/node-forward/node/pull/18


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Remove a few Environment::GetCurrent() calls that g++ failed to detect
were not used for anything.  The return value was assigned to a local
variable but not used meaningfully.

PR-URL: https://github.com/node-forward/node/pull/18


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Defined in src/node.cc but not actually in use; remove it.

PR-URL: https://github.com/node-forward/node/pull/18


Reviewed-By: Fedor Indutny <fedor@indutny.com>

On POSIX platforms, check that the uid and gid match the euid and egid
respectively before looking up the environment variable.

Before this commit, an i18n-enabled suid node would cheerfully load
attacker-controlled ICU data through the NODE_ICU_DATA environment
variable.

This commit is not a complete fix.  For example, it's up for debate
what to do with the NODE_CHANNEL_FD environment variable.

PR-URL: https://github.com/node-forward/node/pull/18


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Mechanically replace assert() statements with UNREACHABLE(), CHECK(),
or CHECK_{EQ,NE,LT,GT,LE,GE}() statements.

The exceptions are src/node.h and src/node_object_wrap.h because they
are public headers.

PR-URL: https://github.com/node-forward/node/pull/16


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Make tools/check-imports.sh stop complaining, remove or reorder 'using'
statements.

PR-URL: https://github.com/node-forward/node/pull/16


Reviewed-By: Fedor Indutny <fedor@indutny.com>

API callback functions don't need to create a v8::HandleScope instance
because V8 already creates one in the JS->C++ adapter frame.

PR-URL: https://github.com/node-forward/node/pull/16


Reviewed-By: Fedor Indutny <fedor@indutny.com>

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/8476

The new v8 doesn't build on non gnu++0x, set it to a proper value for
all systems.

Provide default Platform implementation for v8's purposes.

vcbuild.bat is calling vcvars.bat, which doesn't detect if the environment
has already been set. This causes repeated entries to be added to the PATH,
which after a few invocations will lead to an error:
The input line is too long.