- Mar 10, 2018
-
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/19203 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/19203 Reviewed-By:
-
Rich Trott authored
In test-tls-wrap-event-emitter, the text of a TypeError is checked as part of the test. However, this text is generated by the JavaScript engine (V8) and not Node.js. Thus, we should not check the text as JS engine error messages can change without it being considered a breaking change for Node.js. A side effect is that node-chakracore will no longer need to patch this test to pass. PR-URL: https://github.com/nodejs/node/pull/19215 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/19140 Reviewed-By:
-
Gibson Fahnestock authored
This is already true in practice. PR-URL: https://github.com/nodejs/node/pull/19164 Fixes: https://github.com/nodejs/build/issues/1164 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
James M Snell authored
Adds `TRACING_CATEGORY_NODE`, `TRACING_CATEGORY_NODE1` and `TRACING_CATEGORY_NODE2` helper macros for consistently building trace event category strings. For instance, `TRACING_CATEGORY_NODE2(foo, bar)` would generate the category string `node,node.foo,node.foo.bar`, such that... ``` TRACE_EVENT_NESTABLE_ASYNC_BEGIN0( TRACING_CATEGORY_NODE2(foo, bar), "baz", 1); ``` Would emit if trace events are enabled for categories: `node`, `node.foo`, or `node.foo.bar`. This allows a natural scoping down of what trace events a user may want to receive. Enabling the `node` category would receive everything Node.js produces. PR-URL: https://github.com/nodejs/node/pull/19155 Reviewed-By:Andreas Madsen <amwebdk@gmail.com>
-
Daniel Bevenius authored
This commit adds operator overloads for increment/decrement to AliasedBuffer::Reference. The motivation for doing this is to hopefully make code that needs to increment/decrement a little simpler. PR-URL: https://github.com/nodejs/node/pull/19083 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
- Mar 09, 2018
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19246 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19246 Reviewed-By:
-
Rich Trott authored
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: https://github.com/nodejs/node/issues/19197 PR-URL: https://github.com/nodejs/node/pull/19228 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Ken Lin authored
Use arrow functions. PR-URL: https://github.com/nodejs/node/pull/19130 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19238 Reviewed-By:
-
Rich Trott authored
Remove suggestion to avoid `readable` event and `readabe.read()` method. No explanation was provided for this suggestion. PR-URL: https://github.com/nodejs/node/pull/19193 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Chen Gang <gangc.cxy@foxmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
-
Thomas Watson authored
Closes: https://github.com/nodejs/node/issues/18943 PR-URL: https://github.com/nodejs/node/pull/19234 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Refs: https://github.com/nodejs/node/issues/19105 PR-URL: https://github.com/nodejs/node/pull/19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By:
-
Ujjwal Sharma authored
Rename affected tests to remove the "regress" keyword as well as improve naming scheme. Refs: https://github.com/nodejs/node/issues/19105 PR-URL: https://github.com/nodejs/node/pull/19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
Ujjwal Sharma authored
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By:
-
- Mar 08, 2018
-
-
Anatoli Papirovski authored
Instead of having mostly duplicate code in form of internalNextTick, instead use the existing defaultAsyncTriggerIdScope with a slight modification which allows undefined triggerAsyncId to be passed in, which then just triggers the callback with the provided arguments. PR-URL: https://github.com/nodejs/node/pull/19147 Refs: https://github.com/nodejs/node/issues/19104 Reviewed-By:
-
Rich Trott authored
Remove information duplicated in onboarding.md. Organize label list for clarity. Remove `deps` label which we don't actually have. PR-URL: https://github.com/nodejs/node/pull/19160 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19168 Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/node/pull/19100#discussion_r171993685 PR-URL: https://github.com/nodejs/node/pull/19156 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Rich Trott authored
In preparation for a linting rule, use consistent quotation for properties in objects. PR-URL: https://github.com/nodejs/node/pull/19156 Reviewed-By:
-
Myles Borins authored
Notable Changes: * crypto: - add cert.fingerprint256 as SHA256 fingerprint (Hannes Magnusson) https://github.com/nodejs/node/pull/17690 * http2: - Fixed issues with aborted connections in the HTTP/2 implementation (Anna Henningsen) https://github.com/nodejs/node/pull/18987 https://github.com/nodejs/node/pull/19002 * loader: - --inspect-brk now works properly for esmodules (Gus Caplan) https://github.com/nodejs/node/pull/18949 * src: - make process.dlopen() load well-known symbol (Ben Noordhuis) https://github.com/nodejs/node/pull/18934 * trace_events: - add file pattern cli option (Andreas Madsen) https://github.com/nodejs/node/pull/18480 * Added new collaborators: - Chen Gang (MoonBall) https://github.com/MoonBall PR-URL: https://github.com/nodejs/node/pull/19181 -
Ali Ijaz Sheikh authored
Add a simple example showing how to use the inspector API to access the CPU profiler. PR-URL: https://github.com/nodejs/node/pull/19172 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
This is a follow-up of https://github.com/nodejs/node/pull/18990. A new deprecation id was assigned in it, but it was not reflected in code and test. PR-URL: https://github.com/nodejs/node/pull/19209 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/18990 Refs: https://github.com/nodejs/node/pull/15089 Refs: https://github.com/nodejs/node/pull/18158 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/19135 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com>
-
Joyee Cheung authored
On Windows with msys installation, `nm` is available but it is not able to grab symbols from the Windows build. Skipping the test if nm outputs anything to stderr fixes that. PR-URL: https://github.com/nodejs/node/pull/19107 Reviewed-By:
-
Joyee Cheung authored
- Add an accessor property `initialized `to FSEventWrap to check the state of the handle from the JS land - Introduce ERR_FS_WATCHER_ALREADY_STARTED so calling start() on a watcher that is already started will throw instead of doing nothing silently. - Introduce ERR_FS_WATCHER_NOT_STARTED so calling close() on a watcher that is already closed will throw instead of doing nothing silently. - Validate the filename passed to fs.watch() - Assert that the handle in the watcher are instances of FSEvent instead of relying on the illegal invocation error from the VM. - Add more assertions in FSEventWrap methods now that we check `initialized` and the filename in JS land before invoking the binding. - Use uvException instead of errornoException to create the errors with the error numbers from libuv to make them consistent with other errors in fs. TODO: - Improve fs.watchFile() the same way this patch improves fs.watch() - It seems possible to fire both rename and change event from libuv together now that we can check if the handle is closed via `initialized` in JS land. PR-URL: https://github.com/nodejs/node/pull/19089 Reviewed-By:
-
Gabriel Schulhof authored
Document which APIs work while an exception is pending. This is the list of all APIs which do not start with `NAPI_PREAMBLE(env)`. Fixes: https://github.com/nodejs/abi-stable-node/issues/257 PR-URL: https://github.com/nodejs/node/pull/19078 Reviewed-By:
-
- Mar 07, 2018
-
-
Michaël Zasso authored
Original commit message: Use wider types for max_old_space_size and co. Make --max_old_space_size and friends work with values >= 2**31. Such values did not work reliably (or sometimes not all) due to signed integer overflow in size computations, which is UB. Fixes https://github.com/nodejs/node/issues/18786. Bug: chromium:814138 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ibe23cef2417fd5b4a727022b8b0d4b50f1417182 Reviewed-on: https://chromium-review.googlesource.com/927063 Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#51433} Refs: https://github.com/v8/v8/commit/46c4979e860a9aaf4444616955e896e70e72afbf PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [compiler] Fix typing of NumberToString operator. It must be monotone. R=bmeurer@chromium.org Bug: v8:7354 Change-Id: I08dcd3333518029eef08c074c2b91b5c20ad699e Reviewed-on: https://chromium-review.googlesource.com/880982 Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#50801} Refs: https://github.com/v8/v8/commit/8bfbe25a7cbe359f40c4182d64ef75d9795ee085 PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [inspector] Make test byte order independent Change-Id: If0fdc76170ad29b4d3dadddbb32bc87c307c04af Reviewed-on: https://chromium-review.googlesource.com/881883 Reviewed-by:Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#50817} Refs: https://github.com/v8/v8/commit/04a06c9e7ceafa50cfc4991d8f0e5dec888e275b PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By:
-
Mythri Alle authored
Earlier we used to produce code cache along with compile. Now V8 has added an API to request code cache. Support for producing code cache along with compile will be removed soon. PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By:
-
