- Mar 25, 2020
-
-
Richard Lau authored
Signed-off-by:
Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32462 Refs: https://github.com/nodejs/node/pull/31479 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/32078 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
Simplify complex sentence. Remove use of "straightforward". PR-URL: https://github.com/nodejs/node/pull/32427 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
Rich Trott authored
Simplify complex sentence. Remove use of "straightforward". PR-URL: https://github.com/nodejs/node/pull/32427 Reviewed-By:
-
Richard Lau authored
Add a problem matcher for output from remark-lint to our lint-md GitHub Actions CI workflow so that any markdown linter failures are annotated in the pull request in the web UI. Signed-off-by:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me>
-
Eric Dobbertin authored
PR-URL: https://github.com/nodejs/node/pull/31479 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- Mar 24, 2020
-
-
Robert Nagy authored
`net.Socket` is slightly breaking stream invariants by having readable/writable going from `false` to `true`. Streams assume that readable/writable starts out `true` and then goes to `false` through `push(null)`/`end()` after which it never goes back to `true`, e.g. once a stream is `writable == false` it is assumed it will never become `true`. This PR changes 2 things: Unless explicitly set to `false` through options: - starts as `readable`/`writable` `true` by default. - uses `push(null)`/`end()` to set `readable`/`writable` to `false`. Note that this would cause the socket to emit the `'end'`/`'finish'` events, which it did not do previously. In the case it is explicitly set to `false` through options` it is assumed to never become `true`. PR-URL: https://github.com/nodejs/node/pull/32272 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Rich Trott authored
Use common.mustCall() in place of countdown in test-timers-immediate-unref. PR-URL: https://github.com/nodejs/node/pull/32416 Reviewed-By:
-
Rod Vagg authored
Until npm updates update-notifier to a newer version, the dependency tree will contain a version of term-size that has an unsigned macOS binary. This will fail .pkg notarization and will result in failed release builds. We built and signed a term-size and contributed it back to the project for this purpose, but the dependency chain is long enough that it's not likely to be included in a new npm very quickly. Until it is, we need to cherry-pick commit d2f08a1b ontop of any npm updates to master and any other release branch that includes notarization. PR-URL: https://github.com/nodejs/node/pull/32403 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Anna Henningsen authored
Fix the condition for deleting the underlying data pointed to by a `BaseObjectWeakPtr`, which erroneously skipped that deletion when `ptr->get()` was `nullptr`. This fixes a memory leak reported by some of the tests. Refs: https://github.com/nodejs/node/pull/30374#issuecomment-601848973 PR-URL: https://github.com/nodejs/node/pull/32393 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32407 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/32400 PR-URL: https://github.com/nodejs/node/pull/32405 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/commit/d7f11077f15f52a2db191d3a5bcc41581cb7361f Fixes: https://github.com/nodejs/node/issues/30257 PR-URL: https://github.com/nodejs/node/pull/32406 Reviewed-By:
-
- Mar 23, 2020
-
-
Sam Roberts authored
In openssl-1.1.1e the client doesn't seem to like having the TLS connection shut down with no data sent, so send an empty string. A number of related issues showed up in the TLS1.3 port, so this is not entirely surprising. PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By:
-
Hassaan Pasha authored
This test was timing out after update to OpenSSL-1.1.1e. PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By:
-
Hassaan Pasha authored
After an OpenSSL source update, all the config files need to be regenerated and comitted by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/include PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By: -
Hassaan Pasha authored
The scripts used by make were modified to correctly reference the source files that were originially in crypto/include/internal, but got moved to include/crypto. The base path has been left unaltered since that would require too many changes PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By:
-
Hassaan Pasha authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz $ mv openssl-1.1.1e openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By: -
Jan Krems authored
PR-URL: https://github.com/nodejs/node/pull/32068 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
-
- Mar 22, 2020
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32381 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32381 Reviewed-By:
-
Sam Roberts authored
This reverts commit 3ec4b21b. See: https://github.com/nodejs/node/issues/32257 PR-URL: https://github.com/nodejs/node/pull/32324 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
- Mar 21, 2020
-
-
Michaël Zasso authored
v8::ArrayBuffer::IsExternal and v8::ArrayBuffer::Externalize are no longer necessary. PR-URL: https://github.com/nodejs/node/pull/32358 Reviewed-By:
-
Anna Henningsen authored
Add an embedder cctest that also covers a multi-Environment situation, including worker_threads-style inspector support. Co-authored-by:
Joyee Cheung <joyeec9h3@gmail.com> PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
There is currently no way to properly do this. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Jichan authored
If created platform with CreatePlatform, the crash occurs because it does not check if it was initialized to v8_platform when DisposePlatform was called. Refs: https://github.com/nodejs/node/pull/31260 Co-authored-by:
-
Anna Henningsen authored
We do not need a Node.js-provided `v8::TracingController`, generally. Loosen that restriction in order to make it easier for embedders to provide their own subclass of `v8::TracingController`, or none at all. Refs: https://github.com/electron/electron/commit/9c36576dddfaecde1298ff3e089d21a6e54fe67f PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
This should eventually remove any necessity to use the global-state `GetMainThreadMultiIsolatePlatform()`. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
This is a decent replacement for the to-be-deprecated Init() API. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
This makes this bit of the embedder situation a bit easier to use. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/31910 PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
Allow passing a string as the main module rather than using the callback variant. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
This allows embedders to flexibly control how they start JS code rather than using `third_party_main`. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
This addresses some long-standing TODOs by Joyee and me about making the embedder API more powerful and us less reliant on internal APIs for creating the main thread and Workers. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
In our codebase, the assumption generally is that `!is_main_thread()` means that the current Environment belongs to a Node.js Worker thread. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
Workers are fully in control of their Isolates, and this helps avoid a problem with later changes to `CreateEnvironment()` because now we can run the boostrapping code inside the latter. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
Make the calls `stop_sub_worker_contexts()`, `RunCleanup()` part of the public API for easier embedding. (Note that calling `RunAtExit()` is idempotent because the at-exit callback queue is cleared after each call.) PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
